Checkstyle Results

The following document contains the results of Checkstyle 10.9.3 with /Users/connor/Projects/work/emissary/contrib/checkstyle.xml ruleset.

Summary

Files  Info  Warnings  Errors
586 0 10787 0

Files

File  I  W  E
emissary/Emissary.java 0 31 0
emissary/EmissaryTest.java 0 29 0
emissary/admin/PlaceStarter.java 0 2 0
emissary/admin/Startup.java 0 39 0
emissary/admin/StartupIT.java 0 15 0
emissary/analyze/Analyzer.java 0 10 0
emissary/client/EmissaryClient.java 0 35 0
emissary/client/EmissaryClientTest.java 0 21 0
emissary/client/EmissaryResponse.java 0 33 0
emissary/client/HTTPConnectionFactory.java 0 3 0
emissary/client/HTTPConnectionFactoryTest.java 0 1 0
emissary/client/response/Agent.java 0 11 0
emissary/client/response/AgentList.java 0 11 0
emissary/client/response/AgentsFormatter.java 0 7 0
emissary/client/response/AgentsFormatterTest.java 0 5 0
emissary/client/response/AgentsListTest.java 0 18 0
emissary/client/response/AgentsResponseEntity.java 0 11 0
emissary/client/response/BaseResponseEntity.java 0 5 0
emissary/client/response/Config.java 0 17 0
emissary/client/response/ConfigList.java 0 6 0
emissary/client/response/ConfigsResponseEntity.java 0 6 0
emissary/client/response/Directory.java 0 32 0
emissary/client/response/DirectoryList.java 0 11 0
emissary/client/response/DirectoryResponseEntity.java 0 8 0
emissary/client/response/MapResponseEntity.java 0 5 0
emissary/client/response/PeerList.java 0 10 0
emissary/client/response/PeersResponseEntity.java 0 13 0
emissary/client/response/PlaceList.java 0 11 0
emissary/client/response/PlacesResponseEntity.java 0 11 0
emissary/command/AgentsCommand.java 0 2 0
emissary/command/Banner.java 0 6 0
emissary/command/BaseCommand.java 0 38 0
emissary/command/BaseCommandTest.java 0 4 0
emissary/command/ConfigCommand.java 0 11 0
emissary/command/DirectoryCommand.java 0 2 0
emissary/command/EmissaryCommand.java 0 1 0
emissary/command/EnvCommand.java 0 6 0
emissary/command/FeedCommand.java 0 22 0
emissary/command/FeedCommandIT.java 0 64 0
emissary/command/HelpCommand.java 0 12 0
emissary/command/HttpCommand.java 0 18 0
emissary/command/MonitorCommand.java 0 12 0
emissary/command/PeersCommand.java 0 10 0
emissary/command/PeersCommandIT.java 0 34 0
emissary/command/PoolCommand.java 0 2 0
emissary/command/ServerCommand.java 0 9 0
emissary/command/ServerCommandIT.java 0 4 0
emissary/command/ServiceCommand.java 0 9 0
emissary/command/TopologyCommand.java 0 4 0
emissary/command/VersionCommand.java 0 3 0
emissary/command/converter/FileExistsConverter.java 0 5 0
emissary/command/converter/FileExistsConverterTest.java 0 10 0
emissary/command/converter/ModeConverter.java 0 1 0
emissary/command/converter/PathExistsConverter.java 0 8 0
emissary/command/converter/PathExistsConverterTest.java 0 10 0
emissary/command/converter/PathExistsReadableConverter.java 0 4 0
emissary/command/converter/PathExistsReadableConverterTest.java 0 16 0
emissary/command/converter/PriorityDirectoryConverter.java 0 2 0
emissary/command/converter/PriorityDirectoryConverterTest.java 0 19 0
emissary/command/converter/ProjectBaseConverter.java 0 9 0
emissary/command/converter/ProjectBaseConverterTest.java 0 10 0
emissary/command/converter/WorkspaceSortModeConverter.java 0 1 0
emissary/command/converter/WorkspaceSortModeConverterTest.java 0 42 0
emissary/config/ConfigEntry.java 0 7 0
emissary/config/ConfigUtil.java 0 3 0
emissary/config/ConfigUtilTest.java 0 24 0
emissary/config/Configurator.java 0 2 0
emissary/config/ExtractResource.java 0 1 0
emissary/config/FTestServiceConfigGuide.java 0 4 0
emissary/config/ServiceConfigGuide.java 0 12 0
emissary/config/ServiceConfigGuideTest.java 0 13 0
emissary/core/AgentPoolHealthCheck.java 0 1 0
emissary/core/BaseDataObject.java 0 73 0
emissary/core/BaseDataObjectTest.java 0 15 0
emissary/core/DataObjectFactory.java 0 4 0
emissary/core/DataObjectFactoryTest.java 0 11 0
emissary/core/DiffCheckConfiguration.java 0 27 0
emissary/core/ExtendedDataObject.java 0 3 0
emissary/core/ExtractedRecord.java 0 9 0
emissary/core/ExtractedRecordTest.java 0 10 0
emissary/core/FTestMobileAgent.java 0 4 0
emissary/core/FTestMovingAgent.java 0 1 0
emissary/core/Factory.java 0 1 0
emissary/core/FactoryTest.java 0 37 0
emissary/core/Family.java 0 2 0
emissary/core/FamilyTest.java 0 4 0
emissary/core/FilePickUpPlaceHealthCheck.java 0 2 0
emissary/core/FilePickUpPlaceHealthCheckTest.java 0 3 0
emissary/core/Form.java 0 1 0
emissary/core/HDMobileAgent.java 0 1 0
emissary/core/HDMobileAgentBugIT.java 0 52 0
emissary/core/HDMobileAgentTest.java 0 11 0
emissary/core/IBaseDataObject.java 0 5 0
emissary/core/IBaseDataObjectDiffHelper.java 0 3 0
emissary/core/IBaseDataObjectDiffHelperTest.java 0 112 0
emissary/core/IBaseDataObjectHelper.java 0 8 0
emissary/core/IBaseDataObjectHelperTest.java 0 84 0
emissary/core/IBaseDataObjectXmlCodecs.java 0 57 0
emissary/core/IBaseDataObjectXmlHelper.java 0 1 0
emissary/core/IBaseDataObjectXmlHelperTest.java 0 12 0
emissary/core/IPausable.java 0 2 0
emissary/core/InterruptibleCharSequence.java 0 9 0
emissary/core/InterruptibleCharSequenceTest.java 0 16 0
emissary/core/MetricsFormatterTest.java 0 2 0
emissary/core/MetricsManager.java 0 10 0
emissary/core/MetricsManagerTest.java 0 3 0
emissary/core/MobileAgent.java 0 16 0
emissary/core/MobileAgentTest.java 0 33 0
emissary/core/Namespace.java 0 5 0
emissary/core/Pausable.java 0 8 0
emissary/core/ResourceWatcher.java 0 17 0
emissary/core/ResourceWatcherTest.java 0 24 0
emissary/core/SafeUsageChecker.java 0 13 0
emissary/core/Stage.java 0 7 0
emissary/core/StageTest.java 0 2 0
emissary/core/TimedResource.java 0 26 0
emissary/core/TimedResourceTest.java 0 18 0
emissary/core/TransformHistory.java 0 52 0
emissary/core/TransformHistoryTest.java 0 48 0
emissary/core/channels/AbstractSeekableByteChannel.java 0 10 0
emissary/core/channels/AbstractSeekableByteChannelTest.java 0 5 0
emissary/core/channels/BufferedChannelFactory.java 0 19 0
emissary/core/channels/ChannelTestHelper.java 0 2 0
emissary/core/channels/CheckCloseChannelFactory.java 0 7 0
emissary/core/channels/ConcatenateChannelFactory.java 0 19 0
emissary/core/channels/ConcatenateChannelFactoryTest.java 0 1 0
emissary/core/channels/FileChannelFactory.java 0 10 0
emissary/core/channels/FillChannelFactory.java 0 6 0
emissary/core/channels/ImmutableChannelFactory.java 0 8 0
emissary/core/channels/ImmutableChannelFactoryTest.java 0 2 0
emissary/core/channels/InMemoryChannelFactory.java 0 2 0
emissary/core/channels/InputStreamChannelFactory.java 0 21 0
emissary/core/channels/InputStreamChannelFactoryTest.java 0 9 0
emissary/core/channels/LoggingChannelFactory.java 0 40 0
emissary/core/channels/LoggingChannelFactoryTest.java 0 14 0
emissary/core/channels/LoggingInputStreamFactory.java 0 6 0
emissary/core/channels/LoggingInputStreamFactoryTest.java 0 16 0
emissary/core/channels/SeekableByteChannelHelper.java 0 1 0
emissary/core/channels/SeekableByteChannelHelperTest.java 0 5 0
emissary/core/channels/SegmentChannelFactory.java 0 9 0
emissary/core/constants/Configurations.java 0 1 0
emissary/core/constants/IbdoMethodNames.java 0 1 0
emissary/core/constants/IbdoXmlElementNames.java 0 1 0
emissary/core/constants/Parameters.java 0 1 0
emissary/core/sentinel/Sentinel.java 0 37 0
emissary/core/sentinel/SentinelTest.java 0 21 0
emissary/core/sentinel/protocols/Protocol.java 0 32 0
emissary/core/sentinel/protocols/ProtocolTest.java 0 94 0
emissary/core/sentinel/protocols/actions/Action.java 0 1 0
emissary/core/sentinel/protocols/actions/Exit.java 0 1 0
emissary/core/sentinel/protocols/actions/Kill.java 0 2 0
emissary/core/sentinel/protocols/actions/Notify.java 0 1 0
emissary/core/sentinel/protocols/actions/Recover.java 0 3 0
emissary/core/sentinel/protocols/actions/Stop.java 0 2 0
emissary/core/sentinel/protocols/rules/AllMaxTime.java 0 10 0
emissary/core/sentinel/protocols/rules/AllMaxTimeTest.java 0 55 0
emissary/core/sentinel/protocols/rules/AnyMaxTime.java 0 10 0
emissary/core/sentinel/protocols/rules/AnyMaxTimeTest.java 0 58 0
emissary/core/sentinel/protocols/rules/Rule.java 0 24 0
emissary/directory/DirectoryAdapter.java 0 2 0
emissary/directory/DirectoryEntry.java 0 19 0
emissary/directory/DirectoryEntryList.java 0 1 0
emissary/directory/DirectoryEntryListTest.java 0 13 0
emissary/directory/DirectoryEntryMapTest.java 0 7 0
emissary/directory/DirectoryObserverManager.java 0 3 0
emissary/directory/DirectoryPlace.java 0 13 0
emissary/directory/DirectoryPlaceTest.java 0 1 0
emissary/directory/DirectoryXmlContainer.java 0 1 0
emissary/directory/EmissaryNode.java 0 20 0
emissary/directory/HeartbeatManager.java 0 14 0
emissary/directory/HeartbeatManagerTest.java 0 22 0
emissary/directory/KeyManipulator.java 0 1 0
emissary/directory/KeyManipulatorTest.java 0 2 0
emissary/directory/RoutingAlgorithmTest.java 0 4 0
emissary/directory/WildcardEntry.java 0 3 0
emissary/id/IdPlace.java 0 3 0
emissary/id/IdPlaceTest.java 0 18 0
emissary/id/Identification.java 0 4 0
emissary/id/SizeIdPlace.java 0 20 0
emissary/id/SizeIdPlaceTest.java 0 8 0
emissary/id/UnixFilePlace.java 0 13 0
emissary/id/UnixFilePlaceTest.java 0 5 0
emissary/id/WorkUnit.java 0 7 0
emissary/jni/JNI.java 0 5 0
emissary/jni/JniRepositoryPlace.java 0 3 0
emissary/kff/ChecksumCalculator.java 0 34 0
emissary/kff/ChecksumCalculatorTest.java 0 20 0
emissary/kff/ChecksumResults.java 0 24 0
emissary/kff/ChecksumResultsTest.java 0 4 0
emissary/kff/EditDistance.java 0 57 0
emissary/kff/KffChain.java 0 36 0
emissary/kff/KffChainLoader.java 0 14 0
emissary/kff/KffChainTest.java 0 18 0
emissary/kff/KffDataObjectHandler.java 0 59 0
emissary/kff/KffDataObjectHandlerTest.java 0 266 0
emissary/kff/KffFile.java 0 50 0
emissary/kff/KffFileTest.java 0 45 0
emissary/kff/KffMemcached.java 0 68 0
emissary/kff/KffMemcachedTest.java 0 42 0
emissary/kff/KffQuincyFile.java 0 8 0
emissary/kff/KffQuincyFileTest.java 0 1 0
emissary/kff/KffResult.java 0 31 0
emissary/kff/SpamSumSignature.java 0 28 0
emissary/kff/Ssdeep.java 0 6 0
emissary/kff/SsdeepTest.java 0 14 0
emissary/log/MDCConstants.java 0 1 0
emissary/output/DropOffPlace.java 0 7 0
emissary/output/DropOffPlaceTest.java 0 14 0
emissary/output/DropOffUtil.java 0 45 0
emissary/output/DropOffUtilTest.java 0 35 0
emissary/output/filter/AbstractFilter.java 0 62 0
emissary/output/filter/AbstractFilterTest.java 0 44 0
emissary/output/filter/AbstractRollableFilter.java 0 17 0
emissary/output/filter/DataFilterTest.java 0 9 0
emissary/output/filter/JsonOutputFilter.java 0 65 0
emissary/output/filter/JsonOutputFilterTest.java 0 172 0
emissary/output/filter/XmlOutputFilter.java 0 7 0
emissary/output/filter/XmlOutputFilterTest.java 0 29 0
emissary/output/io/DateFilterFilenameGenerator.java 0 3 0
emissary/output/io/DateFilterFilenameGeneratorTest.java 0 10 0
emissary/output/io/DateStampFilenameGenerator.java 0 20 0
emissary/output/io/SimpleFileNameGenerator.java 0 1 0
emissary/output/roller/JournaledCoalescer.java 0 55 0
emissary/output/roller/JournaledCoalescerTest.java 0 97 0
emissary/output/roller/journal/Journal.java 0 21 0
emissary/output/roller/journal/JournalEntry.java 0 4 0
emissary/output/roller/journal/JournalReader.java 0 66 0
emissary/output/roller/journal/JournalTest.java 0 5 0
emissary/output/roller/journal/JournalWriter.java 0 46 0
emissary/output/roller/journal/JournaledChannel.java 0 6 0
emissary/output/roller/journal/JournaledChannelPool.java 0 3 0
emissary/output/roller/journal/JournaledChannelPoolTest.java 0 2 0
emissary/output/roller/journal/JournaledChannelTest.java 0 10 0
emissary/output/roller/journal/KeyedOutput.java 0 2 0
emissary/parser/DataByteArraySlicer.java 0 9 0
emissary/parser/DataByteArraySlicerTest.java 0 10 0
emissary/parser/DataByteBufferSlicer.java 0 10 0
emissary/parser/DataByteBufferSlicerTest.java 0 13 0
emissary/parser/DataIdentifier.java 0 20 0
emissary/parser/DataIdentifierTest.java 0 13 0
emissary/parser/DecomposedSession.java 0 56 0
emissary/parser/DecomposedSessionTest.java 0 21 0
emissary/parser/FillingNIOParser.java 0 11 0
emissary/parser/InputSession.java 0 84 0
emissary/parser/InputSessionTest.java 0 5 0
emissary/parser/NIOSessionParser.java 0 39 0
emissary/parser/ParserEOFException.java 0 1 0
emissary/parser/ParserException.java 0 3 0
emissary/parser/ParserFactory.java 0 37 0
emissary/parser/ParserFactoryTest.java 0 3 0
emissary/parser/ParserNextChunkException.java 0 1 0
emissary/parser/PositionRecord.java 0 9 0
emissary/parser/PositionRecordTest.java 0 4 0
emissary/parser/SessionParser.java 0 5 0
emissary/parser/SessionProducer.java 0 37 0
emissary/parser/SessionProducerTest.java 0 12 0
emissary/parser/SimpleNioParser.java 0 21 0
emissary/parser/SimpleNioParserTest.java 0 21 0
emissary/pickup/BreakableFilePickUpClient.java 0 26 0
emissary/pickup/FTestFailedPickupClient.java 0 88 0
emissary/pickup/FTestMultipleWorkSpaces.java 0 107 0
emissary/pickup/FTestWorkSpaceMaxBundleSize.java 0 81 0
emissary/pickup/IPickUpPlace.java 0 1 0
emissary/pickup/PickUpPlace.java 0 149 0
emissary/pickup/PickUpSpace.java 0 51 0
emissary/pickup/PickupQueue.java 0 15 0
emissary/pickup/PickupQueueTest.java 0 26 0
emissary/pickup/Priority.java 0 1 0
emissary/pickup/PriorityDirectory.java 0 12 0
emissary/pickup/QueServer.java 0 35 0
emissary/pickup/QueServerTest.java 0 55 0
emissary/pickup/WorkBundle.java 0 114 0
emissary/pickup/WorkBundleTest.java 0 38 0
emissary/pickup/WorkSpace.java 0 55 0
emissary/pickup/WorkSpaceTest.java 0 120 0
emissary/pickup/WorkUnit.java 0 19 0
emissary/pickup/WorkUnitTest.java 0 4 0
emissary/pickup/file/FTestSpacePlaceInteraction.java 0 95 0
emissary/pickup/file/FileDataServer.java 0 41 0
emissary/pickup/file/FilePickUpClient.java 0 89 0
emissary/pickup/file/FilePickUpClientTest.java 0 66 0
emissary/pickup/file/FilePickUpPlace.java 0 22 0
emissary/place/ComparisonPlace.java 0 15 0
emissary/place/ComparisonPlaceTest.java 0 2 0
emissary/place/ComparisonPlaceTestProcessHDPlace.java 0 6 0
emissary/place/ComparisonPlaceTestProcessPlace.java 0 6 0
emissary/place/CoordinationPlace.java 0 57 0
emissary/place/CoordinationPlaceTest.java 0 19 0
emissary/place/FTestCoordinatePlace.java 0 14 0
emissary/place/FTestSkippingCoordinationPlace.java 0 18 0
emissary/place/IMultiFileServerPlace.java 0 1 0
emissary/place/KffHashPlace.java 0 18 0
emissary/place/KffHashPlaceTest.java 0 3 0
emissary/place/MultiFileServerPlace.java 0 26 0
emissary/place/MultiFileServerPlaceTest.java 0 56 0
emissary/place/MultiFileUnixCommandPlace.java 0 190 0
emissary/place/MultiFileUnixCommandPlaceTest.java 0 63 0
emissary/place/MyFileConfigedTestPlace.java 0 15 0
emissary/place/MyStreamConfigedTestPlace.java 0 15 0
emissary/place/OOMPlace.java 0 8 0
emissary/place/RehashingPlaceTest.java 0 16 0
emissary/place/ServiceProviderPlace.java 0 261 0
emissary/place/ServiceProviderPlaceGetTLDTest.java 0 11 0
emissary/place/ServiceProviderPlaceTest.java 0 105 0
emissary/place/UnixCommandPlace.java 0 124 0
emissary/place/UnixCommandPlaceTest.java 0 49 0
emissary/place/VersionPlace.java 0 35 0
emissary/place/VersionPlaceTest.java 0 30 0
emissary/place/sample/CachePlace.java 0 25 0
emissary/place/sample/DelayPlace.java 0 9 0
emissary/place/sample/DevNullPlace.java 0 8 0
emissary/place/sample/TemplatePlace.java 0 8 0
emissary/place/sample/ToLowerPlace.java 0 12 0
emissary/place/sample/ToUpperPlace.java 0 12 0
emissary/pool/AgentPool.java 0 28 0
emissary/pool/AgentPoolTest.java 0 6 0
emissary/pool/AgentThreadGroup.java 0 3 0
emissary/pool/MobileAgentFactory.java 0 29 0
emissary/pool/MoveSpool.java 0 94 0
emissary/pool/PayloadLauncher.java 0 7 0
emissary/roll/RollManager.java 0 28 0
emissary/roll/RollManagerTest.java 0 15 0
emissary/roll/RollScheduledExecutor.java 0 27 0
emissary/roll/RollUtil.java 0 11 0
emissary/roll/RollableTest.java 0 12 0
emissary/roll/Roller.java 0 50 0
emissary/server/EmissaryServer.java 0 88 0
emissary/server/EmissaryServerIT.java 0 15 0
emissary/server/InitializeContext.java 0 3 0
emissary/server/InitializeContextTest.java 0 10 0
emissary/server/api/Agents.java 0 17 0
emissary/server/api/ApiUtils.java 0 4 0
emissary/server/api/Configs.java 0 20 0
emissary/server/api/Directories.java 0 6 0
emissary/server/api/EmissaryApiTest.java 0 49 0
emissary/server/api/Env.java 0 7 0
emissary/server/api/HealthCheckAction.java 0 1 0
emissary/server/api/MetricsAction.java 0 1 0
emissary/server/api/Pause.java 0 3 0
emissary/server/api/Peers.java 0 7 0
emissary/server/api/PeersIT.java 0 12 0
emissary/server/api/Places.java 0 11 0
emissary/server/api/Pool.java 0 12 0
emissary/server/api/Shutdown.java 0 4 0
emissary/server/api/Version.java 0 11 0
emissary/server/mvc/DumpDirectoryAction.java 0 34 0
emissary/server/mvc/EmissaryMvcTest.java 0 16 0
emissary/server/mvc/EnvironmentAction.java 0 20 0
emissary/server/mvc/NamespaceAction.java 0 16 0
emissary/server/mvc/NavAction.java 0 35 0
emissary/server/mvc/PauseAction.java 0 4 0
emissary/server/mvc/ShutdownAction.java 0 2 0
emissary/server/mvc/ThreadDumpAction.java 0 11 0
emissary/server/mvc/TransferDirectoryAction.java 0 3 0
emissary/server/mvc/adapters/DirectoryAdapter.java 0 4 0
emissary/server/mvc/adapters/RequestUtil.java 0 6 0
emissary/server/mvc/adapters/RequestUtilTest.java 0 11 0
emissary/server/mvc/internal/DeregisterPlaceAction.java 0 6 0
emissary/server/mvc/internal/DeregisterPlaceActionTest.java 0 19 0
emissary/server/mvc/internal/FailDirectoryAction.java 0 9 0
emissary/server/mvc/internal/FailDirectoryActionTest.java 0 18 0
emissary/server/mvc/internal/HeartbeatAction.java 0 2 0
emissary/server/mvc/internal/HeartbeatActionTest.java 0 20 0
emissary/server/mvc/internal/RegisterPeerAction.java 0 10 0
emissary/server/mvc/internal/RegisterPeerActionTest.java 0 19 0
emissary/server/mvc/internal/RollOutputsAction.java 0 6 0
emissary/server/mvc/internal/WorkBundleCompletedAction.java 0 13 0
emissary/server/mvc/internal/WorkBundleCompletedActionTest.java 0 21 0
emissary/server/mvc/internal/WorkSpaceClientOpenWorkSpaceAction.java 0 7 0
emissary/server/mvc/internal/WorkSpaceClientSpaceTakeAction.java 0 8 0
emissary/server/mvc/internal/WorkSpaceClientSpaceTakeActionTest.java 0 18 0
emissary/spi/ClassLocationVerificationProvider.java 0 15 0
emissary/spi/ClassLocationVerificationProviderTest.java 0 2 0
emissary/spi/EmissaryObjectTracingProvider.java 0 5 0
emissary/spi/InitializationProvider.java 0 1 0
emissary/spi/ObjectTracingService.java 0 6 0
emissary/spi/SPILoader.java 0 3 0
emissary/test/core/junit5/ExtractionTest.java 0 102 0
emissary/test/core/junit5/FunctionalTest.java 0 48 0
emissary/test/core/junit5/IdentificationTest.java 0 22 0
emissary/test/core/junit5/InitialFinalFormFormat.java 0 17 0
emissary/test/core/junit5/LogbackTester.java 0 47 0
emissary/test/core/junit5/LogbackTesterTest.java 0 32 0
emissary/test/core/junit5/RegressionTest.java 0 13 0
emissary/test/core/junit5/RegressionTestUtil.java 0 4 0
emissary/test/core/junit5/TestExtractionTest.java 0 29 0
emissary/test/core/junit5/UnitTest.java 0 46 0
emissary/test/core/junit5/extensions/EmissaryIsolatedClassLoaderExtension.java 0 15 0
emissary/test/core/junit5/extensions/TestAttempts.java 0 31 0
emissary/test/util/ComplexUnicodeSamples.java 0 7 0
emissary/test/util/ComplexUnicodeSamplesTest.java 0 11 0
emissary/test/util/RegularExpressionTestUtil.java 0 10 0
emissary/test/util/ThreadDump.java 0 1 0
emissary/transform/HtmlEscapePlace.java 0 22 0
emissary/transform/HtmlEscapePlaceTest.java 0 28 0
emissary/transform/JavascriptEscapePlace.java 0 11 0
emissary/transform/JsonEscapePlace.java 0 9 0
emissary/transform/decode/HtmlEscape.java 0 44 0
emissary/transform/decode/HtmlEscapeTest.java 0 47 0
emissary/transform/decode/JavascriptEscape.java 0 9 0
emissary/transform/decode/JsonEscape.java 0 16 0
emissary/transform/decode/JsonEscapeTest.java 0 13 0
emissary/util/ByteUtil.java 0 46 0
emissary/util/ByteUtilTest.java 0 19 0
emissary/util/CaseInsensitiveMap.java 0 21 0
emissary/util/CaseInsensitiveMapTest.java 0 9 0
emissary/util/CharacterCounterSet.java 0 9 0
emissary/util/CharacterCounterSetTest.java 0 6 0
emissary/util/CharsetUtil.java 0 10 0
emissary/util/CharsetUtilTest.java 0 1 0
emissary/util/ClassComparator.java 0 3 0
emissary/util/ClassLookupCache.java 0 1 0
emissary/util/ConstructorLookupCache.java 0 2 0
emissary/util/ConstructorLookupCacheTest.java 0 17 0
emissary/util/CounterSet.java 0 15 0
emissary/util/CounterSetTest.java 0 6 0
emissary/util/CustomRolloverLogbackAppender.java 0 10 0
emissary/util/DataUtil.java 0 1 0
emissary/util/DateTimeFormatParser.java 0 13 0
emissary/util/DateTimeFormatParserLegacy.java 0 2 0
emissary/util/DateTimeFormatParserTest.java 0 8 0
emissary/util/DependencyCheck.java 0 30 0
emissary/util/DependencyCheckTest.java 0 9 0
emissary/util/DisposeHelper.java 0 1 0
emissary/util/DisposeHelperTest.java 0 48 0
emissary/util/Entropy.java 0 4 0
emissary/util/EntropyTest.java 0 2 0
emissary/util/FlexibleDateTimeParser.java 0 15 0
emissary/util/FlexibleDateTimeParserTest.java 0 51 0
emissary/util/GitRepositoryState.java 0 27 0
emissary/util/Hexl.java 0 10 0
emissary/util/HtmlEntityMap.java 0 14 0
emissary/util/HtmlEntityMapTest.java 0 4 0
emissary/util/JMXUtil.java 0 1 0
emissary/util/JavaCharSet.java 0 1 0
emissary/util/LineTokenizer.java 0 60 0
emissary/util/LineTokenizerTest.java 0 6 0
emissary/util/MagicNumberUtil.java 0 1 0
emissary/util/MagicNumberUtilTest.java 0 4 0
emissary/util/Pair.java 0 2 0
emissary/util/PayloadUtil.java 0 7 0
emissary/util/PayloadUtilTest.java 0 11 0
emissary/util/PkiUtil.java 0 11 0
emissary/util/PkiUtilTest.java 0 12 0
emissary/util/PlaceComparisonHelper.java 0 1 0
emissary/util/PlaceComparisonHelperTest.java 0 57 0
emissary/util/ShortNameComparator.java 0 6 0
emissary/util/ShortNameComparatorTest.java 0 3 0
emissary/util/SizeUtil.java 0 9 0
emissary/util/StringUtil.java 0 3 0
emissary/util/TestMinimalServiceProviderPlace.java 0 1 0
emissary/util/TimeUtil.java 0 13 0
emissary/util/TimeUtilTest.java 0 5 0
emissary/util/TypeEngine.java 0 24 0
emissary/util/UnixFile.java 0 19 0
emissary/util/Version.java 0 9 0
emissary/util/WatcherThread.java 0 26 0
emissary/util/WindowedSeekableByteChannel.java 0 16 0
emissary/util/WindowedSeekableByteChannelTest.java 0 2 0
emissary/util/io/BufferedWriterOutputStream.java 0 32 0
emissary/util/io/FastStringBuffer.java 0 7 0
emissary/util/io/FileFind.java 0 42 0
emissary/util/io/FileManipulator.java 0 2 0
emissary/util/io/ListOpenFiles.java 0 5 0
emissary/util/io/ListOpenFilesTest.java 0 9 0
emissary/util/io/LoggingInputStream.java 0 21 0
emissary/util/io/LoggingPrintStream.java 0 22 0
emissary/util/io/LoggingPrintStreamTest.java 0 60 0
emissary/util/io/ReadOutput.java 0 19 0
emissary/util/io/ResourceReader.java 0 49 0
emissary/util/io/ResourceReaderTest.java 0 5 0
emissary/util/io/SocketUtils.java 0 11 0
emissary/util/io/UnitTestFileUtils.java 0 14 0
emissary/util/magic/ByteArrayPrecisionException.java 0 1 0
emissary/util/magic/MagicMath.java 0 72 0
emissary/util/magic/MagicMathTest.java 0 3 0
emissary/util/magic/MagicNumber.java 0 89 0
emissary/util/magic/MagicNumberFactory.java 0 63 0
emissary/util/magic/MagicNumberTest.java 0 17 0
emissary/util/magic/ParseException.java 0 1 0
emissary/util/os/OSReleaseUtil.java 0 10 0
emissary/util/os/OSReleaseUtilTest.java 0 4 0
emissary/util/roll/RollableFileOutputStream.java 0 61 0
emissary/util/roll/RollableFileOutputStreamTest.java 0 36 0
emissary/util/search/BackwardsTreeScanner.java 0 43 0
emissary/util/search/BackwardsTreeScannerTest.java 0 7 0
emissary/util/search/ByteMatcher.java 0 128 0
emissary/util/search/ByteMatcherTest.java 0 22 0
emissary/util/search/ByteTokenizer.java 0 98 0
emissary/util/search/ByteTokenizerTest.java 0 3 0
emissary/util/search/FastBoyerMoore.java 0 18 0
emissary/util/search/FastBoyerMooreTest.java 0 1 0
emissary/util/search/Hit.java 0 2 0
emissary/util/search/KeywordScanner.java 0 13 0
emissary/util/search/KeywordScannerTest.java 0 7 0
emissary/util/search/MultiKeywordScanner.java 0 1 0
emissary/util/search/MultiKeywordScannerTest.java 0 16 0
emissary/util/shell/Executrix.java 0 65 0
emissary/util/shell/ExecutrixTest.java 0 74 0
emissary/util/shell/ProcessReader.java 0 4 0
emissary/util/shell/ProcessReaderTest.java 0 25 0
emissary/util/shell/ReadBinaryOutputBuffer.java 0 6 0
emissary/util/shell/ReadBinaryOutputBufferTest.java 0 1 0
emissary/util/shell/ReadOutputBuffer.java 0 1 0
emissary/util/shell/ReadOutputBufferTest.java 0 1 0
emissary/util/shell/ReadOutputLogger.java 0 5 0
emissary/util/shell/TempFileNames.java 0 39 0
emissary/util/web/HtmlEscaper.java 0 1 0
emissary/util/web/HttpPostParameters.java 0 1 0
emissary/util/web/Url.java 0 1 0
emissary/util/web/UrlData.java 0 10 0
emissary/util/web/UrlRequestProperty.java 0 3 0
emissary/util/web/UrlTest.java 0 1 0
emissary/util/xml/AbstractJDOMUtil.java 0 1 0
emissary/util/xml/JDOMUtil.java 0 1 0
emissary/util/xml/SaferJDOMUtil.java 0 2 0

Rules

Category Rule Violations Severity
blocks AvoidNestedBlocks 2  Warning
EmptyCatchBlock
  • exceptionVariableName: "expected"
 3  Warning
LeftCurly 2  Warning
RightCurly
  • tokens: "CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR, LITERAL_WHILE, LITERAL_DO, STATIC_INIT, INSTANCE_INIT"
  • option: "alone"
 151  Warning
coding EqualsAvoidNull 28  Warning
FallThrough 3  Warning
FinalLocalVariable 2598  Warning
HiddenField
  • ignoreConstructorParameter: "true"
 143  Warning
IllegalTokenText
  • format: "\\u00(08|09|0(a|A)|0(c|C)|0(d|D)|22|27|5(C|c))|\\(0(10|11|12|14|15|42|47)|134)"
  • tokens: "STRING_LITERAL, CHAR_LITERAL"
  • message: "Avoid using corresponding octal or Unicode escape."
 2  Warning
MissingSwitchDefault 2  Warning
ModifiedControlVariable 15  Warning
ParameterAssignment 19  Warning
RequireThis
  • validateOnlyOverlapping: "false"
  • checkMethods: "false"
 4522  Warning
SimplifyBooleanExpression 2  Warning
VariableDeclarationUsageDistance 41  Warning
design VisibilityModifier 798  Warning
indentation Indentation
  • arrayInitIndent: "2"
  • lineWrappingIndentation: "2"
 74  Warning
javadoc AtclauseOrder
  • tagOrder: "@param, @return, @throws, @deprecated"
  • target: "CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"
 5  Warning
misc FinalParameters 2204  Warning
modifier ModifierOrder 5  Warning
RedundantModifier 83  Warning
naming MethodName
  • format: "^[a-z][a-z0-9][a-zA-Z0-9_]*$"
 3  Warning
TypeName 1  Warning
sizes LineLength
  • max: "170"
  • ignorePattern: "^package.*|^import.*|a href|href|http://|https://|ftp://"
  • tabWidth: "4"
 1  Error
whitespace EmptyLineSeparator
  • allowNoEmptyLineBetweenFields: "true"
  • tokens: "PACKAGE_DEF, IMPORT, CLASS_DEF, INTERFACE_DEF, ENUM_DEF, INSTANCE_INIT, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"
 7  Warning
OperatorWrap
  • tokens: "BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR "
  • option: "NL"
 48  Warning
SeparatorWrap
  • tokens: "COMMA"
  • option: "EOL"
 25  Warning
SeparatorWrap
  • tokens: "DOT"
  • option: "nl"
 25  Warning

Details

emissary/Emissary.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'commandClasses' should be declared final. 57
 Warning coding FinalLocalVariable Variable 'staticCopy' should be declared final. 61
 Warning coding FinalLocalVariable Variable 'command' should be declared final. 64
 Warning coding RequireThis Reference to instance variable 'cli' needs "this.". 76
 Warning misc FinalParameters Parameter cmds should be final. 83
 Warning coding RequireThis Reference to instance variable 'commands' needs "this.". 84
 Warning coding RequireThis Reference to instance variable 'commands' needs "this.". 86
 Warning coding RequireThis Reference to instance variable 'cli' needs "this.". 87
 Warning coding RequireThis Reference to instance variable 'commands' needs "this.". 87
 Warning misc FinalParameters Parameter args should be final. 91
 Warning coding FinalLocalVariable Variable 'shouldSetVerbose' should be declared final. 93
 Warning coding EqualsAvoidNull String literal expressions should be on the left side of an equals comparison. 94
 Warning coding RequireThis Reference to instance variable 'cli' needs "this.". 98
 Warning coding FinalLocalVariable Variable 'commandNames' should be declared final. 99
 Warning coding RequireThis Reference to instance variable 'cli' needs "this.". 99
 Warning coding RequireThis Reference to instance variable 'cli' needs "this.". 103
 Warning coding FinalLocalVariable Variable 'commandName' should be declared final. 106
 Warning coding FinalLocalVariable Variable 'cmd' should be declared final. 107
 Warning coding RequireThis Reference to instance variable 'commands' needs "this.". 107
 Warning coding RequireThis Reference to instance variable 'cli' needs "this.". 112
 Warning coding RequireThis Reference to instance variable 'cli' needs "this.". 117
 Warning coding RequireThis Reference to instance variable 'cli' needs "this.". 123
 Warning misc FinalParameters Parameter cmd should be final. 132
 Warning coding RequireThis Reference to instance variable 'bannerDumped' needs "this.". 133
 Warning coding RequireThis Reference to instance variable 'bannerDumped' needs "this.". 134
 Warning misc FinalParameters Parameter retCode should be final. 159
 Warning misc FinalParameters Parameter args should be final. 163
 Warning coding FinalLocalVariable Variable 'root' should be declared final. 181
 Warning coding FinalLocalVariable Variable 'lc' should be declared final. 184
 Warning coding FinalLocalVariable Variable 'ple' should be declared final. 187
 Warning coding FinalLocalVariable Variable 'consoleAppender' should be declared final. 192

emissary/EmissaryTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'cmd' should be declared final. 38
 Warning coding FinalLocalVariable Variable 'cmds' should be declared final. 44
 Warning coding FinalLocalVariable Variable 'emissary' should be declared final. 50
 Warning coding FinalLocalVariable Variable 'sortedNames' should be declared final. 51
 Warning coding FinalLocalVariable Variable 'namesAsStored' should be declared final. 53
 Warning coding FinalLocalVariable Variable 'emissary' should be declared final. 61
 Warning coding FinalLocalVariable Variable 'emissary' should be declared final. 70
 Warning coding FinalLocalVariable Variable 'emissary' should be declared final. 79
 Warning coding FinalLocalVariable Variable 'cmds' should be declared final. 89
 Warning coding FinalLocalVariable Variable 'emissary' should be declared final. 92
 Warning coding FinalLocalVariable Variable 'cmds' should be declared final. 102
 Warning coding FinalLocalVariable Variable 'emissary' should be declared final. 105
 Warning coding FinalLocalVariable Variable 'cmds' should be declared final. 116
 Warning coding FinalLocalVariable Variable 'emissary' should be declared final. 121
 Warning misc FinalParameters Parameter args should be final. 127
 Warning coding FinalLocalVariable Variable 'ret' should be declared final. 128
 Warning design VisibilityModifier Variable 'outContent' must be private and have accessor methods. 136
 Warning design VisibilityModifier Variable 'errContent' must be private and have accessor methods. 137
 Warning coding RequireThis Reference to instance variable 'outContent' needs "this.". 140
 Warning coding RequireThis Reference to instance variable 'errContent' needs "this.". 144
 Warning misc FinalParameters Parameter cmds should be final. 151
 Warning coding RequireThis Reference to instance variable 'outContent' needs "this.". 158
 Warning coding RequireThis Reference to instance variable 'errContent' needs "this.". 159
 Warning misc FinalParameters Parameter retCode should be final. 163
 Warning misc FinalParameters Parameter retOutput should be final. 167
 Warning coding RequireThis Reference to instance variable 'outContent' needs "this.". 169
 Warning misc FinalParameters Parameter c should be final. 186
 Warning misc FinalParameters Parameter c should be final. 216
 Warning misc FinalParameters Parameter c should be final. 238

emissary/admin/PlaceStarter.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter isStrictMode should be final. 230
 Warning blocks RightCurly '}' at column 29 should be alone on a line. 250

emissary/admin/Startup.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'directoryAction' must be private and have accessor methods. 49
 Warning design VisibilityModifier Variable 'hostsConfig' must be private and have accessor methods. 59
 Warning design VisibilityModifier Variable 'localDirectories' must be private and have accessor methods. 62
 Warning design VisibilityModifier Variable 'failedLocalDirectories' must be private and have accessor methods. 65
 Warning design VisibilityModifier Variable 'failedPlaces' must be private and have accessor methods. 67
 Warning design VisibilityModifier Variable 'placesToStart' must be private and have accessor methods. 73
 Warning design VisibilityModifier Variable 'placeLists' must be private and have accessor methods. 76
 Warning design VisibilityModifier Variable 'pickupLists' must be private and have accessor methods. 77
 Warning design VisibilityModifier Variable 'invisPlacesStartedInStrictMode' must be private and have accessor methods. 85
 Warning coding RequireThis Reference to instance variable 'node' needs "this.". 184
 Warning misc FinalParameters Parameter node should be final. 195
 Warning misc FinalParameters Parameter node should be final. 200
 Warning misc FinalParameters Parameter node should be final. 204
 Warning coding FinalLocalVariable Variable 'emissaryNode' should be declared final. 294
 Warning coding RequireThis Reference to instance variable 'placesToStart' needs "this.". 358
 Warning coding RequireThis Reference to instance variable 'failedLocalDirectories' needs "this.". 359
 Warning coding RequireThis Reference to instance variable 'placesToStart' needs "this.". 368
 Warning coding FinalLocalVariable Variable 'parallelPlaceStartup' should be declared final. 375
 Warning coding RequireThis Reference to instance variable 'hostsConfig' needs "this.". 375
 Warning coding FinalLocalVariable Variable 'hostParametersStream' should be declared final. 376
 Warning coding FinalLocalVariable Variable 'startupBuilder' should be declared final. 387
 Warning coding RequireThis Reference to instance variable 'placesToStart' needs "this.". 394
 Warning coding RequireThis Reference to instance variable 'node' needs "this.". 399
 Warning coding RequireThis Reference to instance variable 'node' needs "this.". 399
 Warning coding RequireThis Reference to instance variable 'placesToStart' needs "this.". 403
 Warning coding RequireThis Reference to instance variable 'failedPlaces' needs "this.". 417
 Warning coding RequireThis Reference to instance variable 'placesToStart' needs "this.". 418
 Warning coding RequireThis Reference to instance variable 'placesToStart' needs "this.". 438
 Warning coding RequireThis Reference to instance variable 'placesToStart' needs "this.". 439
 Warning coding FinalLocalVariable Variable 'failedPlaceList' should be declared final. 453
 Warning coding FinalLocalVariable Variable 'failedCoordPlaceList' should be declared final. 458
 Warning whitespace OperatorWrap '+' should be on a new line. 464
 Warning blocks RightCurly '}' at column 9 should be alone on a line. 505
 Warning misc FinalParameters Parameter theLocation should be final. 527
 Warning misc FinalParameters Parameter placeList should be final. 527
 Warning coding FinalLocalVariable Variable 'l' should be declared final. 529
 Warning misc FinalParameters Parameter location should be final. 537
 Warning coding FinalLocalVariable Variable 'dirPlace' should be declared final. 549
 Warning coding FinalLocalVariable Variable 'dirEntries' should be declared final. 550

emissary/admin/StartupIT.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'somePlaces' should be declared final. 38
 Warning coding FinalLocalVariable Variable 'node' should be declared final. 39
 Warning coding FinalLocalVariable Variable 'location' should be declared final. 40
 Warning coding FinalLocalVariable Variable 'startup' should be declared final. 48
 Warning coding FinalLocalVariable Variable 'pickups' should be declared final. 53
 Warning coding FinalLocalVariable Variable 'places' should be declared final. 54
 Warning coding FinalLocalVariable Variable 'node' should be declared final. 63
 Warning coding FinalLocalVariable Variable 'location' should be declared final. 64
 Warning coding FinalLocalVariable Variable 'entry' should be declared final. 94
 Warning coding FinalLocalVariable Variable 'dirEntries' should be declared final. 97
 Warning coding FinalLocalVariable Variable 'directoryPlace' should be declared final. 100
 Warning coding FinalLocalVariable Variable 'serverConfigStream' should be declared final. 116
 Warning coding FinalLocalVariable Variable 'serverLocation' should be declared final. 117
 Warning coding FinalLocalVariable Variable 'clientConfigStream' should be declared final. 123
 Warning coding FinalLocalVariable Variable 'clientLocation' should be declared final. 124

emissary/analyze/Analyzer.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'preferredViews' must be private and have accessor methods. 17
 Warning design VisibilityModifier Variable 'analyzedDataName' must be private and have accessor methods. 18
 Warning design VisibilityModifier Variable 'preferredViewPatternList' must be private and have accessor methods. 19
 Warning design VisibilityModifier Variable 'findPreferredViewByRegex' must be private and have accessor methods. 21
 Warning coding RequireThis Reference to instance variable 'findPreferredViewByRegex' needs "this.". 69
 Warning coding RequireThis Reference to instance variable 'preferredViewPatternList' needs "this.". 70
 Warning coding RequireThis Reference to instance variable 'preferredViews' needs "this.". 70
 Warning coding RequireThis Reference to instance variable 'findPreferredViewByRegex' needs "this.". 82
 Warning coding RequireThis Reference to instance variable 'preferredViewPatternList' needs "this.". 83
 Warning coding RequireThis Reference to instance variable 'preferredViews' needs "this.". 85

emissary/client/EmissaryClient.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'context' must be private and have accessor methods. 74
 Warning design VisibilityModifier Variable 'retries' must be private and have accessor methods. 75
 Warning design VisibilityModifier Variable 'username' must be private and have accessor methods. 76
 Warning design VisibilityModifier Variable 'connectionTimeout' must be private and have accessor methods. 78
 Warning design VisibilityModifier Variable 'connectionManagerTimeout' must be private and have accessor methods. 80
 Warning design VisibilityModifier Variable 'socketTimeout' must be private and have accessor methods. 82
 Warning misc FinalParameters Parameter requestConfig should be final. 168
 Warning misc FinalParameters Parameter connectionConfig should be final. 168
 Warning misc FinalParameters Parameter client should be final. 172
 Warning misc FinalParameters Parameter client should be final. 176
 Warning misc FinalParameters Parameter requestConfig should be final. 176
 Warning misc FinalParameters Parameter connectionConfig should be final. 176
 Warning coding FinalLocalVariable Variable 'localContext' should be declared final. 199
 Warning coding RequireThis Reference to instance variable 'requestConfig' needs "this.". 210
 Warning coding FinalLocalVariable Variable 'thisClient' should be declared final. 211
 Warning coding FinalLocalVariable Variable 'response' should be declared final. 215
 Warning coding RequireThis Reference to instance variable 'client' needs "this.". 222
 Warning coding RequireThis Reference to instance variable 'requestConfig' needs "this.". 226
 Warning coding RequireThis Reference to instance variable 'connectionConfig' needs "this.". 230
 Warning misc FinalParameters Parameter timeout should be final. 234
 Warning coding RequireThis Reference to instance variable 'connectionConfig' needs "this.". 236
 Warning coding RequireThis Reference to instance variable 'connectionConfig' needs "this.". 236
 Warning misc FinalParameters Parameter uri should be final. 246
 Warning misc FinalParameters Parameter context should be final. 246
 Warning coding HiddenField 'context' hides a field. 246
 Warning misc FinalParameters Parameter endpoint should be final. 246
 Warning misc FinalParameters Parameter uri should be final. 250
 Warning misc FinalParameters Parameter uri should be final. 254
 Warning misc FinalParameters Parameter csrfToken should be final. 254
 Warning coding FinalLocalVariable Variable 'method' should be declared final. 255
 Warning misc FinalParameters Parameter request should be final. 260
 Warning misc FinalParameters Parameter csrfToken should be final. 260
 Warning misc FinalParameters Parameter request should be final. 264
 Warning misc FinalParameters Parameter csrfParam should be final. 264
 Warning misc FinalParameters Parameter csrfToken should be final. 264

emissary/client/EmissaryClientTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'origCfg' should be declared final. 31
 Warning coding FinalLocalVariable Variable 'hiddenCfg' should be declared final. 32
 Warning coding FinalLocalVariable Variable 'client' should be declared final. 37
 Warning coding FinalLocalVariable Variable 'requestConfig' should be declared final. 38
 Warning coding FinalLocalVariable Variable 'connectionConfig' should be declared final. 39
 Warning coding FinalLocalVariable Variable 'client' should be declared final. 62
 Warning coding FinalLocalVariable Variable 'requestConfig' should be declared final. 63
 Warning coding FinalLocalVariable Variable 'connectionConfig' should be declared final. 64
 Warning coding FinalLocalVariable Variable 'cfgFile' should be declared final. 75
 Warning coding FinalLocalVariable Variable 'newConnectionTimeout' should be declared final. 77
 Warning coding FinalLocalVariable Variable 'newConnectionManagerTimeout' should be declared final. 78
 Warning coding FinalLocalVariable Variable 'newSocketTimeout' should be declared final. 79
 Warning coding FinalLocalVariable Variable 'cfg' should be declared final. 80
 Warning coding FinalLocalVariable Variable 'data' should be declared final. 83
 Warning coding FinalLocalVariable Variable 'client' should be declared final. 86
 Warning coding FinalLocalVariable Variable 'requestConfig' should be declared final. 87
 Warning coding FinalLocalVariable Variable 'connectionConfig' should be declared final. 88
 Warning coding FinalLocalVariable Variable 'client' should be declared final. 103
 Warning coding FinalLocalVariable Variable 'connectionConfig' should be declared final. 105
 Warning coding FinalLocalVariable Variable 'valueInCfgOnClasspath' should be declared final. 107
 Warning coding FinalLocalVariable Variable 'newTimeout' should be declared final. 109

emissary/client/EmissaryResponse.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'status' must be private and have accessor methods. 28
 Warning design VisibilityModifier Variable 'content' must be private and have accessor methods. 30
 Warning design VisibilityModifier Variable 'contentType' must be private and have accessor methods. 31
 Warning design VisibilityModifier Variable 'headers' must be private and have accessor methods. 32
 Warning design VisibilityModifier Variable 'objectMapper' must be private and have accessor methods. 33
 Warning misc FinalParameters Parameter response should be final. 35
 Warning coding RequireThis Reference to instance variable 'headers' needs "this.". 38
 Warning coding FinalLocalVariable Variable 'contentHeaders' should be declared final. 39
 Warning coding RequireThis Reference to instance variable 'contentType' needs "this.". 41
 Warning coding RequireThis Reference to instance variable 'contentType' needs "this.". 50
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 53
 Warning coding RequireThis Reference to instance variable 'status' needs "this.". 66
 Warning coding RequireThis Reference to instance variable 'content' needs "this.". 67
 Warning coding RequireThis Reference to instance variable 'status' needs "this.". 71
 Warning coding RequireThis Reference to instance variable 'headers' needs "this.". 75
 Warning coding RequireThis Reference to instance variable 'content' needs "this.". 80
 Warning coding RequireThis Reference to instance variable 'status' needs "this.". 84
 Warning coding RequireThis Reference to instance variable 'content' needs "this.". 85
 Warning coding RequireThis Reference to instance variable 'status' needs "this.". 87
 Warning coding RequireThis Reference to instance variable 'content' needs "this.". 87
 Warning misc FinalParameters Parameter mapper should be final. 91
 Warning coding RequireThis Reference to instance variable 'content' needs "this.". 92
 Warning coding RequireThis Reference to instance variable 'status' needs "this.". 96
 Warning coding RequireThis Reference to instance variable 'objectMapper' needs "this.". 97
 Warning coding RequireThis Reference to instance variable 'content' needs "this.". 97
 Warning coding RequireThis Reference to instance variable 'content' needs "this.". 99
 Warning coding RequireThis Reference to instance variable 'content' needs "this.". 103
 Warning misc FinalParameters Parameter msg should be final. 107
 Warning misc FinalParameters Parameter mapper should be final. 107
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 110
 Warning misc FinalParameters Parameter response should be final. 124
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 125
 Warning coding FinalLocalVariable Variable 'er' should be declared final. 126

emissary/client/HTTPConnectionFactory.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'connMan' must be private and have accessor methods. 79
 Warning design VisibilityModifier Variable 'maxConns' must be private and have accessor methods. 83
 Warning design VisibilityModifier Variable 'userAgent' must be private and have accessor methods. 85

emissary/client/HTTPConnectionFactoryTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'pw' should be declared final. 117

emissary/client/response/Agent.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 21 should be alone on a line. 22
 Warning misc FinalParameters Parameter name should be final. 24
 Warning misc FinalParameters Parameter status should be final. 24
 Warning coding RequireThis Reference to instance variable 'name' needs "this.". 30
 Warning misc FinalParameters Parameter name should be final. 33
 Warning coding HiddenField 'name' hides a field. 33
 Warning coding RequireThis Reference to instance variable 'status' needs "this.". 38
 Warning misc FinalParameters Parameter status should be final. 41
 Warning coding HiddenField 'status' hides a field. 41
 Warning misc FinalParameters Parameter o should be final. 46
 Warning misc FinalParameters Parameter o should be final. 51

emissary/client/response/AgentList.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'agents' needs "this.". 27
 Warning misc FinalParameters Parameter host should be final. 30
 Warning misc FinalParameters Parameter agents should be final. 30
 Warning coding RequireThis Reference to instance variable 'host' needs "this.". 36
 Warning misc FinalParameters Parameter host should be final. 39
 Warning coding HiddenField 'host' hides a field. 39
 Warning coding RequireThis Reference to instance variable 'agents' needs "this.". 44
 Warning misc FinalParameters Parameter agents should be final. 47
 Warning coding HiddenField 'agents' hides a field. 47
 Warning misc FinalParameters Parameter agent should be final. 51
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 56

emissary/client/response/AgentsFormatter.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'json' should be declared final. 22
 Warning coding FinalLocalVariable Variable 'json' should be declared final. 29
 Warning coding FinalLocalVariable Variable 'json' should be declared final. 35
 Warning coding RequireThis Reference to instance variable 'timestamp' needs "this.". 36
 Warning coding RequireThis Reference to instance variable 'host' needs "this.". 37
 Warning coding HiddenField 'host' hides a field. 49
 Warning coding HiddenField 'timestamp' hides a field. 54

emissary/client/response/AgentsFormatterTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'expected' should be declared final. 11
 Warning coding FinalLocalVariable Variable 'formatter' should be declared final. 12
 Warning coding FinalLocalVariable Variable 'agent' should be declared final. 18
 Warning coding FinalLocalVariable Variable 'expected' should be declared final. 19
 Warning coding FinalLocalVariable Variable 'formatter' should be declared final. 20

emissary/client/response/AgentsListTest.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'lc' needs "this.". 21
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 25
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 26
 Warning coding RequireThis Reference to instance variable 'rootLogger' needs "this.". 27
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 27
 Warning coding RequireThis Reference to instance variable 'rootLogger' needs "this.". 32
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 32
 Warning coding FinalLocalVariable Variable 'agent1' should be declared final. 37
 Warning coding VariableDeclarationUsageDistance Distance between variable 'agent2' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 38
 Warning coding FinalLocalVariable Variable 'agent2' should be declared final. 38
 Warning coding FinalLocalVariable Variable 'agent3' should be declared final. 39
 Warning coding FinalLocalVariable Variable 'agentSet' should be declared final. 42
 Warning coding FinalLocalVariable Variable 'agentList' should be declared final. 46
 Warning coding FinalLocalVariable Variable 'expected' should be declared final. 50
 Warning whitespace OperatorWrap '+' should be on a new line. 50
 Warning whitespace OperatorWrap '+' should be on a new line. 51
 Warning whitespace OperatorWrap '+' should be on a new line. 52
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 55

emissary/client/response/AgentsResponseEntity.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 36 should be alone on a line. 26
 Warning misc FinalParameters Parameter local should be final. 28
 Warning misc FinalParameters Parameter pl should be final. 32
 Warning coding RequireThis Reference to instance variable 'local' needs "this.". 39
 Warning misc FinalParameters Parameter local should be final. 42
 Warning coding HiddenField 'local' hides a field. 42
 Warning coding RequireThis Reference to instance variable 'cluster' needs "this.". 47
 Warning misc FinalParameters Parameter e should be final. 51
 Warning coding FinalLocalVariable Variable 'pre' should be declared final. 54
 Warning coding RequireThis Reference to instance variable 'cluster' needs "this.". 61
 Warning coding RequireThis Reference to instance variable 'local' needs "this.". 61

emissary/client/response/BaseResponseEntity.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter error should be final. 24
 Warning coding RequireThis Reference to instance variable 'errors' needs "this.". 25
 Warning misc FinalParameters Parameter entity should be final. 34
 Warning misc FinalParameters Parameter errors should be final. 39
 Warning coding HiddenField 'errors' hides a field. 39

emissary/client/response/Config.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'flavors' must be private and have accessor methods. 18
 Warning design VisibilityModifier Variable 'configs' must be private and have accessor methods. 21
 Warning design VisibilityModifier Variable 'entries' must be private and have accessor methods. 24
 Warning blocks RightCurly '}' at column 22 should be alone on a line. 26
 Warning misc FinalParameters Parameter flavors should be final. 28
 Warning misc FinalParameters Parameter configs should be final. 28
 Warning misc FinalParameters Parameter entries should be final. 28
 Warning coding RequireThis Reference to instance variable 'flavors' needs "this.". 35
 Warning misc FinalParameters Parameter flavors should be final. 38
 Warning coding HiddenField 'flavors' hides a field. 38
 Warning coding RequireThis Reference to instance variable 'configs' needs "this.". 43
 Warning misc FinalParameters Parameter configs should be final. 46
 Warning coding HiddenField 'configs' hides a field. 46
 Warning coding RequireThis Reference to instance variable 'entries' needs "this.". 51
 Warning misc FinalParameters Parameter entries should be final. 54
 Warning coding HiddenField 'entries' hides a field. 54
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 60

emissary/client/response/ConfigList.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'configs' needs "this.". 25
 Warning coding RequireThis Reference to instance variable 'configs' needs "this.". 29
 Warning misc FinalParameters Parameter configs should be final. 32
 Warning coding HiddenField 'configs' hides a field. 32
 Warning misc FinalParameters Parameter config should be final. 36
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 41

emissary/client/response/ConfigsResponseEntity.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 37 should be alone on a line. 21
 Warning misc FinalParameters Parameter local should be final. 23
 Warning coding RequireThis Reference to instance variable 'local' needs "this.". 28
 Warning misc FinalParameters Parameter local should be final. 31
 Warning coding HiddenField 'local' hides a field. 31
 Warning misc FinalParameters Parameter e should be final. 36

emissary/client/response/Directory.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 25 should be alone on a line. 35
 Warning misc FinalParameters Parameter directoryEntry should be final. 37
 Warning coding RequireThis Reference to instance variable 'entry' needs "this.". 43
 Warning coding RequireThis Reference to instance variable 'directoryEntry' needs "this.". 43
 Warning coding RequireThis Reference to instance variable 'dataId' needs "this.". 44
 Warning coding RequireThis Reference to instance variable 'directoryEntry' needs "this.". 44
 Warning coding RequireThis Reference to instance variable 'cost' needs "this.". 45
 Warning coding RequireThis Reference to instance variable 'directoryEntry' needs "this.". 45
 Warning coding RequireThis Reference to instance variable 'quality' needs "this.". 46
 Warning coding RequireThis Reference to instance variable 'directoryEntry' needs "this.". 46
 Warning coding RequireThis Reference to instance variable 'expense' needs "this.". 47
 Warning coding RequireThis Reference to instance variable 'directoryEntry' needs "this.". 47
 Warning coding RequireThis Reference to instance variable 'directoryEntry' needs "this.". 51
 Warning misc FinalParameters Parameter directoryEntry should be final. 54
 Warning coding HiddenField 'directoryEntry' hides a field. 54
 Warning coding RequireThis Reference to instance variable 'entry' needs "this.". 59
 Warning misc FinalParameters Parameter entry should be final. 62
 Warning coding HiddenField 'entry' hides a field. 62
 Warning coding RequireThis Reference to instance variable 'dataId' needs "this.". 67
 Warning misc FinalParameters Parameter dataId should be final. 70
 Warning coding HiddenField 'dataId' hides a field. 70
 Warning coding RequireThis Reference to instance variable 'cost' needs "this.". 75
 Warning misc FinalParameters Parameter cost should be final. 78
 Warning coding HiddenField 'cost' hides a field. 78
 Warning coding RequireThis Reference to instance variable 'quality' needs "this.". 83
 Warning misc FinalParameters Parameter quality should be final. 86
 Warning coding HiddenField 'quality' hides a field. 86
 Warning coding RequireThis Reference to instance variable 'expense' needs "this.". 91
 Warning misc FinalParameters Parameter expense should be final. 94
 Warning coding HiddenField 'expense' hides a field. 94
 Warning misc FinalParameters Parameter o should be final. 99
 Warning misc FinalParameters Parameter o should be final. 104

emissary/client/response/DirectoryList.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'entries' needs "this.". 27
 Warning misc FinalParameters Parameter directoryPlace should be final. 30
 Warning misc FinalParameters Parameter entries should be final. 30
 Warning coding RequireThis Reference to instance variable 'directoryPlace' needs "this.". 36
 Warning misc FinalParameters Parameter directoryPlace should be final. 39
 Warning coding HiddenField 'directoryPlace' hides a field. 39
 Warning coding RequireThis Reference to instance variable 'entries' needs "this.". 44
 Warning misc FinalParameters Parameter entries should be final. 47
 Warning coding HiddenField 'entries' hides a field. 47
 Warning misc FinalParameters Parameter entry should be final. 51
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 57

emissary/client/response/DirectoryResponseEntity.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 39 should be alone on a line. 20
 Warning misc FinalParameters Parameter local should be final. 22
 Warning coding RequireThis Reference to instance variable 'local' needs "this.". 27
 Warning misc FinalParameters Parameter local should be final. 30
 Warning coding HiddenField 'local' hides a field. 30
 Warning misc FinalParameters Parameter local should be final. 34
 Warning coding HiddenField 'local' hides a field. 34
 Warning misc FinalParameters Parameter e should be final. 39

emissary/client/response/MapResponseEntity.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'response' needs "this.". 24
 Warning misc FinalParameters Parameter key should be final. 27
 Warning misc FinalParameters Parameter value should be final. 27
 Warning misc FinalParameters Parameter e should be final. 36
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 39

emissary/client/response/PeerList.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter host should be final. 24
 Warning misc FinalParameters Parameter peers should be final. 24
 Warning blocks RightCurly '}' at column 24 should be alone on a line. 30
 Warning coding RequireThis Reference to instance variable 'host' needs "this.". 33
 Warning misc FinalParameters Parameter host should be final. 36
 Warning coding HiddenField 'host' hides a field. 36
 Warning coding RequireThis Reference to instance variable 'peers' needs "this.". 41
 Warning misc FinalParameters Parameter peers should be final. 44
 Warning coding HiddenField 'peers' hides a field. 44
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 49

emissary/client/response/PeersResponseEntity.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 35 should be alone on a line. 27
 Warning misc FinalParameters Parameter local should be final. 29
 Warning misc FinalParameters Parameter pl should be final. 33
 Warning coding RequireThis Reference to instance variable 'cluster' needs "this.". 34
 Warning coding RequireThis Reference to instance variable 'cluster' needs "this.". 35
 Warning coding RequireThis Reference to instance variable 'local' needs "this.". 41
 Warning misc FinalParameters Parameter local should be final. 44
 Warning coding HiddenField 'local' hides a field. 44
 Warning coding RequireThis Reference to instance variable 'cluster' needs "this.". 49
 Warning misc FinalParameters Parameter e should be final. 53
 Warning coding FinalLocalVariable Variable 'pre' should be declared final. 56
 Warning coding FinalLocalVariable Variable 'errors' should be declared final. 69
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 71

emissary/client/response/PlaceList.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'places' needs "this.". 27
 Warning misc FinalParameters Parameter host should be final. 30
 Warning misc FinalParameters Parameter places should be final. 30
 Warning coding RequireThis Reference to instance variable 'host' needs "this.". 36
 Warning misc FinalParameters Parameter host should be final. 39
 Warning coding HiddenField 'host' hides a field. 39
 Warning coding RequireThis Reference to instance variable 'places' needs "this.". 44
 Warning misc FinalParameters Parameter places should be final. 47
 Warning coding HiddenField 'places' hides a field. 47
 Warning misc FinalParameters Parameter place should be final. 51
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 56

emissary/client/response/PlacesResponseEntity.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 36 should be alone on a line. 27
 Warning misc FinalParameters Parameter local should be final. 29
 Warning misc FinalParameters Parameter pl should be final. 33
 Warning coding RequireThis Reference to instance variable 'cluster' needs "this.". 34
 Warning coding RequireThis Reference to instance variable 'cluster' needs "this.". 35
 Warning coding RequireThis Reference to instance variable 'local' needs "this.". 44
 Warning misc FinalParameters Parameter local should be final. 47
 Warning coding HiddenField 'local' hides a field. 47
 Warning coding RequireThis Reference to instance variable 'cluster' needs "this.". 52
 Warning misc FinalParameters Parameter e should be final. 56
 Warning coding FinalLocalVariable Variable 'pre' should be declared final. 59

emissary/command/AgentsCommand.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter client should be final. 23
 Warning misc FinalParameters Parameter endpoint should be final. 23

emissary/command/Banner.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'in' should be declared final. 18
 Warning coding RequireThis Reference to instance variable 'bannerText' needs "this.". 20
 Warning coding FinalLocalVariable Variable 'reader' should be declared final. 24
 Warning coding FinalLocalVariable Variable 'result' should be declared final. 25
 Warning coding RequireThis Reference to instance variable 'bannerText' needs "this.". 34
 Warning coding RequireThis Reference to instance variable 'bannerText' needs "this.". 40

emissary/command/BaseCommand.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 67
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 68
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 69
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 70
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 74
 Warning coding RequireThis Reference to instance variable 'projectBase' needs "this.". 78
 Warning coding RequireThis Reference to instance variable 'logbackConfig' needs "this.". 82
 Warning coding RequireThis Reference to instance variable 'logbackConfig' needs "this.". 85
 Warning coding RequireThis Reference to instance variable 'flavor' needs "this.". 89
 Warning misc FinalParameters Parameter flavor should be final. 92
 Warning coding HiddenField 'flavor' hides a field. 92
 Warning coding RequireThis Reference to instance variable 'binDir' needs "this.". 99
 Warning coding RequireThis Reference to instance variable 'binDir' needs "this.". 102
 Warning coding RequireThis Reference to instance variable 'outputDir' needs "this.". 106
 Warning coding RequireThis Reference to instance variable 'outputDir' needs "this.". 109
 Warning coding RequireThis Reference to instance variable 'errorDir' needs "this.". 113
 Warning coding RequireThis Reference to instance variable 'errorDir' needs "this.". 116
 Warning coding RequireThis Reference to instance variable 'quiet' needs "this.". 120
 Warning misc FinalParameters Parameter key should be final. 143
 Warning misc FinalParameters Parameter value should be final. 143
 Warning misc FinalParameters Parameter clazz should be final. 157
 Warning misc FinalParameters Parameter args should be final. 157
 Warning coding FinalLocalVariable Variable 'cmd' should be declared final. 158
 Warning coding FinalLocalVariable Variable 'baos' should be declared final. 164
 Warning coding FinalLocalVariable Variable 'ps' should be declared final. 165
 Warning coding FinalLocalVariable Variable 'old' should be declared final. 166
 Warning coding FinalLocalVariable Variable 'cl' should be declared final. 169
 Warning coding FinalLocalVariable Variable 'code' should be declared final. 170
 Warning misc FinalParameters Parameter clazz should be final. 193
 Warning misc FinalParameters Parameter args should be final. 193
 Warning coding FinalLocalVariable Variable 'loggerContext' should be declared final. 206
 Warning coding FinalLocalVariable Variable 'logCfg' should be declared final. 207
 Warning misc FinalParameters Parameter loggerContext should be final. 221
 Warning misc FinalParameters Parameter configFilePath should be final. 221
 Warning coding FinalLocalVariable Variable 'newContext' should be declared final. 224
 Warning misc FinalParameters Parameter format should be final. 232
 Warning misc FinalParameters Parameter args should be final. 232
 Warning blocks RightCurly '}' at column 24 should be alone on a line. 246

emissary/command/BaseCommandTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'flavorString' should be declared final. 18
 Warning coding FinalLocalVariable Variable 'args' should be declared final. 19
 Warning coding FinalLocalVariable Variable 'cmd' should be declared final. 24
 Warning misc FinalParameters Parameter c should be final. 36

emissary/command/ConfigCommand.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'offline' needs "this.". 51
 Warning coding RequireThis Reference to instance variable 'spec' needs "this.". 52
 Warning coding RequireThis Reference to instance variable 'offline' needs "this.". 55
 Warning misc FinalParameters Parameter c should be final. 62
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 65
 Warning coding RequireThis Reference to instance variable 'offline' needs "this.". 65
 Warning coding FinalLocalVariable Variable 'endpoint' should be declared final. 73
 Warning coding RequireThis Reference to instance variable 'detailed' needs "this.". 73
 Warning coding FinalLocalVariable Variable 'client' should be declared final. 75
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 81
 Warning coding RequireThis Reference to instance variable 'detailed' needs "this.". 81

emissary/command/DirectoryCommand.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter client should be final. 28
 Warning misc FinalParameters Parameter endpoint should be final. 28

emissary/command/EmissaryCommand.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 25 should be alone on a line. 24

emissary/command/EnvCommand.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'bashable' needs "this.". 37
 Warning coding RequireThis Reference to instance variable 'bashable' needs "this.". 43
 Warning misc FinalParameters Parameter c should be final. 50
 Warning coding FinalLocalVariable Variable 'lc' should be declared final. 55
 Warning coding FinalLocalVariable Variable 'jettyUtilLogger' should be declared final. 58
 Warning coding FinalLocalVariable Variable 'client' should be declared final. 67

emissary/command/FeedCommand.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'priorityDirectories' needs "this.". 101
 Warning coding RequireThis Reference to instance variable 'spec' needs "this.". 103
 Warning coding RequireThis Reference to instance variable 'workspaceClass' needs "this.". 106
 Warning coding FinalLocalVariable Variable 'ws' should be declared final. 108
 Warning coding RequireThis Reference to instance variable 'workspaceClass' needs "this.". 108
 Warning coding RequireThis Reference to instance variable 'workspaceClass' needs "this.". 111
 Warning coding FinalLocalVariable Variable 'flavorSet' should be declared final. 129
 Warning coding RequireThis Reference to instance variable 'workspaceClass' needs "this.". 138
 Warning coding RequireThis Reference to instance variable 'simple' needs "this.". 142
 Warning coding RequireThis Reference to instance variable 'caseId' needs "this.". 146
 Warning coding RequireThis Reference to instance variable 'caseClass' needs "this.". 150
 Warning coding RequireThis Reference to instance variable 'eatPrefix' needs "this.". 154
 Warning coding RequireThis Reference to instance variable 'skipDotFile' needs "this.". 158
 Warning coding RequireThis Reference to instance variable 'includeDirs' needs "this.". 162
 Warning coding RequireThis Reference to instance variable 'clientPattern' needs "this.". 166
 Warning coding RequireThis Reference to instance variable 'bundleSize' needs "this.". 170
 Warning coding RequireThis Reference to instance variable 'priorityDirectories' needs "this.". 181
 Warning coding RequireThis Reference to instance variable 'sort' needs "this.". 185
 Warning coding RequireThis Reference to instance variable 'workspaceName' needs "this.". 189
 Warning coding RequireThis Reference to instance variable 'loop' needs "this.". 193
 Warning coding RequireThis Reference to instance variable 'retry' needs "this.". 197
 Warning coding RequireThis Reference to instance variable 'fileTimestamp' needs "this.". 201

emissary/command/FeedCommandIT.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'tmpDir' must be private and have accessor methods. 54
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 58
 Warning coding RequireThis Reference to instance variable 'baseDir' needs "this.". 59
 Warning coding RequireThis Reference to instance variable 'inputDir' needs "this.". 60
 Warning coding RequireThis Reference to instance variable 'tmpDir' needs "this.". 60
 Warning coding RequireThis Reference to instance variable 'arguments' needs "this.". 61
 Warning coding RequireThis Reference to instance variable 'inputDir' needs "this.". 67
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 74
 Warning coding RequireThis Reference to instance variable 'arguments' needs "this.". 81
 Warning coding RequireThis Reference to instance variable 'baseDir' needs "this.". 81
 Warning coding RequireThis Reference to instance variable 'inputDir' needs "this.". 81
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 84
 Warning coding RequireThis Reference to instance variable 'arguments' needs "this.". 84
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 87
 Warning coding RequireThis Reference to instance variable 'inputDir' needs "this.". 88
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 88
 Warning coding RequireThis Reference to instance variable 'baseDir' needs "this.". 89
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 89
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 92
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 93
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 94
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 95
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 96
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 97
 Warning coding RequireThis Reference to instance variable 'baseDir' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 99
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 100
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 101
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 102
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 103
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 104
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 105
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 106
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 107
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 108
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 109
 Warning design VisibilityModifier Variable 'cartesian' must be private and have accessor methods. 113
 Warning misc FinalParameters Parameter context should be final. 121
 Warning coding RequireThis Reference to instance variable 'cartesian' needs "this.". 122
 Warning misc FinalParameters Parameter baseDirArg should be final. 128
 Warning misc FinalParameters Parameter inputDirArg should be final. 129
 Warning misc FinalParameters Parameter stringArg should be final. 130
 Warning misc FinalParameters Parameter booleanArg should be final. 131
 Warning misc FinalParameters Parameter intArg should be final. 132
 Warning coding RequireThis Reference to instance variable 'arguments' needs "this.". 134
 Warning coding RequireThis Reference to instance variable 'arguments' needs "this.". 135
 Warning coding RequireThis Reference to instance variable 'baseDir' needs "this.". 135
 Warning coding RequireThis Reference to instance variable 'arguments' needs "this.". 136
 Warning coding RequireThis Reference to instance variable 'arguments' needs "this.". 137
 Warning coding RequireThis Reference to instance variable 'inputDir' needs "this.". 137
 Warning coding RequireThis Reference to instance variable 'arguments' needs "this.". 138
 Warning coding RequireThis Reference to instance variable 'arguments' needs "this.". 139
 Warning coding RequireThis Reference to instance variable 'arguments' needs "this.". 140
 Warning coding RequireThis Reference to instance variable 'arguments' needs "this.". 141
 Warning coding RequireThis Reference to instance variable 'arguments' needs "this.". 142
 Warning coding RequireThis Reference to instance variable 'arguments' needs "this.". 145
 Warning coding RequireThis Reference to instance variable 'baseDir' needs "this.". 150
 Warning coding RequireThis Reference to instance variable 'inputDir' needs "this.". 150
 Warning coding RequireThis Reference to instance variable 'baseDir' needs "this.". 156
 Warning coding RequireThis Reference to instance variable 'inputDir' needs "this.". 156
 Warning coding RequireThis Reference to instance variable 'baseDir' needs "this.". 163
 Warning coding RequireThis Reference to instance variable 'inputDir' needs "this.". 163

emissary/command/HelpCommand.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'subcommands' must be private and have accessor methods. 26
 Warning coding RequireThis Reference to instance variable 'subcommands' needs "this.". 30
 Warning coding RequireThis Reference to instance variable 'subcommands' needs "this.". 34
 Warning misc FinalParameters Parameter c should be final. 43
 Warning coding RequireThis Reference to instance variable 'subcommands' needs "this.". 45
 Warning coding RequireThis Reference to instance variable 'subcommands' needs "this.". 47
 Warning coding FinalLocalVariable Variable 'subcommand' should be declared final. 51
 Warning misc FinalParameters Parameter cl should be final. 61
 Warning coding FinalLocalVariable Variable 'descList' should be declared final. 65
 Warning misc FinalParameters Parameter c should be final. 75
 Warning misc FinalParameters Parameter subcommand should be final. 75
 Warning coding FinalLocalVariable Variable 'help' should be declared final. 78

emissary/command/HttpCommand.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'port' needs "this.". 55
 Warning coding RequireThis Reference to instance variable 'host' needs "this.". 59
 Warning coding RequireThis Reference to instance variable 'scheme' needs "this.". 63
 Warning coding RequireThis Reference to instance variable 'jettyUserFile' needs "this.". 67
 Warning coding RequireThis Reference to instance variable 'sslEnabled' needs "this.". 71
 Warning coding RequireThis Reference to instance variable 'sniDisabled' needs "this.". 79
 Warning coding RequireThis Reference to instance variable 'sslEnabled' needs "this.". 94
 Warning coding FinalLocalVariable Variable 'flavorMode' should be declared final. 95
 Warning coding FinalLocalVariable Variable 'flavorSet' should be declared final. 103
 Warning coding RequireThis Reference to instance variable 'scheme' needs "this.". 112
 Warning coding RequireThis Reference to instance variable 'host' needs "this.". 118
 Warning coding RequireThis Reference to instance variable 'port' needs "this.". 119
 Warning coding RequireThis Reference to instance variable 'scheme' needs "this.". 120
 Warning misc FinalParameters Parameter endpoint should be final. 130
 Warning misc FinalParameters Parameter endpoint should be final. 140
 Warning coding FinalLocalVariable Variable 'client' should be declared final. 141
 Warning coding FinalLocalVariable Variable 'post' should be declared final. 142
 Warning misc FinalParameters Parameter endpoint should be final. 156

emissary/command/MonitorCommand.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'monitor' needs "this.". 34
 Warning coding RequireThis Reference to instance variable 'sleepInterval' needs "this.". 38
 Warning coding RequireThis Reference to instance variable 'clustered' needs "this.". 42
 Warning misc FinalParameters Parameter c should be final. 50
 Warning blocks RightCurly '}' at column 13 should be alone on a line. 59
 Warning coding FinalLocalVariable Variable 'client' should be declared final. 66
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 68
 Warning coding FinalLocalVariable Variable 'endpoint' should be declared final. 83
 Warning coding FinalLocalVariable Variable 'response' should be declared final. 84
 Warning coding RequireThis Reference to instance variable 'lock' needs "this.". 85
 Warning coding RequireThis Reference to instance variable 'lock' needs "this.". 90
 Warning misc FinalParameters Parameter entity should be final. 99

emissary/command/PeersCommand.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter c should be final. 40
 Warning coding RequireThis Reference to instance variable 'delimiter' needs "this.". 43
 Warning coding RequireThis Reference to instance variable 'ignoreHost' needs "this.". 43
 Warning coding RequireThis Reference to instance variable 'delimiter' needs "this.". 52
 Warning coding FinalLocalVariable Variable 'replaced' should be declared final. 53
 Warning coding RequireThis Reference to instance variable 'delimiter' needs "this.". 53
 Warning coding RequireThis Reference to instance variable 'delimiter' needs "this.". 54
 Warning misc FinalParameters Parameter wantPort should be final. 59
 Warning coding FinalLocalVariable Variable 'peerConfig' should be declared final. 60
 Warning coding FinalLocalVariable Variable 'peer' should be declared final. 65

emissary/command/PeersCommandIT.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'arguments' needs "this.". 40
 Warning coding RequireThis Reference to instance variable 'outContent' needs "this.". 41
 Warning coding RequireThis Reference to instance variable 'errContent' needs "this.". 42
 Warning coding RequireThis Reference to instance variable 'arguments' needs "this.". 49
 Warning coding RequireThis Reference to instance variable 'outContent' needs "this.". 50
 Warning coding RequireThis Reference to instance variable 'errContent' needs "this.". 51
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 52
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 58
 Warning coding RequireThis Reference to instance variable 'arguments' needs "this.". 58
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 61
 Warning coding RequireThis Reference to instance variable 'outContent' needs "this.". 64
 Warning coding RequireThis Reference to instance variable 'arguments' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 74
 Warning coding RequireThis Reference to instance variable 'arguments' needs "this.". 74
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 77
 Warning coding RequireThis Reference to instance variable 'outContent' needs "this.". 80
 Warning coding RequireThis Reference to instance variable 'arguments' needs "this.". 89
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 90
 Warning coding RequireThis Reference to instance variable 'arguments' needs "this.". 90
 Warning coding FinalLocalVariable Variable 'newLine' should be declared final. 91
 Warning coding FinalLocalVariable Variable 'expected' should be declared final. 92
 Warning coding RequireThis Reference to instance variable 'command' needs "this.". 95
 Warning coding RequireThis Reference to instance variable 'outContent' needs "this.". 98
 Warning coding FinalLocalVariable Variable 'peers' should be declared final. 104
 Warning coding FinalLocalVariable Variable 'peers' should be declared final. 114
 Warning coding FinalLocalVariable Variable 'peers' should be declared final. 124
 Warning coding FinalLocalVariable Variable 'peers' should be declared final. 133
 Warning misc FinalParameters Parameter cmd should be final. 148
 Warning coding VariableDeclarationUsageDistance Distance between variable 'origOut' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 149
 Warning coding FinalLocalVariable Variable 'origOut' should be declared final. 149
 Warning coding VariableDeclarationUsageDistance Distance between variable 'origErr' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 150
 Warning coding FinalLocalVariable Variable 'origErr' should be declared final. 150
 Warning coding RequireThis Reference to instance variable 'outContent' needs "this.". 151
 Warning coding RequireThis Reference to instance variable 'errContent' needs "this.". 152

emissary/command/PoolCommand.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter client should be final. 23
 Warning misc FinalParameters Parameter endpoint should be final. 23

emissary/command/ServerCommand.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'mode' needs "this.". 57
 Warning coding RequireThis Reference to instance variable 'staticDir' needs "this.". 61
 Warning coding RequireThis Reference to instance variable 'agents' needs "this.". 65
 Warning coding RequireThis Reference to instance variable 'dumpJettyBeans' needs "this.". 69
 Warning coding RequireThis Reference to instance variable 'strictMode' needs "this.". 78
 Warning coding FinalLocalVariable Variable 'flavorMode' should be declared final. 89
 Warning coding FinalLocalVariable Variable 'flavorSet' should be declared final. 101
 Warning misc FinalParameters Parameter state should be final. 129
 Warning coding FinalLocalVariable Variable 'response' should be declared final. 131

emissary/command/ServerCommandIT.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'cmd' should be declared final. 19
 Warning coding FinalLocalVariable Variable 'cmd' should be declared final. 25
 Warning coding FinalLocalVariable Variable 'cmd' should be declared final. 31
 Warning coding FinalLocalVariable Variable 'e' should be declared final. 37

emissary/command/ServiceCommand.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'csrf' needs "this.". 44
 Warning coding RequireThis Reference to instance variable 'stop' needs "this.". 48
 Warning coding RequireThis Reference to instance variable 'kill' needs "this.". 52
 Warning coding RequireThis Reference to instance variable 'pause' needs "this.". 56
 Warning coding RequireThis Reference to instance variable 'unpause' needs "this.". 60
 Warning misc FinalParameters Parameter c should be final. 92
 Warning coding FinalLocalVariable Variable 'response' should be declared final. 97
 Warning coding FinalLocalVariable Variable 'isRunning' should be declared final. 98
 Warning coding FinalLocalVariable Variable 'response' should be declared final. 132

emissary/command/TopologyCommand.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter c should be final. 32
 Warning coding FinalLocalVariable Variable 'endpoint' should be declared final. 34
 Warning coding FinalLocalVariable Variable 'client' should be declared final. 36
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 37

emissary/command/VersionCommand.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'quiet' must be private and have accessor methods. 18
 Warning coding RequireThis Reference to instance variable 'quiet' needs "this.". 21
 Warning misc FinalParameters Parameter c should be final. 35

emissary/command/converter/FileExistsConverter.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter optionName should be final. 21
 Warning misc FinalParameters Parameter value should be final. 26
 Warning coding FinalLocalVariable Variable 'p' should be declared final. 27
 Warning coding FinalLocalVariable Variable 'msg' should be declared final. 29
 Warning coding RequireThis Reference to instance variable 'optionName' needs "this.". 29

emissary/command/converter/FileExistsConverterTest.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'path' needs "this.". 25
 Warning coding RequireThis Reference to instance variable 'converter' needs "this.". 26
 Warning coding RequireThis Reference to instance variable 'path' needs "this.". 32
 Warning coding FinalLocalVariable Variable 'result' should be declared final. 38
 Warning coding RequireThis Reference to instance variable 'converter' needs "this.". 38
 Warning coding RequireThis Reference to instance variable 'path' needs "this.". 38
 Warning coding FinalLocalVariable Variable 'result' should be declared final. 47
 Warning coding RequireThis Reference to instance variable 'converter' needs "this.". 47
 Warning coding RequireThis Reference to instance variable 'path' needs "this.". 47
 Warning coding RequireThis Reference to instance variable 'converter' needs "this.". 55

emissary/command/converter/ModeConverter.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter s should be final. 12

emissary/command/converter/PathExistsConverter.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter optionName should be final. 20
 Warning misc FinalParameters Parameter value should be final. 27
 Warning coding RequireThis Reference to instance variable 'optionName' needs "this.". 28
 Warning misc FinalParameters Parameter option should be final. 31
 Warning misc FinalParameters Parameter value should be final. 31
 Warning coding FinalLocalVariable Variable 'p' should be declared final. 32
 Warning coding FinalLocalVariable Variable 'msg' should be declared final. 35
 Warning coding RequireThis Reference to instance variable 'optionName' needs "this.". 43

emissary/command/converter/PathExistsConverterTest.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'path' needs "this.". 24
 Warning coding RequireThis Reference to instance variable 'converter' needs "this.". 25
 Warning coding RequireThis Reference to instance variable 'path' needs "this.". 31
 Warning coding FinalLocalVariable Variable 'result' should be declared final. 37
 Warning coding RequireThis Reference to instance variable 'converter' needs "this.". 37
 Warning coding RequireThis Reference to instance variable 'path' needs "this.". 37
 Warning coding FinalLocalVariable Variable 'result' should be declared final. 46
 Warning coding RequireThis Reference to instance variable 'converter' needs "this.". 46
 Warning coding RequireThis Reference to instance variable 'path' needs "this.". 46
 Warning coding RequireThis Reference to instance variable 'converter' needs "this.". 54

emissary/command/converter/PathExistsReadableConverter.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter optionName should be final. 15
 Warning misc FinalParameters Parameter value should be final. 22
 Warning coding FinalLocalVariable Variable 'p' should be declared final. 23
 Warning coding FinalLocalVariable Variable 'msg' should be declared final. 25

emissary/command/converter/PathExistsReadableConverterTest.java

Severity Category Rule Message Line
 Warning coding HiddenField 'path' hides a field. 26
 Warning coding RequireThis Reference to instance variable 'converter' needs "this.". 28
 Warning coding FinalLocalVariable Variable 'result' should be declared final. 34
 Warning coding RequireThis Reference to instance variable 'converter' needs "this.". 34
 Warning coding RequireThis Reference to instance variable 'path' needs "this.". 34
 Warning coding FinalLocalVariable Variable 'result' should be declared final. 43
 Warning coding RequireThis Reference to instance variable 'converter' needs "this.". 43
 Warning coding RequireThis Reference to instance variable 'path' needs "this.". 43
 Warning coding FinalLocalVariable Variable 'perms' should be declared final. 52
 Warning coding RequireThis Reference to instance variable 'path' needs "this.". 54
 Warning coding FinalLocalVariable Variable 'cnvrt' should be declared final. 57
 Warning coding RequireThis Reference to instance variable 'path' needs "this.". 57
 Warning coding FinalLocalVariable Variable 'thrown' should be declared final. 58
 Warning coding RequireThis Reference to instance variable 'converter' needs "this.". 58
 Warning coding RequireThis Reference to instance variable 'path' needs "this.". 61
 Warning coding RequireThis Reference to instance variable 'path' needs "this.". 65

emissary/command/converter/PriorityDirectoryConverter.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter value should be final. 22
 Warning coding FinalLocalVariable Variable 'matcher' should be declared final. 25

emissary/command/converter/PriorityDirectoryConverterTest.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'converter' needs "this.". 23
 Warning coding RequireThis Reference to instance variable 'pd' needs "this.". 24
 Warning coding RequireThis Reference to instance variable 'pd' needs "this.". 30
 Warning coding RequireThis Reference to instance variable 'converter' needs "this.". 30
 Warning coding RequireThis Reference to instance variable 'pd' needs "this.". 33
 Warning coding RequireThis Reference to instance variable 'pd' needs "this.". 34
 Warning coding RequireThis Reference to instance variable 'converter' needs "this.". 40
 Warning coding RequireThis Reference to instance variable 'pd' needs "this.". 46
 Warning coding RequireThis Reference to instance variable 'converter' needs "this.". 46
 Warning coding RequireThis Reference to instance variable 'pd' needs "this.". 49
 Warning coding RequireThis Reference to instance variable 'pd' needs "this.". 50
 Warning coding RequireThis Reference to instance variable 'pd' needs "this.". 56
 Warning coding RequireThis Reference to instance variable 'converter' needs "this.". 56
 Warning coding RequireThis Reference to instance variable 'pd' needs "this.". 59
 Warning coding RequireThis Reference to instance variable 'pd' needs "this.". 60
 Warning coding RequireThis Reference to instance variable 'pd' needs "this.". 67
 Warning coding RequireThis Reference to instance variable 'converter' needs "this.". 67
 Warning coding RequireThis Reference to instance variable 'pd' needs "this.". 70
 Warning coding RequireThis Reference to instance variable 'pd' needs "this.". 71

emissary/command/converter/ProjectBaseConverter.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter optionName should be final. 16
 Warning misc FinalParameters Parameter value should be final. 23
 Warning coding FinalLocalVariable Variable 'origValue' should be declared final. 24
 Warning coding FinalLocalVariable Variable 'projectBaseEnv' should be declared final. 25
 Warning coding FinalLocalVariable Variable 'projectBaseEnvPath' should be declared final. 26
 Warning coding ParameterAssignment Assignment of parameter 'value' is not allowed. 41
 Warning coding FinalLocalVariable Variable 'p' should be declared final. 45
 Warning coding FinalLocalVariable Variable 'pString' should be declared final. 46
 Warning coding FinalLocalVariable Variable 'msg' should be declared final. 50

emissary/command/converter/ProjectBaseConverterTest.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'path' needs "this.". 24
 Warning coding RequireThis Reference to instance variable 'converter' needs "this.". 25
 Warning coding RequireThis Reference to instance variable 'path' needs "this.". 31
 Warning coding FinalLocalVariable Variable 'result' should be declared final. 36
 Warning coding RequireThis Reference to instance variable 'converter' needs "this.". 36
 Warning coding FinalLocalVariable Variable 'result' should be declared final. 42
 Warning coding RequireThis Reference to instance variable 'converter' needs "this.". 42
 Warning coding FinalLocalVariable Variable 'projectBase' should be declared final. 49
 Warning coding RequireThis Reference to instance variable 'path' needs "this.". 49
 Warning coding RequireThis Reference to instance variable 'converter' needs "this.". 50

emissary/command/converter/WorkspaceSortModeConverter.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter value should be final. 19

emissary/command/converter/WorkspaceSortModeConverterTest.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'comparator' needs "this.". 24
 Warning coding RequireThis Reference to instance variable 'converter' needs "this.". 25
 Warning coding RequireThis Reference to instance variable 'converter' needs "this.". 30
 Warning coding RequireThis Reference to instance variable 'comparator' needs "this.". 35
 Warning coding RequireThis Reference to instance variable 'converter' needs "this.". 35
 Warning coding RequireThis Reference to instance variable 'comparator' needs "this.". 36
 Warning coding RequireThis Reference to instance variable 'comparator' needs "this.". 37
 Warning coding FinalLocalVariable Variable 'one' should be declared final. 39
 Warning coding FinalLocalVariable Variable 'two' should be declared final. 40
 Warning coding RequireThis Reference to instance variable 'comparator' needs "this.". 44
 Warning coding RequireThis Reference to instance variable 'comparator' needs "this.". 45
 Warning coding RequireThis Reference to instance variable 'comparator' needs "this.". 48
 Warning coding RequireThis Reference to instance variable 'comparator' needs "this.". 53
 Warning coding RequireThis Reference to instance variable 'converter' needs "this.". 53
 Warning coding RequireThis Reference to instance variable 'comparator' needs "this.". 54
 Warning coding RequireThis Reference to instance variable 'comparator' needs "this.". 55
 Warning coding FinalLocalVariable Variable 'one' should be declared final. 57
 Warning coding FinalLocalVariable Variable 'two' should be declared final. 58
 Warning coding RequireThis Reference to instance variable 'comparator' needs "this.". 62
 Warning coding RequireThis Reference to instance variable 'comparator' needs "this.". 63
 Warning coding RequireThis Reference to instance variable 'comparator' needs "this.". 66
 Warning coding RequireThis Reference to instance variable 'comparator' needs "this.". 71
 Warning coding RequireThis Reference to instance variable 'converter' needs "this.". 71
 Warning coding RequireThis Reference to instance variable 'comparator' needs "this.". 72
 Warning coding RequireThis Reference to instance variable 'comparator' needs "this.". 73
 Warning coding FinalLocalVariable Variable 'one' should be declared final. 75
 Warning coding FinalLocalVariable Variable 'two' should be declared final. 76
 Warning coding RequireThis Reference to instance variable 'comparator' needs "this.". 80
 Warning coding RequireThis Reference to instance variable 'comparator' needs "this.". 81
 Warning coding RequireThis Reference to instance variable 'comparator' needs "this.". 84
 Warning coding RequireThis Reference to instance variable 'comparator' needs "this.". 89
 Warning coding RequireThis Reference to instance variable 'converter' needs "this.". 89
 Warning coding RequireThis Reference to instance variable 'comparator' needs "this.". 90
 Warning coding RequireThis Reference to instance variable 'comparator' needs "this.". 91
 Warning coding FinalLocalVariable Variable 'one' should be declared final. 93
 Warning coding FinalLocalVariable Variable 'two' should be declared final. 94
 Warning coding RequireThis Reference to instance variable 'comparator' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'comparator' needs "this.". 99
 Warning coding RequireThis Reference to instance variable 'comparator' needs "this.". 102
 Warning misc FinalParameters Parameter comparator should be final. 105
 Warning coding FinalLocalVariable Variable 'one' should be declared final. 106
 Warning coding FinalLocalVariable Variable 'two' should be declared final. 107

emissary/config/ConfigEntry.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 27 should be alone on a line. 23
 Warning misc FinalParameters Parameter o should be final. 62
 Warning coding FinalLocalVariable Variable 'entry' should be declared final. 71
 Warning coding RequireThis Reference to instance variable 'key' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'value' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'key' needs "this.". 78
 Warning coding RequireThis Reference to instance variable 'value' needs "this.". 78

emissary/config/ConfigUtil.java

Severity Category Rule Message Line
 Warning coding EqualsAvoidNull String literal expressions should be on the left side of an equals comparison. 146
 Warning coding EqualsAvoidNull String literal expressions should be on the left side of an equals comparison. 149
 Warning blocks RightCurly '}' at column 27 should be alone on a line. 638

emissary/config/ConfigUtilTest.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'configPath' needs "this.". 56
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 58
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 59
 Warning coding RequireThis Reference to instance variable 'configLogger' needs "this.". 60
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 60
 Warning coding RequireThis Reference to instance variable 'configLogger' needs "this.". 66
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 66
 Warning coding RequireThis Reference to instance variable 'configPath' needs "this.". 76
 Warning coding RequireThis Reference to instance variable 'configPath' needs "this.". 277
 Warning coding RequireThis Reference to instance variable 'configPath' needs "this.". 400
 Warning coding RequireThis Reference to instance variable 'configPath' needs "this.". 404
 Warning coding RequireThis Reference to instance variable 'configPath' needs "this.". 407
 Warning coding FinalLocalVariable Variable 'thrown' should be declared final. 427
 Warning coding FinalLocalVariable Variable 'thrown' should be declared final. 444
 Warning coding RequireThis Reference to instance variable 'configPath' needs "this.". 543
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 551
 Warning coding RequireThis Reference to instance variable 'configPath' needs "this.". 562
 Warning coding RequireThis Reference to instance variable 'configPath' needs "this.". 568
 Warning coding RequireThis Reference to instance variable 'configPath' needs "this.". 574
 Warning coding RequireThis Reference to instance variable 'configPath' needs "this.". 580
 Warning coding RequireThis Reference to instance variable 'configPath' needs "this.". 587
 Warning coding FinalLocalVariable Variable 'importFileName' should be declared final. 631
 Warning coding FinalLocalVariable Variable 'noImportExpectedMessage' should be declared final. 643
 Warning coding RequireThis Reference to instance variable 'configPath' needs "this.". 650

emissary/config/Configurator.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'final' modifier. 54
 Warning modifier RedundantModifier Redundant 'final' modifier. 89

emissary/config/ExtractResource.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'outputDirectory' must be private and have accessor methods. 23

emissary/config/FTestServiceConfigGuide.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'configFiles' should be declared final. 30
 Warning coding FinalLocalVariable Variable 'root' should be declared final. 37
 Warning misc FinalParameters Parameter resource should be final. 48
 Warning coding FinalLocalVariable Variable 'underTest' should be declared final. 49

emissary/config/ServiceConfigGuide.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'serviceParameters' must be private and have accessor methods. 57
 Warning design VisibilityModifier Variable 'removeParameters' must be private and have accessor methods. 60
 Warning design VisibilityModifier Variable 'operator' must be private and have accessor methods. 62
 Warning design VisibilityModifier Variable 'values' must be private and have accessor methods. 77
 Warning coding VariableDeclarationUsageDistance Distance between variable 'nextToken' declaration and its first usage is 7, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 205
 Warning coding FinalLocalVariable Variable 'importFileName' should be declared final. 324
 Warning coding ModifiedControlVariable Control variable 'i' is modified. 416
 Warning whitespace OperatorWrap '+' should be on a new line. 459
 Warning whitespace OperatorWrap '+' should be on a new line. 460
 Warning coding HiddenField 'values' hides a field. 580
 Warning coding HiddenField 'values' hides a field. 846
 Warning coding FinalLocalVariable Variable 'value' should be declared final. 863

emissary/config/ServiceConfigGuideTest.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter cfg should be final. 62
 Warning misc FinalParameters Parameter cfgEntry should be final. 62
 Warning misc FinalParameters Parameter expectedLength should be final. 62
 Warning misc FinalParameters Parameter expected should be final. 62
 Warning coding FinalLocalVariable Variable 'iox' should be declared final. 77
 Warning coding FinalLocalVariable Variable 'iox' should be declared final. 166
 Warning coding FinalLocalVariable Variable 'keys' should be declared final. 279
 Warning coding VariableDeclarationUsageDistance Distance between variable 'values' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 280
 Warning coding FinalLocalVariable Variable 'values' should be declared final. 280
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 16, expected level should be 10. 356
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 16, expected level should be 10. 357
 Warning coding FinalLocalVariable Variable 'importFileName' should be declared final. 500
 Warning coding FinalLocalVariable Variable 'noImportExpectedMessage' should be declared final. 512

emissary/core/AgentPoolHealthCheck.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'agentKey' should be declared final. 16

emissary/core/BaseDataObject.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'theData' must be private and have accessor methods. 54
 Warning design VisibilityModifier Variable 'theFileName' must be private and have accessor methods. 60
 Warning design VisibilityModifier Variable 'shortName' must be private and have accessor methods. 65
 Warning design VisibilityModifier Variable 'internalId' must be private and have accessor methods. 70
 Warning design VisibilityModifier Variable 'currentForm' must be private and have accessor methods. 76
 Warning design VisibilityModifier Variable 'procError' must be private and have accessor methods. 81
 Warning design VisibilityModifier Variable 'history' must be private and have accessor methods. 86
 Warning design VisibilityModifier Variable 'fontEncoding' must be private and have accessor methods. 92
 Warning design VisibilityModifier Variable 'parameters' must be private and have accessor methods. 97
 Warning design VisibilityModifier Variable 'numChildren' must be private and have accessor methods. 102
 Warning design VisibilityModifier Variable 'numSiblings' must be private and have accessor methods. 108
 Warning design VisibilityModifier Variable 'birthOrder' must be private and have accessor methods. 113
 Warning design VisibilityModifier Variable 'multipartAlternative' must be private and have accessor methods. 118
 Warning design VisibilityModifier Variable 'header' must be private and have accessor methods. 124
 Warning design VisibilityModifier Variable 'footer' must be private and have accessor methods. 130
 Warning design VisibilityModifier Variable 'headerEncoding' must be private and have accessor methods. 136
 Warning design VisibilityModifier Variable 'classification' must be private and have accessor methods. 142
 Warning design VisibilityModifier Variable 'brokenDocument' must be private and have accessor methods. 148
 Warning design VisibilityModifier Variable 'emptyFileTypes' must be private and have accessor methods. 151
 Warning design VisibilityModifier Variable 'priority' must be private and have accessor methods. 156
 Warning design VisibilityModifier Variable 'creationTimestamp' must be private and have accessor methods. 161
 Warning design VisibilityModifier Variable 'extractedRecords' must be private and have accessor methods. 167
 Warning design VisibilityModifier Variable 'outputable' must be private and have accessor methods. 172
 Warning design VisibilityModifier Variable 'id' must be private and have accessor methods. 177
 Warning design VisibilityModifier Variable 'workBundleId' must be private and have accessor methods. 182
 Warning design VisibilityModifier Variable 'transactionId' must be private and have accessor methods. 187
 Warning design VisibilityModifier Variable 'seekableByteChannelFactory' must be private and have accessor methods. 193
 Warning design VisibilityModifier Variable 'tld' must be private and have accessor methods. 196
 Warning coding RequireThis Reference to instance variable 'theData' needs "this.". 222
 Warning coding RequireThis Reference to instance variable 'seekableByteChannelFactory' needs "this.". 223
 Warning coding RequireThis Reference to instance variable 'seekableByteChannelFactory' needs "this.". 229
 Warning coding RequireThis Reference to instance variable 'tld' needs "this.". 243
 Warning coding RequireThis Reference to instance variable 'tld' needs "this.". 257
 Warning misc FinalParameters Parameter tld should be final. 282
 Warning misc FinalParameters Parameter tld should be final. 293
 Warning coding HiddenField 'header' hides a field. 307
 Warning coding HiddenField 'footer' hides a field. 338
 Warning coding RequireThis Reference to instance variable 'seekableByteChannelFactory' needs "this.". 379
 Warning coding RequireThis Reference to instance variable 'theData' needs "this.". 426
 Warning coding RequireThis Reference to instance variable 'theData' needs "this.". 493
 Warning coding RequireThis Reference to instance variable 'theData' needs "this.". 517
 Warning misc FinalParameters Parameter newForm should be final. 726
 Warning misc FinalParameters Parameter method should be final. 726
 Warning coding RequireThis Reference to instance variable 'currentForm' needs "this.". 727
 Warning coding RequireThis Reference to instance variable 'history' needs "this.". 739
 Warning coding RequireThis Reference to instance variable 'history' needs "this.". 768
 Warning misc FinalParameters Parameter includeCoordinated should be final. 777
 Warning coding RequireThis Reference to instance variable 'history' needs "this.". 778
 Warning misc FinalParameters Parameter coordinated should be final. 792
 Warning misc FinalParameters Parameter newHistory should be final. 797
 Warning coding FinalLocalVariable Variable 'entry' should be declared final. 815
 Warning coding RequireThis Reference to instance variable 'history' needs "this.". 815
 Warning coding FinalLocalVariable Variable 'entry' should be declared final. 822
 Warning coding RequireThis Reference to instance variable 'history' needs "this.". 822
 Warning coding RequireThis Reference to instance variable 'history' needs "this.". 828
 Warning coding RequireThis Reference to instance variable 'history' needs "this.". 833
 Warning coding FinalLocalVariable Variable 'v' should be declared final. 954
 Warning coding HiddenField 'classification' hides a field. 1305
 Warning coding HiddenField 'priority' hides a field. 1320
 Warning coding HiddenField 'creationTimestamp' hides a field. 1369
 Warning coding RequireThis Reference to instance variable 'outputable' needs "this.". 1451
 Warning misc FinalParameters Parameter outputable should be final. 1455
 Warning coding HiddenField 'outputable' hides a field. 1455
 Warning coding RequireThis Reference to instance variable 'id' needs "this.". 1461
 Warning misc FinalParameters Parameter id should be final. 1465
 Warning coding HiddenField 'id' hides a field. 1465
 Warning coding RequireThis Reference to instance variable 'workBundleId' needs "this.". 1471
 Warning misc FinalParameters Parameter workBundleId should be final. 1475
 Warning coding HiddenField 'workBundleId' hides a field. 1475
 Warning coding RequireThis Reference to instance variable 'transactionId' needs "this.". 1481
 Warning misc FinalParameters Parameter transactionId should be final. 1485
 Warning coding HiddenField 'transactionId' hides a field. 1485
 Warning coding RequireThis Reference to instance variable 'tld' needs "this.". 1491

emissary/core/BaseDataObjectTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'b5' should be declared final. 105
 Warning coding FinalLocalVariable Variable 'bdo' should be declared final. 161
 Warning coding FinalLocalVariable Variable 'bdo' should be declared final. 170
 Warning coding FinalLocalVariable Variable 'bdo' should be declared final. 231
 Warning coding FinalLocalVariable Variable 'source' should be declared final. 335
 Warning coding FinalLocalVariable Variable 'sorted' should be declared final. 336
 Warning coding FinalLocalVariable Variable 'source' should be declared final. 349
 Warning coding FinalLocalVariable Variable 'sorted' should be declared final. 350
 Warning misc FinalParameters Parameter pullToTop should be final. 692
 Warning misc FinalParameters Parameter expected should be final. 692
 Warning misc FinalParameters Parameter expectedAt should be final. 692
 Warning misc FinalParameters Parameter msg should be final. 692
 Warning coding FinalLocalVariable Variable 'theData' should be declared final. 1249
 Warning coding FinalLocalVariable Variable 'testIbdo' should be declared final. 1356
 Warning coding FinalLocalVariable Variable 'logEvent' should be declared final. 1428

emissary/core/DataObjectFactory.java

Severity Category Rule Message Line
 Warning coding HiddenField 'clazz' hides a field. 54
 Warning coding HiddenField 'clazz' hides a field. 72
 Warning misc FinalParameters Parameter tld should be final. 126
 Warning misc FinalParameters Parameter tld should be final. 156

emissary/core/DataObjectFactoryTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'testPayload' should be declared final. 81
 Warning coding FinalLocalVariable Variable 'ibdo' should be declared final. 82
 Warning coding FinalLocalVariable Variable 'extract' should be declared final. 88
 Warning coding FinalLocalVariable Variable 'testPayload' should be declared final. 97
 Warning coding FinalLocalVariable Variable 'ibdo' should be declared final. 98
 Warning coding FinalLocalVariable Variable 'extract' should be declared final. 104
 Warning coding FinalLocalVariable Variable 'tld' should be declared final. 113
 Warning modifier RedundantModifier Redundant 'public' modifier. 136
 Warning modifier RedundantModifier Redundant 'public' modifier. 140
 Warning modifier RedundantModifier Redundant 'public' modifier. 149
 Warning modifier RedundantModifier Redundant 'public' modifier. 153

emissary/core/DiffCheckConfiguration.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'enabled' needs "this.". 48
 Warning coding RequireThis Reference to instance variable 'enabled' needs "this.". 57
 Warning coding RequireThis Reference to instance variable 'enabled' needs "this.". 66
 Warning coding RequireThis Reference to instance variable 'enabled' needs "this.". 75
 Warning coding RequireThis Reference to instance variable 'enabled' needs "this.". 84
 Warning coding RequireThis Reference to instance variable 'enabled' needs "this.". 93
 Warning coding RequireThis Reference to instance variable 'enabled' needs "this.". 102
 Warning coding RequireThis Reference to instance variable 'building' needs "this.". 130
 Warning coding RequireThis Reference to instance variable 'building' needs "this.". 141
 Warning coding RequireThis Reference to instance variable 'building' needs "this.". 143
 Warning coding RequireThis Reference to instance variable 'building' needs "this.". 143
 Warning coding RequireThis Reference to instance variable 'building' needs "this.". 154
 Warning coding RequireThis Reference to instance variable 'building' needs "this.". 163
 Warning coding RequireThis Reference to instance variable 'building' needs "this.". 173
 Warning coding RequireThis Reference to instance variable 'building' needs "this.". 183
 Warning coding RequireThis Reference to instance variable 'building' needs "this.". 193
 Warning coding RequireThis Reference to instance variable 'building' needs "this.". 203
 Warning coding RequireThis Reference to instance variable 'building' needs "this.". 213
 Warning coding RequireThis Reference to instance variable 'building' needs "this.". 223
 Warning coding RequireThis Reference to instance variable 'building' needs "this.". 233
 Warning coding RequireThis Reference to instance variable 'building' needs "this.". 243
 Warning coding RequireThis Reference to instance variable 'building' needs "this.". 253
 Warning coding RequireThis Reference to instance variable 'building' needs "this.". 254
 Warning coding RequireThis Reference to instance variable 'building' needs "this.". 264
 Warning coding RequireThis Reference to instance variable 'building' needs "this.". 274
 Warning coding RequireThis Reference to instance variable 'building' needs "this.". 275
 Warning coding RequireThis Reference to instance variable 'building' needs "this.". 285

emissary/core/ExtendedDataObject.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'intVar' must be private and have accessor methods. 24
 Warning design VisibilityModifier Variable 'longVar' must be private and have accessor methods. 25
 Warning design VisibilityModifier Variable 'stringVar' must be private and have accessor methods. 26

emissary/core/ExtractedRecord.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter newData should be final. 16
 Warning misc FinalParameters Parameter name should be final. 16
 Warning misc FinalParameters Parameter newData should be final. 22
 Warning misc FinalParameters Parameter name should be final. 22
 Warning misc FinalParameters Parameter form should be final. 22
 Warning misc FinalParameters Parameter newData should be final. 28
 Warning misc FinalParameters Parameter name should be final. 28
 Warning misc FinalParameters Parameter form should be final. 28
 Warning misc FinalParameters Parameter fileType should be final. 28

emissary/core/ExtractedRecordTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'extract' should be declared final. 18
 Warning coding FinalLocalVariable Variable 'extract' should be declared final. 24
 Warning coding FinalLocalVariable Variable 'extract2' should be declared final. 25
 Warning coding FinalLocalVariable Variable 'extract' should be declared final. 31
 Warning coding FinalLocalVariable Variable 'extract2' should be declared final. 32
 Warning coding FinalLocalVariable Variable 'extract' should be declared final. 38
 Warning coding FinalLocalVariable Variable 'extract2' should be declared final. 39
 Warning coding FinalLocalVariable Variable 'extract' should be declared final. 45
 Warning coding FinalLocalVariable Variable 'extract' should be declared final. 51
 Warning coding FinalLocalVariable Variable 'extract' should be declared final. 57

emissary/core/FTestMobileAgent.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'public' modifier. 91
 Warning blocks RightCurly '}' at column 94 should be alone on a line. 91
 Warning modifier RedundantModifier Redundant 'public' modifier. 107
 Warning blocks RightCurly '}' at column 99 should be alone on a line. 107

emissary/core/FTestMovingAgent.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 9 should be alone on a line. 154

emissary/core/Factory.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 24 should be alone on a line. 40

emissary/core/FactoryTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'args' should be declared final. 34
 Warning coding FinalLocalVariable Variable 'o' should be declared final. 35
 Warning coding FinalLocalVariable Variable 'ex' should be declared final. 42
 Warning coding FinalLocalVariable Variable 'args' should be declared final. 43
 Warning coding FinalLocalVariable Variable 'o' should be declared final. 44
 Warning coding FinalLocalVariable Variable 'o' should be declared final. 51
 Warning coding FinalLocalVariable Variable 'o' should be declared final. 58
 Warning coding FinalLocalVariable Variable 'args' should be declared final. 70
 Warning coding FinalLocalVariable Variable 'args' should be declared final. 76
 Warning coding FinalLocalVariable Variable 'args' should be declared final. 82
 Warning coding FinalLocalVariable Variable 'o' should be declared final. 83
 Warning coding FinalLocalVariable Variable 'key' should be declared final. 93
 Warning coding FinalLocalVariable Variable 'args' should be declared final. 94
 Warning coding FinalLocalVariable Variable 'o' should be declared final. 95
 Warning coding FinalLocalVariable Variable 'o2' should be declared final. 98
 Warning coding FinalLocalVariable Variable 'key' should be declared final. 106
 Warning coding FinalLocalVariable Variable 'o' should be declared final. 107
 Warning coding FinalLocalVariable Variable 'o2' should be declared final. 108
 Warning coding FinalLocalVariable Variable 'key' should be declared final. 117
 Warning coding FinalLocalVariable Variable 'o' should be declared final. 118
 Warning coding FinalLocalVariable Variable 'o2' should be declared final. 119
 Warning coding FinalLocalVariable Variable 'key' should be declared final. 128
 Warning coding FinalLocalVariable Variable 'o' should be declared final. 129
 Warning coding FinalLocalVariable Variable 'o2' should be declared final. 130
 Warning coding FinalLocalVariable Variable 'key' should be declared final. 139
 Warning coding FinalLocalVariable Variable 'o' should be declared final. 140
 Warning coding FinalLocalVariable Variable 'o2' should be declared final. 141
 Warning coding FinalLocalVariable Variable 'key' should be declared final. 175
 Warning coding FinalLocalVariable Variable 'o' should be declared final. 176
 Warning coding FinalLocalVariable Variable 'o2' should be declared final. 177
 Warning modifier RedundantModifier Redundant 'public' modifier. 187
 Warning misc FinalParameters Parameter myKey should be final. 187
 Warning coding RequireThis Reference to instance variable 'myKey' needs "this.". 194
 Warning modifier RedundantModifier Redundant 'public' modifier. 201
 Warning misc FinalParameters Parameter myKey should be final. 201
 Warning coding RequireThis Reference to instance variable 'myKey' needs "this.". 206
 Warning modifier RedundantModifier Redundant 'public' modifier. 211

emissary/core/Family.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'basename' must be private and have accessor methods. 15
 Warning design VisibilityModifier Variable 'num' must be private and have accessor methods. 18

emissary/core/FamilyTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'f' should be declared final. 24
 Warning coding FinalLocalVariable Variable 'f' should be declared final. 31
 Warning coding FinalLocalVariable Variable 'f' should be declared final. 38
 Warning coding FinalLocalVariable Variable 'g' should be declared final. 39

emissary/core/FilePickUpPlaceHealthCheck.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'maxFileCountBeforeUnhealthy' must be private and have accessor methods. 21
 Warning design VisibilityModifier Variable 'maxAggregateFileSizeBeforeUnhealthy' must be private and have accessor methods. 26

emissary/core/FilePickUpPlaceHealthCheckTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'f' should be declared final. 20
 Warning coding FinalLocalVariable Variable 'fpc' should be declared final. 26
 Warning coding FinalLocalVariable Variable 'f' should be declared final. 27

emissary/core/Form.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 21 should be alone on a line. 28

emissary/core/HDMobileAgent.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'payloadList' must be private and have accessor methods. 33

emissary/core/HDMobileAgentBugIT.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'directory' needs "this.". 40
 Warning coding RequireThis Reference to instance variable 'analyze' needs "this.". 41
 Warning coding RequireThis Reference to instance variable 'skipped' needs "this.". 42
 Warning coding RequireThis Reference to instance variable 'validate' needs "this.". 43
 Warning coding RequireThis Reference to instance variable 'ma' needs "this.". 45
 Warning coding RequireThis Reference to instance variable 'ma' needs "this.". 46
 Warning coding RequireThis Reference to instance variable 'analyze' needs "this.". 46
 Warning coding RequireThis Reference to instance variable 'directory' needs "this.". 51
 Warning coding RequireThis Reference to instance variable 'analyze' needs "this.". 52
 Warning coding RequireThis Reference to instance variable 'skipped' needs "this.". 53
 Warning coding RequireThis Reference to instance variable 'validate' needs "this.". 54
 Warning misc FinalParameters Parameter key should be final. 57
 Warning misc FinalParameters Parameter clsName should be final. 57
 Warning misc FinalParameters Parameter key should be final. 61
 Warning misc FinalParameters Parameter clsName should be final. 61
 Warning misc FinalParameters Parameter index should be final. 65
 Warning misc FinalParameters Parameter form should be final. 65
 Warning coding FinalLocalVariable Variable 'ibdo' should be declared final. 66
 Warning coding FinalLocalVariable Variable 'form1' should be declared final. 76
 Warning coding VariableDeclarationUsageDistance Distance between variable 'form2' declaration and its first usage is 6, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 77
 Warning coding FinalLocalVariable Variable 'form2' should be declared final. 77
 Warning coding RequireThis Reference to instance variable 'ma' needs "this.". 93
 Warning coding RequireThis Reference to instance variable 'ma' needs "this.". 94
 Warning coding RequireThis Reference to instance variable 'ma' needs "this.". 95
 Warning coding RequireThis Reference to instance variable 'analyze' needs "this.". 95
 Warning coding RequireThis Reference to instance variable 'ma' needs "this.". 114
 Warning coding RequireThis Reference to instance variable 'ma' needs "this.". 115
 Warning coding RequireThis Reference to instance variable 'ma' needs "this.". 116
 Warning coding RequireThis Reference to instance variable 'analyze' needs "this.". 116
 Warning coding RequireThis Reference to instance variable 'ma' needs "this.". 155
 Warning coding RequireThis Reference to instance variable 'ma' needs "this.". 156
 Warning coding RequireThis Reference to instance variable 'ma' needs "this.". 157
 Warning coding RequireThis Reference to instance variable 'ma' needs "this.". 158
 Warning coding RequireThis Reference to instance variable 'analyze' needs "this.". 158
 Warning modifier RedundantModifier Redundant 'public' modifier. 176
 Warning misc FinalParameters Parameter configFile should be final. 176
 Warning misc FinalParameters Parameter theDir should be final. 176
 Warning misc FinalParameters Parameter thePlaceLocation should be final. 176
 Warning blocks RightCurly '}' at column 112 should be alone on a line. 176
 Warning misc FinalParameters Parameter payloadListArg should be final. 179
 Warning modifier RedundantModifier Redundant 'public' modifier. 190
 Warning misc FinalParameters Parameter configFile should be final. 190
 Warning misc FinalParameters Parameter theDir should be final. 190
 Warning misc FinalParameters Parameter thePlaceLocation should be final. 190
 Warning blocks RightCurly '}' at column 112 should be alone on a line. 190
 Warning misc FinalParameters Parameter payloadListArg should be final. 193
 Warning modifier RedundantModifier Redundant 'public' modifier. 204
 Warning misc FinalParameters Parameter configFile should be final. 204
 Warning misc FinalParameters Parameter theDir should be final. 204
 Warning misc FinalParameters Parameter thePlaceLocation should be final. 204
 Warning blocks RightCurly '}' at column 111 should be alone on a line. 204
 Warning misc FinalParameters Parameter payloadListArg should be final. 207

emissary/core/HDMobileAgentTest.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'public' modifier. 20
 Warning blocks RightCurly '}' at column 33 should be alone on a line. 20
 Warning coding FinalLocalVariable Variable 'children' should be declared final. 25
 Warning coding FinalLocalVariable Variable 'ibdo' should be declared final. 26
 Warning coding FinalLocalVariable Variable 'ma' should be declared final. 30
 Warning modifier RedundantModifier Redundant 'public' modifier. 45
 Warning misc FinalParameters Parameter configInfo should be final. 45
 Warning misc FinalParameters Parameter children should be final. 49
 Warning coding HiddenField 'children' hides a field. 49
 Warning misc FinalParameters Parameter payloadListArg should be final. 54
 Warning coding RequireThis Reference to instance variable 'children' needs "this.". 55

emissary/core/IBaseDataObject.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 47 should be alone on a line. 40
 Warning whitespace EmptyLineSeparator ';' should be separated from previous line. 40
 Warning modifier RedundantModifier Redundant 'final' modifier. 65
 Warning modifier RedundantModifier Redundant 'final' modifier. 79
 Warning coding FinalLocalVariable Variable 'strings' should be declared final. 441

emissary/core/IBaseDataObjectDiffHelper.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 42 should be alone on a line. 38
 Warning whitespace OperatorWrap '||' should be on a new line. 242
 Warning coding FinalLocalVariable Variable 'newMap' should be declared final. 309

emissary/core/IBaseDataObjectDiffHelperTest.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 42
 Warning coding RequireThis Reference to instance variable 'ibdo2' needs "this.". 43
 Warning coding RequireThis Reference to instance variable 'ibdoList1' needs "this.". 44
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 44
 Warning coding RequireThis Reference to instance variable 'ibdoList2' needs "this.". 45
 Warning coding RequireThis Reference to instance variable 'ibdo2' needs "this.". 45
 Warning coding RequireThis Reference to instance variable 'differences' needs "this.". 46
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 54
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 54
 Warning coding RequireThis Reference to instance variable 'differences' needs "this.". 54
 Warning coding RequireThis Reference to instance variable 'differences' needs "this.". 55
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 56
 Warning coding RequireThis Reference to instance variable 'ibdo2' needs "this.". 56
 Warning coding RequireThis Reference to instance variable 'differences' needs "this.". 56
 Warning coding RequireThis Reference to instance variable 'differences' needs "this.". 57
 Warning coding RequireThis Reference to instance variable 'differences' needs "this.". 58
 Warning coding RequireThis Reference to instance variable 'ibdo2' needs "this.". 59
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 59
 Warning coding RequireThis Reference to instance variable 'differences' needs "this.". 59
 Warning coding RequireThis Reference to instance variable 'differences' needs "this.". 60
 Warning coding RequireThis Reference to instance variable 'differences' needs "this.". 61
 Warning coding RequireThis Reference to instance variable 'differences' needs "this.". 66
 Warning coding RequireThis Reference to instance variable 'differences' needs "this.". 67
 Warning coding RequireThis Reference to instance variable 'differences' needs "this.". 68
 Warning coding RequireThis Reference to instance variable 'differences' needs "this.". 69
 Warning coding RequireThis Reference to instance variable 'differences' needs "this.". 70
 Warning coding RequireThis Reference to instance variable 'ibdo2' needs "this.". 80
 Warning coding RequireThis Reference to instance variable 'differences' needs "this.". 80
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 81
 Warning coding RequireThis Reference to instance variable 'differences' needs "this.". 81
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 82
 Warning coding RequireThis Reference to instance variable 'ibdo2' needs "this.". 82
 Warning coding RequireThis Reference to instance variable 'ibdoList1' needs "this.". 83
 Warning coding RequireThis Reference to instance variable 'ibdoList2' needs "this.". 83
 Warning coding RequireThis Reference to instance variable 'differences' needs "this.". 83
 Warning coding RequireThis Reference to instance variable 'ibdoList1' needs "this.". 84
 Warning coding RequireThis Reference to instance variable 'ibdoList2' needs "this.". 84
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 85
 Warning coding RequireThis Reference to instance variable 'ibdo2' needs "this.". 85
 Warning coding RequireThis Reference to instance variable 'differences' needs "this.". 85
 Warning coding RequireThis Reference to instance variable 'differences' needs "this.". 86
 Warning coding RequireThis Reference to instance variable 'differences' needs "this.". 90
 Warning coding RequireThis Reference to instance variable 'differences' needs "this.". 94
 Warning coding RequireThis Reference to instance variable 'differences' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'differences' needs "this.". 99
 Warning coding RequireThis Reference to instance variable 'differences' needs "this.". 100
 Warning coding RequireThis Reference to instance variable 'ibdo2' needs "this.". 106
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 109
 Warning coding RequireThis Reference to instance variable 'ibdo2' needs "this.". 110
 Warning coding RequireThis Reference to instance variable 'ibdo2' needs "this.". 113
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 140
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 141
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 142
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 148
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 149
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 159
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 160
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 166
 Warning coding RequireThis Reference to instance variable 'ibdo2' needs "this.". 167
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 168
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 169
 Warning coding RequireThis Reference to instance variable 'ibdo2' needs "this.". 170
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 176
 Warning coding RequireThis Reference to instance variable 'ibdo2' needs "this.". 177
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 178
 Warning coding RequireThis Reference to instance variable 'ibdo2' needs "this.". 179
 Warning coding RequireThis Reference to instance variable 'ibdo2' needs "this.". 180
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 186
 Warning coding RequireThis Reference to instance variable 'ibdo2' needs "this.". 187
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 188
 Warning coding RequireThis Reference to instance variable 'ibdo2' needs "this.". 189
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 198
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 199
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 200
 Warning coding RequireThis Reference to instance variable 'ibdo2' needs "this.". 203
 Warning coding RequireThis Reference to instance variable 'ibdo2' needs "this.". 204
 Warning coding RequireThis Reference to instance variable 'ibdo2' needs "this.". 205
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 211
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 217
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 224
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 225
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 226
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 232
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 244
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 250
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 256
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 262
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 268
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 274
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 280
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 286
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 292
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 298
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 304
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 310
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 316
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 322
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 328
 Warning coding RequireThis Reference to instance variable 'ibdo2' needs "this.". 328
 Warning coding RequireThis Reference to instance variable 'ibdoList1' needs "this.". 332
 Warning coding RequireThis Reference to instance variable 'ibdoList1' needs "this.". 332
 Warning coding RequireThis Reference to instance variable 'ibdoList2' needs "this.". 333
 Warning coding RequireThis Reference to instance variable 'ibdoList1' needs "this.". 334
 Warning coding RequireThis Reference to instance variable 'ibdo2' needs "this.". 336
 Warning coding RequireThis Reference to instance variable 'ibdoList1' needs "this.". 337
 Warning coding RequireThis Reference to instance variable 'ibdoList2' needs "this.". 337
 Warning coding FinalLocalVariable Variable 'expectedParams' should be declared final. 343
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 347
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 348
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 349
 Warning coding FinalLocalVariable Variable 'sortedParams' should be declared final. 352
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 352

emissary/core/IBaseDataObjectHelper.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 38 should be alone on a line. 38
 Warning javadoc AtclauseOrder Block tags have to appear in the order '[@param, @return, @throws, @deprecated]'. 56
 Warning javadoc AtclauseOrder Block tags have to appear in the order '[@param, @return, @throws, @deprecated]'. 57
 Warning javadoc AtclauseOrder Block tags have to appear in the order '[@param, @return, @throws, @deprecated]'. 58
 Warning misc FinalParameters Parameter preferredViewNamePatterns should be final. 232
 Warning misc FinalParameters Parameter payload should be final. 243
 Warning misc FinalParameters Parameter preferredViewNamePattern should be final. 243
 Warning misc FinalParameters Parameter preferredViews should be final. 255

emissary/core/IBaseDataObjectHelperTest.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 57
 Warning coding RequireThis Reference to instance variable 'ibdo2' needs "this.". 58
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 132
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 133
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 138
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 139
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 140
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 141
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 146
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 147
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 148
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 150
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 151
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 153
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 154
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 159
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 160
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 161
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 166
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 167
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 168
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 169
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 174
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 175
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 180
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 181
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 186
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 187
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 188
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 189
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 194
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 195
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 200
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 205
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 206
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 211
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 212
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 217
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 218
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 223
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 224
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 229
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 230
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 235
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 236
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 241
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 242
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 247
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 248
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 253
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 254
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 259
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 260
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 265
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 266
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 271
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 272
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 277
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 278
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 283
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 284
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 293
 Warning coding RequireThis Reference to instance variable 'ibdo2' needs "this.". 294
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 336
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 366
 Warning coding RequireThis Reference to instance variable 'ibdo2' needs "this.". 367
 Warning coding FinalLocalVariable Variable 'view1Bytes' should be declared final. 389
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 390
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 392
 Warning coding FinalLocalVariable Variable 'primaryViewBytes' should be declared final. 394
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 395
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 397
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 400
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 403
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 406
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 409
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 412
 Warning misc FinalParameters Parameter values should be final. 416
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 430
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 432
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 433
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 435
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 436
 Warning coding RequireThis Reference to instance variable 'ibdo1' needs "this.". 438

emissary/core/IBaseDataObjectXmlCodecs.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'STATIC_INIT' should be separated from previous line. 105
 Warning misc FinalParameters Parameter currentElement should be final. 229
 Warning misc FinalParameters Parameter ibdo should be final. 229
 Warning misc FinalParameters Parameter elementName should be final. 229
 Warning coding FinalLocalVariable Variable 'methodName' should be declared final. 230
 Warning coding FinalLocalVariable Variable 'elements' should be declared final. 231
 Warning coding RequireThis Reference to instance variable 'booleanDecoder' needs "this.". 232
 Warning misc FinalParameters Parameter currentElement should be final. 235
 Warning misc FinalParameters Parameter ibdo should be final. 235
 Warning misc FinalParameters Parameter elementName should be final. 235
 Warning coding FinalLocalVariable Variable 'methodName' should be declared final. 236
 Warning coding FinalLocalVariable Variable 'elements' should be declared final. 237
 Warning coding RequireThis Reference to instance variable 'byteArrayDecoder' needs "this.". 238
 Warning misc FinalParameters Parameter currentElement should be final. 241
 Warning misc FinalParameters Parameter ibdo should be final. 241
 Warning misc FinalParameters Parameter elementName should be final. 241
 Warning coding FinalLocalVariable Variable 'methodName' should be declared final. 242
 Warning coding FinalLocalVariable Variable 'elements' should be declared final. 243
 Warning coding RequireThis Reference to instance variable 'integerDecoder' needs "this.". 244
 Warning misc FinalParameters Parameter currentElement should be final. 247
 Warning misc FinalParameters Parameter ibdo should be final. 247
 Warning misc FinalParameters Parameter elementName should be final. 247
 Warning coding FinalLocalVariable Variable 'methodName' should be declared final. 248
 Warning coding FinalLocalVariable Variable 'elements' should be declared final. 249
 Warning coding RequireThis Reference to instance variable 'seekableByteChannelFactoryDecoder' needs "this.". 250
 Warning misc FinalParameters Parameter currentElement should be final. 253
 Warning misc FinalParameters Parameter ibdo should be final. 253
 Warning misc FinalParameters Parameter elementName should be final. 253
 Warning coding FinalLocalVariable Variable 'methodName' should be declared final. 254
 Warning coding FinalLocalVariable Variable 'elements' should be declared final. 255
 Warning coding RequireThis Reference to instance variable 'stringByteArrayDecoder' needs "this.". 256
 Warning misc FinalParameters Parameter currentElement should be final. 259
 Warning misc FinalParameters Parameter ibdo should be final. 259
 Warning misc FinalParameters Parameter elementName should be final. 259
 Warning coding FinalLocalVariable Variable 'methodName' should be declared final. 260
 Warning coding FinalLocalVariable Variable 'elements' should be declared final. 261
 Warning coding RequireThis Reference to instance variable 'stringDecoder' needs "this.". 262
 Warning misc FinalParameters Parameter currentElement should be final. 265
 Warning misc FinalParameters Parameter ibdo should be final. 265
 Warning misc FinalParameters Parameter elementName should be final. 265
 Warning coding FinalLocalVariable Variable 'methodName' should be declared final. 266
 Warning coding FinalLocalVariable Variable 'elements' should be declared final. 267
 Warning coding RequireThis Reference to instance variable 'stringObjectDecoder' needs "this.". 268
 Warning misc FinalParameters Parameter elementName should be final. 271
 Warning coding FinalLocalVariable Variable 'methodName' should be declared final. 272
 Warning design VisibilityModifier Variable 'booleanEncoder' must be private and have accessor methods. 285
 Warning design VisibilityModifier Variable 'byteArrayEncoder' must be private and have accessor methods. 289
 Warning design VisibilityModifier Variable 'integerEncoder' must be private and have accessor methods. 293
 Warning design VisibilityModifier Variable 'seekableByteChannelFactoryEncoder' must be private and have accessor methods. 297
 Warning design VisibilityModifier Variable 'stringByteArrayEncoder' must be private and have accessor methods. 301
 Warning design VisibilityModifier Variable 'stringEncoder' must be private and have accessor methods. 305
 Warning design VisibilityModifier Variable 'stringObjectEncoder' must be private and have accessor methods. 309
 Warning blocks RightCurly '}' at column 41 should be alone on a line. 726
 Warning coding FinalLocalVariable Variable 'base64String' should be declared final. 781
 Warning whitespace OperatorWrap '+' should be on a new line. 781
 Warning whitespace OperatorWrap '+' should be on a new line. 782
 Warning javadoc AtclauseOrder Block tags have to appear in the order '[@param, @return, @throws, @deprecated]'. 823

emissary/core/IBaseDataObjectXmlHelper.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 41 should be alone on a line. 54

emissary/core/IBaseDataObjectXmlHelperTest.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter rootElement should be final. 222
 Warning misc FinalParameters Parameter lengthToCheck should be final. 222
 Warning misc FinalParameters Parameter xmlPathElementNames should be final. 222
 Warning coding FinalLocalVariable Variable 'lengthElement' should be declared final. 236
 Warning coding FinalLocalVariable Variable 'length' should be declared final. 243
 Warning misc FinalParameters Parameter rootElement should be final. 256
 Warning misc FinalParameters Parameter lengthToCheck should be final. 256
 Warning misc FinalParameters Parameter key should be final. 256
 Warning misc FinalParameters Parameter xmlPathElementNames should be final. 256
 Warning coding FinalLocalVariable Variable 'keyValueElements' should be declared final. 270
 Warning coding FinalLocalVariable Variable 'lengthElement' should be declared final. 284
 Warning coding FinalLocalVariable Variable 'length' should be declared final. 291

emissary/core/IPausable.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 27 should be alone on a line. 8
 Warning blocks RightCurly '}' at column 29 should be alone on a line. 13

emissary/core/InterruptibleCharSequence.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'inner' must be private and have accessor methods. 4
 Warning misc FinalParameters Parameter inner should be final. 6
 Warning misc FinalParameters Parameter index should be final. 12
 Warning coding RequireThis Reference to instance variable 'inner' needs "this.". 16
 Warning coding RequireThis Reference to instance variable 'inner' needs "this.". 21
 Warning misc FinalParameters Parameter start should be final. 25
 Warning misc FinalParameters Parameter end should be final. 25
 Warning coding RequireThis Reference to instance variable 'inner' needs "this.". 26
 Warning coding RequireThis Reference to instance variable 'inner' needs "this.". 31

emissary/core/InterruptibleCharSequenceTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'regex' should be declared final. 25
 Warning coding FinalLocalVariable Variable 'inputNormal' should be declared final. 26
 Warning coding FinalLocalVariable Variable 'inputWrapped' should be declared final. 27
 Warning coding FinalLocalVariable Variable 'trials' should be declared final. 31
 Warning coding FinalLocalVariable Variable 'overheadPercentage' should be declared final. 47
 Warning misc FinalParameters Parameter input should be final. 51
 Warning misc FinalParameters Parameter regex should be final. 51
 Warning coding FinalLocalVariable Variable 't' should be declared final. 56
 Warning coding FinalLocalVariable Variable 'matcherResult' should be declared final. 57
 Warning coding FinalLocalVariable Variable 'blockingQueue' should be declared final. 73
 Warning coding FinalLocalVariable Variable 't' should be declared final. 74
 Warning coding FinalLocalVariable Variable 'result' should be declared final. 77
 Warning coding FinalLocalVariable Variable 'obnoxiousInput' should be declared final. 85
 Warning coding FinalLocalVariable Variable 'blockingQueue' should be declared final. 88
 Warning coding FinalLocalVariable Variable 't' should be declared final. 89
 Warning coding FinalLocalVariable Variable 'result' should be declared final. 97

emissary/core/MetricsFormatterTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 15
 Warning coding FinalLocalVariable Variable 's' should be declared final. 16

emissary/core/MetricsManager.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'metrics' must be private and have accessor methods. 48
 Warning design VisibilityModifier Variable 'healthChecks' must be private and have accessor methods. 49
 Warning design VisibilityModifier Variable 'reporter' must be private and have accessor methods. 51
 Warning design VisibilityModifier Variable 'conf' must be private and have accessor methods. 52
 Warning coding RequireThis Reference to instance variable 'metrics' needs "this.". 207
 Warning coding RequireThis Reference to instance variable 'metrics' needs "this.". 208
 Warning coding RequireThis Reference to instance variable 'metrics' needs "this.". 209
 Warning coding RequireThis Reference to instance variable 'metrics' needs "this.". 210
 Warning coding RequireThis Reference to instance variable 'metrics' needs "this.". 211
 Warning coding RequireThis Reference to instance variable 'metrics' needs "this.". 212

emissary/core/MetricsManagerTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'conf' should be declared final. 18
 Warning coding FinalLocalVariable Variable 'mm' should be declared final. 22
 Warning coding FinalLocalVariable Variable 'stats' should be declared final. 23

emissary/core/MobileAgent.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'thread' must be private and have accessor methods. 43
 Warning design VisibilityModifier Variable 'maxMoveErrors' must be private and have accessor methods. 52
 Warning design VisibilityModifier Variable 'maxItinerarySteps' must be private and have accessor methods. 56
 Warning design VisibilityModifier Variable 'payload' must be private and have accessor methods. 64
 Warning design VisibilityModifier Variable 'idle' must be private and have accessor methods. 67
 Warning design VisibilityModifier Variable 'arrivalPlace' must be private and have accessor methods. 71
 Warning design VisibilityModifier Variable 'processFirstPlace' must be private and have accessor methods. 72
 Warning design VisibilityModifier Variable 'lastPlaceProcessed' must be private and have accessor methods. 74
 Warning design VisibilityModifier Variable 'agentId' must be private and have accessor methods. 78
 Warning design VisibilityModifier Variable 'visitedPlaces' must be private and have accessor methods. 82
 Warning design VisibilityModifier Variable 'timeToQuit' must be private and have accessor methods. 85
 Warning design VisibilityModifier Variable 'nextKeyQueue' must be private and have accessor methods. 88
 Warning design VisibilityModifier Variable 'moveErrorsOccurred' must be private and have accessor methods. 91
 Warning whitespace OperatorWrap '&&' should be on a new line. 447
 Warning blocks RightCurly '}' at column 21 should be alone on a line. 568
 Warning coding FinalLocalVariable Variable 'stage' should be declared final. 592

emissary/core/MobileAgentTest.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'agent' needs "this.". 29
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 30
 Warning coding RequireThis Reference to instance variable 'd' needs "this.". 31
 Warning coding RequireThis Reference to instance variable 'd' needs "this.". 32
 Warning coding RequireThis Reference to instance variable 'agent' needs "this.". 38
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 39
 Warning coding RequireThis Reference to instance variable 'd' needs "this.". 44
 Warning coding RequireThis Reference to instance variable 'agent' needs "this.". 45
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 45
 Warning coding RequireThis Reference to instance variable 'd' needs "this.". 45
 Warning coding RequireThis Reference to instance variable 'd' needs "this.". 72
 Warning coding RequireThis Reference to instance variable 'agent' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'd' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'd' needs "this.". 74
 Warning coding RequireThis Reference to instance variable 'agent' needs "this.". 77
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 77
 Warning coding RequireThis Reference to instance variable 'd' needs "this.". 77
 Warning coding RequireThis Reference to instance variable 'agent' needs "this.". 80
 Warning coding RequireThis Reference to instance variable 'agent' needs "this.". 81
 Warning coding FinalLocalVariable Variable 'agent' should be declared final. 86
 Warning coding HiddenField 'agent' hides a field. 86
 Warning coding FinalLocalVariable Variable 'configDeniedData' should be declared final. 89
 Warning coding FinalLocalVariable Variable 'config' should be declared final. 92
 Warning coding FinalLocalVariable Variable 'place' should be declared final. 93
 Warning coding HiddenField 'place' hides a field. 93
 Warning coding FinalLocalVariable Variable 'd1' should be declared final. 94
 Warning coding FinalLocalVariable Variable 'configDeniedData2' should be declared final. 99
 Warning coding FinalLocalVariable Variable 'config2' should be declared final. 102
 Warning coding FinalLocalVariable Variable 'place2' should be declared final. 103
 Warning coding FinalLocalVariable Variable 'd2' should be declared final. 104
 Warning modifier RedundantModifier Redundant 'public' modifier. 140
 Warning misc FinalParameters Parameter config should be final. 140

emissary/core/Namespace.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 26 should be alone on a line. 30
 Warning misc FinalParameters Parameter arg should be final. 65
 Warning misc FinalParameters Parameter arg should be final. 76
 Warning misc FinalParameters Parameter silent should be final. 76
 Warning coding FinalLocalVariable Variable 'lookups' should be declared final. 77

emissary/core/Pausable.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'pauseInterval' must be private and have accessor methods. 13
 Warning misc FinalParameters Parameter name should be final. 17
 Warning misc FinalParameters Parameter name should be final. 21
 Warning misc FinalParameters Parameter pauseInterval should be final. 21
 Warning coding RequireThis Reference to instance variable 'paused' needs "this.". 31
 Warning coding RequireThis Reference to instance variable 'paused' needs "this.". 39
 Warning coding RequireThis Reference to instance variable 'paused' needs "this.". 49
 Warning coding RequireThis Reference to instance variable 'pauseInterval' needs "this.". 58

emissary/core/ResourceWatcher.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'timeLimitMillis' must be private and have accessor methods. 31
 Warning design VisibilityModifier Variable 'placeTimeLimits' must be private and have accessor methods. 37
 Warning design VisibilityModifier Variable 'monitor' must be private and have accessor methods. 41
 Warning design VisibilityModifier Variable 'timeToQuit' must be private and have accessor methods. 44
 Warning design VisibilityModifier Variable 'metrics' must be private and have accessor methods. 46
 Warning design VisibilityModifier Variable 'metricsFormatter' must be private and have accessor methods. 48
 Warning design VisibilityModifier Variable 'tracking' must be private and have accessor methods. 52
 Warning coding FinalLocalVariable Variable 'placeName' should be declared final. 73
 Warning coding RequireThis Reference to instance variable 'placeTimeLimits' needs "this.". 74
 Warning coding RequireThis Reference to instance variable 'timeLimitMillis' needs "this.". 78
 Warning coding RequireThis Reference to instance variable 'placeTimeLimits' needs "this.". 79
 Warning coding FinalLocalVariable Variable 'tr' should be declared final. 92
 Warning coding RequireThis Reference to instance variable 'metrics' needs "this.". 92
 Warning coding RequireThis Reference to instance variable 'tracking' needs "this.". 93
 Warning coding FinalLocalVariable Variable 'it' should be declared final. 146
 Warning coding RequireThis Reference to instance variable 'tracking' needs "this.". 146
 Warning coding FinalLocalVariable Variable 'histogramField' should be declared final. 172

emissary/core/ResourceWatcherTest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'resourceWatcher' must be private and have accessor methods. 25
 Warning design VisibilityModifier Variable 'place' must be private and have accessor methods. 27
 Warning coding FinalLocalVariable Variable 'threadCount' should be declared final. 33
 Warning coding FinalLocalVariable Variable 'iterations' should be declared final. 34
 Warning coding FinalLocalVariable Variable 'cdl' should be declared final. 36
 Warning coding FinalLocalVariable Variable 'tg' should be declared final. 37
 Warning coding FinalLocalVariable Variable 'rc' should be declared final. 42
 Warning coding RequireThis Reference to instance variable 'resourceWatcher' needs "this.". 62
 Warning design VisibilityModifier Variable 'times' must be private and have accessor methods. 75
 Warning design VisibilityModifier Variable 'duration' must be private and have accessor methods. 76
 Warning design VisibilityModifier Variable 'rand' must be private and have accessor methods. 77
 Warning design VisibilityModifier Variable 'cdl' must be private and have accessor methods. 78
 Warning modifier RedundantModifier Redundant 'public' modifier. 80
 Warning misc FinalParameters Parameter cdl should be final. 80
 Warning coding RequireThis Reference to instance variable 'rand' needs "this.". 93
 Warning coding RequireThis Reference to instance variable 'cdl' needs "this.". 99
 Warning misc FinalParameters Parameter payload should be final. 116
 Warning misc FinalParameters Parameter sourcePlace should be final. 116
 Warning misc FinalParameters Parameter payload should be final. 121
 Warning misc FinalParameters Parameter arrivalPlace should be final. 121
 Warning misc FinalParameters Parameter mec should be final. 121
 Warning misc FinalParameters Parameter iq should be final. 121
 Warning misc FinalParameters Parameter value should be final. 185
 Warning misc FinalParameters Parameter value should be final. 195

emissary/core/SafeUsageChecker.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'configurator' should be declared final. 34
 Warning design VisibilityModifier Variable 'enabled' must be private and have accessor methods. 52
 Warning coding RequireThis Reference to instance variable 'enabled' needs "this.". 55
 Warning misc FinalParameters Parameter configurator should be final. 58
 Warning coding RequireThis Reference to instance variable 'enabled' needs "this.". 59
 Warning coding RequireThis Reference to instance variable 'enabled' needs "this.". 66
 Warning coding RequireThis Reference to instance variable 'cache' needs "this.". 67
 Warning coding RequireThis Reference to instance variable 'enabled' needs "this.". 77
 Warning coding RequireThis Reference to instance variable 'cache' needs "this.". 78
 Warning coding RequireThis Reference to instance variable 'enabled' needs "this.". 89
 Warning coding RequireThis Reference to instance variable 'enabled' needs "this.". 99
 Warning coding FinalLocalVariable Variable 'isUnsafe' should be declared final. 100
 Warning coding RequireThis Reference to instance variable 'cache' needs "this.". 100

emissary/core/Stage.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'isParallel' must be private and have accessor methods. 36
 Warning misc FinalParameters Parameter isParallel should be final. 43
 Warning coding RequireThis Reference to instance variable 'isParallel' needs "this.". 53
 Warning misc FinalParameters Parameter name should be final. 63
 Warning coding FinalLocalVariable Variable 'stage' should be declared final. 93
 Warning coding FinalLocalVariable Variable 'current' should be declared final. 116
 Warning coding FinalLocalVariable Variable 'stage' should be declared final. 132

emissary/core/StageTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'i' should be declared final. 24
 Warning coding FinalLocalVariable Variable 'list' should be declared final. 50

emissary/core/TimedResource.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'isClosed' needs "this.". 36
 Warning coding RequireThis Reference to instance variable 'started' needs "this.". 37
 Warning coding RequireThis Reference to instance variable 'allowedDuration' needs "this.". 38
 Warning coding RequireThis Reference to instance variable 'agent' needs "this.". 39
 Warning coding RequireThis Reference to instance variable 'payloadCount' needs "this.". 40
 Warning coding RequireThis Reference to instance variable 'placeName' needs "this.". 41
 Warning coding RequireThis Reference to instance variable 'timerContext' needs "this.". 42
 Warning misc FinalParameters Parameter now should be final. 56
 Warning coding RequireThis Reference to instance variable 'allowedDuration' needs "this.". 57
 Warning coding RequireThis Reference to instance variable 'started' needs "this.". 57
 Warning coding RequireThis Reference to instance variable 'allowedDuration' needs "this.". 57
 Warning coding RequireThis Reference to instance variable 'payloadCount' needs "this.". 57
 Warning coding RequireThis Reference to instance variable 'isClosed' needs "this.". 60
 Warning coding RequireThis Reference to instance variable 'isClosed' needs "this.". 66
 Warning coding RequireThis Reference to instance variable 'lock' needs "this.". 69
 Warning coding RequireThis Reference to instance variable 'isClosed' needs "this.". 71
 Warning coding RequireThis Reference to instance variable 'agent' needs "this.". 72
 Warning coding RequireThis Reference to instance variable 'placeName' needs "this.". 72
 Warning coding RequireThis Reference to instance variable 'agent' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'agent' needs "this.". 76
 Warning coding RequireThis Reference to instance variable 'lock' needs "this.". 78
 Warning coding RequireThis Reference to instance variable 'lock' needs "this.". 84
 Warning coding RequireThis Reference to instance variable 'isClosed' needs "this.". 86
 Warning coding RequireThis Reference to instance variable 'timerContext' needs "this.". 89
 Warning coding RequireThis Reference to instance variable 'isClosed' needs "this.". 90
 Warning coding RequireThis Reference to instance variable 'lock' needs "this.". 92

emissary/core/TimedResourceTest.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'tp' needs "this.". 24
 Warning coding FinalLocalVariable Variable 'tma' should be declared final. 30
 Warning coding RequireThis Reference to instance variable 'tp' needs "this.". 32
 Warning coding FinalLocalVariable Variable 'tma' should be declared final. 44
 Warning coding RequireThis Reference to instance variable 'tp' needs "this.". 46
 Warning coding FinalLocalVariable Variable 'tma' should be declared final. 57
 Warning coding FinalLocalVariable Variable 'first' should be declared final. 59
 Warning coding RequireThis Reference to instance variable 'tp' needs "this.". 59
 Warning coding VariableDeclarationUsageDistance Distance between variable 'second' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 62
 Warning coding FinalLocalVariable Variable 'second' should be declared final. 62
 Warning coding RequireThis Reference to instance variable 'tp' needs "this.". 62
 Warning design VisibilityModifier Variable 'latch' must be private and have accessor methods. 79
 Warning design VisibilityModifier Variable 'interrupted' must be private and have accessor methods. 81
 Warning modifier RedundantModifier Redundant 'public' modifier. 83
 Warning coding RequireThis Reference to instance variable 'latch' needs "this.". 90
 Warning coding RequireThis Reference to instance variable 'latch' needs "this.". 94
 Warning coding RequireThis Reference to instance variable 'interrupted' needs "this.". 96
 Warning coding RequireThis Reference to instance variable 'latch' needs "this.". 98

emissary/core/TransformHistory.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'history' needs "this.". 27
 Warning misc FinalParameters Parameter history should be final. 30
 Warning misc FinalParameters Parameter keys should be final. 39
 Warning misc FinalParameters Parameter history should be final. 49
 Warning coding HiddenField 'history' hides a field. 49
 Warning misc FinalParameters Parameter history should be final. 54
 Warning coding HiddenField 'history' hides a field. 54
 Warning misc FinalParameters Parameter key should be final. 79
 Warning misc FinalParameters Parameter coordinated should be final. 79
 Warning coding FinalLocalVariable Variable 'last' should be declared final. 81
 Warning coding RequireThis Reference to instance variable 'history' needs "this.". 86
 Warning coding RequireThis Reference to instance variable 'history' needs "this.". 95
 Warning misc FinalParameters Parameter includeCoordinated should be final. 112
 Warning coding FinalLocalVariable Variable 'keys' should be declared final. 114
 Warning coding RequireThis Reference to instance variable 'history' needs "this.". 115
 Warning coding RequireThis Reference to instance variable 'history' needs "this.". 121
 Warning coding RequireThis Reference to instance variable 'history' needs "this.". 133
 Warning coding RequireThis Reference to instance variable 'history' needs "this.". 143
 Warning coding RequireThis Reference to instance variable 'history' needs "this.". 146
 Warning coding RequireThis Reference to instance variable 'history' needs "this.". 146
 Warning coding RequireThis Reference to instance variable 'history' needs "this.". 156
 Warning coding RequireThis Reference to instance variable 'history' needs "this.". 156
 Warning coding RequireThis Reference to instance variable 'history' needs "this.". 159
 Warning coding RequireThis Reference to instance variable 'history' needs "this.". 159
 Warning coding RequireThis Reference to instance variable 'history' needs "this.". 168
 Warning coding RequireThis Reference to instance variable 'history' needs "this.". 182
 Warning coding RequireThis Reference to instance variable 'history' needs "this.". 185
 Warning coding RequireThis Reference to instance variable 'history' needs "this.". 185
 Warning misc FinalParameters Parameter includeCoordinated should be final. 193
 Warning coding RequireThis Reference to instance variable 'history' needs "this.". 194
 Warning coding RequireThis Reference to instance variable 'history' needs "this.". 196
 Warning coding FinalLocalVariable Variable 'formattedHistory' should be declared final. 202
 Warning coding FinalLocalVariable Variable 'key' should be declared final. 206
 Warning coding FinalLocalVariable Variable 'displayStrings' should be declared final. 208
 Warning coding FinalLocalVariable Variable 'last' should be declared final. 214
 Warning coding RequireThis Reference to instance variable 'history' needs "this.". 246
 Warning design VisibilityModifier Variable 'key' must be private and have accessor methods. 251
 Warning design VisibilityModifier Variable 'coordinated' must be private and have accessor methods. 252
 Warning blocks RightCurly '}' at column 28 should be alone on a line. 257
 Warning misc FinalParameters Parameter key should be final. 259
 Warning misc FinalParameters Parameter stripUrl should be final. 267
 Warning coding RequireThis Reference to instance variable 'key' needs "this.". 268
 Warning coding RequireThis Reference to instance variable 'key' needs "this.". 268
 Warning misc FinalParameters Parameter stripUrl should be final. 275
 Warning coding RequireThis Reference to instance variable 'coordinated' needs "this.". 276
 Warning coding RequireThis Reference to instance variable 'coordinated' needs "this.". 277
 Warning misc FinalParameters Parameter key should be final. 280
 Warning coding HiddenField 'key' hides a field. 280
 Warning coding RequireThis Reference to instance variable 'coordinated' needs "this.". 281
 Warning misc FinalParameters Parameter key should be final. 284
 Warning coding FinalLocalVariable Variable 'hist' should be declared final. 290
 Warning coding RequireThis Reference to instance variable 'coordinated' needs "this.". 291

emissary/core/TransformHistoryTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'key1' should be declared final. 19
 Warning coding FinalLocalVariable Variable 'key2' should be declared final. 20
 Warning coding FinalLocalVariable Variable 'key3' should be declared final. 21
 Warning coding FinalLocalVariable Variable 'key4' should be declared final. 22
 Warning coding FinalLocalVariable Variable 'keySet1' should be declared final. 24
 Warning coding VariableDeclarationUsageDistance Distance between variable 'keySet2' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 25
 Warning coding FinalLocalVariable Variable 'keySet2' should be declared final. 25
 Warning coding FinalLocalVariable Variable 'th' should be declared final. 28
 Warning coding FinalLocalVariable Variable 'historyObject' should be declared final. 41
 Warning coding FinalLocalVariable Variable 'newHistory' should be declared final. 49
 Warning coding FinalLocalVariable Variable 'key1' should be declared final. 57
 Warning coding VariableDeclarationUsageDistance Distance between variable 'key2' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 58
 Warning coding FinalLocalVariable Variable 'key2' should be declared final. 58
 Warning coding VariableDeclarationUsageDistance Distance between variable 'key3' declaration and its first usage is 8, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 59
 Warning coding FinalLocalVariable Variable 'key3' should be declared final. 59
 Warning coding FinalLocalVariable Variable 'keyList' should be declared final. 60
 Warning coding FinalLocalVariable Variable 'th' should be declared final. 63
 Warning coding FinalLocalVariable Variable 'key1' should be declared final. 84
 Warning coding FinalLocalVariable Variable 'key2' should be declared final. 85
 Warning coding FinalLocalVariable Variable 'key3' should be declared final. 86
 Warning coding VariableDeclarationUsageDistance Distance between variable 'key4' declaration and its first usage is 7, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 87
 Warning coding FinalLocalVariable Variable 'key4' should be declared final. 87
 Warning coding FinalLocalVariable Variable 'th' should be declared final. 89
 Warning coding FinalLocalVariable Variable 'key1' should be declared final. 120
 Warning coding FinalLocalVariable Variable 'key2' should be declared final. 121
 Warning coding FinalLocalVariable Variable 'key3' should be declared final. 122
 Warning coding VariableDeclarationUsageDistance Distance between variable 'key4' declaration and its first usage is 6, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 123
 Warning coding FinalLocalVariable Variable 'key4' should be declared final. 123
 Warning coding VariableDeclarationUsageDistance Distance between variable 'keyList' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 124
 Warning coding FinalLocalVariable Variable 'keyList' should be declared final. 124
 Warning coding FinalLocalVariable Variable 'th' should be declared final. 126
 Warning coding FinalLocalVariable Variable 'key1' should be declared final. 146
 Warning coding FinalLocalVariable Variable 'key2' should be declared final. 147
 Warning coding FinalLocalVariable Variable 'key3' should be declared final. 148
 Warning coding FinalLocalVariable Variable 'key4' should be declared final. 149
 Warning coding FinalLocalVariable Variable 'key5' should be declared final. 150
 Warning coding FinalLocalVariable Variable 'key6' should be declared final. 151
 Warning coding FinalLocalVariable Variable 'newline' should be declared final. 153
 Warning coding FinalLocalVariable Variable 'expected' should be declared final. 154
 Warning coding FinalLocalVariable Variable 'th' should be declared final. 163
 Warning coding FinalLocalVariable Variable 'th' should be declared final. 176
 Warning coding FinalLocalVariable Variable 'formatted' should be declared final. 184
 Warning coding FinalLocalVariable Variable 'th' should be declared final. 194
 Warning coding FinalLocalVariable Variable 'formatted' should be declared final. 203
 Warning coding FinalLocalVariable Variable 'th' should be declared final. 212
 Warning coding FinalLocalVariable Variable 'formatted' should be declared final. 223
 Warning coding FinalLocalVariable Variable 'key1' should be declared final. 232
 Warning coding FinalLocalVariable Variable 'th' should be declared final. 234

emissary/core/channels/AbstractSeekableByteChannel.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 46 should be alone on a line. 33
 Warning coding RequireThis Reference to instance variable 'open' needs "this.". 64
 Warning coding RequireThis Reference to instance variable 'open' needs "this.". 65
 Warning coding RequireThis Reference to instance variable 'open' needs "this.". 77
 Warning coding RequireThis Reference to instance variable 'open' needs "this.". 87
 Warning coding RequireThis Reference to instance variable 'position' needs "this.". 88
 Warning coding HiddenField 'position' hides a field. 97
 Warning coding RequireThis Reference to instance variable 'open' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'open' needs "this.". 114
 Warning coding RequireThis Reference to instance variable 'open' needs "this.". 182

emissary/core/channels/AbstractSeekableByteChannelTest.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'public' modifier. 22
 Warning coding RequireThis Reference to instance variable 'size' needs "this.". 28
 Warning blocks RightCurly '}' at column 56 should be alone on a line. 32
 Warning coding FinalLocalVariable Variable 'sbc' should be declared final. 54
 Warning coding FinalLocalVariable Variable 'bb' should be declared final. 70

emissary/core/channels/BufferedChannelFactory.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 39 should be alone on a line. 14
 Warning modifier RedundantModifier Redundant 'public' modifier. 47
 Warning coding RequireThis Reference to instance variable 'seekableByteChannelFactory' needs "this.". 68
 Warning coding RequireThis Reference to instance variable 'bufferSize' needs "this.". 68
 Warning modifier RedundantModifier Redundant 'public' modifier. 104
 Warning coding RequireThis Reference to instance variable 'seekableByteChannel' needs "this.". 112
 Warning coding RequireThis Reference to instance variable 'bufferSize' needs "this.". 118
 Warning coding RequireThis Reference to instance variable 'bufferSize' needs "this.". 118
 Warning coding RequireThis Reference to instance variable 'bufferStart' needs "this.". 120
 Warning coding RequireThis Reference to instance variable 'buffer' needs "this.". 121
 Warning coding RequireThis Reference to instance variable 'seekableByteChannel' needs "this.". 122
 Warning coding RequireThis Reference to instance variable 'bufferValidBytes' needs "this.". 124
 Warning coding RequireThis Reference to instance variable 'seekableByteChannel' needs "this.". 124
 Warning coding RequireThis Reference to instance variable 'buffer' needs "this.". 124
 Warning coding RequireThis Reference to instance variable 'bufferStart' needs "this.". 125
 Warning coding RequireThis Reference to instance variable 'bufferSize' needs "this.". 128
 Warning coding RequireThis Reference to instance variable 'bufferValidBytes' needs "this.". 129
 Warning coding RequireThis Reference to instance variable 'buffer' needs "this.". 131
 Warning coding RequireThis Reference to instance variable 'seekableByteChannel' needs "this.". 138

emissary/core/channels/ChannelTestHelper.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 34 should be alone on a line. 14
 Warning whitespace EmptyLineSeparator ';' should be separated from previous line. 14

emissary/core/channels/CheckCloseChannelFactory.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'isClosedList' must be private and have accessor methods. 13
 Warning coding RequireThis Reference to instance variable 'isClosedList' needs "this.". 17
 Warning design VisibilityModifier Variable 'myInstanceNumber' must be private and have accessor methods. 20
 Warning coding RequireThis Reference to instance variable 'instanceNumber' needs "this.". 20
 Warning coding RequireThis Reference to instance variable 'isClosedList' needs "CheckCloseChannelFactory.this.". 24
 Warning coding RequireThis Reference to instance variable 'myInstanceNumber' needs "this.". 24
 Warning misc FinalParameters Parameter byteBuffer should be final. 28

emissary/core/channels/ConcatenateChannelFactory.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 42 should be alone on a line. 14
 Warning coding RequireThis Reference to instance variable 'first' needs "this.". 52
 Warning coding RequireThis Reference to instance variable 'second' needs "this.". 52
 Warning coding RequireThis Reference to instance variable 'first' needs "this.". 84
 Warning coding RequireThis Reference to instance variable 'second' needs "this.". 85
 Warning coding RequireThis Reference to instance variable 'first' needs "this.". 94
 Warning coding RequireThis Reference to instance variable 'first' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'first' needs "this.". 99
 Warning coding RequireThis Reference to instance variable 'second' needs "this.". 101
 Warning coding RequireThis Reference to instance variable 'second' needs "this.". 102
 Warning coding RequireThis Reference to instance variable 'first' needs "this.". 108
 Warning coding RequireThis Reference to instance variable 'first' needs "this.". 109
 Warning coding RequireThis Reference to instance variable 'second' needs "this.". 111
 Warning coding RequireThis Reference to instance variable 'second' needs "this.". 112
 Warning coding RequireThis Reference to instance variable 'totalSize' needs "this.". 120
 Warning coding RequireThis Reference to instance variable 'first' needs "this.". 121
 Warning coding RequireThis Reference to instance variable 'second' needs "this.". 122
 Warning coding RequireThis Reference to instance variable 'totalSize' needs "this.". 126
 Warning coding RequireThis Reference to instance variable 'totalSize' needs "this.". 132

emissary/core/channels/ConcatenateChannelFactoryTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'sbc' should be declared final. 28

emissary/core/channels/FileChannelFactory.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 35 should be alone on a line. 19
 Warning coding RequireThis Reference to instance variable 'path' needs "this.". 53
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 70
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 71
 Warning coding RequireThis Reference to instance variable 'path' needs "this.". 71
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 77
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 78
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 86
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 87
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 93

emissary/core/channels/FillChannelFactory.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 35 should be alone on a line. 13
 Warning coding RequireThis Reference to instance variable 'size' needs "this.". 50
 Warning coding RequireThis Reference to instance variable 'value' needs "this.". 50
 Warning coding RequireThis Reference to instance variable 'size' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'value' needs "this.". 87
 Warning coding RequireThis Reference to instance variable 'value' needs "this.". 91

emissary/core/channels/ImmutableChannelFactory.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 40 should be alone on a line. 14
 Warning coding RequireThis Reference to instance variable 'sbcf' needs "this.". 59
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 80
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 85
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 90
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 95
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 100
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 105

emissary/core/channels/ImmutableChannelFactoryTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'sbcf' should be declared final. 40
 Warning coding FinalLocalVariable Variable 'sbc' should be declared final. 41

emissary/core/channels/InMemoryChannelFactory.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 39 should be alone on a line. 12
 Warning coding RequireThis Reference to instance variable 'bytes' needs "this.". 47

emissary/core/channels/InputStreamChannelFactory.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 42 should be alone on a line. 13
 Warning modifier RedundantModifier Redundant 'public' modifier. 32
 Warning coding RequireThis Reference to instance variable 'size' needs "this.". 41
 Warning coding RequireThis Reference to instance variable 'inputStreamFactory' needs "this.". 41
 Warning modifier RedundantModifier Redundant 'public' modifier. 65
 Warning coding RequireThis Reference to instance variable 'inputStream' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'inputStream' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'inputStream' needs "this.". 74
 Warning coding RequireThis Reference to instance variable 'inputStream' needs "this.". 75
 Warning coding RequireThis Reference to instance variable 'inputStream' needs "this.". 78
 Warning coding RequireThis Reference to instance variable 'inputStream' needs "this.". 79
 Warning coding RequireThis Reference to instance variable 'inputStreamFactory' needs "this.". 79
 Warning coding RequireThis Reference to instance variable 'inputStream' needs "this.". 83
 Warning coding RequireThis Reference to instance variable 'inputStream' needs "this.". 83
 Warning coding RequireThis Reference to instance variable 'size' needs "this.". 89
 Warning coding RequireThis Reference to instance variable 'inputStreamFactory' needs "this.". 90
 Warning coding RequireThis Reference to instance variable 'size' needs "this.". 91
 Warning coding RequireThis Reference to instance variable 'size' needs "this.". 94
 Warning coding RequireThis Reference to instance variable 'inputStream' needs "this.". 99
 Warning coding RequireThis Reference to instance variable 'inputStream' needs "this.". 100
 Warning coding RequireThis Reference to instance variable 'inputStream' needs "this.". 101

emissary/core/channels/InputStreamChannelFactoryTest.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'public' modifier. 24
 Warning coding RequireThis Reference to instance variable 'bytes' needs "this.". 30
 Warning coding FinalLocalVariable Variable 'sbc' should be declared final. 62
 Warning coding FinalLocalVariable Variable 'buff' should be declared final. 92
 Warning coding FinalLocalVariable Variable 'buff' should be declared final. 103
 Warning coding FinalLocalVariable Variable 'buff' should be declared final. 115
 Warning coding FinalLocalVariable Variable 'buff' should be declared final. 126
 Warning coding FinalLocalVariable Variable 'buff' should be declared final. 138
 Warning coding FinalLocalVariable Variable 'buff' should be declared final. 152

emissary/core/channels/LoggingChannelFactory.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 38 should be alone on a line. 17
 Warning coding RequireThis Reference to instance variable 'seekableByteChannelFactory' needs "this.". 72
 Warning coding RequireThis Reference to instance variable 'identifier' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'currentInstance' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'logStackTrace' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'seekableByteChannel' needs "this.". 118
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 120
 Warning coding RequireThis Reference to instance variable 'logStackTrace' needs "this.". 120
 Warning coding RequireThis Reference to instance variable 'prefix' needs "this.". 120
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 127
 Warning coding RequireThis Reference to instance variable 'logStackTrace' needs "this.". 127
 Warning coding RequireThis Reference to instance variable 'prefix' needs "this.". 127
 Warning coding RequireThis Reference to instance variable 'seekableByteChannel' needs "this.". 129
 Warning coding RequireThis Reference to instance variable 'seekableByteChannel' needs "this.". 136
 Warning coding RequireThis Reference to instance variable 'seekableByteChannel' needs "this.". 138
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 140
 Warning coding RequireThis Reference to instance variable 'logStackTrace' needs "this.". 140
 Warning coding RequireThis Reference to instance variable 'prefix' needs "this.". 140
 Warning coding RequireThis Reference to instance variable 'seekableByteChannel' needs "this.". 149
 Warning coding RequireThis Reference to instance variable 'seekableByteChannel' needs "this.". 151
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 153
 Warning coding RequireThis Reference to instance variable 'logStackTrace' needs "this.". 153
 Warning coding RequireThis Reference to instance variable 'prefix' needs "this.". 153
 Warning coding RequireThis Reference to instance variable 'seekableByteChannel' needs "this.". 161
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 163
 Warning coding RequireThis Reference to instance variable 'logStackTrace' needs "this.". 163
 Warning coding RequireThis Reference to instance variable 'prefix' needs "this.". 163
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 170
 Warning coding RequireThis Reference to instance variable 'logStackTrace' needs "this.". 170
 Warning coding RequireThis Reference to instance variable 'prefix' needs "this.". 170
 Warning coding RequireThis Reference to instance variable 'seekableByteChannel' needs "this.". 172
 Warning coding RequireThis Reference to instance variable 'seekableByteChannel' needs "this.". 177
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 179
 Warning coding RequireThis Reference to instance variable 'logStackTrace' needs "this.". 179
 Warning coding RequireThis Reference to instance variable 'prefix' needs "this.". 179
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 186
 Warning coding RequireThis Reference to instance variable 'logStackTrace' needs "this.". 186
 Warning coding RequireThis Reference to instance variable 'prefix' needs "this.". 186
 Warning coding RequireThis Reference to instance variable 'seekableByteChannel' needs "this.". 188

emissary/core/channels/LoggingChannelFactoryTest.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 35
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 36
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 37
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 37
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 42
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 42
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 48
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 49
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 52
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 56
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 59
 Warning modifier RedundantModifier Redundant 'public' modifier. 126
 Warning coding RequireThis Reference to instance variable 'path' needs "this.". 136
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 139

emissary/core/channels/LoggingInputStreamFactory.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 42 should be alone on a line. 17
 Warning coding RequireThis Reference to instance variable 'inputStreamFactory' needs "this.". 72
 Warning coding RequireThis Reference to instance variable 'identifier' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'currentInstance' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'logStackTrace' needs "this.". 73

emissary/core/channels/LoggingInputStreamFactoryTest.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 34
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 35
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 36
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 36
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 41
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 41
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 50
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 51
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 55
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 59
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 65
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 107
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 109
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 123
 Warning modifier RedundantModifier Redundant 'public' modifier. 129
 Warning coding RequireThis Reference to instance variable 'bytes' needs "this.". 135

emissary/core/channels/SeekableByteChannelHelper.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 42 should be alone on a line. 25

emissary/core/channels/SeekableByteChannelHelperTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'bytes' should be declared final. 52
 Warning misc FinalParameters Parameter tempDir should be final. 58
 Warning misc FinalParameters Parameter b should be final. 134
 Warning misc FinalParameters Parameter off should be final. 134
 Warning misc FinalParameters Parameter len should be final. 134

emissary/core/channels/SegmentChannelFactory.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 38 should be alone on a line. 13
 Warning coding RequireThis Reference to instance variable 'seekableByteChannelFactory' needs "this.". 64
 Warning coding RequireThis Reference to instance variable 'start' needs "this.". 64
 Warning coding RequireThis Reference to instance variable 'length' needs "this.". 64
 Warning coding RequireThis Reference to instance variable 'seekableByteChannel' needs "this.". 94
 Warning coding RequireThis Reference to instance variable 'seekableByteChannel' needs "this.". 99
 Warning coding RequireThis Reference to instance variable 'start' needs "this.". 99
 Warning coding RequireThis Reference to instance variable 'seekableByteChannel' needs "this.". 101
 Warning coding RequireThis Reference to instance variable 'length' needs "this.". 106

emissary/core/constants/Configurations.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 31 should be alone on a line. 42

emissary/core/constants/IbdoMethodNames.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 32 should be alone on a line. 85

emissary/core/constants/IbdoXmlElementNames.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 36 should be alone on a line. 114

emissary/core/constants/Parameters.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 27 should be alone on a line. 23

emissary/core/sentinel/Sentinel.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'trackers' must be private and have accessor methods. 38
 Warning design VisibilityModifier Variable 'protocols' must be private and have accessor methods. 41
 Warning design VisibilityModifier Variable 'config' must be private and have accessor methods. 44
 Warning design VisibilityModifier Variable 'pollingInterval' must be private and have accessor methods. 47
 Warning design VisibilityModifier Variable 'timeToQuit' must be private and have accessor methods. 50
 Warning design VisibilityModifier Variable 'enabled' must be private and have accessor methods. 53
 Warning coding RequireThis Reference to instance variable 'pollingInterval' needs "this.". 106
 Warning coding RequireThis Reference to instance variable 'protocols' needs "this.". 121
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 140
 Warning coding FinalLocalVariable Variable 'protocol' should be declared final. 147
 Warning coding RequireThis Reference to instance variable 'protocols' needs "this.". 162
 Warning coding FinalLocalVariable Variable 'agentKeys' should be declared final. 173
 Warning coding RequireThis Reference to instance variable 'protocols' needs "this.". 180
 Warning coding RequireThis Reference to instance variable 'trackers' needs "this.". 180
 Warning misc FinalParameters Parameter agentKey should be final. 189
 Warning coding FinalLocalVariable Variable 'mobileAgent' should be declared final. 191
 Warning coding FinalLocalVariable Variable 'trackedAgent' should be declared final. 192
 Warning coding RequireThis Reference to instance variable 'trackers' needs "this.". 192
 Warning coding RequireThis Reference to instance variable 'pollingInterval' needs "this.". 200
 Warning misc FinalParameters Parameter agentName should be final. 215
 Warning coding RequireThis Reference to instance variable 'agentName' needs "this.". 220
 Warning coding RequireThis Reference to instance variable 'agentId' needs "this.". 224
 Warning misc FinalParameters Parameter agentId should be final. 227
 Warning coding HiddenField 'agentId' hides a field. 227
 Warning coding RequireThis Reference to instance variable 'shortName' needs "this.". 239
 Warning misc FinalParameters Parameter agentId should be final. 242
 Warning coding RequireThis Reference to instance variable 'directoryEntryKey' needs "this.". 247
 Warning misc FinalParameters Parameter directoryEntryKey should be final. 250
 Warning coding HiddenField 'directoryEntryKey' hides a field. 250
 Warning misc FinalParameters Parameter directoryEntryKey should be final. 258
 Warning coding RequireThis Reference to instance variable 'timer' needs "this.". 263
 Warning misc FinalParameters Parameter time should be final. 270
 Warning misc FinalParameters Parameter o should be final. 286
 Warning coding RequireThis Reference to instance variable 'agentName' needs "this.". 293
 Warning coding RequireThis Reference to instance variable 'directoryEntryKey' needs "this.". 294
 Warning coding RequireThis Reference to instance variable 'shortName' needs "this.". 295
 Warning coding RequireThis Reference to instance variable 'timer' needs "this.". 296

emissary/core/sentinel/SentinelTest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'sentinel' must be private and have accessor methods. 28
 Warning coding RequireThis Reference to instance variable 'sentinel' needs "this.". 34
 Warning coding FinalLocalVariable Variable 'agentKey' should be declared final. 39
 Warning coding FinalLocalVariable Variable 'placename' should be declared final. 40
 Warning coding FinalLocalVariable Variable 'shortname' should be declared final. 41
 Warning coding FinalLocalVariable Variable 'hdma' should be declared final. 43
 Warning coding FinalLocalVariable Variable 'tracker' should be declared final. 49
 Warning coding RequireThis Reference to instance variable 'sentinel' needs "this.". 53
 Warning coding RequireThis Reference to instance variable 'sentinel' needs "this.". 54
 Warning coding FinalLocalVariable Variable 'tracker' should be declared final. 65
 Warning coding FinalLocalVariable Variable 'tracker' should be declared final. 80
 Warning coding FinalLocalVariable Variable 'tracker1' should be declared final. 95
 Warning coding FinalLocalVariable Variable 'tracker2' should be declared final. 96
 Warning coding FinalLocalVariable Variable 'tracker3' should be declared final. 97
 Warning coding RequireThis Reference to instance variable 'sentinel' needs "this.". 99
 Warning coding RequireThis Reference to instance variable 'sentinel' needs "this.". 100
 Warning coding RequireThis Reference to instance variable 'sentinel' needs "this.". 101
 Warning coding FinalLocalVariable Variable 'sorted' should be declared final. 103
 Warning coding RequireThis Reference to instance variable 'sentinel' needs "this.". 103
 Warning coding FinalLocalVariable Variable 'mapper' should be declared final. 111
 Warning coding FinalLocalVariable Variable 'mapper' should be declared final. 121

emissary/core/sentinel/protocols/Protocol.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'config' must be private and have accessor methods. 36
 Warning design VisibilityModifier Variable 'enabled' must be private and have accessor methods. 37
 Warning design VisibilityModifier Variable 'rules' must be private and have accessor methods. 38
 Warning design VisibilityModifier Variable 'action' must be private and have accessor methods. 39
 Warning blocks RightCurly '}' at column 17 should be alone on a line. 41
 Warning misc FinalParameters Parameter conf should be final. 43
 Warning coding RequireThis Reference to instance variable 'enabled' needs "this.". 48
 Warning misc FinalParameters Parameter trackers should be final. 54
 Warning coding FinalLocalVariable Variable 'placeAgentStats' should be declared final. 56
 Warning coding RequireThis Reference to instance variable 'rules' needs "this.". 59
 Warning coding RequireThis Reference to instance variable 'rules' needs "this.". 60
 Warning coding RequireThis Reference to instance variable 'action' needs "this.". 61
 Warning misc FinalParameters Parameter conf should be final. 71
 Warning misc FinalParameters Parameter config should be final. 83
 Warning coding HiddenField 'config' hides a field. 83
 Warning coding RequireThis Reference to instance variable 'enabled' needs "this.". 85
 Warning coding FinalLocalVariable Variable 'map' should be declared final. 95
 Warning coding FinalLocalVariable Variable 'rule' should be declared final. 96
 Warning coding FinalLocalVariable Variable 'ruleImpl' should be declared final. 97
 Warning misc FinalParameters Parameter place should be final. 120
 Warning coding FinalLocalVariable Variable 'directoryPlace' should be declared final. 122
 Warning misc FinalParameters Parameter trackers should be final. 130
 Warning coding FinalLocalVariable Variable 'placeAgentStats' should be declared final. 131
 Warning coding FinalLocalVariable Variable 'placeKey' should be declared final. 133
 Warning coding RequireThis Reference to instance variable 'rules' needs "this.". 144
 Warning coding RequireThis Reference to instance variable 'action' needs "this.". 145
 Warning misc FinalParameters Parameter place should be final. 156
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 161
 Warning coding RequireThis Reference to instance variable 'count' needs "this.". 165
 Warning coding RequireThis Reference to instance variable 'maxTimeInPlace' needs "this.". 169
 Warning coding RequireThis Reference to instance variable 'minTimeInPlace' needs "this.". 173
 Warning misc FinalParameters Parameter timer should be final. 176

emissary/core/sentinel/protocols/ProtocolTest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'protocol' must be private and have accessor methods. 44
 Warning design VisibilityModifier Variable 'rule1' must be private and have accessor methods. 45
 Warning design VisibilityModifier Variable 'action' must be private and have accessor methods. 46
 Warning design VisibilityModifier Variable 'trackers' must be private and have accessor methods. 47
 Warning coding RequireThis Reference to instance variable 'rule1' needs "this.". 54
 Warning coding RequireThis Reference to instance variable 'action' needs "this.". 55
 Warning coding RequireThis Reference to instance variable 'protocol' needs "this.". 57
 Warning coding RequireThis Reference to instance variable 'protocol' needs "this.". 58
 Warning coding RequireThis Reference to instance variable 'action' needs "this.". 58
 Warning coding RequireThis Reference to instance variable 'protocol' needs "this.". 59
 Warning coding RequireThis Reference to instance variable 'rule1' needs "this.". 59
 Warning coding RequireThis Reference to instance variable 'protocol' needs "this.". 60
 Warning coding RequireThis Reference to instance variable 'trackers' needs "this.". 62
 Warning coding FinalLocalVariable Variable 'agent' should be declared final. 64
 Warning coding FinalLocalVariable Variable 'tracker' should be declared final. 65
 Warning coding RequireThis Reference to instance variable 'trackers' needs "this.". 70
 Warning coding RequireThis Reference to instance variable 'protocol' needs "this.". 76
 Warning coding RequireThis Reference to instance variable 'rule1' needs "this.". 81
 Warning coding RequireThis Reference to instance variable 'protocol' needs "this.". 82
 Warning coding RequireThis Reference to instance variable 'trackers' needs "this.". 82
 Warning coding RequireThis Reference to instance variable 'action' needs "this.". 83
 Warning coding FinalLocalVariable Variable 'paStats' should be declared final. 88
 Warning coding RequireThis Reference to instance variable 'protocol' needs "this.". 88
 Warning coding RequireThis Reference to instance variable 'trackers' needs "this.". 88
 Warning coding FinalLocalVariable Variable 'stats' should be declared final. 89
 Warning coding FinalLocalVariable Variable 'config' should be declared final. 98
 Warning coding FinalLocalVariable Variable 'dir' should be declared final. 105
 Warning coding RequireThis Reference to instance variable 'protocol' needs "this.". 110
 Warning coding RequireThis Reference to instance variable 'protocol' needs "this.". 111
 Warning coding RequireThis Reference to instance variable 'protocol' needs "this.". 112
 Warning coding RequireThis Reference to instance variable 'trackers' needs "this.". 118
 Warning coding FinalLocalVariable Variable 'dir' should be declared final. 123
 Warning coding RequireThis Reference to instance variable 'protocol' needs "this.". 128
 Warning coding RequireThis Reference to instance variable 'protocol' needs "this.". 129
 Warning coding FinalLocalVariable Variable 'protocol' should be declared final. 135
 Warning coding HiddenField 'protocol' hides a field. 135
 Warning coding FinalLocalVariable Variable 'mapper' should be declared final. 140
 Warning design VisibilityModifier Variable 'toUpperLowerPattern' must be private and have accessor methods. 151
 Warning design VisibilityModifier Variable 'toLowerPlace' must be private and have accessor methods. 152
 Warning design VisibilityModifier Variable 'toUpperPlace' must be private and have accessor methods. 153
 Warning design VisibilityModifier Variable 'defaultPoolSize' must be private and have accessor methods. 154
 Warning design VisibilityModifier Variable 'action' must be private and have accessor methods. 156
 Warning design VisibilityModifier Variable 'pool' must be private and have accessor methods. 157
 Warning design VisibilityModifier Variable 'trackers' must be private and have accessor methods. 158
 Warning coding RequireThis Reference to instance variable 'action' needs "this.". 164
 Warning coding RequireThis Reference to instance variable 'pool' needs "this.". 165
 Warning coding RequireThis Reference to instance variable 'trackers' needs "this.". 166
 Warning coding FinalLocalVariable Variable 'protocol' should be declared final. 171
 Warning coding HiddenField 'protocol' hides a field. 171
 Warning coding RequireThis Reference to instance variable 'action' needs "this.". 172
 Warning coding RequireThis Reference to instance variable 'toUpperLowerPattern' needs "this.". 173
 Warning coding RequireThis Reference to instance variable 'toUpperLowerPattern' needs "this.". 174
 Warning coding RequireThis Reference to instance variable 'defaultPoolSize' needs "this.". 176
 Warning coding FinalLocalVariable Variable 'protocol' should be declared final. 181
 Warning coding HiddenField 'protocol' hides a field. 181
 Warning coding RequireThis Reference to instance variable 'action' needs "this.". 182
 Warning coding RequireThis Reference to instance variable 'toUpperLowerPattern' needs "this.". 183
 Warning coding RequireThis Reference to instance variable 'toUpperLowerPattern' needs "this.". 184
 Warning coding RequireThis Reference to instance variable 'defaultPoolSize' needs "this.". 186
 Warning coding FinalLocalVariable Variable 'protocol' should be declared final. 191
 Warning coding HiddenField 'protocol' hides a field. 191
 Warning coding RequireThis Reference to instance variable 'action' needs "this.". 192
 Warning coding RequireThis Reference to instance variable 'toUpperLowerPattern' needs "this.". 193
 Warning coding RequireThis Reference to instance variable 'defaultPoolSize' needs "this.". 195
 Warning coding FinalLocalVariable Variable 'protocol' should be declared final. 200
 Warning coding HiddenField 'protocol' hides a field. 200
 Warning coding RequireThis Reference to instance variable 'action' needs "this.". 201
 Warning coding RequireThis Reference to instance variable 'toLowerPlace' needs "this.". 202
 Warning coding RequireThis Reference to instance variable 'defaultPoolSize' needs "this.". 204
 Warning coding FinalLocalVariable Variable 'protocol' should be declared final. 209
 Warning coding HiddenField 'protocol' hides a field. 209
 Warning coding RequireThis Reference to instance variable 'action' needs "this.". 210
 Warning coding RequireThis Reference to instance variable 'toUpperPlace' needs "this.". 211
 Warning coding RequireThis Reference to instance variable 'defaultPoolSize' needs "this.". 213
 Warning coding FinalLocalVariable Variable 'protocol' should be declared final. 218
 Warning coding HiddenField 'protocol' hides a field. 218
 Warning coding RequireThis Reference to instance variable 'action' needs "this.". 219
 Warning coding RequireThis Reference to instance variable 'toUpperLowerPattern' needs "this.". 220
 Warning coding RequireThis Reference to instance variable 'toUpperLowerPattern' needs "this.". 221
 Warning coding RequireThis Reference to instance variable 'defaultPoolSize' needs "this.". 223
 Warning misc FinalParameters Parameter protocol should be final. 226
 Warning coding HiddenField 'protocol' hides a field. 226
 Warning misc FinalParameters Parameter poolSize should be final. 226
 Warning misc FinalParameters Parameter expected should be final. 226
 Warning coding RequireThis Reference to instance variable 'pool' needs "this.". 228
 Warning coding RequireThis Reference to instance variable 'pool' needs "this.". 229
 Warning coding RequireThis Reference to instance variable 'trackers' needs "this.". 230
 Warning coding RequireThis Reference to instance variable 'action' needs "this.". 231
 Warning coding RequireThis Reference to instance variable 'trackers' needs "this.". 231
 Warning coding FinalLocalVariable Variable 'agent1' should be declared final. 236
 Warning coding FinalLocalVariable Variable 'agent2' should be declared final. 242
 Warning coding FinalLocalVariable Variable 'agent3' should be declared final. 248
 Warning coding FinalLocalVariable Variable 'agent4' should be declared final. 254
 Warning coding FinalLocalVariable Variable 'agent5' should be declared final. 260

emissary/core/sentinel/protocols/actions/Action.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter trackers should be final. 24

emissary/core/sentinel/protocols/actions/Exit.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter trackers should be final. 14

emissary/core/sentinel/protocols/actions/Kill.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter trackers should be final. 15
 Warning coding FinalLocalVariable Variable 'unused' should be declared final. 17

emissary/core/sentinel/protocols/actions/Notify.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter trackers should be final. 13

emissary/core/sentinel/protocols/actions/Recover.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter tracker should be final. 17
 Warning coding FinalLocalVariable Variable 'agentNames' should be declared final. 19
 Warning coding FinalLocalVariable Variable 'mobileAgent' should be declared final. 26

emissary/core/sentinel/protocols/actions/Stop.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter trackers should be final. 15
 Warning coding FinalLocalVariable Variable 'unused' should be declared final. 17

emissary/core/sentinel/protocols/rules/AllMaxTime.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter name should be final. 18
 Warning misc FinalParameters Parameter place should be final. 18
 Warning misc FinalParameters Parameter timeLimit should be final. 18
 Warning misc FinalParameters Parameter threshold should be final. 18
 Warning misc FinalParameters Parameter name should be final. 22
 Warning misc FinalParameters Parameter place should be final. 22
 Warning misc FinalParameters Parameter timeLimit should be final. 22
 Warning misc FinalParameters Parameter threshold should be final. 22
 Warning misc FinalParameters Parameter placeAgentStats should be final. 33
 Warning coding FinalLocalVariable Variable 'minTimeInPlace' should be declared final. 34

emissary/core/sentinel/protocols/rules/AllMaxTimeTest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'placeAgentStats' must be private and have accessor methods. 24
 Warning coding FinalLocalVariable Variable 'stats' should be declared final. 30
 Warning coding RequireThis Reference to instance variable 'placeAgentStats' needs "this.". 31
 Warning coding FinalLocalVariable Variable 'rule' should be declared final. 56
 Warning coding RequireThis Reference to instance variable 'placeAgentStats' needs "this.". 57
 Warning coding FinalLocalVariable Variable 'rule' should be declared final. 62
 Warning coding RequireThis Reference to instance variable 'placeAgentStats' needs "this.". 63
 Warning design VisibilityModifier Variable 'toUpperLowerPattern' must be private and have accessor methods. 69
 Warning design VisibilityModifier Variable 'toLowerPlace' must be private and have accessor methods. 70
 Warning design VisibilityModifier Variable 'toUpperPlace' must be private and have accessor methods. 71
 Warning design VisibilityModifier Variable 'defaultPoolSize' must be private and have accessor methods. 72
 Warning design VisibilityModifier Variable 'defaultTimeLimit' must be private and have accessor methods. 73
 Warning design VisibilityModifier Variable 'pool' must be private and have accessor methods. 75
 Warning design VisibilityModifier Variable 'stats' must be private and have accessor methods. 76
 Warning coding RequireThis Reference to instance variable 'pool' needs "this.". 82
 Warning coding RequireThis Reference to instance variable 'stats' needs "this.". 83
 Warning coding RequireThis Reference to instance variable 'toUpperLowerPattern' needs "this.". 88
 Warning coding RequireThis Reference to instance variable 'defaultTimeLimit' needs "this.". 88
 Warning coding RequireThis Reference to instance variable 'defaultPoolSize' needs "this.". 88
 Warning coding RequireThis Reference to instance variable 'toUpperLowerPattern' needs "this.". 93
 Warning coding RequireThis Reference to instance variable 'defaultTimeLimit' needs "this.". 93
 Warning coding RequireThis Reference to instance variable 'defaultPoolSize' needs "this.". 93
 Warning coding RequireThis Reference to instance variable 'toLowerPlace' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'defaultTimeLimit' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'defaultPoolSize' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'toUpperPlace' needs "this.". 103
 Warning coding RequireThis Reference to instance variable 'defaultTimeLimit' needs "this.". 103
 Warning coding RequireThis Reference to instance variable 'defaultPoolSize' needs "this.". 103
 Warning coding RequireThis Reference to instance variable 'toUpperLowerPattern' needs "this.". 108
 Warning coding RequireThis Reference to instance variable 'defaultTimeLimit' needs "this.". 108
 Warning coding RequireThis Reference to instance variable 'defaultPoolSize' needs "this.". 108
 Warning coding RequireThis Reference to instance variable 'toUpperLowerPattern' needs "this.". 113
 Warning coding RequireThis Reference to instance variable 'defaultTimeLimit' needs "this.". 113
 Warning coding RequireThis Reference to instance variable 'defaultPoolSize' needs "this.". 113
 Warning coding RequireThis Reference to instance variable 'toUpperLowerPattern' needs "this.". 118
 Warning coding RequireThis Reference to instance variable 'defaultTimeLimit' needs "this.". 118
 Warning coding RequireThis Reference to instance variable 'defaultPoolSize' needs "this.". 118
 Warning coding RequireThis Reference to instance variable 'toLowerPlace' needs "this.". 123
 Warning coding RequireThis Reference to instance variable 'defaultTimeLimit' needs "this.". 123
 Warning coding RequireThis Reference to instance variable 'defaultPoolSize' needs "this.". 123
 Warning misc FinalParameters Parameter matcher should be final. 126
 Warning misc FinalParameters Parameter time should be final. 126
 Warning misc FinalParameters Parameter threshold should be final. 126
 Warning misc FinalParameters Parameter poolSize should be final. 126
 Warning coding FinalLocalVariable Variable 'rule' should be declared final. 127
 Warning coding RequireThis Reference to instance variable 'pool' needs "this.". 129
 Warning coding RequireThis Reference to instance variable 'pool' needs "this.". 130
 Warning coding RequireThis Reference to instance variable 'stats' needs "this.". 131
 Warning coding FinalLocalVariable Variable 'lowerStats' should be declared final. 136
 Warning coding RequireThis Reference to instance variable 'defaultTimeLimit' needs "this.". 137
 Warning coding RequireThis Reference to instance variable 'defaultTimeLimit' needs "this.". 138
 Warning coding RequireThis Reference to instance variable 'defaultTimeLimit' needs "this.". 139
 Warning coding FinalLocalVariable Variable 'upperStats' should be declared final. 141
 Warning coding RequireThis Reference to instance variable 'defaultTimeLimit' needs "this.". 142
 Warning coding RequireThis Reference to instance variable 'defaultTimeLimit' needs "this.". 143

emissary/core/sentinel/protocols/rules/AnyMaxTime.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter name should be final. 18
 Warning misc FinalParameters Parameter place should be final. 18
 Warning misc FinalParameters Parameter timeLimit should be final. 18
 Warning misc FinalParameters Parameter threshold should be final. 18
 Warning misc FinalParameters Parameter name should be final. 22
 Warning misc FinalParameters Parameter place should be final. 22
 Warning misc FinalParameters Parameter timeLimit should be final. 22
 Warning misc FinalParameters Parameter threshold should be final. 22
 Warning misc FinalParameters Parameter placeAgentStats should be final. 33
 Warning coding FinalLocalVariable Variable 'maxTimeInPlace' should be declared final. 34

emissary/core/sentinel/protocols/rules/AnyMaxTimeTest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'placeAgentStats' must be private and have accessor methods. 24
 Warning coding FinalLocalVariable Variable 'stats' should be declared final. 30
 Warning coding RequireThis Reference to instance variable 'placeAgentStats' needs "this.". 31
 Warning coding FinalLocalVariable Variable 'rule' should be declared final. 56
 Warning coding RequireThis Reference to instance variable 'placeAgentStats' needs "this.". 57
 Warning coding FinalLocalVariable Variable 'rule' should be declared final. 62
 Warning coding RequireThis Reference to instance variable 'placeAgentStats' needs "this.". 63
 Warning design VisibilityModifier Variable 'toUpperLowerPattern' must be private and have accessor methods. 69
 Warning design VisibilityModifier Variable 'toLowerPlace' must be private and have accessor methods. 70
 Warning design VisibilityModifier Variable 'toUpperPlace' must be private and have accessor methods. 71
 Warning design VisibilityModifier Variable 'defaultPoolSize' must be private and have accessor methods. 72
 Warning design VisibilityModifier Variable 'defaultTimeLimit' must be private and have accessor methods. 73
 Warning design VisibilityModifier Variable 'pool' must be private and have accessor methods. 75
 Warning design VisibilityModifier Variable 'stats' must be private and have accessor methods. 76
 Warning coding RequireThis Reference to instance variable 'pool' needs "this.". 82
 Warning coding RequireThis Reference to instance variable 'stats' needs "this.". 83
 Warning coding RequireThis Reference to instance variable 'toUpperLowerPattern' needs "this.". 88
 Warning coding RequireThis Reference to instance variable 'defaultTimeLimit' needs "this.". 88
 Warning coding RequireThis Reference to instance variable 'defaultPoolSize' needs "this.". 88
 Warning coding RequireThis Reference to instance variable 'toUpperLowerPattern' needs "this.". 93
 Warning coding RequireThis Reference to instance variable 'defaultTimeLimit' needs "this.". 93
 Warning coding RequireThis Reference to instance variable 'defaultPoolSize' needs "this.". 93
 Warning coding RequireThis Reference to instance variable 'toUpperLowerPattern' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'defaultTimeLimit' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'defaultPoolSize' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'toUpperLowerPattern' needs "this.". 103
 Warning coding RequireThis Reference to instance variable 'defaultTimeLimit' needs "this.". 103
 Warning coding RequireThis Reference to instance variable 'defaultPoolSize' needs "this.". 103
 Warning coding RequireThis Reference to instance variable 'toLowerPlace' needs "this.". 108
 Warning coding RequireThis Reference to instance variable 'defaultTimeLimit' needs "this.". 108
 Warning coding RequireThis Reference to instance variable 'defaultPoolSize' needs "this.". 108
 Warning coding RequireThis Reference to instance variable 'toLowerPlace' needs "this.". 113
 Warning coding RequireThis Reference to instance variable 'defaultTimeLimit' needs "this.". 113
 Warning coding RequireThis Reference to instance variable 'defaultPoolSize' needs "this.". 113
 Warning coding RequireThis Reference to instance variable 'toLowerPlace' needs "this.". 118
 Warning coding RequireThis Reference to instance variable 'defaultTimeLimit' needs "this.". 118
 Warning coding RequireThis Reference to instance variable 'defaultPoolSize' needs "this.". 118
 Warning coding RequireThis Reference to instance variable 'toUpperPlace' needs "this.". 123
 Warning coding RequireThis Reference to instance variable 'defaultTimeLimit' needs "this.". 123
 Warning coding RequireThis Reference to instance variable 'defaultPoolSize' needs "this.". 123
 Warning coding RequireThis Reference to instance variable 'toUpperPlace' needs "this.". 128
 Warning coding RequireThis Reference to instance variable 'defaultTimeLimit' needs "this.". 128
 Warning coding RequireThis Reference to instance variable 'defaultPoolSize' needs "this.". 128
 Warning misc FinalParameters Parameter matcher should be final. 131
 Warning misc FinalParameters Parameter time should be final. 131
 Warning misc FinalParameters Parameter threshold should be final. 131
 Warning misc FinalParameters Parameter poolSize should be final. 131
 Warning coding FinalLocalVariable Variable 'rule' should be declared final. 132
 Warning coding RequireThis Reference to instance variable 'pool' needs "this.". 134
 Warning coding RequireThis Reference to instance variable 'pool' needs "this.". 135
 Warning coding RequireThis Reference to instance variable 'stats' needs "this.". 136
 Warning coding FinalLocalVariable Variable 'lowerStats' should be declared final. 141
 Warning coding RequireThis Reference to instance variable 'defaultTimeLimit' needs "this.". 142
 Warning coding RequireThis Reference to instance variable 'defaultTimeLimit' needs "this.". 143
 Warning coding RequireThis Reference to instance variable 'defaultTimeLimit' needs "this.". 144
 Warning coding FinalLocalVariable Variable 'upperStats' should be declared final. 146
 Warning coding RequireThis Reference to instance variable 'defaultTimeLimit' needs "this.". 147
 Warning coding RequireThis Reference to instance variable 'defaultTimeLimit' needs "this.". 148

emissary/core/sentinel/protocols/rules/Rule.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'name' must be private and have accessor methods. 23
 Warning design VisibilityModifier Variable 'place' must be private and have accessor methods. 26
 Warning design VisibilityModifier Variable 'timeLimit' must be private and have accessor methods. 29
 Warning design VisibilityModifier Variable 'threshold' must be private and have accessor methods. 32
 Warning misc FinalParameters Parameter name should be final. 34
 Warning misc FinalParameters Parameter place should be final. 34
 Warning misc FinalParameters Parameter timeLimit should be final. 34
 Warning misc FinalParameters Parameter threshold should be final. 34
 Warning misc FinalParameters Parameter name should be final. 54
 Warning misc FinalParameters Parameter place should be final. 54
 Warning misc FinalParameters Parameter timeLimit should be final. 54
 Warning misc FinalParameters Parameter threshold should be final. 54
 Warning misc FinalParameters Parameter placeAgentStats should be final. 65
 Warning coding FinalLocalVariable Variable 'filtered' should be declared final. 66
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 67
 Warning misc FinalParameters Parameter placeAgentStats should be final. 77
 Warning coding FinalLocalVariable Variable 'count' should be declared final. 78
 Warning coding FinalLocalVariable Variable 'poolSize' should be declared final. 79
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 80
 Warning coding RequireThis Reference to instance variable 'threshold' needs "this.". 80
 Warning coding RequireThis Reference to instance variable 'name' needs "this.". 108
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 110
 Warning coding RequireThis Reference to instance variable 'timeLimit' needs "this.". 111
 Warning coding RequireThis Reference to instance variable 'threshold' needs "this.". 112

emissary/directory/DirectoryAdapter.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'pattern' must be private and have accessor methods. 24
 Warning blocks RightCurly '}' at column 32 should be alone on a line. 29

emissary/directory/DirectoryEntry.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'theKey' must be private and have accessor methods. 31
 Warning design VisibilityModifier Variable 'theCost' must be private and have accessor methods. 34
 Warning design VisibilityModifier Variable 'theQuality' must be private and have accessor methods. 37
 Warning design VisibilityModifier Variable 'theExpense' must be private and have accessor methods. 42
 Warning design VisibilityModifier Variable 'lookupAttempted' must be private and have accessor methods. 45
 Warning design VisibilityModifier Variable 'localPlace' must be private and have accessor methods. 49
 Warning design VisibilityModifier Variable 'dataType' must be private and have accessor methods. 52
 Warning design VisibilityModifier Variable 'dataId' must be private and have accessor methods. 55
 Warning design VisibilityModifier Variable 'serviceName' must be private and have accessor methods. 58
 Warning design VisibilityModifier Variable 'serviceType' must be private and have accessor methods. 61
 Warning design VisibilityModifier Variable 'serviceLocation' must be private and have accessor methods. 64
 Warning design VisibilityModifier Variable 'serviceHostUrl' must be private and have accessor methods. 67
 Warning design VisibilityModifier Variable 'description' must be private and have accessor methods. 74
 Warning design VisibilityModifier Variable 'age' must be private and have accessor methods. 77
 Warning coding HiddenField 'dataType' hides a field. 335
 Warning coding HiddenField 'serviceLocation' hides a field. 345
 Warning coding HiddenField 'serviceType' hides a field. 457
 Warning coding HiddenField 'serviceName' hides a field. 473
 Warning coding HiddenField 'age' hides a field. 554

emissary/directory/DirectoryEntryList.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'serviceList' should be declared final. 235

emissary/directory/DirectoryEntryListTest.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'dl' needs "this.". 94
 Warning coding RequireThis Reference to instance variable 'd' needs "this.". 94
 Warning coding RequireThis Reference to instance variable 'dl' needs "this.". 95
 Warning coding RequireThis Reference to instance variable 'd2' needs "this.". 95
 Warning coding RequireThis Reference to instance variable 'dl' needs "this.". 96
 Warning coding RequireThis Reference to instance variable 'd3' needs "this.". 96
 Warning coding RequireThis Reference to instance variable 'dl' needs "this.". 97
 Warning coding FinalLocalVariable Variable 'o' should be declared final. 98
 Warning coding RequireThis Reference to instance variable 'dl' needs "this.". 98
 Warning coding FinalLocalVariable Variable 'o2' should be declared final. 100
 Warning coding RequireThis Reference to instance variable 'dl' needs "this.". 100
 Warning coding FinalLocalVariable Variable 'o3' should be declared final. 103
 Warning coding RequireThis Reference to instance variable 'dl' needs "this.". 103

emissary/directory/DirectoryEntryMapTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 155
 Warning whitespace OperatorWrap '+' should be on a new line. 155
 Warning whitespace OperatorWrap '+' should be on a new line. 156
 Warning whitespace OperatorWrap '+' should be on a new line. 157
 Warning whitespace OperatorWrap '+' should be on a new line. 158
 Warning whitespace OperatorWrap '+' should be on a new line. 159
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 24, expected level should be one of the following: 18, 30, 31. 169

emissary/directory/DirectoryObserverManager.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'directoryKey' must be private and have accessor methods. 19
 Warning design VisibilityModifier Variable 'observers' must be private and have accessor methods. 22
 Warning coding MissingSwitchDefault switch without "default" clause. 234

emissary/directory/DirectoryPlace.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'entryMap' must be private and have accessor methods. 49
 Warning design VisibilityModifier Variable 'peerDirectories' must be private and have accessor methods. 52
 Warning design VisibilityModifier Variable 'staticPeers' must be private and have accessor methods. 57
 Warning design VisibilityModifier Variable 'heartbeat' must be private and have accessor methods. 60
 Warning design VisibilityModifier Variable 'observerManager' must be private and have accessor methods. 63
 Warning design VisibilityModifier Variable 'rdvPeer' must be private and have accessor methods. 66
 Warning design VisibilityModifier Variable 'shutdownInitiated' must be private and have accessor methods. 69
 Warning design VisibilityModifier Variable 'running' must be private and have accessor methods. 72
 Warning design VisibilityModifier Variable 'emissaryNode' must be private and have accessor methods. 75
 Warning design VisibilityModifier Variable 'zoneSlopWindowMillis' must be private and have accessor methods. 84
 Warning misc FinalParameters Parameter node should be final. 94
 Warning coding FinalLocalVariable Variable 'entries' should be declared final. 952
 Warning coding FinalLocalVariable Variable 'destination' should be declared final. 1105

emissary/directory/DirectoryPlaceTest.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'public' modifier. 150

emissary/directory/DirectoryXmlContainer.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 38 should be alone on a line. 168

emissary/directory/EmissaryNode.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'nodeName' must be private and have accessor methods. 72
 Warning design VisibilityModifier Variable 'nodePort' must be private and have accessor methods. 73
 Warning design VisibilityModifier Variable 'nodeScheme' must be private and have accessor methods. 75
 Warning design VisibilityModifier Variable 'nodeType' must be private and have accessor methods. 78
 Warning design VisibilityModifier Variable 'nodeMode' must be private and have accessor methods. 79
 Warning design VisibilityModifier Variable 'nodeNameIsDefault' must be private and have accessor methods. 80
 Warning design VisibilityModifier Variable 'nodeServiceType' must be private and have accessor methods. 82
 Warning design VisibilityModifier Variable 'strictStartupMode' must be private and have accessor methods. 84
 Warning misc FinalParameters Parameter nodeMode should be final. 94
 Warning coding RequireThis Reference to instance variable 'nodeMode' needs "this.". 116
 Warning coding RequireThis Reference to instance variable 'strictStartupMode' needs "this.". 183
 Warning misc FinalParameters Parameter strictStartupMode should be final. 186
 Warning coding HiddenField 'strictStartupMode' hides a field. 186
 Warning coding FinalLocalVariable Variable 'cfg' should be declared final. 212
 Warning coding FinalLocalVariable Variable 'pool' should be declared final. 253
 Warning coding FinalLocalVariable Variable 'spool' should be declared final. 257
 Warning coding FinalLocalVariable Variable 'metricsManager' should be declared final. 261
 Warning coding FinalLocalVariable Variable 'watcher' should be declared final. 265
 Warning coding FinalLocalVariable Variable 'nodeConfigStream' should be declared final. 276
 Warning coding FinalLocalVariable Variable 'startupEngine' should be declared final. 277

emissary/directory/HeartbeatManager.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'timer' must be private and have accessor methods. 40
 Warning design VisibilityModifier Variable 'thisDirectory' must be private and have accessor methods. 43
 Warning design VisibilityModifier Variable 'initialDelaySeconds' must be private and have accessor methods. 51
 Warning design VisibilityModifier Variable 'intervalSeconds' must be private and have accessor methods. 59
 Warning design VisibilityModifier Variable 'failThreshold' must be private and have accessor methods. 62
 Warning design VisibilityModifier Variable 'permanentFailThreshold' must be private and have accessor methods. 65
 Warning design VisibilityModifier Variable 'directories' must be private and have accessor methods. 74
 Warning coding FinalLocalVariable Variable 'response' should be declared final. 340
 Warning misc FinalParameters Parameter fromPlace should be final. 356
 Warning misc FinalParameters Parameter toPlace should be final. 356
 Warning misc FinalParameters Parameter fromPlace should be final. 360
 Warning misc FinalParameters Parameter toPlace should be final. 360
 Warning misc FinalParameters Parameter client should be final. 360
 Warning modifier RedundantModifier Redundant 'public' modifier. 389

emissary/directory/HeartbeatManagerTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'fromPlace' should be declared final. 33
 Warning coding FinalLocalVariable Variable 'toPlace' should be declared final. 34
 Warning coding FinalLocalVariable Variable 'response' should be declared final. 35
 Warning coding FinalLocalVariable Variable 'directoryKey' should be declared final. 41
 Warning coding FinalLocalVariable Variable 'mgr' should be declared final. 42
 Warning coding FinalLocalVariable Variable 'isUp' should be declared final. 43
 Warning coding FinalLocalVariable Variable 'mockClient' should be declared final. 51
 Warning coding FinalLocalVariable Variable 'client' should be declared final. 55
 Warning coding FinalLocalVariable Variable 'fromPlace' should be declared final. 57
 Warning coding FinalLocalVariable Variable 'toPlace' should be declared final. 58
 Warning coding FinalLocalVariable Variable 'response' should be declared final. 59
 Warning coding FinalLocalVariable Variable 'mockClient' should be declared final. 65
 Warning coding FinalLocalVariable Variable 'mockResponse' should be declared final. 66
 Warning coding FinalLocalVariable Variable 'mockHttpEntity' should be declared final. 67
 Warning coding FinalLocalVariable Variable 'responseString' should be declared final. 71
 Warning coding FinalLocalVariable Variable 'header1' should be declared final. 73
 Warning coding FinalLocalVariable Variable 'headers' should be declared final. 74
 Warning coding FinalLocalVariable Variable 'resp' should be declared final. 77
 Warning coding FinalLocalVariable Variable 'client' should be declared final. 80
 Warning coding FinalLocalVariable Variable 'fromPlace' should be declared final. 82
 Warning coding FinalLocalVariable Variable 'toPlace' should be declared final. 83
 Warning coding FinalLocalVariable Variable 'response' should be declared final. 84

emissary/directory/KeyManipulator.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 31 should be alone on a line. 422

emissary/directory/KeyManipulatorTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'expected' should be declared final. 138
 Warning coding FinalLocalVariable Variable 'actual' should be declared final. 139

emissary/directory/RoutingAlgorithmTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'deniedWildcardPlace' should be declared final. 378
 Warning coding FinalLocalVariable Variable 'expected' should be declared final. 383
 Warning coding FinalLocalVariable Variable 'deniedWildcardPlace' should be declared final. 397
 Warning modifier RedundantModifier Redundant 'public' modifier. 415

emissary/directory/WildcardEntry.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'dataType' must be private and have accessor methods. 43
 Warning design VisibilityModifier Variable 'serviceType' must be private and have accessor methods. 45
 Warning design VisibilityModifier Variable 'wc' must be private and have accessor methods. 47

emissary/id/IdPlace.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'finalForms' must be private and have accessor methods. 20
 Warning design VisibilityModifier Variable 'renames' must be private and have accessor methods. 23
 Warning design VisibilityModifier Variable 'ignores' must be private and have accessor methods. 26

emissary/id/IdPlaceTest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'place' must be private and have accessor methods. 20
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 24
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 30
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 31
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 36
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 37
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 42
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 45
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 52
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 56
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 63
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 67
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 74
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 78
 Warning modifier RedundantModifier Redundant 'public' modifier. 87
 Warning blocks RightCurly '}' at column 48 should be alone on a line. 87
 Warning misc FinalParameters Parameter payload should be final. 90
 Warning misc FinalParameters Parameter s should be final. 96

emissary/id/Identification.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'types' must be private and have accessor methods. 20
 Warning design VisibilityModifier Variable 'props' must be private and have accessor methods. 21
 Warning blocks RightCurly '}' at column 30 should be alone on a line. 26
 Warning misc FinalParameters Parameter s should be final. 168

emissary/id/SizeIdPlace.java

Severity Category Rule Message Line
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 12, expected level should be one of the following: 6, 42, 43. 14
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 12, expected level should be one of the following: 6, 42, 43. 15
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 12, expected level should be one of the following: 6, 42, 43. 16
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 12, expected level should be one of the following: 6, 42, 43. 17
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 12, expected level should be one of the following: 6, 42, 43. 18
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 12, expected level should be one of the following: 6, 42, 43. 19
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 12, expected level should be one of the following: 6, 42, 43. 20
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 12, expected level should be one of the following: 6, 46, 47. 24
 Warning design VisibilityModifier Variable 'setFileType' must be private and have accessor methods. 27
 Warning design VisibilityModifier Variable 'setCurrentForm' must be private and have accessor methods. 30
 Warning misc FinalParameters Parameter config should be final. 37
 Warning misc FinalParameters Parameter cfgInfo should be final. 52
 Warning misc FinalParameters Parameter dir should be final. 52
 Warning misc FinalParameters Parameter placeLoc should be final. 52
 Warning blocks RightCurly '}' at column 38 should be alone on a line. 60
 Warning misc FinalParameters Parameter payload should be final. 68
 Warning coding FinalLocalVariable Variable 'szType' should be declared final. 69
 Warning coding RequireThis Reference to instance variable 'setFileType' needs "this.". 70
 Warning coding RequireThis Reference to instance variable 'setCurrentForm' needs "this.". 73
 Warning misc FinalParameters Parameter sz should be final. 86

emissary/id/SizeIdPlaceTest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'place' must be private and have accessor methods. 17
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 23
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 30
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 35
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 40
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 45
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 50
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 53

emissary/id/UnixFilePlace.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'chop' must be private and have accessor methods. 23
 Warning design VisibilityModifier Variable 'replace' must be private and have accessor methods. 24
 Warning design VisibilityModifier Variable 'replaceFiletype' must be private and have accessor methods. 25
 Warning design VisibilityModifier Variable 'upcase' must be private and have accessor methods. 26
 Warning design VisibilityModifier Variable 'removeCommas' must be private and have accessor methods. 27
 Warning design VisibilityModifier Variable 'swallowIgnorableExceptions' must be private and have accessor methods. 28
 Warning design VisibilityModifier Variable 'chopAtTwo' must be private and have accessor methods. 29
 Warning design VisibilityModifier Variable 'minSizeMap' must be private and have accessor methods. 30
 Warning design VisibilityModifier Variable 'unixFileUtil' must be private and have accessor methods. 36
 Warning misc FinalParameters Parameter config should be final. 57
 Warning coding FinalLocalVariable Variable 'firstSubstring' should be declared final. 117
 Warning coding FinalLocalVariable Variable 'parts' should be declared final. 120
 Warning coding RequireThis Reference to instance variable 'replaceFiletype' needs "this.". 146

emissary/id/UnixFilePlaceTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'rr' should be declared final. 38
 Warning coding FinalLocalVariable Variable 'configG' should be declared final. 39
 Warning coding FinalLocalVariable Variable 'resource' should be declared final. 43
 Warning coding FinalLocalVariable Variable 'data' should be declared final. 46
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 47

emissary/id/WorkUnit.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'filename' must be private and have accessor methods. 14
 Warning design VisibilityModifier Variable 'data' must be private and have accessor methods. 15
 Warning design VisibilityModifier Variable 'header' must be private and have accessor methods. 16
 Warning design VisibilityModifier Variable 'footer' must be private and have accessor methods. 17
 Warning design VisibilityModifier Variable 'currentForm' must be private and have accessor methods. 18
 Warning design VisibilityModifier Variable 'params' must be private and have accessor methods. 19
 Warning blocks RightCurly '}' at column 24 should be alone on a line. 22

emissary/jni/JNI.java

Severity Category Rule Message Line
 Warning whitespace OperatorWrap '+' should be on a new line. 189
 Warning whitespace OperatorWrap '+' should be on a new line. 190
 Warning whitespace OperatorWrap '+' should be on a new line. 191
 Warning coding FinalLocalVariable Variable 'repositoryProxy' should be declared final. 395
 Warning coding FinalLocalVariable Variable 'repositoryProxy' should be declared final. 444

emissary/jni/JniRepositoryPlace.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'libraryDirectoryString' must be private and have accessor methods. 18
 Warning design VisibilityModifier Variable 'libraryDirectoryFile' must be private and have accessor methods. 19
 Warning blocks RightCurly '}' at column 63 should be alone on a line. 158

emissary/kff/ChecksumCalculator.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter alg should be final. 51
 Warning misc FinalParameters Parameter useCrc should be final. 51
 Warning misc FinalParameters Parameter algs should be final. 64
 Warning coding EqualsAvoidNull String literal expressions should be on the left side of an equals comparison. 67
 Warning coding EqualsAvoidNull String literal expressions should be on the left side of an equals comparison. 69
 Warning coding RequireThis Reference to instance variable 'digest' needs "this.". 72
 Warning misc FinalParameters Parameter algs should be final. 84
 Warning coding EqualsAvoidNull String literal expressions should be on the left side of an equals comparison. 87
 Warning coding EqualsAvoidNull String literal expressions should be on the left side of an equals comparison. 89
 Warning coding RequireThis Reference to instance variable 'digest' needs "this.". 92
 Warning coding RequireThis Reference to instance variable 'crc' needs "this.". 103
 Warning misc FinalParameters Parameter use should be final. 111
 Warning coding RequireThis Reference to instance variable 'crc' needs "this.". 113
 Warning coding RequireThis Reference to instance variable 'crc' needs "this.". 115
 Warning coding RequireThis Reference to instance variable 'ssdeep' needs "this.". 123
 Warning misc FinalParameters Parameter use should be final. 131
 Warning coding RequireThis Reference to instance variable 'ssdeep' needs "this.". 133
 Warning coding RequireThis Reference to instance variable 'ssdeep' needs "this.". 135
 Warning misc FinalParameters Parameter buffer should be final. 145
 Warning coding FinalLocalVariable Variable 'res' should be declared final. 147
 Warning coding RequireThis Reference to instance variable 'digest' needs "this.". 150
 Warning coding RequireThis Reference to instance variable 'crc' needs "this.". 157
 Warning coding RequireThis Reference to instance variable 'crc' needs "this.". 158
 Warning coding RequireThis Reference to instance variable 'crc' needs "this.". 159
 Warning coding RequireThis Reference to instance variable 'crc' needs "this.". 160
 Warning coding RequireThis Reference to instance variable 'ssdeep' needs "this.". 164
 Warning coding RequireThis Reference to instance variable 'ssdeep' needs "this.". 165
 Warning coding RequireThis Reference to instance variable 'digest' needs "this.". 181
 Warning coding RequireThis Reference to instance variable 'crc' needs "this.". 196
 Warning coding RequireThis Reference to instance variable 'crc' needs "this.". 198
 Warning coding RequireThis Reference to instance variable 'crc' needs "this.". 202
 Warning coding RequireThis Reference to instance variable 'crc' needs "this.". 205
 Warning coding RequireThis Reference to instance variable 'ssdeep' needs "this.". 211
 Warning coding RequireThis Reference to instance variable 'ssdeep' needs "this.". 212

emissary/kff/ChecksumCalculatorTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'cc' should be declared final. 37
 Warning coding FinalLocalVariable Variable 'cr' should be declared final. 38
 Warning coding FinalLocalVariable Variable 'algs' should be declared final. 40
 Warning coding FinalLocalVariable Variable 'cc' should be declared final. 54
 Warning coding FinalLocalVariable Variable 'cr' should be declared final. 55
 Warning coding FinalLocalVariable Variable 'algs' should be declared final. 57
 Warning coding FinalLocalVariable Variable 'cc' should be declared final. 73
 Warning coding FinalLocalVariable Variable 'cr' should be declared final. 74
 Warning coding FinalLocalVariable Variable 'algs' should be declared final. 76
 Warning coding FinalLocalVariable Variable 'cc' should be declared final. 91
 Warning coding FinalLocalVariable Variable 'cr' should be declared final. 92
 Warning coding FinalLocalVariable Variable 'algs' should be declared final. 94
 Warning coding FinalLocalVariable Variable 'cc' should be declared final. 110
 Warning coding FinalLocalVariable Variable 'cr' should be declared final. 111
 Warning coding FinalLocalVariable Variable 'algs' should be declared final. 113
 Warning coding FinalLocalVariable Variable 'i' should be declared final. 116
 Warning coding FinalLocalVariable Variable 'cc' should be declared final. 130
 Warning coding FinalLocalVariable Variable 'cr' should be declared final. 133
 Warning coding FinalLocalVariable Variable 'algs' should be declared final. 135
 Warning coding FinalLocalVariable Variable 'i' should be declared final. 138

emissary/kff/ChecksumResults.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'hashComp' must be private and have accessor methods. 23
 Warning misc FinalParameters Parameter argCrc should be final. 40
 Warning misc FinalParameters Parameter ssdeep should be final. 59
 Warning coding HiddenField 'ssdeep' hides a field. 59
 Warning misc FinalParameters Parameter alg should be final. 69
 Warning coding RequireThis Reference to instance variable 'crc' needs "this.". 70
 Warning coding RequireThis Reference to instance variable 'crc' needs "this.". 71
 Warning coding RequireThis Reference to instance variable 'ssdeep' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'ssdeep' needs "this.". 74
 Warning coding RequireThis Reference to instance variable 'hashComp' needs "this.". 76
 Warning misc FinalParameters Parameter alg should be final. 86
 Warning coding FinalLocalVariable Variable 'comp' should be declared final. 87
 Warning coding RequireThis Reference to instance variable 'hashComp' needs "this.". 87
 Warning coding RequireThis Reference to instance variable 'crc' needs "this.". 89
 Warning coding RequireThis Reference to instance variable 'crc' needs "this.". 90
 Warning coding RequireThis Reference to instance variable 'ssdeep' needs "this.". 92
 Warning coding RequireThis Reference to instance variable 'ssdeep' needs "this.". 93
 Warning misc FinalParameters Parameter alg should be final. 107
 Warning misc FinalParameters Parameter argHash should be final. 107
 Warning coding RequireThis Reference to instance variable 'hashComp' needs "this.". 108
 Warning coding FinalLocalVariable Variable 'set' should be declared final. 117
 Warning coding RequireThis Reference to instance variable 'hashComp' needs "this.". 117
 Warning coding RequireThis Reference to instance variable 'crc' needs "this.". 118
 Warning coding RequireThis Reference to instance variable 'ssdeep' needs "this.". 121

emissary/kff/ChecksumResultsTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'cc' should be declared final. 22
 Warning coding FinalLocalVariable Variable 'cr' should be declared final. 23
 Warning coding FinalLocalVariable Variable 'algs' should be declared final. 25
 Warning coding FinalLocalVariable Variable 'i' should be declared final. 28

emissary/kff/EditDistance.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter x should be final. 60
 Warning misc FinalParameters Parameter y should be final. 60
 Warning coding FinalLocalVariable Variable 'iswap' should be declared final. 61
 Warning misc FinalParameters Parameter x should be final. 67
 Warning misc FinalParameters Parameter y should be final. 67
 Warning coding FinalLocalVariable Variable 'cswap' should be declared final. 68
 Warning misc FinalParameters Parameter x should be final. 75
 Warning misc FinalParameters Parameter y should be final. 75
 Warning misc FinalParameters Parameter z should be final. 75
 Warning coding FinalLocalVariable Variable 'mx' should be declared final. 76
 Warning coding FinalLocalVariable Variable 'my' should be declared final. 77
 Warning coding FinalLocalVariable Variable 'mz' should be declared final. 78
 Warning misc FinalParameters Parameter x should be final. 83
 Warning misc FinalParameters Parameter y should be final. 83
 Warning coding FinalLocalVariable Variable 'mx' should be declared final. 84
 Warning coding FinalLocalVariable Variable 'my' should be declared final. 85
 Warning design VisibilityModifier Variable 'insertCost' must be private and have accessor methods. 89
 Warning design VisibilityModifier Variable 'deleteCost' must be private and have accessor methods. 90
 Warning design VisibilityModifier Variable 'row' must be private and have accessor methods. 93
 Warning design VisibilityModifier Variable 'col' must be private and have accessor methods. 94
 Warning design VisibilityModifier Variable 'index' must be private and have accessor methods. 95
 Warning design VisibilityModifier Variable 'radix' must be private and have accessor methods. 96
 Warning design VisibilityModifier Variable 'low' must be private and have accessor methods. 97
 Warning design VisibilityModifier Variable 'buffer' must be private and have accessor methods. 98
 Warning design VisibilityModifier Variable 'store' must be private and have accessor methods. 102
 Warning design VisibilityModifier Variable 'ins' must be private and have accessor methods. 109
 Warning design VisibilityModifier Variable 'del' must be private and have accessor methods. 110
 Warning design VisibilityModifier Variable 'ch' must be private and have accessor methods. 111
 Warning design VisibilityModifier Variable 'swapCost' must be private and have accessor methods. 112
 Warning design VisibilityModifier Variable 'fromLen' must be private and have accessor methods. 114
 Warning design VisibilityModifier Variable 'toLen' must be private and have accessor methods. 115
 Warning misc FinalParameters Parameter x should be final. 117
 Warning misc FinalParameters Parameter y should be final. 117
 Warning misc FinalParameters Parameter index should be final. 117
 Warning coding HiddenField 'index' hides a field. 117
 Warning misc FinalParameters Parameter x should be final. 121
 Warning misc FinalParameters Parameter y should be final. 121
 Warning naming MethodName Method name 'n' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9_]*$'. 125
 Warning misc FinalParameters Parameter x should be final. 125
 Warning misc FinalParameters Parameter y should be final. 125
 Warning naming MethodName Method name 'w' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9_]*$'. 129
 Warning misc FinalParameters Parameter x should be final. 129
 Warning misc FinalParameters Parameter y should be final. 129
 Warning misc FinalParameters Parameter x should be final. 133
 Warning misc FinalParameters Parameter y should be final. 133
 Warning misc FinalParameters Parameter x should be final. 137
 Warning misc FinalParameters Parameter from should be final. 144
 Warning misc FinalParameters Parameter fromLen should be final. 144
 Warning coding HiddenField 'fromLen' hides a field. 144
 Warning misc FinalParameters Parameter to should be final. 144
 Warning misc FinalParameters Parameter toLen should be final. 144
 Warning coding HiddenField 'toLen' hides a field. 144
 Warning coding FinalLocalVariable Variable 'x' should be declared final. 165
 Warning coding FinalLocalVariable Variable 'y' should be declared final. 166
 Warning coding FinalLocalVariable Variable 'xx' should be declared final. 170
 Warning coding FinalLocalVariable Variable 'yy' should be declared final. 171
 Warning blocks RightCurly '}' at column 29 should be alone on a line. 250

emissary/kff/KffChain.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'list' must be private and have accessor methods. 23
 Warning design VisibilityModifier Variable 'kffMinDataSize' must be private and have accessor methods. 27
 Warning design VisibilityModifier Variable 'algorithms' must be private and have accessor methods. 30
 Warning blocks RightCurly '}' at column 24 should be alone on a line. 35
 Warning misc FinalParameters Parameter f should be final. 40
 Warning coding RequireThis Reference to instance variable 'list' needs "this.". 42
 Warning coding RequireThis Reference to instance variable 'list' needs "this.". 50
 Warning misc FinalParameters Parameter i should be final. 58
 Warning coding ParameterAssignment Assignment of parameter 'i' is not allowed. 60
 Warning coding RequireThis Reference to instance variable 'kffMinDataSize' needs "this.". 62
 Warning misc FinalParameters Parameter c should be final. 71
 Warning coding RequireThis Reference to instance variable 'algorithms' needs "this.". 72
 Warning misc FinalParameters Parameter c should be final. 81
 Warning coding RequireThis Reference to instance variable 'algorithms' needs "this.". 82
 Warning coding RequireThis Reference to instance variable 'algorithms' needs "this.". 83
 Warning misc FinalParameters Parameter alg should be final. 92
 Warning coding RequireThis Reference to instance variable 'algorithms' needs "this.". 93
 Warning misc FinalParameters Parameter alg should be final. 102
 Warning coding RequireThis Reference to instance variable 'algorithms' needs "this.". 103
 Warning coding FinalLocalVariable Variable 'list' should be declared final. 113
 Warning coding HiddenField 'list' hides a field. 113
 Warning coding RequireThis Reference to instance variable 'algorithms' needs "this.". 113
 Warning coding RequireThis Reference to instance variable 'kffMinDataSize' needs "this.". 126
 Warning coding RequireThis Reference to instance variable 'list' needs "this.". 126
 Warning coding RequireThis Reference to instance variable 'list' needs "this.". 135
 Warning coding RequireThis Reference to instance variable 'kffMinDataSize' needs "this.". 160
 Warning coding RequireThis Reference to instance variable 'list' needs "this.". 160
 Warning coding RequireThis Reference to instance variable 'list' needs "this.". 169
 Warning misc FinalParameters Parameter l should be final. 187
 Warning misc FinalParameters Parameter itemName should be final. 187
 Warning misc FinalParameters Parameter csum should be final. 187
 Warning coding FinalLocalVariable Variable 'r' should be declared final. 188
 Warning coding FinalLocalVariable Variable 'hit' should be declared final. 192
 Warning misc FinalParameters Parameter fileContents should be final. 208
 Warning coding RequireThis Reference to instance variable 'algorithms' needs "this.". 209
 Warning coding RequireThis Reference to instance variable 'algorithms' needs "this.". 220

emissary/kff/KffChainLoader.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 31 should be alone on a line. 41
 Warning coding FinalLocalVariable Variable 'chain' should be declared final. 48
 Warning coding FinalLocalVariable Variable 'configG' should be declared final. 50
 Warning coding FinalLocalVariable Variable 'algs' should be declared final. 56
 Warning misc FinalParameters Parameter chain should be final. 76
 Warning misc FinalParameters Parameter m should be final. 76
 Warning misc FinalParameters Parameter filterType should be final. 76
 Warning coding FinalLocalVariable Variable 'key' should be declared final. 81
 Warning coding FinalLocalVariable Variable 'name' should be declared final. 82
 Warning coding FinalLocalVariable Variable 'clazz' should be declared final. 84
 Warning misc FinalParameters Parameter args should be final. 112
 Warning coding FinalLocalVariable Variable 'kff' should be declared final. 113
 Warning coding FinalLocalVariable Variable 'buffer' should be declared final. 117
 Warning coding FinalLocalVariable Variable 'r' should be declared final. 119

emissary/kff/KffChainTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'chain' should be declared final. 23
 Warning coding FinalLocalVariable Variable 'cr' should be declared final. 31
 Warning coding FinalLocalVariable Variable 'algs' should be declared final. 32
 Warning coding FinalLocalVariable Variable 'i' should be declared final. 35
 Warning coding VariableDeclarationUsageDistance Distance between variable 'chain' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 46
 Warning coding FinalLocalVariable Variable 'chain' should be declared final. 46
 Warning coding FinalLocalVariable Variable 'myAlgs' should be declared final. 47
 Warning coding FinalLocalVariable Variable 'cr' should be declared final. 54
 Warning coding FinalLocalVariable Variable 'algs' should be declared final. 55
 Warning coding FinalLocalVariable Variable 'i' should be declared final. 58
 Warning coding VariableDeclarationUsageDistance Distance between variable 'chain' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 69
 Warning coding FinalLocalVariable Variable 'chain' should be declared final. 69
 Warning coding FinalLocalVariable Variable 'myAlgs' should be declared final. 70
 Warning coding FinalLocalVariable Variable 'kr' should be declared final. 79
 Warning coding FinalLocalVariable Variable 'algs' should be declared final. 80
 Warning coding FinalLocalVariable Variable 'i' should be declared final. 83
 Warning coding FinalLocalVariable Variable 'md5c' should be declared final. 92
 Warning coding FinalLocalVariable Variable 'md5r' should be declared final. 93

emissary/kff/KffDataObjectHandler.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'kff' must be private and have accessor methods. 40
 Warning design VisibilityModifier Variable 'truncateKnownData' must be private and have accessor methods. 46
 Warning design VisibilityModifier Variable 'setFormOnKnownData' must be private and have accessor methods. 47
 Warning design VisibilityModifier Variable 'setFileTypeOnKnown' must be private and have accessor methods. 48
 Warning blocks RightCurly '}' at column 36 should be alone on a line. 63
 Warning misc FinalParameters Parameter truncateKnownData should be final. 68
 Warning misc FinalParameters Parameter setFormOnKnownData should be final. 68
 Warning misc FinalParameters Parameter setFileTypeOnKnown should be final. 68
 Warning misc FinalParameters Parameter data should be final. 82
 Warning misc FinalParameters Parameter name should be final. 82
 Warning misc FinalParameters Parameter data should be final. 95
 Warning misc FinalParameters Parameter name should be final. 95
 Warning misc FinalParameters Parameter prefix should be final. 95
 Warning coding ParameterAssignment Assignment of parameter 'prefix' is not allowed. 98
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 104
 Warning misc FinalParameters Parameter prefix should be final. 134
 Warning coding ParameterAssignment Assignment of parameter 'prefix' is not allowed. 137
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 144
 Warning misc FinalParameters Parameter result should be final. 154
 Warning misc FinalParameters Parameter prefix should be final. 154
 Warning coding FinalLocalVariable Variable 'results' should be declared final. 155
 Warning coding FinalLocalVariable Variable 'originalMD5' should be declared final. 196
 Warning coding RequireThis Reference to instance variable 'setFileTypeOnKnown' needs "this.". 219
 Warning coding RequireThis Reference to instance variable 'setFormOnKnownData' needs "this.". 222
 Warning coding RequireThis Reference to instance variable 'truncateKnownData' needs "this.". 225
 Warning misc FinalParameters Parameter d should be final. 240
 Warning coding FinalLocalVariable Variable 'paramValue' should be declared final. 247
 Warning coding FinalLocalVariable Variable 'originalMD5' should be declared final. 249
 Warning misc FinalParameters Parameter d should be final. 264
 Warning misc FinalParameters Parameter originalMD5 should be final. 264
 Warning coding FinalLocalVariable Variable 'paramValue' should be declared final. 266
 Warning coding FinalLocalVariable Variable 'currentMD5' should be declared final. 268
 Warning misc FinalParameters Parameter d should be final. 280
 Warning coding FinalLocalVariable Variable 'parentDupe' should be declared final. 281
 Warning misc FinalParameters Parameter d should be final. 293
 Warning misc FinalParameters Parameter d should be final. 303
 Warning misc FinalParameters Parameter d should be final. 318
 Warning misc FinalParameters Parameter d should be final. 328
 Warning misc FinalParameters Parameter hash should be final. 328
 Warning coding FinalLocalVariable Variable 'hl' should be declared final. 329
 Warning misc FinalParameters Parameter d should be final. 362
 Warning misc FinalParameters Parameter d should be final. 372
 Warning misc FinalParameters Parameter hash should be final. 372
 Warning misc FinalParameters Parameter d should be final. 381
 Warning misc FinalParameters Parameter d should be final. 391
 Warning misc FinalParameters Parameter hash should be final. 391
 Warning misc FinalParameters Parameter d should be final. 400
 Warning misc FinalParameters Parameter d should be final. 410
 Warning misc FinalParameters Parameter hash should be final. 410
 Warning misc FinalParameters Parameter d should be final. 419
 Warning misc FinalParameters Parameter d should be final. 429
 Warning misc FinalParameters Parameter hash should be final. 429
 Warning misc FinalParameters Parameter d should be final. 438
 Warning misc FinalParameters Parameter d should be final. 448
 Warning misc FinalParameters Parameter hash should be final. 448
 Warning misc FinalParameters Parameter d should be final. 457
 Warning misc FinalParameters Parameter d should be final. 467
 Warning misc FinalParameters Parameter hash should be final. 467
 Warning misc FinalParameters Parameter d should be final. 477

emissary/kff/KffDataObjectHandlerTest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'kff' must be private and have accessor methods. 59
 Warning design VisibilityModifier Variable 'payload' must be private and have accessor methods. 61
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 67
 Warning coding FinalLocalVariable Variable 'data' should be declared final. 69
 Warning coding FinalLocalVariable Variable 'defaultCurrentForm' should be declared final. 70
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 71
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 81
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 82
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 87
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 92
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 103
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 109
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 114
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 120
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 121
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 122
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 122
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 123
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 124
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 125
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 126
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 127
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 128
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 129
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 130
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 131
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 132
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 133
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 134
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 135
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 136
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 137
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 138
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 139
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 140
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 141
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 142
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 143
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 149
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 150
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 151
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 151
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 153
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 155
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 157
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 163
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 163
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 164
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 165
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 166
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 167
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 168
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 169
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 170
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 171
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 172
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 173
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 174
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 175
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 176
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 177
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 178
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 179
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 180
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 181
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 182
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 183
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 184
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 186
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 188
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 195
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 196
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 197
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 197
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 199
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 200
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 201
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 202
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 203
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 204
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 205
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 206
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 207
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 208
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 209
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 210
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 211
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 212
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 213
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 214
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 215
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 216
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 217
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 218
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 220
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 222
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 225
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 229
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 229
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 230
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 231
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 232
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 233
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 234
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 235
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 236
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 237
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 238
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 239
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 240
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 241
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 242
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 243
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 244
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 245
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 246
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 247
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 248
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 249
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 250
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 251
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 252
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 253
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 254
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 255
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 256
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 257
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 258
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 259
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 260
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 261
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 262
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 263
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 264
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 267
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 269
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 271
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 273
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 274
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 275
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 280
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 280
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 281
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 282
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 283
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 284
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 289
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 290
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 291
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 292
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 293
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 294
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 295
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 296
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 297
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 298
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 299
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 300
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 302
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 303
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 304
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 309
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 310
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 311
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 312
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 312
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 313
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 314
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 315
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 316
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 317
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 318
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 319
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 320
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 321
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 322
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 323
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 324
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 325
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 326
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 327
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 328
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 329
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 330
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 331
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 332
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 333
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 338
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 339
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 340
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 341
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 341
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 342
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 343
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 344
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 345
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 346
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 347
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 348
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 349
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 350
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 351
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 352
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 353
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 354
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 355
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 356
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 357
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 358
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 359
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 360
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 361
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 362
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 363
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 368
 Warning misc FinalParameters Parameter byteBuffer should be final. 380
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 390
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 391
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 391
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 392
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 393
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 394
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 395
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 396
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 397
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 398
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 399
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 400
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 401
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 402
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 403
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 404
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 405
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 406
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 407
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 408
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 409
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 410
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 411
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 413
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 414
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 415
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 415
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 416
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 417
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 418
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 419
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 420
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 421
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 422
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 423
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 424
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 425
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 426
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 427
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 428
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 429
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 430
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 431
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 432
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 433
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 434
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 435
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 441
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 446

emissary/kff/KffFile.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'knownFile' must be private and have accessor methods. 32
 Warning design VisibilityModifier Variable 'mappedBuf' must be private and have accessor methods. 35
 Warning design VisibilityModifier Variable 'recordLength' must be private and have accessor methods. 41
 Warning design VisibilityModifier Variable 'filterName' must be private and have accessor methods. 44
 Warning design VisibilityModifier Variable 'ftype' must be private and have accessor methods. 46
 Warning design VisibilityModifier Variable 'myPreferredAlgorithm' must be private and have accessor methods. 48
 Warning design VisibilityModifier Variable 'reentrantLock' must be private and have accessor methods. 50
 Warning misc FinalParameters Parameter filename should be final. 61
 Warning misc FinalParameters Parameter filterName should be final. 61
 Warning misc FinalParameters Parameter ftype should be final. 61
 Warning misc FinalParameters Parameter filename should be final. 76
 Warning misc FinalParameters Parameter filterName should be final. 76
 Warning misc FinalParameters Parameter ftype should be final. 76
 Warning misc FinalParameters Parameter recordLength should be final. 76
 Warning coding RequireThis Reference to instance variable 'knownFile' needs "this.". 82
 Warning coding RequireThis Reference to instance variable 'bSearchInitHigh' needs "this.". 85
 Warning coding RequireThis Reference to instance variable 'knownFile' needs "this.". 85
 Warning coding RequireThis Reference to instance variable 'bSearchInitHigh' needs "this.". 87
 Warning coding RequireThis Reference to instance variable 'filterName' needs "this.". 95
 Warning coding RequireThis Reference to instance variable 'ftype' needs "this.". 104
 Warning misc FinalParameters Parameter f should be final. 112
 Warning coding RequireThis Reference to instance variable 'ftype' needs "this.". 113
 Warning misc FinalParameters Parameter alg should be final. 121
 Warning coding RequireThis Reference to instance variable 'myPreferredAlgorithm' needs "this.". 122
 Warning coding RequireThis Reference to instance variable 'myPreferredAlgorithm' needs "this.". 129
 Warning misc FinalParameters Parameter hash should be final. 139
 Warning misc FinalParameters Parameter crc should be final. 139
 Warning coding RequireThis Reference to instance variable 'bSearchInitHigh' needs "this.". 143
 Warning coding FinalLocalVariable Variable 'rec' should be declared final. 146
 Warning coding RequireThis Reference to instance variable 'recordLength' needs "this.". 146
 Warning coding RequireThis Reference to instance variable 'reentrantLock' needs "this.". 148
 Warning coding FinalLocalVariable Variable 'mid' should be declared final. 153
 Warning coding RequireThis Reference to instance variable 'knownFile' needs "this.". 156
 Warning coding RequireThis Reference to instance variable 'recordLength' needs "this.". 156
 Warning coding RequireThis Reference to instance variable 'knownFile' needs "this.". 157
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 160
 Warning coding RequireThis Reference to instance variable 'reentrantLock' needs "this.". 175
 Warning coding RequireThis Reference to instance variable 'reentrantLock' needs "this.". 176
 Warning misc FinalParameters Parameter record should be final. 191
 Warning misc FinalParameters Parameter hash should be final. 191
 Warning misc FinalParameters Parameter crc should be final. 191
 Warning coding FinalLocalVariable Variable 'ihash' should be declared final. 197
 Warning coding FinalLocalVariable Variable 'irec' should be declared final. 198
 Warning coding FinalLocalVariable Variable 'icrc' should be declared final. 209
 Warning coding FinalLocalVariable Variable 'irec' should be declared final. 210
 Warning misc FinalParameters Parameter fname should be final. 222
 Warning misc FinalParameters Parameter csum should be final. 222
 Warning coding FinalLocalVariable Variable 'hash' should be declared final. 223
 Warning coding RequireThis Reference to instance variable 'myPreferredAlgorithm' needs "this.". 223
 Warning coding RequireThis Reference to instance variable 'myPreferredAlgorithm' needs "this.". 225

emissary/kff/KffFileTest.java

Severity Category Rule Message Line
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 12, expected level should be one of the following: 6, 53, 54. 44
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 12, expected level should be one of the following: 6, 53, 54. 45
 Warning design VisibilityModifier Variable 'channelFactory' must be private and have accessor methods. 52
 Warning coding FinalLocalVariable Variable 'incorrectSha1Bytes' should be declared final. 79
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 16, expected level should be one of the following: 10, 37, 38. 80
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 16, expected level should be one of the following: 10, 37, 38. 81
 Warning coding FinalLocalVariable Variable 'EXPECTED_FAILURE_COUNT' should be declared final. 96
 Warning coding FinalLocalVariable Variable 'testInputs' should be declared final. 99
 Warning coding FinalLocalVariable Variable 'numberOfKffEntriesInTestFile' should be declared final. 103
 Warning coding FinalLocalVariable Variable 'callables' should be declared final. 110
 Warning coding FinalLocalVariable Variable 'results' should be declared final. 118
 Warning misc FinalParameters Parameter testInputs should be final. 129
 Warning misc FinalParameters Parameter recordCount should be final. 129
 Warning coding FinalLocalVariable Variable 'csr' should be declared final. 133
 Warning coding FinalLocalVariable Variable 'expectedFailure' should be declared final. 134
 Warning misc FinalParameters Parameter testInputs should be final. 139
 Warning coding FinalLocalVariable Variable 'numberOfKffEntriesInTestFile' should be declared final. 140
 Warning coding RequireThis Reference to instance variable 'channelFactory' needs "this.". 142
 Warning coding FinalLocalVariable Variable 'csr' should be declared final. 147
 Warning coding FinalLocalVariable Variable 'expectedSuccess' should be declared final. 148
 Warning misc FinalParameters Parameter testInputs should be final. 159
 Warning misc FinalParameters Parameter sbc should be final. 171
 Warning misc FinalParameters Parameter startPosition should be final. 171
 Warning coding FinalLocalVariable Variable 'buffer' should be declared final. 173
 Warning coding FinalLocalVariable Variable 'randomBytes' should be declared final. 186
 Warning misc FinalParameters Parameter recordBytes should be final. 198
 Warning coding FinalLocalVariable Variable 'sha1Bytes' should be declared final. 201
 Warning coding FinalLocalVariable Variable 'crc32Bytes' should be declared final. 202
 Warning coding FinalLocalVariable Variable 'csr' should be declared final. 203
 Warning misc FinalParameters Parameter recordBytes should be final. 215
 Warning misc FinalParameters Parameter recordBytes should be final. 227
 Warning coding FinalLocalVariable Variable 'result' should be declared final. 230
 Warning misc FinalParameters Parameter testInputs should be final. 241
 Warning misc FinalParameters Parameter kffFile should be final. 254
 Warning misc FinalParameters Parameter csr should be final. 254
 Warning misc FinalParameters Parameter expectedResult should be final. 254
 Warning coding FinalLocalVariable Variable 'actual' should be declared final. 268
 Warning coding RequireThis Reference to instance variable 'kffFile' needs "this.". 268
 Warning coding RequireThis Reference to instance variable 'csr' needs "this.". 268
 Warning coding RequireThis Reference to instance variable 'expectedResult' needs "this.". 270
 Warning coding RequireThis Reference to instance variable 'expectedResult' needs "this.". 271
 Warning design VisibilityModifier Variable 'csr' must be private and have accessor methods. 280
 Warning design VisibilityModifier Variable 'expectedResult' must be private and have accessor methods. 281
 Warning misc FinalParameters Parameter csr should be final. 283
 Warning misc FinalParameters Parameter expectedResult should be final. 283

emissary/kff/KffMemcached.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'preferredAlgorithm' must be private and have accessor methods. 54
 Warning design VisibilityModifier Variable 'filterName' must be private and have accessor methods. 59
 Warning design VisibilityModifier Variable 'ftype' must be private and have accessor methods. 64
 Warning design VisibilityModifier Variable 'ageoff' must be private and have accessor methods. 69
 Warning design VisibilityModifier Variable 'opTimeoutMillis' must be private and have accessor methods. 74
 Warning design VisibilityModifier Variable 'failMode' must be private and have accessor methods. 79
 Warning design VisibilityModifier Variable 'ignorePatterns' must be private and have accessor methods. 85
 Warning design VisibilityModifier Variable 'storeIdDupe' must be private and have accessor methods. 92
 Warning design VisibilityModifier Variable 'useBinaryProtocol' must be private and have accessor methods. 97
 Warning design VisibilityModifier Variable 'client' must be private and have accessor methods. 102
 Warning misc FinalParameters Parameter filename should be final. 111
 Warning misc FinalParameters Parameter filterName should be final. 111
 Warning misc FinalParameters Parameter ftype should be final. 111
 Warning misc FinalParameters Parameter testIdWithSpaces should be final. 124
 Warning misc FinalParameters Parameter filterName should be final. 124
 Warning misc FinalParameters Parameter duplicate should be final. 124
 Warning misc FinalParameters Parameter testClient should be final. 124
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 126
 Warning coding FinalLocalVariable Variable 'configG' should be declared final. 134
 Warning coding FinalLocalVariable Variable 'serversFromConfig' should be declared final. 137
 Warning coding FinalLocalVariable Variable 'servers' should be declared final. 138
 Warning coding FinalLocalVariable Variable 'serverTokens' should be declared final. 142
 Warning coding FinalLocalVariable Variable 'host' should be declared final. 143
 Warning coding FinalLocalVariable Variable 'port' should be declared final. 144
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 152
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 154
 Warning coding RequireThis Reference to instance variable 'ageoff' needs "this.". 158
 Warning coding RequireThis Reference to instance variable 'preferredAlgorithm' needs "this.". 161
 Warning coding RequireThis Reference to instance variable 'ignorePatterns' needs "this.". 164
 Warning coding RequireThis Reference to instance variable 'storeIdDupe' needs "this.". 167
 Warning coding RequireThis Reference to instance variable 'useBinaryProtocol' needs "this.". 170
 Warning coding RequireThis Reference to instance variable 'useBinaryProtocol' needs "this.". 170
 Warning coding RequireThis Reference to instance variable 'opTimeoutMillis' needs "this.". 173
 Warning coding RequireThis Reference to instance variable 'opTimeoutMillis' needs "this.". 173
 Warning coding FinalLocalVariable Variable 'failModeAsString' should be declared final. 175
 Warning coding EqualsAvoidNull String literal expressions should be on the left side of an equalsIgnoreCase comparison. 176
 Warning coding RequireThis Reference to instance variable 'failMode' needs "this.". 177
 Warning coding EqualsAvoidNull String literal expressions should be on the left side of an equalsIgnoreCase comparison. 178
 Warning coding RequireThis Reference to instance variable 'failMode' needs "this.". 179
 Warning coding FinalLocalVariable Variable 'cfb' should be declared final. 184
 Warning coding RequireThis Reference to instance variable 'failMode' needs "this.". 186
 Warning coding RequireThis Reference to instance variable 'opTimeoutMillis' needs "this.". 188
 Warning coding RequireThis Reference to instance variable 'useBinaryProtocol' needs "this.". 190
 Warning coding RequireThis Reference to instance variable 'client' needs "this.". 195
 Warning coding RequireThis Reference to instance variable 'client' needs "this.". 197
 Warning misc FinalParameters Parameter id should be final. 209
 Warning misc FinalParameters Parameter sums should be final. 209
 Warning coding RequireThis Reference to instance variable 'ignorePatterns' needs "this.". 220
 Warning coding RequireThis Reference to instance variable 'ignorePatterns' needs "this.". 222
 Warning coding FinalLocalVariable Variable 'hash' should be declared final. 229
 Warning coding RequireThis Reference to instance variable 'preferredAlgorithm' needs "this.". 229
 Warning coding FinalLocalVariable Variable 'key' should be declared final. 235
 Warning coding FinalLocalVariable Variable 'future' should be declared final. 238
 Warning coding RequireThis Reference to instance variable 'client' needs "this.". 238
 Warning coding FinalLocalVariable Variable 'result' should be declared final. 242
 Warning coding RequireThis Reference to instance variable 'opTimeoutMillis' needs "this.". 242
 Warning coding RequireThis Reference to instance variable 'storeIdDupe' needs "this.". 245
 Warning coding FinalLocalVariable Variable 'unused' should be declared final. 249
 Warning coding RequireThis Reference to instance variable 'client' needs "this.". 249
 Warning coding RequireThis Reference to instance variable 'ageoff' needs "this.". 249
 Warning coding FinalLocalVariable Variable 'unused' should be declared final. 259
 Warning coding RequireThis Reference to instance variable 'client' needs "this.". 259
 Warning coding RequireThis Reference to instance variable 'ageoff' needs "this.". 259
 Warning coding RequireThis Reference to instance variable 'preferredAlgorithm' needs "this.". 266
 Warning misc FinalParameters Parameter preferredAlgorithm should be final. 269
 Warning coding HiddenField 'preferredAlgorithm' hides a field. 269
 Warning coding RequireThis Reference to instance variable 'filterName' needs "this.". 275
 Warning coding RequireThis Reference to instance variable 'ftype' needs "this.". 280

emissary/kff/KffMemcachedTest.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'mockMemcachedClient' needs "this.". 53
 Warning coding RequireThis Reference to instance variable 'isBinaryConnection' needs "this.". 61
 Warning coding FinalLocalVariable Variable 'mcdFilter' should be declared final. 67
 Warning coding FinalLocalVariable Variable 'mcdFilter' should be declared final. 76
 Warning coding FinalLocalVariable Variable 'results' should be declared final. 77
 Warning coding FinalLocalVariable Variable 'mcdFilter' should be declared final. 86
 Warning coding FinalLocalVariable Variable 'mcdFilter' should be declared final. 92
 Warning coding FinalLocalVariable Variable 'mcdFilter' should be declared final. 98
 Warning coding RequireThis Reference to instance variable 'isBinaryConnection' needs "this.". 104
 Warning coding FinalLocalVariable Variable 'mcdFilter' should be declared final. 105
 Warning misc FinalParameters Parameter mcd should be final. 109
 Warning coding FinalLocalVariable Variable 'kffalgs' should be declared final. 110
 Warning misc FinalParameters Parameter storeIdDupe should be final. 116
 Warning misc FinalParameters Parameter simulateHit should be final. 116
 Warning misc FinalParameters Parameter expectedKey should be final. 116
 Warning coding HiddenField 'expectedKey' hides a field. 116
 Warning coding FinalLocalVariable Variable 'filter' should be declared final. 119
 Warning coding RequireThis Reference to instance variable 'mockMemcachedClient' needs "this.". 119
 Warning coding RequireThis Reference to instance variable 'cacheResult' needs "this.". 122
 Warning coding RequireThis Reference to instance variable 'cacheResult' needs "this.". 124
 Warning misc FinalParameters Parameter key should be final. 130
 Warning misc FinalParameters Parameter cacheFilter should be final. 138
 Warning misc FinalParameters Parameter storeIdDupe should be final. 138
 Warning coding FinalLocalVariable Variable 'storeIdDupeField' should be declared final. 143
 Warning coding FinalLocalVariable Variable 'localMockMemcachedClient' should be declared final. 152
 Warning coding FinalLocalVariable Variable 'args' should be declared final. 155
 Warning coding FinalLocalVariable Variable 'args' should be declared final. 161
 Warning coding FinalLocalVariable Variable 'key' should be declared final. 162
 Warning coding RequireThis Reference to instance variable 'expectedKey' needs "this.". 164
 Warning coding RequireThis Reference to instance variable 'expectedKey' needs "this.". 165
 Warning coding RequireThis Reference to instance variable 'isBinaryConnection' needs "this.". 168
 Warning modifier RedundantModifier Redundant 'public' modifier. 180
 Warning misc FinalParameters Parameter l should be final. 180
 Warning misc FinalParameters Parameter opTimeout should be final. 180
 Warning misc FinalParameters Parameter key should be final. 180
 Warning misc FinalParameters Parameter ign should be final. 185
 Warning misc FinalParameters Parameter duration should be final. 196
 Warning misc FinalParameters Parameter units should be final. 196
 Warning coding RequireThis Reference to instance variable 'cacheResult' needs "KffMemcachedTest.this.". 197
 Warning misc FinalParameters Parameter d should be final. 206
 Warning misc FinalParameters Parameter s should be final. 206
 Warning misc FinalParameters Parameter to should be final. 211

emissary/kff/KffQuincyFile.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter filename should be final. 22
 Warning misc FinalParameters Parameter filterName should be final. 22
 Warning misc FinalParameters Parameter ftype should be final. 22
 Warning misc FinalParameters Parameter args should be final. 28
 Warning coding FinalLocalVariable Variable 'kff' should be declared final. 29
 Warning coding FinalLocalVariable Variable 'kfile' should be declared final. 30
 Warning coding FinalLocalVariable Variable 'buffer' should be declared final. 39
 Warning coding FinalLocalVariable Variable 'r' should be declared final. 41

emissary/kff/KffQuincyFileTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'args' should be declared final. 36

emissary/kff/KffResult.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'itemName' must be private and have accessor methods. 22
 Warning design VisibilityModifier Variable 'filterName' must be private and have accessor methods. 25
 Warning design VisibilityModifier Variable 'hit' must be private and have accessor methods. 27
 Warning design VisibilityModifier Variable 'filterType' must be private and have accessor methods. 30
 Warning design VisibilityModifier Variable 'crc32' must be private and have accessor methods. 32
 Warning design VisibilityModifier Variable 'ssdeep' must be private and have accessor methods. 34
 Warning design VisibilityModifier Variable 'hashComp' must be private and have accessor methods. 36
 Warning blocks RightCurly '}' at column 25 should be alone on a line. 41
 Warning misc FinalParameters Parameter csum should be final. 48
 Warning coding RequireThis Reference to instance variable 'hashComp' needs "this.". 52
 Warning misc FinalParameters Parameter isHit should be final. 61
 Warning misc FinalParameters Parameter argHit should be final. 79
 Warning misc FinalParameters Parameter ft should be final. 88
 Warning coding RequireThis Reference to instance variable 'filterType' needs "this.". 97
 Warning misc FinalParameters Parameter argCrc32 should be final. 128
 Warning misc FinalParameters Parameter ssdeep should be final. 146
 Warning coding HiddenField 'ssdeep' hides a field. 146
 Warning misc FinalParameters Parameter argSha should be final. 178
 Warning misc FinalParameters Parameter argMd5 should be final. 196
 Warning misc FinalParameters Parameter alg should be final. 205
 Warning coding RequireThis Reference to instance variable 'hashComp' needs "this.". 206
 Warning misc FinalParameters Parameter alg should be final. 215
 Warning misc FinalParameters Parameter digest should be final. 215
 Warning coding RequireThis Reference to instance variable 'hashComp' needs "this.". 216
 Warning misc FinalParameters Parameter alg should be final. 225
 Warning coding EqualsAvoidNull String literal expressions should be on the left side of an equals comparison. 226
 Warning coding FinalLocalVariable Variable 'digest' should be declared final. 230
 Warning coding RequireThis Reference to instance variable 'hashComp' needs "this.". 230
 Warning coding RequireThis Reference to instance variable 'hashComp' needs "this.". 242
 Warning misc FinalParameters Parameter argItemName should be final. 250
 Warning misc FinalParameters Parameter argFilterName should be final. 266

emissary/kff/SpamSumSignature.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter str should be final. 26
 Warning coding FinalLocalVariable Variable 'r' should be declared final. 27
 Warning misc FinalParameters Parameter hsh should be final. 38
 Warning misc FinalParameters Parameter signature should be final. 56
 Warning coding FinalLocalVariable Variable 'idx1' should be declared final. 61
 Warning coding FinalLocalVariable Variable 'idx2' should be declared final. 62
 Warning coding RequireThis Reference to instance variable 'blockSize' needs "this.". 72
 Warning coding RequireThis Reference to instance variable 'hash1' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'hash2' needs "this.". 74
 Warning misc FinalParameters Parameter blockSize should be final. 77
 Warning misc FinalParameters Parameter hash1 should be final. 77
 Warning misc FinalParameters Parameter hash2 should be final. 77
 Warning misc FinalParameters Parameter obj should be final. 88
 Warning misc FinalParameters Parameter other should be final. 101
 Warning coding RequireThis Reference to instance variable 'hash1' needs "this.". 114
 Warning coding RequireThis Reference to instance variable 'hash2' needs "this.". 120
 Warning coding FinalLocalVariable Variable 'hashText1' should be declared final. 131
 Warning coding RequireThis Reference to instance variable 'hash1' needs "this.". 131
 Warning coding FinalLocalVariable Variable 'hashText2' should be declared final. 132
 Warning coding RequireThis Reference to instance variable 'hash2' needs "this.". 132
 Warning coding RequireThis Reference to instance variable 'blockSize' needs "this.". 133
 Warning coding RequireThis Reference to instance variable 'blockSize' needs "this.". 145
 Warning coding RequireThis Reference to instance variable 'hash1' needs "this.". 153
 Warning coding RequireThis Reference to instance variable 'hash2' needs "this.". 161
 Warning misc FinalParameters Parameter args should be final. 165
 Warning coding FinalLocalVariable Variable 'sss1' should be declared final. 171
 Warning coding FinalLocalVariable Variable 'sss2' should be declared final. 172
 Warning coding FinalLocalVariable Variable 'ssdeep' should be declared final. 173

emissary/kff/Ssdeep.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'public' modifier. 106
 Warning modifier RedundantModifier Redundant 'public' modifier. 117
 Warning modifier RedundantModifier Redundant 'public' modifier. 128
 Warning modifier RedundantModifier Redundant 'public' modifier. 360
 Warning blocks RightCurly '}' at column 32 should be alone on a line. 360
 Warning blocks RightCurly '}' at column 22 should be alone on a line. 395

emissary/kff/SsdeepTest.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'ss' needs "this.". 36
 Warning coding RequireThis Reference to instance variable 'ss' needs "this.". 83
 Warning coding RequireThis Reference to instance variable 'ss' needs "this.". 119
 Warning coding RequireThis Reference to instance variable 'ss' needs "this.". 135
 Warning coding RequireThis Reference to instance variable 'ss' needs "this.". 136
 Warning coding RequireThis Reference to instance variable 'ss' needs "this.". 137
 Warning coding RequireThis Reference to instance variable 'ss' needs "this.". 142
 Warning coding RequireThis Reference to instance variable 'ss' needs "this.". 143
 Warning coding RequireThis Reference to instance variable 'ss' needs "this.". 144
 Warning coding RequireThis Reference to instance variable 'ss' needs "this.". 144
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 12, expected level should be one of the following: 6, 65, 66. 153
 Warning coding RequireThis Reference to instance variable 'ss' needs "this.". 165
 Warning coding RequireThis Reference to instance variable 'ss' needs "this.". 175
 Warning coding RequireThis Reference to instance variable 'ss' needs "this.". 176

emissary/log/MDCConstants.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 29 should be alone on a line. 8

emissary/output/DropOffPlace.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'doSynchronized' must be private and have accessor methods. 34
 Warning design VisibilityModifier Variable 'elideContentForms' must be private and have accessor methods. 35
 Warning design VisibilityModifier Variable 'noNukeForms' must be private and have accessor methods. 36
 Warning design VisibilityModifier Variable 'outputFilters' must be private and have accessor methods. 37
 Warning design VisibilityModifier Variable 'failurePolicyTerminate' must be private and have accessor methods. 38
 Warning design VisibilityModifier Variable 'dropOffUtil' must be private and have accessor methods. 39
 Warning coding RequireThis Reference to instance variable 'outputCompletionPayloadSize' needs "this.". 230

emissary/output/DropOffPlaceTest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'place' must be private and have accessor methods. 38
 Warning coding HiddenField 'tempDir' hides a field. 42
 Warning coding RequireThis Reference to instance variable 'tempDir' needs "this.". 58
 Warning coding FinalLocalVariable Variable 'appender' should be declared final. 89
 Warning coding FinalLocalVariable Variable 'content' should be declared final. 90
 Warning coding FinalLocalVariable Variable 'expected' should be declared final. 91
 Warning coding FinalLocalVariable Variable 'appender' should be declared final. 124
 Warning coding FinalLocalVariable Variable 'fileType' should be declared final. 125
 Warning coding FinalLocalVariable Variable 'expected' should be declared final. 126
 Warning misc FinalParameters Parameter path should be final. 154
 Warning misc FinalParameters Parameter file should be final. 157
 Warning misc FinalParameters Parameter attrs should be final. 157
 Warning misc FinalParameters Parameter dir should be final. 163
 Warning misc FinalParameters Parameter exc should be final. 163

emissary/output/DropOffUtil.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'unixRoot' must be private and have accessor methods. 55
 Warning design VisibilityModifier Variable 'placeOutputData' must be private and have accessor methods. 57
 Warning design VisibilityModifier Variable 'idTokens' must be private and have accessor methods. 60
 Warning design VisibilityModifier Variable 'dateTokens' must be private and have accessor methods. 63
 Warning design VisibilityModifier Variable 'parentParams' must be private and have accessor methods. 66
 Warning design VisibilityModifier Variable 'outputDirectories' must be private and have accessor methods. 69
 Warning design VisibilityModifier Variable 'executrix' must be private and have accessor methods. 71
 Warning design VisibilityModifier Variable 'prefix' must be private and have accessor methods. 76
 Warning design VisibilityModifier Variable 'uuidInOutputFilenames' must be private and have accessor methods. 77
 Warning design VisibilityModifier Variable 'maxFilextLen' must be private and have accessor methods. 78
 Warning design VisibilityModifier Variable 'defaultEventDateToNow' must be private and have accessor methods. 92
 Warning coding RequireThis Reference to instance variable 'prefix' needs "this.". 149
 Warning coding RequireThis Reference to instance variable 'prefix' needs "this.". 168
 Warning coding RequireThis Reference to instance variable 'prefix' needs "this.". 171
 Warning blocks RightCurly '}' at column 13 should be alone on a line. 246
 Warning misc FinalParameters Parameter token should be final. 461
 Warning coding FinalLocalVariable Variable 'badfs' should be declared final. 589
 Warning whitespace OperatorWrap '+' should be on a new line. 627
 Warning whitespace OperatorWrap '+' should be on a new line. 628
 Warning whitespace OperatorWrap '+' should be on a new line. 629
 Warning whitespace OperatorWrap '+' should be on a new line. 630
 Warning design VisibilityModifier Variable 'fieldName' must be private and have accessor methods. 727
 Warning misc FinalParameters Parameter fieldName should be final. 729
 Warning coding RequireThis Reference to instance variable 'fieldName' needs "this.". 734
 Warning coding FinalLocalVariable Variable 'zdt' should be declared final. 888
 Warning misc FinalParameters Parameter p should be final. 912
 Warning coding FinalLocalVariable Variable 'filenames' should be declared final. 913
 Warning coding FinalLocalVariable Variable 'extensions' should be declared final. 914
 Warning misc FinalParameters Parameter filenames should be final. 927
 Warning misc FinalParameters Parameter maxFilextLen should be final. 927
 Warning misc FinalParameters Parameter d should be final. 947
 Warning misc FinalParameters Parameter d should be final. 962
 Warning misc FinalParameters Parameter filenameFields should be final. 962
 Warning misc FinalParameters Parameter d should be final. 974
 Warning misc FinalParameters Parameter filenameFields should be final. 974
 Warning coding FinalLocalVariable Variable 'filenames' should be declared final. 976
 Warning coding FinalLocalVariable Variable 'stringFileName' should be declared final. 981
 Warning coding RequireThis Reference to instance variable 'parentParams' needs "this.". 1003
 Warning coding RequireThis Reference to instance variable 'parentParams' needs "this.". 1004
 Warning coding RequireThis Reference to instance variable 'parentParams' needs "this.". 1040
 Warning coding RequireThis Reference to instance variable 'parentParams' needs "this.". 1041
 Warning coding RequireThis Reference to instance variable 'parentParams' needs "this.". 1061
 Warning coding RequireThis Reference to instance variable 'parentParams' needs "this.". 1062
 Warning coding RequireThis Reference to instance variable 'parentParams' needs "this.". 1082
 Warning coding RequireThis Reference to instance variable 'parentParams' needs "this.". 1083

emissary/output/DropOffUtilTest.java

Severity Category Rule Message Line
 Warning coding VariableDeclarationUsageDistance Distance between variable 'values' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 338
 Warning coding FinalLocalVariable Variable 'tld' should be declared final. 505
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 510
 Warning coding VariableDeclarationUsageDistance Distance between variable 'start' declaration and its first usage is 10, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 514
 Warning coding FinalLocalVariable Variable 'start' should be declared final. 514
 Warning coding FinalLocalVariable Variable 'cfg' should be declared final. 537
 Warning coding FinalLocalVariable Variable 'subdirName' should be declared final. 550
 Warning coding FinalLocalVariable Variable 'metadata' should be declared final. 560
 Warning coding FinalLocalVariable Variable 'poppedForms' should be declared final. 563
 Warning coding FinalLocalVariable Variable 'finalId' should be declared final. 571
 Warning coding FinalLocalVariable Variable 'fontEncoding' should be declared final. 586
 Warning coding FinalLocalVariable Variable 'util' should be declared final. 603
 Warning coding HiddenField 'util' hides a field. 603
 Warning coding FinalLocalVariable Variable 'util' should be declared final. 629
 Warning coding HiddenField 'util' hides a field. 629
 Warning coding FinalLocalVariable Variable 'fileAbsolutepaths' should be declared final. 632
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 16, expected level should be one of the following: 10, 38, 39. 633
 Warning coding FinalLocalVariable Variable 'originalFilenames' should be declared final. 634
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 16, expected level should be one of the following: 10, 38, 39. 635
 Warning coding FinalLocalVariable Variable 'extensions' should be declared final. 637
 Warning coding RequireThis Reference to instance variable 'util' needs "this.". 660
 Warning coding RequireThis Reference to instance variable 'util' needs "this.". 661
 Warning coding RequireThis Reference to instance variable 'util' needs "this.". 662
 Warning coding RequireThis Reference to instance variable 'util' needs "this.". 663
 Warning coding FinalLocalVariable Variable 'ibdo' should be declared final. 668
 Warning coding FinalLocalVariable Variable 'ibdo' should be declared final. 690
 Warning coding FinalLocalVariable Variable 'bestFilenames' should be declared final. 693
 Warning misc FinalParameters Parameter bdo should be final. 699
 Warning misc FinalParameters Parameter fieldValue should be final. 699
 Warning misc FinalParameters Parameter fileTypeCheckParameter should be final. 699
 Warning misc FinalParameters Parameter bdo should be final. 704
 Warning misc FinalParameters Parameter metadata should be final. 704
 Warning misc FinalParameters Parameter expectedResults should be final. 704
 Warning misc FinalParameters Parameter formsArg should be final. 704
 Warning coding FinalLocalVariable Variable 'fileType' should be declared final. 705

emissary/output/filter/AbstractFilter.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'logger' must be private and have accessor methods. 36
 Warning design VisibilityModifier Variable 'configG' must be private and have accessor methods. 39
 Warning design VisibilityModifier Variable 'filterConfig' must be private and have accessor methods. 42
 Warning design VisibilityModifier Variable 'filterName' must be private and have accessor methods. 45
 Warning design VisibilityModifier Variable 'outputSpec' must be private and have accessor methods. 48
 Warning design VisibilityModifier Variable 'errorSpec' must be private and have accessor methods. 51
 Warning design VisibilityModifier Variable 'filterConditionSpec' must be private and have accessor methods. 54
 Warning design VisibilityModifier Variable 'outputTypes' must be private and have accessor methods. 62
 Warning design VisibilityModifier Variable 'denylist' must be private and have accessor methods. 86
 Warning design VisibilityModifier Variable 'wildCardDenylist' must be private and have accessor methods. 87
 Warning design VisibilityModifier Variable 'dropOffUtil' must be private and have accessor methods. 90
 Warning design VisibilityModifier Variable 'denylistAllowedNameChars' must be private and have accessor methods. 92
 Warning design VisibilityModifier Variable 'denylistFiletypeFormat' must be private and have accessor methods. 93
 Warning design VisibilityModifier Variable 'denylistFiletypeFormatPattern' must be private and have accessor methods. 94
 Warning design VisibilityModifier Variable 'denylistViewNameFormat' must be private and have accessor methods. 95
 Warning design VisibilityModifier Variable 'denylistViewNameFormatPattern' must be private and have accessor methods. 96
 Warning coding HiddenField 'filterName' hides a field. 102
 Warning coding HiddenField 'filterName' hides a field. 115
 Warning coding RequireThis Reference to instance variable 'filterConditionSpec' needs "this.". 132
 Warning coding HiddenField 'filterConfig' hides a field. 135
 Warning coding RequireThis Reference to instance variable 'filterConditionSpec' needs "this.". 136
 Warning coding RequireThis Reference to instance variable 'filterConditionSpec' needs "this.". 138
 Warning coding RequireThis Reference to instance variable 'filterConditionSpec' needs "this.". 139
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 145
 Warning coding RequireThis Reference to instance variable 'filterConditionSpec' needs "this.". 150
 Warning coding RequireThis Reference to instance variable 'filterCondition' needs "this.". 159
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 161
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 165
 Warning coding RequireThis Reference to instance variable 'filterConditionSpec' needs "this.". 165
 Warning coding RequireThis Reference to instance variable 'denylistAllowedNameChars' needs "this.". 189
 Warning coding RequireThis Reference to instance variable 'denylistAllowedNameChars' needs "this.". 189
 Warning coding RequireThis Reference to instance variable 'denylistFiletypeFormat' needs "this.". 190
 Warning coding RequireThis Reference to instance variable 'denylistFiletypeFormat' needs "this.". 190
 Warning coding RequireThis Reference to instance variable 'denylistFiletypeFormatPattern' needs "this.". 191
 Warning coding RequireThis Reference to instance variable 'denylistFiletypeFormat' needs "this.". 191
 Warning coding RequireThis Reference to instance variable 'denylistAllowedNameChars' needs "this.". 191
 Warning coding RequireThis Reference to instance variable 'denylistViewNameFormat' needs "this.". 192
 Warning coding RequireThis Reference to instance variable 'denylistViewNameFormat' needs "this.". 192
 Warning coding RequireThis Reference to instance variable 'denylistViewNameFormatPattern' needs "this.". 193
 Warning coding RequireThis Reference to instance variable 'denylistViewNameFormat' needs "this.". 193
 Warning coding RequireThis Reference to instance variable 'denylistAllowedNameChars' needs "this.". 193
 Warning coding FinalLocalVariable Variable 'viewName' should be declared final. 198
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 201
 Warning coding FinalLocalVariable Variable 'strippedEntry' should be declared final. 205
 Warning whitespace OperatorWrap '+' should be on a new line. 213
 Warning coding FinalLocalVariable Variable 'names' should be declared final. 224
 Warning coding FinalLocalVariable Variable 'filetype' should be declared final. 227
 Warning coding FinalLocalVariable Variable 'viewName' should be declared final. 228
 Warning coding EqualsAvoidNull String literal expressions should be on the left side of an equals comparison. 230
 Warning whitespace OperatorWrap '+' should be on a new line. 232
 Warning whitespace OperatorWrap '+' should be on a new line. 237
 Warning coding RequireThis Reference to instance variable 'filterCondition' needs "this.". 345
 Warning coding RequireThis Reference to instance variable 'filterCondition' needs "this.". 345
 Warning coding RequireThis Reference to instance variable 'filterCondition' needs "this.". 350
 Warning coding RequireThis Reference to instance variable 'filterCondition' needs "this.". 350
 Warning coding FinalLocalVariable Variable 'fullName' should be declared final. 546
 Warning misc FinalParameters Parameter str should be final. 583
 Warning coding RequireThis Reference to instance variable 'denylistFiletypeFormatPattern' needs "this.". 584
 Warning coding RequireThis Reference to instance variable 'denylistFiletypeFormatPattern' needs "this.". 588
 Warning misc FinalParameters Parameter str should be final. 591
 Warning coding RequireThis Reference to instance variable 'denylistViewNameFormatPattern' needs "this.". 592
 Warning coding RequireThis Reference to instance variable 'denylistViewNameFormatPattern' needs "this.". 596

emissary/output/filter/AbstractFilterTest.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter d should be final. 29
 Warning misc FinalParameters Parameter params should be final. 29
 Warning coding FinalLocalVariable Variable 'config' should be declared final. 36
 Warning coding FinalLocalVariable Variable 'f' should be declared final. 40
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 46
 Warning design VisibilityModifier Variable 'f' must be private and have accessor methods. 56
 Warning coding FinalLocalVariable Variable 'pattern' should be declared final. 60
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 60
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 63
 Warning coding FinalLocalVariable Variable 'formatString' should be declared final. 66
 Warning coding FinalLocalVariable Variable 'noMatchChars' should be declared final. 68
 Warning coding FinalLocalVariable Variable 'noMatchChar' should be declared final. 70
 Warning coding FinalLocalVariable Variable 'noMatch' should be declared final. 71
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 72
 Warning coding FinalLocalVariable Variable 'nullInsert' should be declared final. 76
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 77
 Warning coding FinalLocalVariable Variable 'matchChars' should be declared final. 80
 Warning coding FinalLocalVariable Variable 'matchChar' should be declared final. 82
 Warning coding FinalLocalVariable Variable 'match' should be declared final. 83
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 84
 Warning coding FinalLocalVariable Variable 'pattern' should be declared final. 91
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 91
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 94
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 97
 Warning coding FinalLocalVariable Variable 'formatStrings' should be declared final. 100
 Warning coding FinalLocalVariable Variable 'noMatchChars' should be declared final. 103
 Warning coding FinalLocalVariable Variable 'noMatchChar' should be declared final. 105
 Warning coding FinalLocalVariable Variable 'noMatch' should be declared final. 106
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 107
 Warning coding FinalLocalVariable Variable 'nullInsert' should be declared final. 111
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 112
 Warning coding FinalLocalVariable Variable 'matchChars' should be declared final. 115
 Warning coding FinalLocalVariable Variable 'matchChar' should be declared final. 117
 Warning coding FinalLocalVariable Variable 'match' should be declared final. 118
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 119
 Warning coding FinalLocalVariable Variable 'invalidEntries' should be declared final. 129
 Warning coding FinalLocalVariable Variable 'f' should be declared final. 139
 Warning coding FinalLocalVariable Variable 'e' should be declared final. 140
 Warning coding FinalLocalVariable Variable 'f' should be declared final. 149
 Warning coding FinalLocalVariable Variable 'filetype1' should be declared final. 153
 Warning coding FinalLocalVariable Variable 'filetype2' should be declared final. 165
 Warning coding FinalLocalVariable Variable 'f' should be declared final. 181
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 185
 Warning coding FinalLocalVariable Variable 'checkTypes' should be declared final. 190

emissary/output/filter/AbstractRollableFilter.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'defaultOutputPath' must be private and have accessor methods. 39
 Warning design VisibilityModifier Variable 'outputPath' must be private and have accessor methods. 40
 Warning design VisibilityModifier Variable 'maxRollFileSize' must be private and have accessor methods. 41
 Warning design VisibilityModifier Variable 'maxOutputAppenders' must be private and have accessor methods. 42
 Warning design VisibilityModifier Variable 'rollInterval' must be private and have accessor methods. 43
 Warning design VisibilityModifier Variable 'rollIntervalUnits' must be private and have accessor methods. 44
 Warning design VisibilityModifier Variable 'roller' must be private and have accessor methods. 45
 Warning design VisibilityModifier Variable 'rollable' must be private and have accessor methods. 46
 Warning design VisibilityModifier Variable 'fileNameGenerator' must be private and have accessor methods. 47
 Warning design VisibilityModifier Variable 'appendNewLine' must be private and have accessor methods. 48
 Warning modifier RedundantModifier Redundant 'final' modifier. 58
 Warning modifier RedundantModifier Redundant 'final' modifier. 58
 Warning coding RequireThis Reference to instance variable 'defaultOutputPath' needs "this.". 81
 Warning coding RequireThis Reference to instance variable 'maxRollFileSize' needs "this.". 97
 Warning coding RequireThis Reference to instance variable 'rollInterval' needs "this.". 99
 Warning coding RequireThis Reference to instance variable 'rollIntervalUnits' needs "this.". 100
 Warning coding RequireThis Reference to instance variable 'appendNewLine' needs "this.". 201

emissary/output/filter/DataFilterTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'config' should be declared final. 23
 Warning coding FinalLocalVariable Variable 'f' should be declared final. 26
 Warning coding FinalLocalVariable Variable 'config' should be declared final. 34
 Warning coding FinalLocalVariable Variable 'f' should be declared final. 38
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 41
 Warning coding FinalLocalVariable Variable 'params' should be declared final. 46
 Warning coding FinalLocalVariable Variable 'status' should be declared final. 48
 Warning coding FinalLocalVariable Variable 'expected' should be declared final. 50
 Warning coding FinalLocalVariable Variable 'output' should be declared final. 54

emissary/output/filter/JsonOutputFilter.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'denylistFields' must be private and have accessor methods. 49
 Warning design VisibilityModifier Variable 'denylistPrefixes' must be private and have accessor methods. 50
 Warning design VisibilityModifier Variable 'allowlistFields' must be private and have accessor methods. 51
 Warning design VisibilityModifier Variable 'allowlistPrefixes' must be private and have accessor methods. 52
 Warning design VisibilityModifier Variable 'denylistValues' must be private and have accessor methods. 53
 Warning design VisibilityModifier Variable 'stripPrefixes' must be private and have accessor methods. 54
 Warning design VisibilityModifier Variable 'emitPayload' must be private and have accessor methods. 56
 Warning design VisibilityModifier Variable 'jsonMapper' must be private and have accessor methods. 58
 Warning coding RequireThis Reference to instance variable 'jsonMapper' needs "this.". 86
 Warning coding RequireThis Reference to instance variable 'jsonMapper' needs "this.". 87
 Warning coding RequireThis Reference to instance variable 'jsonMapper' needs "this.". 88
 Warning coding RequireThis Reference to instance variable 'jsonMapper' needs "this.". 89
 Warning coding RequireThis Reference to instance variable 'emitPayload' needs "this.". 89
 Warning coding RequireThis Reference to instance variable 'jsonMapper' needs "this.". 91
 Warning coding RequireThis Reference to instance variable 'jsonMapper' needs "this.". 96
 Warning design VisibilityModifier Variable 'outputAll' must be private and have accessor methods. 101
 Warning design VisibilityModifier Variable 'emptyDenylist' must be private and have accessor methods. 102
 Warning design VisibilityModifier Variable 'denylistStar' must be private and have accessor methods. 103
 Warning design VisibilityModifier Variable 'emptyAllowlist' must be private and have accessor methods. 104
 Warning design VisibilityModifier Variable 'allowlistStar' must be private and have accessor methods. 105
 Warning modifier RedundantModifier Redundant 'public' modifier. 108
 Warning coding RequireThis Reference to instance variable 'allowlistFields' needs "JsonOutputFilter.this.". 110
 Warning coding RequireThis Reference to instance variable 'allowlistFields' needs "JsonOutputFilter.this.". 110
 Warning coding RequireThis Reference to instance variable 'denylistFields' needs "JsonOutputFilter.this.". 111
 Warning coding RequireThis Reference to instance variable 'denylistFields' needs "JsonOutputFilter.this.". 111
 Warning coding RequireThis Reference to instance variable 'denylistFields' needs "JsonOutputFilter.this.". 112
 Warning coding RequireThis Reference to instance variable 'denylistPrefixes' needs "JsonOutputFilter.this.". 112
 Warning coding RequireThis Reference to instance variable 'allowlistFields' needs "JsonOutputFilter.this.". 113
 Warning coding RequireThis Reference to instance variable 'allowlistPrefixes' needs "JsonOutputFilter.this.". 113
 Warning coding RequireThis Reference to instance variable 'emptyDenylist' needs "this.". 114
 Warning coding RequireThis Reference to instance variable 'allowlistStar' needs "this.". 114
 Warning coding RequireThis Reference to instance variable 'emptyAllowlist' needs "this.". 114
 Warning misc FinalParameters Parameter pojo should be final. 118
 Warning misc FinalParameters Parameter jgen should be final. 118
 Warning misc FinalParameters Parameter provider should be final. 118
 Warning misc FinalParameters Parameter writer should be final. 118
 Warning coding FinalLocalVariable Variable 'key' should be declared final. 120
 Warning coding FinalLocalVariable Variable 'values' should be declared final. 122
 Warning coding FinalLocalVariable Variable 'write' should be declared final. 125
 Warning misc FinalParameters Parameter key should be final. 137
 Warning coding RequireThis Reference to instance variable 'outputAll' needs "this.". 138
 Warning coding RequireThis Reference to instance variable 'denylistFields' needs "JsonOutputFilter.this.". 143
 Warning coding RequireThis Reference to instance variable 'allowlistFields' needs "JsonOutputFilter.this.". 145
 Warning coding RequireThis Reference to instance variable 'denylistPrefixes' needs "JsonOutputFilter.this.". 150
 Warning coding RequireThis Reference to instance variable 'denylistStar' needs "this.". 157
 Warning coding RequireThis Reference to instance variable 'allowlistStar' needs "this.". 159
 Warning coding RequireThis Reference to instance variable 'allowlistPrefixes' needs "JsonOutputFilter.this.". 164
 Warning coding RequireThis Reference to instance variable 'emptyAllowlist' needs "this.". 171
 Warning misc FinalParameters Parameter key should be final. 174
 Warning misc FinalParameters Parameter values should be final. 174
 Warning coding FinalLocalVariable Variable 'keep' should be declared final. 175
 Warning coding RequireThis Reference to instance variable 'denylistValues' needs "JsonOutputFilter.this.". 177
 Warning coding RequireThis Reference to instance variable 'denylistValues' needs "JsonOutputFilter.this.". 177
 Warning misc FinalParameters Parameter name should be final. 184
 Warning misc FinalParameters Parameter name should be final. 188
 Warning coding RequireThis Reference to instance variable 'stripPrefixes' needs "JsonOutputFilter.this.". 189
 Warning misc FinalParameters Parameter name should be final. 197
 Warning coding FinalLocalVariable Variable 'ch' should be declared final. 199
 Warning modifier RedundantModifier Redundant 'public' modifier. 220
 Warning misc FinalParameters Parameter ibdo should be final. 231
 Warning misc FinalParameters Parameter jgen should be final. 231
 Warning misc FinalParameters Parameter provider should be final. 231
 Warning coding FinalLocalVariable Variable 'javaType' should be declared final. 233
 Warning coding FinalLocalVariable Variable 'beanDesc' should be declared final. 234
 Warning coding FinalLocalVariable Variable 'serializer' should be declared final. 235

emissary/output/filter/JsonOutputFilterTest.java

Severity Category Rule Message Line
 Warning coding HiddenField 'tmpDir' hides a field. 39
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 42
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 43
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 44
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 46
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 48
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 49
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 50
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 51
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 52
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 53
 Warning coding RequireThis Reference to instance variable 'tmpDir' needs "this.". 58
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 59
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 64
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 64
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 64
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 65
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 70
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 70
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 70
 Warning coding FinalLocalVariable Variable 'payloadList' should be declared final. 72
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 73
 Warning coding FinalLocalVariable Variable 'params' should be declared final. 75
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 77
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 77
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 78
 Warning coding FinalLocalVariable Variable 'output' should be declared final. 80
 Warning coding FinalLocalVariable Variable 'status' should be declared final. 81
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 81
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 90
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 91
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 91
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 91
 Warning coding FinalLocalVariable Variable 'output' should be declared final. 93
 Warning coding FinalLocalVariable Variable 'status' should be declared final. 94
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 94
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 94
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 103
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 104
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 104
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 104
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 106
 Warning coding HiddenField 'payload' hides a field. 106
 Warning coding FinalLocalVariable Variable 'nested' should be declared final. 111
 Warning coding FinalLocalVariable Variable 'record' should be declared final. 113
 Warning coding FinalLocalVariable Variable 'payloadList' should be declared final. 121
 Warning coding FinalLocalVariable Variable 'params' should be declared final. 124
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 127
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 128
 Warning coding FinalLocalVariable Variable 'output' should be declared final. 130
 Warning coding FinalLocalVariable Variable 'status' should be declared final. 131
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 131
 Warning coding FinalLocalVariable Variable 's' should be declared final. 134
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 142
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 143
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 143
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 143
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 145
 Warning coding FinalLocalVariable Variable 'payloadList' should be declared final. 147
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 148
 Warning coding FinalLocalVariable Variable 'params' should be declared final. 150
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 152
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 152
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 153
 Warning coding FinalLocalVariable Variable 'output' should be declared final. 155
 Warning coding FinalLocalVariable Variable 'status' should be declared final. 156
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 156
 Warning coding FinalLocalVariable Variable 's' should be declared final. 157
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 166
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 167
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 168
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 169
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 169
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 169
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 171
 Warning coding HiddenField 'payload' hides a field. 171
 Warning coding FinalLocalVariable Variable 'payloadList' should be declared final. 179
 Warning coding FinalLocalVariable Variable 'params' should be declared final. 182
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 184
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 185
 Warning coding FinalLocalVariable Variable 'output' should be declared final. 187
 Warning coding FinalLocalVariable Variable 'status' should be declared final. 188
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 188
 Warning coding FinalLocalVariable Variable 's' should be declared final. 189
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 200
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 201
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 202
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 202
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 202
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 204
 Warning coding HiddenField 'payload' hides a field. 204
 Warning coding FinalLocalVariable Variable 'payloadList' should be declared final. 212
 Warning coding FinalLocalVariable Variable 'params' should be declared final. 215
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 217
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 218
 Warning coding FinalLocalVariable Variable 'output' should be declared final. 220
 Warning coding FinalLocalVariable Variable 'status' should be declared final. 221
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 221
 Warning coding FinalLocalVariable Variable 's' should be declared final. 222
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 233
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 234
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 234
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 234
 Warning coding FinalLocalVariable Variable 'payloadList' should be declared final. 236
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 237
 Warning coding FinalLocalVariable Variable 'params' should be declared final. 239
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 241
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 241
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 242
 Warning coding FinalLocalVariable Variable 'output' should be declared final. 244
 Warning coding FinalLocalVariable Variable 'status' should be declared final. 245
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 245
 Warning coding FinalLocalVariable Variable 's' should be declared final. 246
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 254
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 255
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 256
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 256
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 256
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 259
 Warning coding HiddenField 'payload' hides a field. 259
 Warning coding FinalLocalVariable Variable 'payloadList' should be declared final. 263
 Warning coding FinalLocalVariable Variable 'output' should be declared final. 267
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 268
 Warning coding FinalLocalVariable Variable 's' should be declared final. 269
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 278
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 279
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 280
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 280
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 280
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 283
 Warning coding HiddenField 'payload' hides a field. 283
 Warning coding FinalLocalVariable Variable 'payloadList' should be declared final. 287
 Warning coding FinalLocalVariable Variable 'output' should be declared final. 291
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 292
 Warning coding FinalLocalVariable Variable 's' should be declared final. 293
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 302
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 303
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 304
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 304
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 304
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 307
 Warning coding HiddenField 'payload' hides a field. 307
 Warning coding FinalLocalVariable Variable 'payloadList' should be declared final. 311
 Warning coding FinalLocalVariable Variable 'output' should be declared final. 315
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 316
 Warning coding FinalLocalVariable Variable 's' should be declared final. 317
 Warning coding FinalLocalVariable Variable 'parent' should be declared final. 327
 Warning coding FinalLocalVariable Variable 'child' should be declared final. 330
 Warning coding FinalLocalVariable Variable 'child2' should be declared final. 333
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 337
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 338
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 338
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 338
 Warning coding FinalLocalVariable Variable 'output' should be declared final. 340
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 343
 Warning coding FinalLocalVariable Variable 's' should be declared final. 346
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 354
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 355
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 356
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 357
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 357
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 357
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 359
 Warning coding HiddenField 'payload' hides a field. 359
 Warning coding FinalLocalVariable Variable 'payloadList' should be declared final. 366
 Warning coding FinalLocalVariable Variable 'params' should be declared final. 369
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 371
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 372
 Warning coding FinalLocalVariable Variable 'output' should be declared final. 374
 Warning coding FinalLocalVariable Variable 'status' should be declared final. 375
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 375
 Warning coding FinalLocalVariable Variable 's' should be declared final. 379

emissary/output/filter/XmlOutputFilter.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter configG should be final. 27
 Warning misc FinalParameters Parameter filterName should be final. 27
 Warning misc FinalParameters Parameter filterConfig should be final. 27
 Warning misc FinalParameters Parameter args should be final. 44
 Warning coding FinalLocalVariable Variable 'name' should be declared final. 45
 Warning coding FinalLocalVariable Variable 'filter' should be declared final. 47
 Warning coding FinalLocalVariable Variable 'config' should be declared final. 49

emissary/output/filter/XmlOutputFilterTest.java

Severity Category Rule Message Line
 Warning coding HiddenField 'tmpDir' hides a field. 35
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 38
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 39
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 40
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 41
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 42
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 44
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 46
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 47
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 48
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 49
 Warning coding RequireThis Reference to instance variable 'tmpDir' needs "this.". 55
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 56
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 61
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 61
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 62
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 63
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 68
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 68
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 68
 Warning coding FinalLocalVariable Variable 'payloadList' should be declared final. 69
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 69
 Warning coding FinalLocalVariable Variable 'params' should be declared final. 71
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 74
 Warning coding FinalLocalVariable Variable 'output' should be declared final. 76
 Warning coding FinalLocalVariable Variable 'status' should be declared final. 77
 Warning coding RequireThis Reference to instance variable 'f' needs "this.". 77

emissary/output/io/DateFilterFilenameGenerator.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter filterName should be final. 30
 Warning coding RequireThis Reference to instance variable 'filterNamePart' needs "this.". 40
 Warning misc FinalParameters Parameter extension should be final. 43

emissary/output/io/DateFilterFilenameGeneratorTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'fileNameGenerator' should be declared final. 27
 Warning coding FinalLocalVariable Variable 'filename1' should be declared final. 29
 Warning coding FinalLocalVariable Variable 'filename2' should be declared final. 30
 Warning coding FinalLocalVariable Variable 'filename1Parts' should be declared final. 31
 Warning coding FinalLocalVariable Variable 'fileNameGenerator' should be declared final. 50
 Warning coding FinalLocalVariable Variable 'filename' should be declared final. 51
 Warning coding FinalLocalVariable Variable 'filenameParts' should be declared final. 52
 Warning coding FinalLocalVariable Variable 'fileNameGenerator' should be declared final. 60
 Warning coding FinalLocalVariable Variable 'filename' should be declared final. 61
 Warning coding FinalLocalVariable Variable 'filenameParts' should be declared final. 62

emissary/output/io/DateStampFilenameGenerator.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'formatter' must be private and have accessor methods. 18
 Warning design VisibilityModifier Variable 'identifier' must be private and have accessor methods. 21
 Warning design VisibilityModifier Variable 'fileSuffix' must be private and have accessor methods. 24
 Warning design VisibilityModifier Variable 'lastFileName' must be private and have accessor methods. 27
 Warning design VisibilityModifier Variable 'seq' must be private and have accessor methods. 30
 Warning misc FinalParameters Parameter fileSuffix should be final. 36
 Warning misc FinalParameters Parameter fileSuffix should be final. 40
 Warning misc FinalParameters Parameter identifier should be final. 40
 Warning misc FinalParameters Parameter fileSuffix should be final. 44
 Warning misc FinalParameters Parameter identifier should be final. 44
 Warning misc FinalParameters Parameter datePattern should be final. 44
 Warning coding FinalLocalVariable Variable 'dateFileName' should be declared final. 52
 Warning coding RequireThis Reference to instance variable 'formatter' needs "this.". 52
 Warning coding RequireThis Reference to instance variable 'seq' needs "this.". 53
 Warning coding RequireThis Reference to instance variable 'lastFileName' needs "this.". 53
 Warning coding RequireThis Reference to instance variable 'seq' needs "this.". 53
 Warning coding RequireThis Reference to instance variable 'lastFileName' needs "this.". 54
 Warning coding RequireThis Reference to instance variable 'seq' needs "this.". 55
 Warning coding RequireThis Reference to instance variable 'identifier' needs "this.". 55
 Warning coding RequireThis Reference to instance variable 'fileSuffix' needs "this.". 55

emissary/output/io/SimpleFileNameGenerator.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'dropOffUtil' needs "this.". 23

emissary/output/roller/JournaledCoalescer.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'outputPath' must be private and have accessor methods. 65
 Warning misc FinalParameters Parameter poolsize should be final. 108
 Warning coding RequireThis Reference to instance variable 'outputPath' needs "this.". 136
 Warning coding FinalLocalVariable Variable 'finalOutputFilename' should be declared final. 138
 Warning coding RequireThis Reference to instance variable 'outputPath' needs "this.". 140
 Warning coding RequireThis Reference to instance variable 'outputPath' needs "this.". 144
 Warning coding RequireThis Reference to instance variable 'lock' needs "this.". 155
 Warning coding RequireThis Reference to instance variable 'journaledPool' needs "this.". 157
 Warning coding FinalLocalVariable Variable 'journals' should be declared final. 160
 Warning coding RequireThis Reference to instance variable 'outputPath' needs "this.". 160
 Warning coding RequireThis Reference to instance variable 'outputPath' needs "this.". 161
 Warning coding RequireThis Reference to instance variable 'poolsize' needs "this.". 161
 Warning coding RequireThis Reference to instance variable 'lock' needs "this.". 165
 Warning coding RequireThis Reference to instance variable 'lock' needs "this.". 177
 Warning coding RequireThis Reference to instance variable 'journaledPool' needs "this.". 180
 Warning coding RequireThis Reference to instance variable 'lock' needs "this.". 185
 Warning coding FinalLocalVariable Variable 'paths' should be declared final. 198
 Warning misc FinalParameters Parameter journalPaths should be final. 216
 Warning coding FinalLocalVariable Variable 'outputMap' should be declared final. 221
 Warning misc FinalParameters Parameter path should be final. 226
 Warning misc FinalParameters Parameter outputMap should be final. 226
 Warning coding FinalLocalVariable Variable 'j' should be declared final. 228
 Warning misc FinalParameters Parameter key should be final. 242
 Warning misc FinalParameters Parameter journals should be final. 242
 Warning coding FinalLocalVariable Variable 'finalOutputPath' should be declared final. 245
 Warning coding FinalLocalVariable Variable 'rolledOutputPath' should be declared final. 246
 Warning coding FinalLocalVariable Variable 'workingOutputPath' should be declared final. 256
 Warning misc FinalParameters Parameter journal should be final. 283
 Warning misc FinalParameters Parameter rolledOutput should be final. 283
 Warning coding FinalLocalVariable Variable 'startPos' should be declared final. 284
 Warning coding FinalLocalVariable Variable 'last' should be declared final. 285
 Warning coding FinalLocalVariable Variable 'p' should be declared final. 291
 Warning coding FinalLocalVariable Variable 'partSize' should be declared final. 294
 Warning coding FinalLocalVariable Variable 'lastGood' should be declared final. 296
 Warning misc FinalParameters Parameter journals should be final. 329
 Warning misc FinalParameters Parameter rolledOutputPath should be final. 329
 Warning misc FinalParameters Parameter finalOutputPath should be final. 329
 Warning misc FinalParameters Parameter rolledOutputPath should be final. 335
 Warning misc FinalParameters Parameter finalOutputPath should be final. 335
 Warning misc FinalParameters Parameter journals should be final. 341
 Warning misc FinalParameters Parameter rolledOutputPath should be final. 341
 Warning misc FinalParameters Parameter finalOutputPath should be final. 341
 Warning misc FinalParameters Parameter rolledOutputPath should be final. 345
 Warning misc FinalParameters Parameter finalOutputPath should be final. 345
 Warning misc FinalParameters Parameter journals should be final. 345
 Warning misc FinalParameters Parameter rolledOutputPath should be final. 350
 Warning misc FinalParameters Parameter finalOutputPath should be final. 350
 Warning misc FinalParameters Parameter path should be final. 364
 Warning coding FinalLocalVariable Variable 'errorPath' should be declared final. 366
 Warning misc FinalParameters Parameter startsWith should be final. 380
 Warning coding RequireThis Reference to instance variable 'outputPath' needs "this.". 381
 Warning misc FinalParameters Parameter journals should be final. 386
 Warning coding FinalLocalVariable Variable 'jpath' should be declared final. 388
 Warning misc FinalParameters Parameter entries should be final. 394
 Warning coding FinalLocalVariable Variable 'p' should be declared final. 396

emissary/output/roller/JournaledCoalescerTest.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'fileNameGenerator' needs "this.". 60
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 61
 Warning coding RequireThis Reference to instance variable 'journaledCoalescer' needs "this.". 62
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 62
 Warning coding RequireThis Reference to instance variable 'fileNameGenerator' needs "this.". 62
 Warning coding RequireThis Reference to instance variable 'tempBud1' needs "this.". 65
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 65
 Warning coding RequireThis Reference to instance variable 'tempBud1' needs "this.". 66
 Warning coding RequireThis Reference to instance variable 'tempBud2' needs "this.". 68
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 68
 Warning coding RequireThis Reference to instance variable 'tempBud2' needs "this.". 69
 Warning coding RequireThis Reference to instance variable 'journaledCoalescer' needs "this.". 74
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 75
 Warning coding RequireThis Reference to instance variable 'fileNameGenerator' needs "this.". 82
 Warning coding FinalLocalVariable Variable 'tmpFile' should be declared final. 89
 Warning coding RequireThis Reference to instance variable 'fileNameGenerator' needs "this.". 90
 Warning coding FinalLocalVariable Variable 'perms' should be declared final. 98
 Warning coding FinalLocalVariable Variable 'tmpdir' should be declared final. 101
 Warning coding RequireThis Reference to instance variable 'fileNameGenerator' needs "this.". 102
 Warning coding FinalLocalVariable Variable 'perms' should be declared final. 112
 Warning coding FinalLocalVariable Variable 'tmpdir' should be declared final. 116
 Warning coding RequireThis Reference to instance variable 'fileNameGenerator' needs "this.". 117
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 124
 Warning coding RequireThis Reference to instance variable 'tempBud1' needs "this.". 127
 Warning coding RequireThis Reference to instance variable 'tempBud2' needs "this.". 128
 Warning coding RequireThis Reference to instance variable 'journaledCoalescer' needs "this.". 134
 Warning coding FinalLocalVariable Variable 'bud1destination' should be declared final. 137
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 137
 Warning coding FinalLocalVariable Variable 'fileResults' should be declared final. 139
 Warning coding FinalLocalVariable Variable 'bud1destination' should be declared final. 147
 Warning coding FinalLocalVariable Variable 'bud2destination' should be declared final. 148
 Warning coding RequireThis Reference to instance variable 'journaledCoalescer' needs "this.". 149
 Warning coding RequireThis Reference to instance variable 'journaledCoalescer' needs "this.". 149
 Warning coding RequireThis Reference to instance variable 'tempBud1' needs "this.". 150
 Warning coding RequireThis Reference to instance variable 'tempBud2' needs "this.". 152
 Warning coding RequireThis Reference to instance variable 'journaledCoalescer' needs "this.". 164
 Warning coding FinalLocalVariable Variable 'totalSize' should be declared final. 166
 Warning coding RequireThis Reference to instance variable 'tempBud1' needs "this.". 166
 Warning coding RequireThis Reference to instance variable 'tempBud2' needs "this.". 166
 Warning coding FinalLocalVariable Variable 'expectedPrefix1' should be declared final. 174
 Warning coding RequireThis Reference to instance variable 'journaledCoalescer' needs "this.". 177
 Warning coding RequireThis Reference to instance variable 'tempBud1' needs "this.". 178
 Warning coding RequireThis Reference to instance variable 'journaledCoalescer' needs "this.". 183
 Warning coding FinalLocalVariable Variable 'expectedPrefix2' should be declared final. 185
 Warning coding RequireThis Reference to instance variable 'journaledCoalescer' needs "this.". 187
 Warning coding RequireThis Reference to instance variable 'tempBud2' needs "this.". 188
 Warning coding FinalLocalVariable Variable 'bud1Destination' should be declared final. 193
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 193
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 196
 Warning coding FinalLocalVariable Variable 'finalBudOutput' should be declared final. 210
 Warning coding RequireThis Reference to instance variable 'journaledCoalescer' needs "this.". 211
 Warning coding RequireThis Reference to instance variable 'tempBud1' needs "this.". 212
 Warning coding FinalLocalVariable Variable 'oldRolling' should be declared final. 217
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 217
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 221
 Warning coding RequireThis Reference to instance variable 'fileNameGenerator' needs "this.". 221
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 236
 Warning coding RequireThis Reference to instance variable 'tempBud1' needs "this.". 239
 Warning coding RequireThis Reference to instance variable 'tempBud2' needs "this.". 240
 Warning coding FinalLocalVariable Variable 'oldRolled' should be declared final. 246
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 246
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 249
 Warning coding RequireThis Reference to instance variable 'fileNameGenerator' needs "this.". 249
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 251
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 256
 Warning coding FinalLocalVariable Variable 'oldRolled' should be declared final. 266
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 266
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 269
 Warning coding RequireThis Reference to instance variable 'fileNameGenerator' needs "this.". 269
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 273
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 278
 Warning coding FinalLocalVariable Variable 'oldRolled' should be declared final. 285
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 285
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 287
 Warning coding RequireThis Reference to instance variable 'fileNameGenerator' needs "this.". 287
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 289
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 294
 Warning coding FinalLocalVariable Variable 'oldRolled' should be declared final. 300
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 300
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 302
 Warning coding RequireThis Reference to instance variable 'fileNameGenerator' needs "this.". 302
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 306
 Warning coding RequireThis Reference to instance variable 'tempBud1' needs "this.". 312
 Warning coding FinalLocalVariable Variable 'finalBudOutput' should be declared final. 313
 Warning coding RequireThis Reference to instance variable 'journaledCoalescer' needs "this.". 314
 Warning coding RequireThis Reference to instance variable 'journaledCoalescer' needs "this.". 319
 Warning coding FinalLocalVariable Variable 'target' should be declared final. 328
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 328
 Warning coding FinalLocalVariable Variable 'key' should be declared final. 329
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 330
 Warning coding FinalLocalVariable Variable 'strings' should be declared final. 332
 Warning coding FinalLocalVariable Variable 'partSize' should be declared final. 342
 Warning coding FinalLocalVariable Variable 'j' should be declared final. 344
 Warning coding FinalLocalVariable Variable 'rolled' should be declared final. 348
 Warning coding RequireThis Reference to instance variable 'targetBudPath' needs "this.". 348
 Warning coding RequireThis Reference to instance variable 'journaledCoalescer' needs "this.". 350
 Warning coding FinalLocalVariable Variable 'rolledSize' should be declared final. 353

emissary/output/roller/journal/Journal.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'version' must be private and have accessor methods. 30
 Warning design VisibilityModifier Variable 'key' must be private and have accessor methods. 31
 Warning design VisibilityModifier Variable 'journalPath' must be private and have accessor methods. 32
 Warning design VisibilityModifier Variable 'entries' must be private and have accessor methods. 34
 Warning misc FinalParameters Parameter journalPath should be final. 36
 Warning coding RequireThis Reference to instance variable 'entries' needs "this.". 41
 Warning misc FinalParameters Parameter b should be final. 44
 Warning coding RequireThis Reference to instance variable 'version' needs "this.". 49
 Warning misc FinalParameters Parameter key should be final. 52
 Warning coding HiddenField 'key' hides a field. 52
 Warning coding RequireThis Reference to instance variable 'entries' needs "this.". 77
 Warning coding RequireThis Reference to instance variable 'entries' needs "this.". 77
 Warning coding RequireThis Reference to instance variable 'entries' needs "this.". 77
 Warning misc FinalParameters Parameter channelSize should be final. 89
 Warning coding RequireThis Reference to instance variable 'entries' needs "this.". 93
 Warning coding FinalLocalVariable Variable 'je' should be declared final. 94
 Warning coding RequireThis Reference to instance variable 'entries' needs "this.". 94
 Warning coding RequireThis Reference to instance variable 'version' needs "this.". 104
 Warning coding RequireThis Reference to instance variable 'key' needs "this.". 104
 Warning coding RequireThis Reference to instance variable 'journalPath' needs "this.". 104
 Warning coding RequireThis Reference to instance variable 'entries' needs "this.". 104

emissary/output/roller/journal/JournalEntry.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'val' must be private and have accessor methods. 12
 Warning design VisibilityModifier Variable 'offset' must be private and have accessor methods. 13
 Warning coding RequireThis Reference to instance variable 'val' needs "this.". 33
 Warning coding RequireThis Reference to instance variable 'offset' needs "this.". 33

emissary/output/roller/journal/JournalReader.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'journalPath' must be private and have accessor methods. 37
 Warning design VisibilityModifier Variable 'journalChannel' must be private and have accessor methods. 46
 Warning coding RequireThis Reference to instance variable 'journal' needs "this.". 57
 Warning coding RequireThis Reference to instance variable 'journalPath' needs "this.". 63
 Warning coding RequireThis Reference to instance variable 'journalPath' needs "this.". 63
 Warning coding RequireThis Reference to instance variable 'journalPath' needs "this.". 66
 Warning coding RequireThis Reference to instance variable 'journalChannel' needs "this.". 71
 Warning coding RequireThis Reference to instance variable 'begin' needs "this.". 71
 Warning coding RequireThis Reference to instance variable 'sequence' needs "this.". 72
 Warning coding RequireThis Reference to instance variable 'startsequence' needs "this.". 72
 Warning coding RequireThis Reference to instance variable 'journalChannel' needs "this.". 74
 Warning coding RequireThis Reference to instance variable 'journalChannel' needs "this.". 74
 Warning coding FinalLocalVariable Variable 'read' should be declared final. 75
 Warning coding RequireThis Reference to instance variable 'journal' needs "this.". 78
 Warning coding RequireThis Reference to instance variable 'startsequence' needs "this.". 78
 Warning coding RequireThis Reference to instance variable 'sequence' needs "this.". 78
 Warning coding RequireThis Reference to instance variable 'sequence' needs "this.". 78
 Warning coding RequireThis Reference to instance variable 'startsequence' needs "this.". 78
 Warning coding FinalLocalVariable Variable 'nextSeq' should be declared final. 81
 Warning coding RequireThis Reference to instance variable 'sequence' needs "this.". 82
 Warning coding RequireThis Reference to instance variable 'sequence' needs "this.". 83
 Warning coding FinalLocalVariable Variable 'e' should be declared final. 86
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 86
 Warning coding RequireThis Reference to instance variable 'journal' needs "this.". 87
 Warning coding RequireThis Reference to instance variable 'journal' needs "this.". 92
 Warning coding FinalLocalVariable Variable 'seq' should be declared final. 97
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 97
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 98
 Warning coding FinalLocalVariable Variable 'mgic' should be declared final. 106
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 107
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 115
 Warning coding RequireThis Reference to instance variable 'journalPath' needs "this.". 119
 Warning coding RequireThis Reference to instance variable 'journal' needs "this.". 121
 Warning coding RequireThis Reference to instance variable 'journal' needs "this.". 123
 Warning coding RequireThis Reference to instance variable 'journal' needs "this.". 125
 Warning coding RequireThis Reference to instance variable 'journal' needs "this.". 127
 Warning coding RequireThis Reference to instance variable 'sequence' needs "this.". 130
 Warning coding RequireThis Reference to instance variable 'sequence' needs "this.". 131
 Warning coding RequireThis Reference to instance variable 'sequence' needs "this.". 132
 Warning coding RequireThis Reference to instance variable 'startsequence' needs "this.". 134
 Warning coding RequireThis Reference to instance variable 'sequence' needs "this.". 134
 Warning coding RequireThis Reference to instance variable 'begin' needs "this.". 135
 Warning coding RequireThis Reference to instance variable 'journalChannel' needs "this.". 135
 Warning coding FinalLocalVariable Variable 'read' should be declared final. 139
 Warning coding FinalLocalVariable Variable 'len' should be declared final. 140
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 140
 Warning coding FinalLocalVariable Variable 'keyBytes' should be declared final. 144
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 146
 Warning misc FinalParameters Parameter limit should be final. 151
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 155
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 156
 Warning coding FinalLocalVariable Variable 'read' should be declared final. 159
 Warning coding RequireThis Reference to instance variable 'journalChannel' needs "this.". 159
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 159
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 169
 Warning coding RequireThis Reference to instance variable 'lock' needs "this.". 175
 Warning coding RequireThis Reference to instance variable 'journalChannel' needs "this.". 177
 Warning coding RequireThis Reference to instance variable 'journalChannel' needs "this.". 178
 Warning coding RequireThis Reference to instance variable 'journalChannel' needs "this.". 180
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 181
 Warning coding RequireThis Reference to instance variable 'lock' needs "this.". 183
 Warning misc FinalParameters Parameter dir should be final. 188
 Warning coding FinalLocalVariable Variable 'paths' should be declared final. 189
 Warning misc FinalParameters Parameter args should be final. 202
 Warning coding FinalLocalVariable Variable 'path' should be declared final. 203
 Warning coding FinalLocalVariable Variable 'j' should be declared final. 205

emissary/output/roller/journal/JournalTest.java

Severity Category Rule Message Line
 Warning coding HiddenField 'tmpDir' hides a field. 20
 Warning coding RequireThis Reference to instance variable 'tmpDir' needs "this.". 45
 Warning coding FinalLocalVariable Variable 'j' should be declared final. 49
 Warning coding FinalLocalVariable Variable 'j' should be declared final. 83
 Warning coding RequireThis Reference to instance variable 'tmpDir' needs "this.". 83

emissary/output/roller/journal/JournalWriter.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'journalPath' must be private and have accessor methods. 36
 Warning design VisibilityModifier Variable 'version' must be private and have accessor methods. 39
 Warning design VisibilityModifier Variable 'key' must be private and have accessor methods. 40
 Warning design VisibilityModifier Variable 'journal' must be private and have accessor methods. 43
 Warning design VisibilityModifier Variable 'prev' must be private and have accessor methods. 44
 Warning coding RequireThis Reference to instance variable 'journalPath' needs "this.". 57
 Warning coding RequireThis Reference to instance variable 'journalPath' needs "this.". 57
 Warning coding RequireThis Reference to instance variable 'journalPath' needs "this.". 60
 Warning misc FinalParameters Parameter e should be final. 69
 Warning coding RequireThis Reference to instance variable 'lock' needs "this.". 70
 Warning coding RequireThis Reference to instance variable 'journal' needs "this.". 72
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 75
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 76
 Warning coding RequireThis Reference to instance variable 'sequence' needs "this.". 76
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 77
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 78
 Warning coding RequireThis Reference to instance variable 'prev' needs "this.". 82
 Warning coding RequireThis Reference to instance variable 'prev' needs "this.". 82
 Warning coding RequireThis Reference to instance variable 'prev' needs "this.". 84
 Warning coding RequireThis Reference to instance variable 'lock' needs "this.". 85
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 90
 Warning coding RequireThis Reference to instance variable 'journal' needs "this.". 91
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 91
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 92
 Warning coding RequireThis Reference to instance variable 'journalPath' needs "this.". 96
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 97
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 99
 Warning coding FinalLocalVariable Variable 'keyBytes' should be declared final. 100
 Warning coding RequireThis Reference to instance variable 'key' needs "this.". 100
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 101
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 103
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 106
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 108
 Warning coding RequireThis Reference to instance variable 'sequence' needs "this.". 111
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 112
 Warning coding RequireThis Reference to instance variable 'sequence' needs "this.". 112
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 113
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 119
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 120
 Warning coding RequireThis Reference to instance variable 'lock' needs "this.". 129
 Warning coding RequireThis Reference to instance variable 'journal' needs "this.". 131
 Warning coding RequireThis Reference to instance variable 'journal' needs "this.". 132
 Warning coding RequireThis Reference to instance variable 'journal' needs "this.". 134
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 135
 Warning coding RequireThis Reference to instance variable 'lock' needs "this.". 137

emissary/output/roller/journal/JournaledChannel.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'fc' must be private and have accessor methods. 24
 Warning design VisibilityModifier Variable 'path' must be private and have accessor methods. 25
 Warning design VisibilityModifier Variable 'e' must be private and have accessor methods. 27
 Warning design VisibilityModifier Variable 'index' must be private and have accessor methods. 28
 Warning design VisibilityModifier Variable 'journal' must be private and have accessor methods. 29
 Warning design VisibilityModifier Variable 'directBuff' must be private and have accessor methods. 31

emissary/output/roller/journal/JournaledChannelPool.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'max' must be private and have accessor methods. 28
 Warning design VisibilityModifier Variable 'directory' must be private and have accessor methods. 29
 Warning design VisibilityModifier Variable 'key' must be private and have accessor methods. 30

emissary/output/roller/journal/JournaledChannelPoolTest.java

Severity Category Rule Message Line
 Warning coding HiddenField 'directory' hides a field. 30
 Warning coding FinalLocalVariable Variable 'j' should be declared final. 73

emissary/output/roller/journal/JournaledChannelTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 33
 Warning coding FinalLocalVariable Variable 'fiveKStr' should be declared final. 63
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 99
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 100
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 105
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 110
 Warning coding FinalLocalVariable Variable 'buff' should be declared final. 115
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 116
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 121

emissary/output/roller/journal/KeyedOutput.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'pool' must be private and have accessor methods. 21
 Warning design VisibilityModifier Variable 'jc' must be private and have accessor methods. 23

emissary/parser/DataByteArraySlicer.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter data should be final. 22
 Warning misc FinalParameters Parameter r should be final. 22
 Warning coding FinalLocalVariable Variable 'n' should be declared final. 23
 Warning misc FinalParameters Parameter data should be final. 35
 Warning misc FinalParameters Parameter list should be final. 35
 Warning coding FinalLocalVariable Variable 'out' should be declared final. 52
 Warning coding FinalLocalVariable Variable 'start' should be declared final. 55
 Warning coding FinalLocalVariable Variable 'len' should be declared final. 56
 Warning blocks RightCurly '}' at column 36 should be alone on a line. 77

emissary/parser/DataByteArraySlicerTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'pr' should be declared final. 16
 Warning coding FinalLocalVariable Variable 'input' should be declared final. 23
 Warning coding FinalLocalVariable Variable 'result' should be declared final. 24
 Warning coding FinalLocalVariable Variable 'pr' should be declared final. 30
 Warning coding FinalLocalVariable Variable 'input' should be declared final. 32
 Warning coding FinalLocalVariable Variable 'result' should be declared final. 33
 Warning coding FinalLocalVariable Variable 'pr' should be declared final. 39
 Warning coding FinalLocalVariable Variable 'input' should be declared final. 40
 Warning coding FinalLocalVariable Variable 'pr' should be declared final. 46
 Warning coding FinalLocalVariable Variable 'input' should be declared final. 47

emissary/parser/DataByteBufferSlicer.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter data should be final. 22
 Warning misc FinalParameters Parameter r should be final. 22
 Warning coding FinalLocalVariable Variable 'len' should be declared final. 26
 Warning coding FinalLocalVariable Variable 'n' should be declared final. 27
 Warning misc FinalParameters Parameter data should be final. 44
 Warning misc FinalParameters Parameter list should be final. 44
 Warning coding FinalLocalVariable Variable 'start' should be declared final. 59
 Warning coding FinalLocalVariable Variable 'len' should be declared final. 60
 Warning coding FinalLocalVariable Variable 'n' should be declared final. 71
 Warning blocks RightCurly '}' at column 37 should be alone on a line. 87

emissary/parser/DataByteBufferSlicerTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'input' should be declared final. 17
 Warning coding FinalLocalVariable Variable 'buffer' should be declared final. 18
 Warning coding FinalLocalVariable Variable 'result' should be declared final. 19
 Warning coding FinalLocalVariable Variable 'input' should be declared final. 25
 Warning coding FinalLocalVariable Variable 'pr' should be declared final. 26
 Warning coding FinalLocalVariable Variable 'buffer' should be declared final. 33
 Warning coding FinalLocalVariable Variable 'result' should be declared final. 34
 Warning coding FinalLocalVariable Variable 'pr' should be declared final. 40
 Warning coding FinalLocalVariable Variable 'input' should be declared final. 41
 Warning coding FinalLocalVariable Variable 'buffer' should be declared final. 42
 Warning coding FinalLocalVariable Variable 'pr' should be declared final. 48
 Warning coding FinalLocalVariable Variable 'input' should be declared final. 49
 Warning coding FinalLocalVariable Variable 'buffer' should be declared final. 50

emissary/parser/DataIdentifier.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'DATA_ID_STR_SZ' must be private and have accessor methods. 29
 Warning design VisibilityModifier Variable 'typesMap' must be private and have accessor methods. 32
 Warning misc FinalParameters Parameter config should be final. 44
 Warning misc FinalParameters Parameter config should be final. 48
 Warning coding ParameterAssignment Assignment of parameter 'config' is not allowed. 51
 Warning coding RequireThis Reference to instance variable 'typesMap' needs "this.". 53
 Warning coding RequireThis Reference to instance variable 'typesMap' needs "this.". 54
 Warning misc FinalParameters Parameter data should be final. 66
 Warning misc FinalParameters Parameter limit should be final. 66
 Warning misc FinalParameters Parameter data should be final. 79
 Warning coding RequireThis Reference to instance variable 'DATA_ID_STR_SZ' needs "this.". 80
 Warning misc FinalParameters Parameter data should be final. 88
 Warning coding RequireThis Reference to instance variable 'typesMap' needs "this.". 89
 Warning coding FinalLocalVariable Variable 'pattern' should be declared final. 90
 Warning coding RequireThis Reference to instance variable 'DATA_ID_STR_SZ' needs "this.". 117
 Warning misc FinalParameters Parameter args should be final. 121
 Warning coding FinalLocalVariable Variable 'dataIdentifier' should be declared final. 122
 Warning coding FinalLocalVariable Variable 'raf' should be declared final. 125
 Warning coding FinalLocalVariable Variable 'data' should be declared final. 126
 Warning coding FinalLocalVariable Variable 'result' should be declared final. 127

emissary/parser/DataIdentifierTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'id' should be declared final. 32
 Warning misc FinalParameters Parameter identify should be final. 50
 Warning misc FinalParameters Parameter expected should be final. 50
 Warning misc FinalParameters Parameter msg should be final. 50
 Warning coding FinalLocalVariable Variable 'config' should be declared final. 51
 Warning coding FinalLocalVariable Variable 'id' should be declared final. 53
 Warning coding FinalLocalVariable Variable 'result' should be declared final. 54
 Warning coding FinalLocalVariable Variable 'id' should be declared final. 60
 Warning misc FinalParameters Parameter DATA should be final. 75
 Warning coding HiddenField 'DATA' hides a field. 75
 Warning misc FinalParameters Parameter DATA should be final. 79
 Warning coding HiddenField 'DATA' hides a field. 79
 Warning misc FinalParameters Parameter limit should be final. 79

emissary/parser/DecomposedSession.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'header' must be private and have accessor methods. 31
 Warning design VisibilityModifier Variable 'footer' must be private and have accessor methods. 33
 Warning design VisibilityModifier Variable 'data' must be private and have accessor methods. 35
 Warning design VisibilityModifier Variable 'classification' must be private and have accessor methods. 37
 Warning design VisibilityModifier Variable 'initialForms' must be private and have accessor methods. 38
 Warning design VisibilityModifier Variable 'metadata' must be private and have accessor methods. 39
 Warning misc FinalParameters Parameter h should be final. 46
 Warning coding RequireThis Reference to instance variable 'header' needs "this.". 47
 Warning coding RequireThis Reference to instance variable 'header' needs "this.". 56
 Warning misc FinalParameters Parameter f should be final. 64
 Warning coding RequireThis Reference to instance variable 'footer' needs "this.". 65
 Warning coding RequireThis Reference to instance variable 'footer' needs "this.". 74
 Warning misc FinalParameters Parameter d should be final. 83
 Warning misc FinalParameters Parameter d should be final. 93
 Warning misc FinalParameters Parameter copy should be final. 93
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 95
 Warning misc FinalParameters Parameter d should be final. 108
 Warning misc FinalParameters Parameter start should be final. 108
 Warning misc FinalParameters Parameter end should be final. 108
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 109
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 110
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 110
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 119
 Warning misc FinalParameters Parameter s should be final. 127
 Warning coding RequireThis Reference to instance variable 'classification' needs "this.". 128
 Warning coding RequireThis Reference to instance variable 'classification' needs "this.". 137
 Warning misc FinalParameters Parameter m should be final. 145
 Warning coding RequireThis Reference to instance variable 'metadata' needs "this.". 146
 Warning coding RequireThis Reference to instance variable 'metadata' needs "this.". 156
 Warning coding RequireThis Reference to instance variable 'metadata' needs "this.". 163
 Warning coding RequireThis Reference to instance variable 'header' needs "this.". 172
 Warning coding RequireThis Reference to instance variable 'footer' needs "this.". 181
 Warning coding RequireThis Reference to instance variable 'classification' needs "this.". 190
 Warning coding RequireThis Reference to instance variable 'metadata' needs "this.". 199
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 208
 Warning misc FinalParameters Parameter name should be final. 217
 Warning misc FinalParameters Parameter value should be final. 217
 Warning coding RequireThis Reference to instance variable 'metadata' needs "this.". 219
 Warning misc FinalParameters Parameter m should be final. 228
 Warning coding FinalLocalVariable Variable 'key' should be declared final. 231
 Warning coding FinalLocalVariable Variable 'v' should be declared final. 232
 Warning coding RequireThis Reference to instance variable 'metadata' needs "this.". 234
 Warning coding RequireThis Reference to instance variable 'metadata' needs "this.". 236
 Warning misc FinalParameters Parameter key should be final. 247
 Warning coding RequireThis Reference to instance variable 'metadata' needs "this.". 248
 Warning misc FinalParameters Parameter key should be final. 256
 Warning misc FinalParameters Parameter key should be final. 267
 Warning misc FinalParameters Parameter sep should be final. 267
 Warning coding FinalLocalVariable Variable 'o' should be declared final. 268
 Warning coding RequireThis Reference to instance variable 'metadata' needs "this.". 268
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 272
 Warning misc FinalParameters Parameter form should be final. 287
 Warning coding RequireThis Reference to instance variable 'initialForms' needs "this.". 289
 Warning misc FinalParameters Parameter forms should be final. 296
 Warning coding RequireThis Reference to instance variable 'initialForms' needs "this.". 298
 Warning coding RequireThis Reference to instance variable 'initialForms' needs "this.". 306

emissary/parser/DecomposedSessionTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 36
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 43
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 51
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 58
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 65
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 72
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 79
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 86
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 94
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 102
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 110
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 118
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 126
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 138
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 144
 Warning coding FinalLocalVariable Variable 'mm' should be declared final. 150
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 157
 Warning coding FinalLocalVariable Variable 'newForms' should be declared final. 168
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 181
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 189
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 196

emissary/parser/FillingNIOParser.java

Severity Category Rule Message Line
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 15
 Warning design VisibilityModifier Variable 'sessionStart' must be private and have accessor methods. 18
 Warning misc FinalParameters Parameter channel should be final. 20
 Warning misc FinalParameters Parameter data should be final. 31
 Warning coding RequireThis Reference to instance variable 'sessionStart' needs "this.". 32
 Warning coding RequireThis Reference to instance variable 'sessionStart' needs "this.". 38
 Warning coding RequireThis Reference to instance variable 'sessionStart' needs "this.". 42
 Warning coding RequireThis Reference to instance variable 'sessionStart' needs "this.". 43
 Warning coding RequireThis Reference to instance variable 'sessionStart' needs "this.". 45
 Warning coding FinalLocalVariable Variable 'b' should be declared final. 49
 Warning coding RequireThis Reference to instance variable 'sessionStart' needs "this.". 53

emissary/parser/InputSession.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'overall' must be private and have accessor methods. 32
 Warning design VisibilityModifier Variable 'header' must be private and have accessor methods. 35
 Warning design VisibilityModifier Variable 'footer' must be private and have accessor methods. 38
 Warning design VisibilityModifier Variable 'data' must be private and have accessor methods. 41
 Warning design VisibilityModifier Variable 'metaData' must be private and have accessor methods. 44
 Warning design VisibilityModifier Variable 'valid' must be private and have accessor methods. 47
 Warning blocks RightCurly '}' at column 28 should be alone on a line. 52
 Warning misc FinalParameters Parameter o should be final. 59
 Warning misc FinalParameters Parameter o should be final. 69
 Warning misc FinalParameters Parameter d should be final. 69
 Warning misc FinalParameters Parameter o should be final. 80
 Warning misc FinalParameters Parameter d should be final. 80
 Warning misc FinalParameters Parameter o should be final. 93
 Warning misc FinalParameters Parameter h should be final. 93
 Warning misc FinalParameters Parameter f should be final. 93
 Warning misc FinalParameters Parameter d should be final. 93
 Warning misc FinalParameters Parameter o should be final. 108
 Warning misc FinalParameters Parameter h should be final. 108
 Warning misc FinalParameters Parameter f should be final. 108
 Warning misc FinalParameters Parameter d should be final. 108
 Warning misc FinalParameters Parameter m should be final. 108
 Warning misc FinalParameters Parameter rec should be final. 119
 Warning misc FinalParameters Parameter start should be final. 130
 Warning misc FinalParameters Parameter length should be final. 130
 Warning misc FinalParameters Parameter m should be final. 139
 Warning coding FinalLocalVariable Variable 'key' should be declared final. 141
 Warning coding FinalLocalVariable Variable 'val' should be declared final. 142
 Warning coding RequireThis Reference to instance variable 'metaData' needs "this.". 145
 Warning coding RequireThis Reference to instance variable 'metaData' needs "this.". 147
 Warning misc FinalParameters Parameter b should be final. 160
 Warning coding RequireThis Reference to instance variable 'valid' needs "this.". 170
 Warning coding RequireThis Reference to instance variable 'overall' needs "this.". 179
 Warning coding RequireThis Reference to instance variable 'overall' needs "this.". 180
 Warning coding RequireThis Reference to instance variable 'overall' needs "this.". 191
 Warning coding RequireThis Reference to instance variable 'overall' needs "this.". 192
 Warning coding RequireThis Reference to instance variable 'overall' needs "this.". 203
 Warning misc FinalParameters Parameter h should be final. 212
 Warning coding RequireThis Reference to instance variable 'header' needs "this.". 215
 Warning misc FinalParameters Parameter d should be final. 225
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 228
 Warning misc FinalParameters Parameter f should be final. 238
 Warning coding RequireThis Reference to instance variable 'footer' needs "this.". 241
 Warning misc FinalParameters Parameter r should be final. 251
 Warning coding RequireThis Reference to instance variable 'header' needs "this.". 253
 Warning misc FinalParameters Parameter pos should be final. 263
 Warning misc FinalParameters Parameter len should be final. 263
 Warning misc FinalParameters Parameter r should be final. 273
 Warning coding RequireThis Reference to instance variable 'footer' needs "this.". 275
 Warning misc FinalParameters Parameter pos should be final. 285
 Warning misc FinalParameters Parameter len should be final. 285
 Warning misc FinalParameters Parameter r should be final. 295
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 297
 Warning misc FinalParameters Parameter pos should be final. 307
 Warning misc FinalParameters Parameter len should be final. 307
 Warning misc FinalParameters Parameter name should be final. 318
 Warning misc FinalParameters Parameter r should be final. 318
 Warning coding RequireThis Reference to instance variable 'metaData' needs "this.". 320
 Warning misc FinalParameters Parameter name should be final. 329
 Warning misc FinalParameters Parameter rec should be final. 329
 Warning coding RequireThis Reference to instance variable 'metaData' needs "this.". 330
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 339
 Warning coding RequireThis Reference to instance variable 'footer' needs "this.". 348
 Warning coding RequireThis Reference to instance variable 'header' needs "this.". 357
 Warning coding RequireThis Reference to instance variable 'metaData' needs "this.". 366
 Warning coding RequireThis Reference to instance variable 'footer' needs "this.". 375
 Warning coding RequireThis Reference to instance variable 'header' needs "this.". 384
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 393
 Warning coding RequireThis Reference to instance variable 'metaData' needs "this.". 402
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 412
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 418
 Warning misc FinalParameters Parameter r should be final. 429
 Warning coding RequireThis Reference to instance variable 'overall' needs "this.". 430
 Warning coding RequireThis Reference to instance variable 'overall' needs "this.". 430
 Warning coding RequireThis Reference to instance variable 'overall' needs "this.". 430
 Warning coding RequireThis Reference to instance variable 'overall' needs "this.". 431
 Warning misc FinalParameters Parameter list should be final. 441
 Warning coding RequireThis Reference to instance variable 'overall' needs "this.". 443
 Warning coding RequireThis Reference to instance variable 'overall' needs "this.". 458
 Warning coding RequireThis Reference to instance variable 'header' needs "this.". 461
 Warning coding RequireThis Reference to instance variable 'footer' needs "this.". 462
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 463
 Warning coding RequireThis Reference to instance variable 'overall' needs "this.". 473
 Warning coding RequireThis Reference to instance variable 'metaData' needs "this.". 473
 Warning coding RequireThis Reference to instance variable 'metaData' needs "this.". 477

emissary/parser/InputSessionTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'i' should be declared final. 18
 Warning coding FinalLocalVariable Variable 'i' should be declared final. 32
 Warning coding FinalLocalVariable Variable 'i' should be declared final. 39
 Warning coding FinalLocalVariable Variable 'i' should be declared final. 50
 Warning coding FinalLocalVariable Variable 'i' should be declared final. 57

emissary/parser/NIOSessionParser.java

Severity Category Rule Message Line
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 20
 Warning design VisibilityModifier Variable 'channel' must be private and have accessor methods. 25
 Warning design VisibilityModifier Variable 'chunkStart' must be private and have accessor methods. 28
 Warning design VisibilityModifier Variable 'data' must be private and have accessor methods. 32
 Warning design VisibilityModifier Variable 'writeOffset' must be private and have accessor methods. 35
 Warning design VisibilityModifier Variable 'minChunkSize' must be private and have accessor methods. 38
 Warning design VisibilityModifier Variable 'maxChunkSize' must be private and have accessor methods. 41
 Warning design VisibilityModifier Variable 'chunkAllocationIncrement' must be private and have accessor methods. 44
 Warning misc FinalParameters Parameter channel should be final. 51
 Warning coding RequireThis Reference to instance variable 'maxChunkSize' needs "this.". 59
 Warning misc FinalParameters Parameter value should be final. 65
 Warning coding RequireThis Reference to instance variable 'maxChunkSize' needs "this.". 67
 Warning misc FinalParameters Parameter data should be final. 78
 Warning coding HiddenField 'data' hides a field. 78
 Warning coding RequireThis Reference to instance variable 'maxChunkSize' needs "this.". 80
 Warning coding RequireThis Reference to instance variable 'chunkStart' needs "this.". 80
 Warning coding RequireThis Reference to instance variable 'writeOffset' needs "this.". 80
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 82
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 88
 Warning coding ParameterAssignment Assignment of parameter 'data' is not allowed. 88
 Warning coding RequireThis Reference to instance variable 'minChunkSize' needs "this.". 88
 Warning coding RequireThis Reference to instance variable 'writeOffset' needs "this.". 91
 Warning coding RequireThis Reference to instance variable 'chunkAllocationIncrement' needs "this.". 93
 Warning coding RequireThis Reference to instance variable 'maxChunkSize' needs "this.". 94
 Warning coding RequireThis Reference to instance variable 'maxChunkSize' needs "this.". 95
 Warning coding RequireThis Reference to instance variable 'maxChunkSize' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'chunkStart' needs "this.". 100
 Warning coding RequireThis Reference to instance variable 'maxChunkSize' needs "this.". 100
 Warning coding FinalLocalVariable Variable 'newData' should be declared final. 103
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 105
 Warning coding ParameterAssignment Assignment of parameter 'data' is not allowed. 105
 Warning coding RequireThis Reference to instance variable 'writeOffset' needs "this.". 109
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 114
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 115
 Warning coding RequireThis Reference to instance variable 'writeOffset' needs "this.". 124
 Warning coding RequireThis Reference to instance variable 'writeOffset' needs "this.". 125
 Warning coding RequireThis Reference to instance variable 'writeOffset' needs "this.". 126
 Warning coding ParameterAssignment Assignment of parameter 'data' is not allowed. 127
 Warning coding RequireThis Reference to instance variable 'writeOffset' needs "this.". 127

emissary/parser/ParserEOFException.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter msg should be final. 15

emissary/parser/ParserException.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter msg should be final. 18
 Warning misc FinalParameters Parameter msg should be final. 28
 Warning misc FinalParameters Parameter cause should be final. 28

emissary/parser/ParserFactory.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'nioTypeMap' must be private and have accessor methods. 38
 Warning design VisibilityModifier Variable 'nioFallbackMax' must be private and have accessor methods. 42
 Warning design VisibilityModifier Variable 'nioParser' must be private and have accessor methods. 45
 Warning design VisibilityModifier Variable 'idEngine' must be private and have accessor methods. 50
 Warning misc FinalParameters Parameter config should be final. 65
 Warning misc FinalParameters Parameter config should be final. 83
 Warning coding ParameterAssignment Assignment of parameter 'config' is not allowed. 86
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 89
 Warning coding RequireThis Reference to instance variable 'nioFallbackMax' needs "this.". 91
 Warning coding RequireThis Reference to instance variable 'nioFallbackMax' needs "this.". 91
 Warning coding RequireThis Reference to instance variable 'nioTypeMap' needs "this.". 93
 Warning coding RequireThis Reference to instance variable 'nioTypeMap' needs "this.". 94
 Warning coding RequireThis Reference to instance variable 'nioTypeMap' needs "this.". 96
 Warning coding RequireThis Reference to instance variable 'nioFallbackMax' needs "this.". 96
 Warning coding RequireThis Reference to instance variable 'nioParser' needs "this.". 99
 Warning coding FinalLocalVariable Variable 'idEngineClass' should be declared final. 101
 Warning misc FinalParameters Parameter channel should be final. 119
 Warning coding FinalLocalVariable Variable 'id' should be declared final. 120
 Warning misc FinalParameters Parameter type should be final. 136
 Warning misc FinalParameters Parameter channel should be final. 136
 Warning misc FinalParameters Parameter channel should be final. 149
 Warning misc FinalParameters Parameter type should be final. 149
 Warning coding FinalLocalVariable Variable 'sp' should be declared final. 150
 Warning coding RequireThis Reference to instance variable 'nioTypeMap' needs "this.". 152
 Warning coding RequireThis Reference to instance variable 'nioTypeMap' needs "this.". 153
 Warning coding RequireThis Reference to instance variable 'nioParser' needs "this.". 155
 Warning misc FinalParameters Parameter clazz should be final. 168
 Warning misc FinalParameters Parameter args should be final. 168
 Warning misc FinalParameters Parameter clazz should be final. 189
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 191
 Warning coding RequireThis Reference to instance variable 'idEngine' needs "this.". 192
 Warning misc FinalParameters Parameter channel should be final. 205
 Warning coding RequireThis Reference to instance variable 'idEngine' needs "this.". 206
 Warning coding FinalLocalVariable Variable 'pos' should be declared final. 208
 Warning coding FinalLocalVariable Variable 'buf' should be declared final. 209
 Warning coding RequireThis Reference to instance variable 'idEngine' needs "this.". 209
 Warning coding RequireThis Reference to instance variable 'idEngine' needs "this.". 211

emissary/parser/ParserFactoryTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'cfg' should be declared final. 21
 Warning coding FinalLocalVariable Variable 'pf' should be declared final. 24
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 25

emissary/parser/ParserNextChunkException.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter msg should be final. 18

emissary/parser/PositionRecord.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter position should be final. 16
 Warning misc FinalParameters Parameter length should be final. 16
 Warning misc FinalParameters Parameter posAndLen should be final. 26
 Warning coding RequireThis Reference to instance variable 'position' needs "this.". 40
 Warning coding RequireThis Reference to instance variable 'length' needs "this.". 49
 Warning coding RequireThis Reference to instance variable 'position' needs "this.". 58
 Warning coding RequireThis Reference to instance variable 'length' needs "this.". 58
 Warning coding RequireThis Reference to instance variable 'position' needs "this.". 63
 Warning coding RequireThis Reference to instance variable 'length' needs "this.". 63

emissary/parser/PositionRecordTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'p1' should be declared final. 16
 Warning coding FinalLocalVariable Variable 'p' should be declared final. 23
 Warning coding FinalLocalVariable Variable 'arry' should be declared final. 30
 Warning coding FinalLocalVariable Variable 'p' should be declared final. 31

emissary/parser/SessionParser.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'fullyParsed' must be private and have accessor methods. 11
 Warning coding RequireThis Reference to instance variable 'fullyParsed' needs "this.". 19
 Warning misc FinalParameters Parameter fullyParsed should be final. 27
 Warning coding HiddenField 'fullyParsed' hides a field. 27
 Warning misc FinalParameters Parameter session should be final. 37

emissary/parser/SessionProducer.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'sp' must be private and have accessor methods. 21
 Warning design VisibilityModifier Variable 'numSessions' must be private and have accessor methods. 23
 Warning design VisibilityModifier Variable 'initialForms' must be private and have accessor methods. 24
 Warning design VisibilityModifier Variable 'firstSession' must be private and have accessor methods. 26
 Warning misc FinalParameters Parameter sp should be final. 35
 Warning misc FinalParameters Parameter myKey should be final. 35
 Warning misc FinalParameters Parameter initialForms should be final. 35
 Warning misc FinalParameters Parameter sp should be final. 47
 Warning misc FinalParameters Parameter initialForm should be final. 47
 Warning misc FinalParameters Parameter session should be final. 53
 Warning misc FinalParameters Parameter defaultSessionName should be final. 53
 Warning coding VariableDeclarationUsageDistance Distance between variable 'theHeader' declaration and its first usage is 6, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 54
 Warning coding FinalLocalVariable Variable 'theHeader' should be declared final. 54
 Warning coding VariableDeclarationUsageDistance Distance between variable 'theFooter' declaration and its first usage is 7, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 55
 Warning coding FinalLocalVariable Variable 'theFooter' should be declared final. 55
 Warning coding FinalLocalVariable Variable 'theData' should be declared final. 56
 Warning coding VariableDeclarationUsageDistance Distance between variable 'classification' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 57
 Warning coding FinalLocalVariable Variable 'classification' should be declared final. 57
 Warning coding VariableDeclarationUsageDistance Distance between variable 'metadata' declaration and its first usage is 8, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 58
 Warning coding FinalLocalVariable Variable 'metadata' should be declared final. 58
 Warning coding RequireThis Reference to instance variable 'sp' needs "this.". 61
 Warning coding RequireThis Reference to instance variable 'sp' needs "this.". 62
 Warning coding FinalLocalVariable Variable 'dataObject' should be declared final. 68
 Warning coding RequireThis Reference to instance variable 'initialForms' needs "this.". 71
 Warning coding RequireThis Reference to instance variable 'initialForms' needs "this.". 71
 Warning coding RequireThis Reference to instance variable 'initialForms' needs "this.". 74
 Warning coding RequireThis Reference to instance variable 'initialForms' needs "this.". 75
 Warning coding FinalLocalVariable Variable 'sessionForms' should be declared final. 79
 Warning coding FinalLocalVariable Variable 'iter' should be declared final. 101
 Warning coding FinalLocalVariable Variable 'entry' should be declared final. 103
 Warning coding FinalLocalVariable Variable 'key' should be declared final. 104
 Warning coding FinalLocalVariable Variable 'baseViewName' should be declared final. 106
 Warning coding FinalLocalVariable Variable 'values' should be declared final. 108
 Warning coding FinalLocalVariable Variable 'viewName' should be declared final. 110
 Warning misc FinalParameters Parameter defaultSessionName should be final. 135
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 136
 Warning coding RequireThis Reference to instance variable 'sp' needs "this.". 136

emissary/parser/SessionProducerTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'parser' should be declared final. 16
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 17
 Warning coding FinalLocalVariable Variable 'sp' should be declared final. 20
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 21
 Warning coding FinalLocalVariable Variable 'parser' should be declared final. 27
 Warning coding FinalLocalVariable Variable 'sp' should be declared final. 28
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 29
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 35
 Warning coding FinalLocalVariable Variable 'parser' should be declared final. 46
 Warning coding FinalLocalVariable Variable 'sp' should be declared final. 47
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 48
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 52

emissary/parser/SimpleNioParser.java

Severity Category Rule Message Line
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 21
 Warning design VisibilityModifier Variable 'currentSessionIndex' must be private and have accessor methods. 23
 Warning misc FinalParameters Parameter channel should be final. 29
 Warning misc FinalParameters Parameter session should be final. 40
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 42
 Warning coding FinalLocalVariable Variable 'md' should be declared final. 53
 Warning coding FinalLocalVariable Variable 'cooked' should be declared final. 55
 Warning misc FinalParameters Parameter raw should be final. 80
 Warning coding FinalLocalVariable Variable 'cooked' should be declared final. 82
 Warning coding FinalLocalVariable Variable 'key' should be declared final. 84
 Warning coding FinalLocalVariable Variable 'tmp' should be declared final. 85
 Warning coding FinalLocalVariable Variable 'value' should be declared final. 87
 Warning coding FinalLocalVariable Variable 'name' should be declared final. 93
 Warning misc FinalParameters Parameter s should be final. 106
 Warning coding FinalLocalVariable Variable 'csize' should be declared final. 134
 Warning coding FinalLocalVariable Variable 'i' should be declared final. 136
 Warning misc FinalParameters Parameter r should be final. 151
 Warning coding FinalLocalVariable Variable 'len' should be declared final. 155
 Warning coding FinalLocalVariable Variable 'n' should be declared final. 156
 Warning misc FinalParameters Parameter records should be final. 178
 Warning coding FinalLocalVariable Variable 'n' should be declared final. 194

emissary/parser/SimpleNioParserTest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'raf' must be private and have accessor methods. 32
 Warning coding FinalLocalVariable Variable 'sp' should be declared final. 39
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 39
 Warning coding FinalLocalVariable Variable 'sp' should be declared final. 49
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 49
 Warning coding FinalLocalVariable Variable 'sd' should be declared final. 50
 Warning coding FinalLocalVariable Variable 'sp' should be declared final. 58
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 58
 Warning coding FinalLocalVariable Variable 'sd' should be declared final. 59
 Warning coding FinalLocalVariable Variable 'DATA' should be declared final. 66
 Warning coding RequireThis Reference to instance variable 'testDataFile' needs "this.". 70
 Warning coding RequireThis Reference to instance variable 'testDataFile' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'raf' needs "this.". 77
 Warning coding RequireThis Reference to instance variable 'testDataFile' needs "this.". 77
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 78
 Warning coding RequireThis Reference to instance variable 'raf' needs "this.". 78
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 84
 Warning coding RequireThis Reference to instance variable 'channel' needs "this.". 85
 Warning coding RequireThis Reference to instance variable 'raf' needs "this.". 87
 Warning coding RequireThis Reference to instance variable 'raf' needs "this.". 88
 Warning coding RequireThis Reference to instance variable 'testDataFile' needs "this.". 90

emissary/pickup/BreakableFilePickUpClient.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'actBrokenDuringReceive' must be private and have accessor methods. 14
 Warning design VisibilityModifier Variable 'actBrokenDuringProcessing' must be private and have accessor methods. 15
 Warning design VisibilityModifier Variable 'brokenShutdownTrigger' must be private and have accessor methods. 16
 Warning misc FinalParameters Parameter configInfo should be final. 18
 Warning misc FinalParameters Parameter dir should be final. 18
 Warning misc FinalParameters Parameter placeLoc should be final. 18
 Warning misc FinalParameters Parameter configInfo should be final. 22
 Warning misc FinalParameters Parameter dir should be final. 22
 Warning misc FinalParameters Parameter placeLoc should be final. 22
 Warning misc FinalParameters Parameter value should be final. 26
 Warning coding RequireThis Reference to instance variable 'actBrokenDuringReceive' needs "this.". 27
 Warning misc FinalParameters Parameter value should be final. 30
 Warning coding RequireThis Reference to instance variable 'actBrokenDuringProcessing' needs "this.". 31
 Warning coding SimplifyBooleanExpression Expression can be simplified. 32
 Warning coding FinalLocalVariable Variable 't' should be declared final. 33
 Warning misc FinalParameters Parameter paths should be final. 40
 Warning coding FinalLocalVariable Variable 'f' should be declared final. 46
 Warning coding RequireThis Reference to instance variable 'actBrokenDuringReceive' needs "this.". 50
 Warning coding RequireThis Reference to instance variable 'actBrokenDuringProcessing' needs "this.". 61
 Warning coding FinalLocalVariable Variable 'incoming' should be declared final. 64
 Warning coding FinalLocalVariable Variable 'toProcess' should be declared final. 65
 Warning coding FinalLocalVariable Variable 'holdFile' should be declared final. 66
 Warning coding RequireThis Reference to instance variable 'brokenShutdownTrigger' needs "this.". 75
 Warning coding RequireThis Reference to instance variable 'brokenShutdownTrigger' needs "BreakableFilePickUpClient.this.". 87
 Warning coding SimplifyBooleanExpression Expression can be simplified. 87
 Warning coding RequireThis Reference to instance variable 'brokenShutdownTrigger' needs "BreakableFilePickUpClient.this.". 89

emissary/pickup/FTestFailedPickupClient.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'inarea' needs "this.". 48
 Warning coding RequireThis Reference to instance variable 'inarea' needs "this.". 49
 Warning coding RequireThis Reference to instance variable 'outarea' needs "this.". 51
 Warning coding RequireThis Reference to instance variable 'outarea' needs "this.". 52
 Warning coding RequireThis Reference to instance variable 'holdarea' needs "this.". 54
 Warning coding RequireThis Reference to instance variable 'holdarea' needs "this.". 55
 Warning coding FinalLocalVariable Variable 'testfile' should be declared final. 57
 Warning coding RequireThis Reference to instance variable 'inarea' needs "this.". 57
 Warning coding RequireThis Reference to instance variable 'workingFiles' needs "this.". 58
 Warning coding RequireThis Reference to instance variable 'workingFilePaths' needs "this.". 59
 Warning coding RequireThis Reference to instance variable 'inareadir' needs "this.". 62
 Warning coding RequireThis Reference to instance variable 'inarea' needs "this.". 62
 Warning coding RequireThis Reference to instance variable 'inareadir' needs "this.". 63
 Warning coding RequireThis Reference to instance variable 'inareadir' needs "this.". 64
 Warning coding FinalLocalVariable Variable 'testfile2' should be declared final. 65
 Warning coding RequireThis Reference to instance variable 'inareadir' needs "this.". 65
 Warning coding RequireThis Reference to instance variable 'workingFiles' needs "this.". 66
 Warning coding RequireThis Reference to instance variable 'workingFilePaths' needs "this.". 67
 Warning coding RequireThis Reference to instance variable 'peer2' needs "this.". 79
 Warning coding RequireThis Reference to instance variable 'peer2' needs "this.". 80
 Warning coding RequireThis Reference to instance variable 'peer2' needs "this.". 81
 Warning coding RequireThis Reference to instance variable 'badplace' needs "this.". 85
 Warning coding RequireThis Reference to instance variable 'badplace' needs "this.". 86
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 90
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 91
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 92
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 93
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 94
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 95
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 96
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 97
 Warning coding RequireThis Reference to instance variable 'inarea' needs "this.". 97
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 109
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 110
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 111
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 112
 Warning coding RequireThis Reference to instance variable 'goodplace' needs "this.". 115
 Warning coding RequireThis Reference to instance variable 'goodplace' needs "this.". 116
 Warning coding RequireThis Reference to instance variable 'goodplace' needs "this.". 117
 Warning coding RequireThis Reference to instance variable 'badplace' needs "this.". 120
 Warning coding RequireThis Reference to instance variable 'badplace' needs "this.". 122
 Warning coding RequireThis Reference to instance variable 'peer2' needs "this.". 125
 Warning coding RequireThis Reference to instance variable 'peer2' needs "this.". 126
 Warning coding RequireThis Reference to instance variable 'peer2' needs "this.". 127
 Warning coding RequireThis Reference to instance variable 'inareadir' needs "this.". 133
 Warning coding RequireThis Reference to instance variable 'inarea' needs "this.". 134
 Warning coding RequireThis Reference to instance variable 'outarea' needs "this.". 135
 Warning coding RequireThis Reference to instance variable 'inarea' needs "this.". 136
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 144
 Warning coding FinalLocalVariable Variable 'expectedPending' should be declared final. 153
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 156
 Warning coding FinalLocalVariable Variable 'tspacethr' should be declared final. 158
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 158
 Warning coding RequireThis Reference to instance variable 'workingFiles' needs "this.". 166
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 181
 Warning coding RequireThis Reference to instance variable 'badplace' needs "this.". 187
 Warning coding RequireThis Reference to instance variable 'peer2' needs "this.". 189
 Warning coding RequireThis Reference to instance variable 'badplace' needs "this.". 190
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 191
 Warning coding RequireThis Reference to instance variable 'badplace' needs "this.". 191
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 195
 Warning coding RequireThis Reference to instance variable 'badplace' needs "this.". 195
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 198
 Warning coding RequireThis Reference to instance variable 'goodplace' needs "this.". 205
 Warning coding RequireThis Reference to instance variable 'peer2' needs "this.". 207
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 208
 Warning coding RequireThis Reference to instance variable 'goodplace' needs "this.". 208
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 214
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 224
 Warning coding RequireThis Reference to instance variable 'workingFiles' needs "this.". 231
 Warning coding RequireThis Reference to instance variable 'workingFilePaths' needs "this.". 237
 Warning coding FinalLocalVariable Variable 'fp' should be declared final. 238
 Warning coding RequireThis Reference to instance variable 'goodplace' needs "this.". 238
 Warning coding FinalLocalVariable Variable 'fd' should be declared final. 239
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 239
 Warning misc FinalParameters Parameter space should be final. 246
 Warning misc FinalParameters Parameter files should be final. 246
 Warning misc FinalParameters Parameter bytes should be final. 246
 Warning misc FinalParameters Parameter bundles should be final. 246
 Warning misc FinalParameters Parameter places should be final. 246
 Warning misc FinalParameters Parameter outbound should be final. 246
 Warning misc FinalParameters Parameter pending should be final. 246
 Warning misc FinalParameters Parameter retried should be final. 246
 Warning modifier RedundantModifier Redundant 'public' modifier. 257
 Warning blocks RightCurly '}' at column 48 should be alone on a line. 257
 Warning misc FinalParameters Parameter key should be final. 260
 Warning misc FinalParameters Parameter key should be final. 265

emissary/pickup/FTestMultipleWorkSpaces.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'inarea1' needs "this.". 56
 Warning coding RequireThis Reference to instance variable 'inarea1' needs "this.". 57
 Warning coding RequireThis Reference to instance variable 'outarea1' needs "this.". 59
 Warning coding RequireThis Reference to instance variable 'outarea1' needs "this.". 60
 Warning coding RequireThis Reference to instance variable 'holdarea' needs "this.". 62
 Warning coding RequireThis Reference to instance variable 'holdarea' needs "this.". 63
 Warning coding FinalLocalVariable Variable 'testfile' should be declared final. 65
 Warning coding RequireThis Reference to instance variable 'inarea1' needs "this.". 65
 Warning coding RequireThis Reference to instance variable 'workingFiles' needs "this.". 66
 Warning coding RequireThis Reference to instance variable 'workingFilePaths' needs "this.". 67
 Warning coding RequireThis Reference to instance variable 'inareadir1' needs "this.". 70
 Warning coding RequireThis Reference to instance variable 'inarea1' needs "this.". 70
 Warning coding RequireThis Reference to instance variable 'inareadir1' needs "this.". 71
 Warning coding RequireThis Reference to instance variable 'inareadir1' needs "this.". 72
 Warning coding FinalLocalVariable Variable 'testfile2' should be declared final. 73
 Warning coding RequireThis Reference to instance variable 'inareadir1' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'workingFiles' needs "this.". 74
 Warning coding RequireThis Reference to instance variable 'workingFilePaths' needs "this.". 75
 Warning coding RequireThis Reference to instance variable 'inarea2' needs "this.". 84
 Warning coding RequireThis Reference to instance variable 'inarea2' needs "this.". 85
 Warning coding RequireThis Reference to instance variable 'outarea2' needs "this.". 87
 Warning coding RequireThis Reference to instance variable 'outarea2' needs "this.". 88
 Warning coding FinalLocalVariable Variable 'testfile3' should be declared final. 90
 Warning coding RequireThis Reference to instance variable 'inarea2' needs "this.". 90
 Warning coding RequireThis Reference to instance variable 'workingFiles' needs "this.". 91
 Warning coding RequireThis Reference to instance variable 'workingFilePaths' needs "this.". 92
 Warning coding RequireThis Reference to instance variable 'inareadir2' needs "this.". 95
 Warning coding RequireThis Reference to instance variable 'inarea2' needs "this.". 95
 Warning coding RequireThis Reference to instance variable 'inareadir2' needs "this.". 96
 Warning coding RequireThis Reference to instance variable 'inareadir2' needs "this.". 97
 Warning coding FinalLocalVariable Variable 'testfile4' should be declared final. 98
 Warning coding RequireThis Reference to instance variable 'inareadir2' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'workingFiles' needs "this.". 99
 Warning coding RequireThis Reference to instance variable 'workingFilePaths' needs "this.". 100
 Warning coding RequireThis Reference to instance variable 'peer2' needs "this.". 115
 Warning coding RequireThis Reference to instance variable 'peer2' needs "this.". 116
 Warning coding RequireThis Reference to instance variable 'peer2' needs "this.". 117
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 120
 Warning coding RequireThis Reference to instance variable 'space1' needs "this.". 125
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 24, expected level should be one of the following: 18, 81, 82. 127
 Warning coding RequireThis Reference to instance variable 'space1' needs "this.". 128
 Warning coding RequireThis Reference to instance variable 'space1' needs "this.". 129
 Warning coding RequireThis Reference to instance variable 'space1' needs "this.". 130
 Warning coding RequireThis Reference to instance variable 'space1' needs "this.". 131
 Warning coding RequireThis Reference to instance variable 'space1' needs "this.". 132
 Warning coding RequireThis Reference to instance variable 'space1' needs "this.". 133
 Warning coding RequireThis Reference to instance variable 'space1' needs "this.". 134
 Warning coding RequireThis Reference to instance variable 'space2' needs "this.". 137
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 24, expected level should be one of the following: 18, 81, 82. 139
 Warning coding RequireThis Reference to instance variable 'space2' needs "this.". 140
 Warning coding RequireThis Reference to instance variable 'space2' needs "this.". 141
 Warning coding RequireThis Reference to instance variable 'space2' needs "this.". 142
 Warning coding RequireThis Reference to instance variable 'space2' needs "this.". 143
 Warning coding RequireThis Reference to instance variable 'space2' needs "this.". 144
 Warning coding RequireThis Reference to instance variable 'space2' needs "this.". 145
 Warning coding RequireThis Reference to instance variable 'space2' needs "this.". 146
 Warning coding RequireThis Reference to instance variable 'space1' needs "this.". 157
 Warning coding RequireThis Reference to instance variable 'space1' needs "this.". 158
 Warning coding RequireThis Reference to instance variable 'space1' needs "this.". 159
 Warning coding RequireThis Reference to instance variable 'space1' needs "this.". 160
 Warning coding RequireThis Reference to instance variable 'space2' needs "this.". 163
 Warning coding RequireThis Reference to instance variable 'space2' needs "this.". 164
 Warning coding RequireThis Reference to instance variable 'space2' needs "this.". 165
 Warning coding RequireThis Reference to instance variable 'space2' needs "this.". 166
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 169
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 170
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 171
 Warning coding RequireThis Reference to instance variable 'peer2' needs "this.". 174
 Warning coding RequireThis Reference to instance variable 'peer2' needs "this.". 175
 Warning coding RequireThis Reference to instance variable 'peer2' needs "this.". 176
 Warning coding RequireThis Reference to instance variable 'inareadir1' needs "this.". 182
 Warning coding RequireThis Reference to instance variable 'inarea1' needs "this.". 183
 Warning coding RequireThis Reference to instance variable 'outarea1' needs "this.". 184
 Warning coding RequireThis Reference to instance variable 'inarea1' needs "this.". 185
 Warning coding RequireThis Reference to instance variable 'inareadir2' needs "this.". 186
 Warning coding RequireThis Reference to instance variable 'inarea2' needs "this.". 187
 Warning coding RequireThis Reference to instance variable 'outarea2' needs "this.". 188
 Warning coding RequireThis Reference to instance variable 'inarea2' needs "this.". 189
 Warning coding FinalLocalVariable Variable 'clientCount' should be declared final. 207
 Warning coding FinalLocalVariable Variable 'expectedOutbound' should be declared final. 208
 Warning coding FinalLocalVariable Variable 'expectedPending' should be declared final. 209
 Warning coding FinalLocalVariable Variable 'expectedRetries' should be declared final. 210
 Warning coding RequireThis Reference to instance variable 'space1' needs "this.". 212
 Warning coding RequireThis Reference to instance variable 'space2' needs "this.". 213
 Warning coding FinalLocalVariable Variable 'tspacethr1' should be declared final. 215
 Warning coding RequireThis Reference to instance variable 'space1' needs "this.". 215
 Warning coding FinalLocalVariable Variable 'tspacethr2' should be declared final. 219
 Warning coding RequireThis Reference to instance variable 'space2' needs "this.". 219
 Warning coding RequireThis Reference to instance variable 'space1' needs "this.". 233
 Warning coding RequireThis Reference to instance variable 'space2' needs "this.". 234
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 244
 Warning coding RequireThis Reference to instance variable 'workingFiles' needs "this.". 251
 Warning coding RequireThis Reference to instance variable 'workingFilePaths' needs "this.". 257
 Warning coding FinalLocalVariable Variable 'fp' should be declared final. 258
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 258
 Warning coding FinalLocalVariable Variable 'fd1' should be declared final. 259
 Warning coding RequireThis Reference to instance variable 'space1' needs "this.". 259
 Warning coding FinalLocalVariable Variable 'fd2' should be declared final. 260
 Warning coding RequireThis Reference to instance variable 'space2' needs "this.". 260
 Warning misc FinalParameters Parameter space should be final. 269
 Warning misc FinalParameters Parameter files should be final. 269
 Warning misc FinalParameters Parameter bytes should be final. 269
 Warning misc FinalParameters Parameter bundles should be final. 269
 Warning misc FinalParameters Parameter places should be final. 269
 Warning misc FinalParameters Parameter outbound should be final. 269
 Warning misc FinalParameters Parameter pending should be final. 269
 Warning misc FinalParameters Parameter retried should be final. 269

emissary/pickup/FTestWorkSpaceMaxBundleSize.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'inarea1' needs "this.". 45
 Warning coding RequireThis Reference to instance variable 'inarea1' needs "this.". 46
 Warning coding RequireThis Reference to instance variable 'outarea1' needs "this.". 48
 Warning coding RequireThis Reference to instance variable 'outarea1' needs "this.". 49
 Warning coding RequireThis Reference to instance variable 'holdarea' needs "this.". 51
 Warning coding RequireThis Reference to instance variable 'holdarea' needs "this.". 52
 Warning coding FinalLocalVariable Variable 'testfile' should be declared final. 54
 Warning coding RequireThis Reference to instance variable 'inarea1' needs "this.". 54
 Warning coding RequireThis Reference to instance variable 'workingFiles' needs "this.". 55
 Warning coding RequireThis Reference to instance variable 'workingFilePaths' needs "this.". 56
 Warning coding RequireThis Reference to instance variable 'inareadir1' needs "this.". 59
 Warning coding RequireThis Reference to instance variable 'inarea1' needs "this.". 59
 Warning coding RequireThis Reference to instance variable 'inareadir1' needs "this.". 60
 Warning coding RequireThis Reference to instance variable 'inareadir1' needs "this.". 61
 Warning coding FinalLocalVariable Variable 'testfile2' should be declared final. 62
 Warning coding RequireThis Reference to instance variable 'inareadir1' needs "this.". 62
 Warning coding RequireThis Reference to instance variable 'workingFiles' needs "this.". 63
 Warning coding RequireThis Reference to instance variable 'workingFilePaths' needs "this.". 64
 Warning coding FinalLocalVariable Variable 'testfile3' should be declared final. 66
 Warning coding RequireThis Reference to instance variable 'inarea1' needs "this.". 66
 Warning coding RequireThis Reference to instance variable 'workingFiles' needs "this.". 67
 Warning coding RequireThis Reference to instance variable 'workingFilePaths' needs "this.". 68
 Warning coding RequireThis Reference to instance variable 'peer' needs "this.". 85
 Warning coding RequireThis Reference to instance variable 'peer' needs "this.". 86
 Warning coding RequireThis Reference to instance variable 'peer' needs "this.". 87
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 96
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 97
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'inarea1' needs "this.". 104
 Warning coding RequireThis Reference to instance variable 'outarea1' needs "this.". 105
 Warning misc FinalParameters Parameter namespace should be final. 110
 Warning misc FinalParameters Parameter maxCount should be final. 110
 Warning misc FinalParameters Parameter maxBytes should be final. 110
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 112
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 24, expected level should be one of the following: 18, 83, 84. 114
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 115
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 116
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 117
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 118
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 119
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 120
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 121
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 122
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 123
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 127
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 128
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 129
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 130
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 130
 Warning misc FinalParameters Parameter threadName should be final. 135
 Warning coding FinalLocalVariable Variable 'tspacethr' should be declared final. 137
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 137
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 152
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 152
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 153
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 153
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 154
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 154
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 155
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 155
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 165
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 165
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 166
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 166
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 167
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 167
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 168
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 168
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 178
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 178
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 179
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 179
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 180
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 180
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 181
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 181
 Warning modifier RedundantModifier Redundant 'public' modifier. 188
 Warning modifier RedundantModifier Redundant 'public' modifier. 192
 Warning misc FinalParameters Parameter command should be final. 192
 Warning misc FinalParameters Parameter value should be final. 196
 Warning misc FinalParameters Parameter value should be final. 200

emissary/pickup/IPickUpPlace.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'package' should be separated from previous line. 4

emissary/pickup/PickUpPlace.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'minimumContentLength' must be private and have accessor methods. 52
 Warning design VisibilityModifier Variable 'maximumContentLength' must be private and have accessor methods. 53
 Warning design VisibilityModifier Variable 'oversizeArea' must be private and have accessor methods. 54
 Warning design VisibilityModifier Variable 'holdingArea' must be private and have accessor methods. 57
 Warning design VisibilityModifier Variable 'errorArea' must be private and have accessor methods. 60
 Warning design VisibilityModifier Variable 'doneArea' must be private and have accessor methods. 64
 Warning design VisibilityModifier Variable 'parserFactory' must be private and have accessor methods. 67
 Warning design VisibilityModifier Variable 'simpleMode' must be private and have accessor methods. 71
 Warning design VisibilityModifier Variable 'agentPool' must be private and have accessor methods. 74
 Warning design VisibilityModifier Variable 'initialFormValues' must be private and have accessor methods. 77
 Warning design VisibilityModifier Variable 'alwaysCopyMetadataVals' must be private and have accessor methods. 80
 Warning design VisibilityModifier Variable 'useObjectTraceLogger' must be private and have accessor methods. 82
 Warning misc FinalParameters Parameter configStream should be final. 89
 Warning misc FinalParameters Parameter configInfo should be final. 101
 Warning misc FinalParameters Parameter placeLocation should be final. 101
 Warning misc FinalParameters Parameter configInfo should be final. 114
 Warning misc FinalParameters Parameter dir should be final. 114
 Warning misc FinalParameters Parameter placeLoc should be final. 114
 Warning misc FinalParameters Parameter configStream should be final. 127
 Warning misc FinalParameters Parameter dir should be final. 127
 Warning misc FinalParameters Parameter placeLoc should be final. 127
 Warning misc FinalParameters Parameter configStream should be final. 139
 Warning misc FinalParameters Parameter placeLoc should be final. 139
 Warning coding RequireThis Reference to instance variable 'minimumContentLength' needs "this.". 158
 Warning coding RequireThis Reference to instance variable 'minimumContentLength' needs "this.". 158
 Warning coding RequireThis Reference to instance variable 'maximumContentLength' needs "this.". 159
 Warning coding RequireThis Reference to instance variable 'maximumContentLength' needs "this.". 159
 Warning coding RequireThis Reference to instance variable 'oversizeArea' needs "this.". 160
 Warning coding RequireThis Reference to instance variable 'oversizeArea' needs "this.". 160
 Warning coding RequireThis Reference to instance variable 'simpleMode' needs "this.". 162
 Warning coding RequireThis Reference to instance variable 'holdingArea' needs "this.". 163
 Warning coding RequireThis Reference to instance variable 'doneArea' needs "this.". 164
 Warning coding RequireThis Reference to instance variable 'doneArea' needs "this.". 164
 Warning coding RequireThis Reference to instance variable 'errorArea' needs "this.". 165
 Warning coding RequireThis Reference to instance variable 'doneArea' needs "this.". 167
 Warning coding RequireThis Reference to instance variable 'doneArea' needs "this.". 167
 Warning coding EqualsAvoidNull String literal expressions should be on the left side of an equals comparison. 167
 Warning coding RequireThis Reference to instance variable 'doneArea' needs "this.". 168
 Warning coding RequireThis Reference to instance variable 'holdingArea' needs "this.". 172
 Warning coding RequireThis Reference to instance variable 'doneArea' needs "this.". 172
 Warning coding RequireThis Reference to instance variable 'errorArea' needs "this.". 172
 Warning coding RequireThis Reference to instance variable 'initialFormValues' needs "this.". 174
 Warning coding RequireThis Reference to instance variable 'initialFormValues' needs "this.". 175
 Warning coding RequireThis Reference to instance variable 'initialFormValues' needs "this.". 176
 Warning coding RequireThis Reference to instance variable 'agentPool' needs "this.". 181
 Warning coding RequireThis Reference to instance variable 'alwaysCopyMetadataVals' needs "this.". 186
 Warning coding RequireThis Reference to instance variable 'useObjectTraceLogger' needs "this.". 189
 Warning coding RequireThis Reference to instance variable 'useObjectTraceLogger' needs "this.". 189
 Warning coding RequireThis Reference to instance variable 'holdingArea' needs "this.". 199
 Warning coding RequireThis Reference to instance variable 'errorArea' needs "this.". 209
 Warning coding RequireThis Reference to instance variable 'doneArea' needs "this.". 219
 Warning coding RequireThis Reference to instance variable 'maximumContentLength' needs "this.". 229
 Warning coding RequireThis Reference to instance variable 'minimumContentLength' needs "this.". 239
 Warning coding RequireThis Reference to instance variable 'oversizeArea' needs "this.". 250
 Warning misc FinalParameters Parameter d should be final. 259
 Warning misc FinalParameters Parameter f should be final. 259
 Warning misc FinalParameters Parameter f should be final. 272
 Warning coding RequireThis Reference to instance variable 'maximumContentLength' needs "this.". 274
 Warning coding RequireThis Reference to instance variable 'maximumContentLength' needs "this.". 274
 Warning coding RequireThis Reference to instance variable 'maximumContentLength' needs "this.". 275
 Warning coding FinalLocalVariable Variable 'fixedName' should be declared final. 280
 Warning coding RequireThis Reference to instance variable 'simpleMode' needs "this.". 281
 Warning misc FinalParameters Parameter theFile should be final. 295
 Warning misc FinalParameters Parameter fixedName should be final. 295
 Warning misc FinalParameters Parameter isOversize should be final. 295
 Warning misc FinalParameters Parameter simpleMode should be final. 295
 Warning coding HiddenField 'simpleMode' hides a field. 295
 Warning misc FinalParameters Parameter outputRoot should be final. 295
 Warning coding RequireThis Reference to instance variable 'useObjectTraceLogger' needs "this.". 300
 Warning misc FinalParameters Parameter theFile should be final. 342
 Warning misc FinalParameters Parameter fixedName should be final. 342
 Warning misc FinalParameters Parameter simpleMode should be final. 342
 Warning coding HiddenField 'simpleMode' hides a field. 342
 Warning coding FinalLocalVariable Variable 'dataObject' should be declared final. 344
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 24, expected level should be one of the following: 18, 60, 61. 346
 Warning misc FinalParameters Parameter theFile should be final. 362
 Warning misc FinalParameters Parameter fixedName should be final. 362
 Warning coding FinalLocalVariable Variable 'theContent' should be declared final. 363
 Warning misc FinalParameters Parameter theFile should be final. 373
 Warning misc FinalParameters Parameter theFile should be final. 384
 Warning misc FinalParameters Parameter outputRoot should be final. 384
 Warning coding RequireThis Reference to instance variable 'holdingArea' needs "this.". 387
 Warning coding RequireThis Reference to instance variable 'holdingArea' needs "this.". 388
 Warning coding FinalLocalVariable Variable 'dest' should be declared final. 392
 Warning misc FinalParameters Parameter theFile should be final. 412
 Warning misc FinalParameters Parameter eatPrefix should be final. 412
 Warning coding RequireThis Reference to instance variable 'holdingArea' needs "this.". 419
 Warning coding RequireThis Reference to instance variable 'holdingArea' needs "this.". 420
 Warning misc FinalParameters Parameter source should be final. 432
 Warning misc FinalParameters Parameter dest should be final. 432
 Warning coding RequireThis Reference to instance variable 'holdingArea' needs "this.". 433
 Warning coding ParameterAssignment Assignment of parameter 'dest' is not allowed. 439
 Warning coding FinalLocalVariable Variable 'renamed' should be declared final. 444
 Warning misc FinalParameters Parameter theFile should be final. 460
 Warning coding FinalLocalVariable Variable 'renamed' should be declared final. 461
 Warning coding RequireThis Reference to instance variable 'errorArea' needs "this.". 461
 Warning misc FinalParameters Parameter theFile should be final. 475
 Warning coding FinalLocalVariable Variable 'deleted' should be declared final. 476
 Warning misc FinalParameters Parameter theFile should be final. 489
 Warning misc FinalParameters Parameter theFile should be final. 499
 Warning misc FinalParameters Parameter outputRoot should be final. 499
 Warning coding RequireThis Reference to instance variable 'holdingArea' needs "this.". 503
 Warning misc FinalParameters Parameter theFile should be final. 516
 Warning coding RequireThis Reference to instance variable 'errorArea' needs "this.". 517
 Warning misc FinalParameters Parameter theContent should be final. 534
 Warning misc FinalParameters Parameter fixedName should be final. 534
 Warning misc FinalParameters Parameter theFile should be final. 534
 Warning misc FinalParameters Parameter simpleMode should be final. 534
 Warning coding HiddenField 'simpleMode' hides a field. 534
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 535
 Warning misc FinalParameters Parameter d should be final. 548
 Warning misc FinalParameters Parameter fixedName should be final. 548
 Warning misc FinalParameters Parameter theFile should be final. 548
 Warning misc FinalParameters Parameter simpleMode should be final. 548
 Warning coding HiddenField 'simpleMode' hides a field. 548
 Warning coding FinalLocalVariable Variable 'currentForm' should be declared final. 549
 Warning coding RequireThis Reference to instance variable 'initialFormValues' needs "this.". 552
 Warning coding RequireThis Reference to instance variable 'initialFormValues' needs "this.". 553
 Warning misc FinalParameters Parameter theFile should be final. 576
 Warning misc FinalParameters Parameter fixedName should be final. 576
 Warning coding FinalLocalVariable Variable 'sp' should be declared final. 584
 Warning coding RequireThis Reference to instance variable 'parserFactory' needs "this.". 584
 Warning coding FinalLocalVariable Variable 'dof' should be declared final. 588
 Warning coding FinalLocalVariable Variable 'fileStart' should be declared final. 590
 Warning coding FinalLocalVariable Variable 'sessionStart' should be declared final. 596
 Warning coding FinalLocalVariable Variable 'sessionName' should be declared final. 599
 Warning coding FinalLocalVariable Variable 'dataObject' should be declared final. 601
 Warning coding FinalLocalVariable Variable 'sessionEnd' should be declared final. 604
 Warning coding FinalLocalVariable Variable 'fileEnd' should be declared final. 612
 Warning misc FinalParameters Parameter data should be final. 633
 Warning misc FinalParameters Parameter fixedName should be final. 633
 Warning misc FinalParameters Parameter theFile should be final. 633
 Warning coding FinalLocalVariable Variable 'sp' should be declared final. 640
 Warning coding RequireThis Reference to instance variable 'parserFactory' needs "this.". 640
 Warning coding FinalLocalVariable Variable 'dof' should be declared final. 643
 Warning coding FinalLocalVariable Variable 'sessionName' should be declared final. 650
 Warning coding FinalLocalVariable Variable 'dataObject' should be declared final. 652
 Warning misc FinalParameters Parameter v should be final. 673
 Warning misc FinalParameters Parameter payload should be final. 700
 Warning misc FinalParameters Parameter timeoutMs should be final. 700
 Warning coding RequireThis Reference to instance variable 'agentPool' needs "this.". 701
 Warning misc FinalParameters Parameter payload should be final. 717
 Warning misc FinalParameters Parameter agentPool should be final. 717
 Warning misc FinalParameters Parameter startingLocation should be final. 717
 Warning misc FinalParameters Parameter timeoutMs should be final. 718
 Warning coding FinalLocalVariable Variable 'startTime' should be declared final. 720
 Warning coding ParameterAssignment Assignment of parameter 'agentPool' is not allowed. 728
 Warning blocks RightCurly '}' at column 13 should be alone on a line. 741
 Warning misc FinalParameters Parameter clazz should be final. 758

emissary/pickup/PickUpSpace.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'openSpaceNames' must be private and have accessor methods. 18
 Warning design VisibilityModifier Variable 'numConsecutiveTakeErrors' must be private and have accessor methods. 21
 Warning design VisibilityModifier Variable 'tpa' must be private and have accessor methods. 24
 Warning design VisibilityModifier Variable 'lastBundleSize' must be private and have accessor methods. 27
 Warning design VisibilityModifier Variable 'pendingBundles' must be private and have accessor methods. 30
 Warning misc FinalParameters Parameter configInfo should be final. 49
 Warning misc FinalParameters Parameter dir should be final. 49
 Warning misc FinalParameters Parameter placeLocation should be final. 49
 Warning misc FinalParameters Parameter configInfo should be final. 59
 Warning misc FinalParameters Parameter placeLocation should be final. 59
 Warning misc FinalParameters Parameter configInfo should be final. 63
 Warning misc FinalParameters Parameter configStream should be final. 74
 Warning misc FinalParameters Parameter theDir should be final. 74
 Warning misc FinalParameters Parameter thePlaceLocation should be final. 74
 Warning misc FinalParameters Parameter spaceName should be final. 84
 Warning coding RequireThis Reference to instance variable 'openSpaceNames' needs "this.". 85
 Warning coding RequireThis Reference to instance variable 'openSpaceNames' needs "this.". 88
 Warning coding RequireThis Reference to instance variable 'numConsecutiveTakeErrors' needs "this.". 89
 Warning coding RequireThis Reference to instance variable 'lastBundleSize' needs "this.". 90
 Warning coding RequireThis Reference to instance variable 'openSpaceNames' needs "this.". 91
 Warning misc FinalParameters Parameter spaceName should be final. 99
 Warning coding RequireThis Reference to instance variable 'openSpaceNames' needs "this.". 101
 Warning coding RequireThis Reference to instance variable 'lastBundleSize' needs "this.". 102
 Warning coding RequireThis Reference to instance variable 'numConsecutiveTakeErrors' needs "this.". 103
 Warning coding RequireThis Reference to instance variable 'openSpaceNames' needs "this.". 113
 Warning coding RequireThis Reference to instance variable 'openSpaceNames' needs "this.". 114
 Warning coding RequireThis Reference to instance variable 'openSpaceNames' needs "this.". 125
 Warning coding RequireThis Reference to instance variable 'openSpaceNames' needs "this.". 133
 Warning coding RequireThis Reference to instance variable 'openSpaceNames' needs "this.". 144
 Warning coding FinalLocalVariable Variable 'closers' should be declared final. 150
 Warning coding RequireThis Reference to instance variable 'openSpaceNames' needs "this.". 154
 Warning coding RequireThis Reference to instance variable 'tpa' needs "this.". 157
 Warning coding RequireThis Reference to instance variable 'numConsecutiveTakeErrors' needs "this.". 165
 Warning coding RequireThis Reference to instance variable 'numConsecutiveTakeErrors' needs "this.". 165
 Warning coding RequireThis Reference to instance variable 'lastBundleSize' needs "this.". 171
 Warning coding RequireThis Reference to instance variable 'numConsecutiveTakeErrors' needs "this.". 172
 Warning coding RequireThis Reference to instance variable 'pendingBundles' needs "this.". 173
 Warning misc FinalParameters Parameter forceClosers should be final. 190
 Warning coding FinalLocalVariable Variable 'closers' should be declared final. 191
 Warning coding RequireThis Reference to instance variable 'openSpaceNames' needs "this.". 192
 Warning coding RequireThis Reference to instance variable 'openSpaceNames' needs "this.". 204
 Warning misc FinalParameters Parameter bundleId should be final. 215
 Warning misc FinalParameters Parameter itWorked should be final. 215
 Warning coding FinalLocalVariable Variable 'openSpaceName' should be declared final. 216
 Warning coding RequireThis Reference to instance variable 'pendingBundles' needs "this.". 216
 Warning coding RequireThis Reference to instance variable 'pendingBundles' needs "this.". 220
 Warning coding RequireThis Reference to instance variable 'tpa' needs "this.". 221
 Warning misc FinalParameters Parameter spaceName should be final. 229
 Warning coding RequireThis Reference to instance variable 'numConsecutiveTakeErrors' needs "this.". 230
 Warning misc FinalParameters Parameter spaceName should be final. 237
 Warning coding RequireThis Reference to instance variable 'lastBundleSize' needs "this.". 238

emissary/pickup/PickupQueue.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'queue' must be private and have accessor methods. 15
 Warning blocks RightCurly '}' at column 27 should be alone on a line. 32
 Warning misc FinalParameters Parameter maxSize should be final. 39
 Warning coding RequireThis Reference to instance variable 'maxQueSize' needs "this.". 40
 Warning misc FinalParameters Parameter paths should be final. 49
 Warning coding RequireThis Reference to instance variable 'queue' needs "this.". 55
 Warning coding RequireThis Reference to instance variable 'queue' needs "this.". 57
 Warning coding RequireThis Reference to instance variable 'queue' needs "this.". 58
 Warning coding RequireThis Reference to instance variable 'queue' needs "this.". 83
 Warning coding RequireThis Reference to instance variable 'queue' needs "this.". 84
 Warning coding RequireThis Reference to instance variable 'queue' needs "this.". 97
 Warning coding RequireThis Reference to instance variable 'queue' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'queue' needs "this.". 100
 Warning misc FinalParameters Parameter num should be final. 111
 Warning coding RequireThis Reference to instance variable 'maxQueSize' needs "this.". 112

emissary/pickup/PickupQueueTest.java

Severity Category Rule Message Line
 Warning coding VariableDeclarationUsageDistance Distance between variable 'p' declaration and its first usage is 7, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 22
 Warning coding FinalLocalVariable Variable 'p' should be declared final. 22
 Warning coding FinalLocalVariable Variable 'w1' should be declared final. 23
 Warning coding FinalLocalVariable Variable 'w2' should be declared final. 25
 Warning coding FinalLocalVariable Variable 'w3' should be declared final. 27
 Warning coding FinalLocalVariable Variable 'w4' should be declared final. 29
 Warning coding FinalLocalVariable Variable 'dq1' should be declared final. 47
 Warning coding FinalLocalVariable Variable 'wb5' should be declared final. 54
 Warning coding FinalLocalVariable Variable 'p' should be declared final. 62
 Warning coding FinalLocalVariable Variable 'p' should be declared final. 69
 Warning coding FinalLocalVariable Variable 'pqt' should be declared final. 70
 Warning coding FinalLocalVariable Variable 't' should be declared final. 71
 Warning blocks EmptyCatchBlock Empty catch block. 76
 Warning coding FinalLocalVariable Variable 'wb' should be declared final. 78
 Warning blocks EmptyCatchBlock Empty catch block. 83
 Warning coding FinalLocalVariable Variable 'hitCount' should be declared final. 85
 Warning design VisibilityModifier Variable 'pq' must be private and have accessor methods. 92
 Warning design VisibilityModifier Variable 'hitcount' must be private and have accessor methods. 93
 Warning design VisibilityModifier Variable 'timeToQuit' must be private and have accessor methods. 94
 Warning modifier RedundantModifier Redundant 'public' modifier. 96
 Warning misc FinalParameters Parameter p should be final. 96
 Warning coding RequireThis Reference to instance variable 'hitcount' needs "this.". 101
 Warning coding RequireThis Reference to instance variable 'timeToQuit' needs "this.". 106
 Warning coding RequireThis Reference to instance variable 'pq' needs "this.". 107
 Warning coding RequireThis Reference to instance variable 'pq' needs "this.". 109
 Warning coding RequireThis Reference to instance variable 'hitcount' needs "this.". 110

emissary/pickup/Priority.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 25 should be alone on a line. 7

emissary/pickup/PriorityDirectory.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'directoryName' must be private and have accessor methods. 7
 Warning design VisibilityModifier Variable 'priority' must be private and have accessor methods. 8
 Warning blocks RightCurly '}' at column 33 should be alone on a line. 10
 Warning misc FinalParameters Parameter directoryName should be final. 12
 Warning misc FinalParameters Parameter priority should be final. 12
 Warning misc FinalParameters Parameter val should be final. 17
 Warning coding RequireThis Reference to instance variable 'priority' needs "this.". 22
 Warning misc FinalParameters Parameter val should be final. 25
 Warning coding RequireThis Reference to instance variable 'directoryName' needs "this.". 30
 Warning misc FinalParameters Parameter that should be final. 38
 Warning coding RequireThis Reference to instance variable 'directoryName' needs "this.". 50
 Warning coding RequireThis Reference to instance variable 'priority' needs "this.". 50

emissary/pickup/QueServer.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'pollingInterval' must be private and have accessor methods. 20
 Warning design VisibilityModifier Variable 'timeToShutdown' must be private and have accessor methods. 23
 Warning design VisibilityModifier Variable 'queue' must be private and have accessor methods. 26
 Warning design VisibilityModifier Variable 'space' must be private and have accessor methods. 29
 Warning misc FinalParameters Parameter space should be final. 37
 Warning misc FinalParameters Parameter queue should be final. 37
 Warning misc FinalParameters Parameter space should be final. 48
 Warning misc FinalParameters Parameter queue should be final. 48
 Warning misc FinalParameters Parameter pollingInterval should be final. 48
 Warning misc FinalParameters Parameter space should be final. 61
 Warning misc FinalParameters Parameter queue should be final. 61
 Warning misc FinalParameters Parameter pollingInterval should be final. 61
 Warning misc FinalParameters Parameter name should be final. 61
 Warning coding RequireThis Reference to instance variable 'timeToShutdown' needs "this.". 76
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 87
 Warning coding RequireThis Reference to instance variable 'queue' needs "this.". 87
 Warning coding FinalLocalVariable Variable 'status' should be declared final. 90
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 90
 Warning coding RequireThis Reference to instance variable 'pollingInterval' needs "this.". 93
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 102
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 102
 Warning coding RequireThis Reference to instance variable 'queue' needs "this.". 103
 Warning coding RequireThis Reference to instance variable 'queue' needs "this.". 105
 Warning coding RequireThis Reference to instance variable 'queue' needs "this.". 106
 Warning coding RequireThis Reference to instance variable 'pollingInterval' needs "this.". 106
 Warning coding RequireThis Reference to instance variable 'queue' needs "this.". 122
 Warning coding FinalLocalVariable Variable 'status' should be declared final. 131
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 133
 Warning coding FinalLocalVariable Variable 'fnb' should be declared final. 135
 Warning coding FinalLocalVariable Variable 'fn' should be declared final. 138
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 143
 Warning coding RequireThis Reference to instance variable 'queue' needs "this.". 149
 Warning coding RequireThis Reference to instance variable 'queue' needs "this.". 175
 Warning misc FinalParameters Parameter bundle should be final. 184
 Warning coding RequireThis Reference to instance variable 'queue' needs "this.". 185

emissary/pickup/QueServerTest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'tepusConfigStream' must be private and have accessor methods. 19
 Warning coding FinalLocalVariable Variable 'cdata' should be declared final. 24
 Warning coding RequireThis Reference to instance variable 'tepusConfigStream' needs "this.". 28
 Warning coding FinalLocalVariable Variable 'w1' should be declared final. 34
 Warning coding FinalLocalVariable Variable 'w2' should be declared final. 36
 Warning coding FinalLocalVariable Variable 'w3' should be declared final. 38
 Warning coding FinalLocalVariable Variable 'w4' should be declared final. 40
 Warning coding RequireThis Reference to instance variable 'tepusConfigStream' needs "this.". 60
 Warning design VisibilityModifier Variable 'bundlesReceived' must be private and have accessor methods. 76
 Warning design VisibilityModifier Variable 'filesReceived' must be private and have accessor methods. 77
 Warning modifier RedundantModifier Redundant 'public' modifier. 79
 Warning misc FinalParameters Parameter space should be final. 79
 Warning misc FinalParameters Parameter queue should be final. 79
 Warning modifier RedundantModifier Redundant 'public' modifier. 83
 Warning misc FinalParameters Parameter space should be final. 83
 Warning misc FinalParameters Parameter queue should be final. 83
 Warning misc FinalParameters Parameter pollingInterval should be final. 83
 Warning modifier RedundantModifier Redundant 'public' modifier. 87
 Warning misc FinalParameters Parameter space should be final. 87
 Warning misc FinalParameters Parameter queue should be final. 87
 Warning misc FinalParameters Parameter pollingInterval should be final. 87
 Warning misc FinalParameters Parameter name should be final. 87
 Warning misc FinalParameters Parameter bundle should be final. 92
 Warning coding RequireThis Reference to instance variable 'bundlesReceived' needs "this.". 93
 Warning coding RequireThis Reference to instance variable 'filesReceived' needs "this.". 94
 Warning design VisibilityModifier Variable 'queServer' must be private and have accessor methods. 100
 Warning design VisibilityModifier Variable 'queue' must be private and have accessor methods. 101
 Warning design VisibilityModifier Variable 'expectedErrors' must be private and have accessor methods. 102
 Warning design VisibilityModifier Variable 'numErrors' must be private and have accessor methods. 103
 Warning design VisibilityModifier Variable 'expectedBundles' must be private and have accessor methods. 104
 Warning design VisibilityModifier Variable 'numBundles' must be private and have accessor methods. 105
 Warning design VisibilityModifier Variable 'bundleCompletedCount' must be private and have accessor methods. 106
 Warning design VisibilityModifier Variable 'bundleFailedCount' must be private and have accessor methods. 107
 Warning modifier RedundantModifier Redundant 'public' modifier. 109
 Warning misc FinalParameters Parameter errors should be final. 109
 Warning misc FinalParameters Parameter bundles should be final. 109
 Warning coding RequireThis Reference to instance variable 'tepusConfigStream' needs "QueServerTest.this.". 110
 Warning coding RequireThis Reference to instance variable 'queue' needs "this.". 113
 Warning coding RequireThis Reference to instance variable 'queServer' needs "this.". 114
 Warning coding RequireThis Reference to instance variable 'queue' needs "this.". 114
 Warning coding RequireThis Reference to instance variable 'queServer' needs "this.". 115
 Warning misc FinalParameters Parameter path should be final. 119
 Warning coding RequireThis Reference to instance variable 'queue' needs "this.". 120
 Warning coding RequireThis Reference to instance variable 'queue' needs "this.". 126
 Warning coding RequireThis Reference to instance variable 'numErrors' needs "this.". 131
 Warning coding RequireThis Reference to instance variable 'expectedErrors' needs "this.". 131
 Warning coding RequireThis Reference to instance variable 'numBundles' needs "this.". 131
 Warning coding RequireThis Reference to instance variable 'expectedBundles' needs "this.". 131
 Warning coding RequireThis Reference to instance variable 'numBundles' needs "this.". 134
 Warning coding FinalLocalVariable Variable 'w' should be declared final. 135
 Warning misc FinalParameters Parameter bundleId should be final. 142
 Warning misc FinalParameters Parameter itWorked should be final. 142
 Warning coding RequireThis Reference to instance variable 'bundleCompletedCount' needs "this.". 144
 Warning coding RequireThis Reference to instance variable 'bundleFailedCount' needs "this.". 146
 Warning coding RequireThis Reference to instance variable 'queServer' needs "this.". 152

emissary/pickup/WorkBundle.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'bundleId' must be private and have accessor methods. 35
 Warning design VisibilityModifier Variable 'outputRoot' must be private and have accessor methods. 38
 Warning design VisibilityModifier Variable 'eatPrefix' must be private and have accessor methods. 41
 Warning design VisibilityModifier Variable 'caseId' must be private and have accessor methods. 45
 Warning design VisibilityModifier Variable 'priority' must be private and have accessor methods. 48
 Warning design VisibilityModifier Variable 'simpleMode' must be private and have accessor methods. 51
 Warning design VisibilityModifier Variable 'workUnitList' must be private and have accessor methods. 53
 Warning design VisibilityModifier Variable 'sentTo' must be private and have accessor methods. 56
 Warning design VisibilityModifier Variable 'errorCount' must be private and have accessor methods. 59
 Warning design VisibilityModifier Variable 'oldestFileModificationTime' must be private and have accessor methods. 64
 Warning design VisibilityModifier Variable 'youngestFileModificationTime' must be private and have accessor methods. 69
 Warning design VisibilityModifier Variable 'totalFileSize' must be private and have accessor methods. 72
 Warning coding RequireThis Reference to instance variable 'bundleId' needs "this.". 78
 Warning misc FinalParameters Parameter outputRoot should be final. 87
 Warning misc FinalParameters Parameter eatPrefix should be final. 87
 Warning coding RequireThis Reference to instance variable 'bundleId' needs "this.". 88
 Warning misc FinalParameters Parameter that should be final. 99
 Warning misc FinalParameters Parameter in should be final. 125
 Warning coding FinalLocalVariable Variable 'wb' should be declared final. 126
 Warning coding FinalLocalVariable Variable 'workUnitSize' should be declared final. 138
 Warning misc FinalParameters Parameter out should be final. 155
 Warning coding RequireThis Reference to instance variable 'bundleId' needs "this.". 156
 Warning coding RequireThis Reference to instance variable 'outputRoot' needs "this.". 157
 Warning coding RequireThis Reference to instance variable 'eatPrefix' needs "this.". 158
 Warning coding RequireThis Reference to instance variable 'caseId' needs "this.". 159
 Warning coding RequireThis Reference to instance variable 'sentTo' needs "this.". 160
 Warning coding RequireThis Reference to instance variable 'errorCount' needs "this.". 161
 Warning coding RequireThis Reference to instance variable 'priority' needs "this.". 162
 Warning coding RequireThis Reference to instance variable 'simpleMode' needs "this.". 163
 Warning coding RequireThis Reference to instance variable 'oldestFileModificationTime' needs "this.". 164
 Warning coding RequireThis Reference to instance variable 'youngestFileModificationTime' needs "this.". 165
 Warning coding RequireThis Reference to instance variable 'totalFileSize' needs "this.". 166
 Warning coding RequireThis Reference to instance variable 'workUnitList' needs "this.". 167
 Warning coding RequireThis Reference to instance variable 'workUnitList' needs "this.". 168
 Warning coding RequireThis Reference to instance variable 'workUnitList' needs "this.". 170
 Warning coding RequireThis Reference to instance variable 'workUnitList' needs "this.". 172
 Warning misc FinalParameters Parameter in should be final. 178
 Warning misc FinalParameters Parameter s should be final. 185
 Warning misc FinalParameters Parameter out should be final. 185
 Warning misc FinalParameters Parameter val should be final. 197
 Warning coding RequireThis Reference to instance variable 'bundleId' needs "this.". 207
 Warning coding RequireThis Reference to instance variable 'bundleId' needs "this.". 208
 Warning coding RequireThis Reference to instance variable 'bundleId' needs "this.". 215
 Warning misc FinalParameters Parameter argOutputRoot should be final. 241
 Warning misc FinalParameters Parameter argEatPrefix should be final. 259
 Warning coding RequireThis Reference to instance variable 'workUnitList' needs "this.". 269
 Warning coding RequireThis Reference to instance variable 'workUnitList' needs "this.". 278
 Warning misc FinalParameters Parameter workUnit should be final. 289
 Warning coding RequireThis Reference to instance variable 'workUnitList' needs "this.". 290
 Warning coding RequireThis Reference to instance variable 'workUnitList' needs "this.". 293
 Warning javadoc AtclauseOrder Block tags have to appear in the order '[@param, @return, @throws, @deprecated]'. 305
 Warning misc FinalParameters Parameter workUnit should be final. 307
 Warning misc FinalParameters Parameter fileModificationTimeInMillis should be final. 307
 Warning misc FinalParameters Parameter fileSize should be final. 307
 Warning coding RequireThis Reference to instance variable 'oldestFileModificationTime' needs "this.". 310
 Warning coding RequireThis Reference to instance variable 'oldestFileModificationTime' needs "this.". 311
 Warning coding RequireThis Reference to instance variable 'youngestFileModificationTime' needs "this.". 313
 Warning coding RequireThis Reference to instance variable 'youngestFileModificationTime' needs "this.". 314
 Warning coding RequireThis Reference to instance variable 'totalFileSize' needs "this.". 316
 Warning misc FinalParameters Parameter list should be final. 328
 Warning coding RequireThis Reference to instance variable 'workUnitList' needs "this.". 329
 Warning coding RequireThis Reference to instance variable 'workUnitList' needs "this.". 332
 Warning coding RequireThis Reference to instance variable 'workUnitList' needs "this.". 333
 Warning coding FinalLocalVariable Variable 'fileNameList' should be declared final. 342
 Warning coding RequireThis Reference to instance variable 'workUnitList' needs "this.". 342
 Warning coding RequireThis Reference to instance variable 'workUnitList' needs "this.". 343
 Warning misc FinalParameters Parameter file should be final. 367
 Warning misc FinalParameters Parameter file should be final. 381
 Warning misc FinalParameters Parameter fileModificationTimeInMillis should be final. 381
 Warning misc FinalParameters Parameter fileSize should be final. 381
 Warning misc FinalParameters Parameter file should be final. 393
 Warning misc FinalParameters Parameter list should be final. 407
 Warning coding RequireThis Reference to instance variable 'workUnitList' needs "this.". 419
 Warning coding RequireThis Reference to instance variable 'workUnitList' needs "this.". 427
 Warning coding RequireThis Reference to instance variable 'oldestFileModificationTime' needs "this.". 428
 Warning coding RequireThis Reference to instance variable 'youngestFileModificationTime' needs "this.". 429
 Warning coding RequireThis Reference to instance variable 'totalFileSize' needs "this.". 430
 Warning misc FinalParameters Parameter argCaseId should be final. 447
 Warning misc FinalParameters Parameter place should be final. 454
 Warning coding RequireThis Reference to instance variable 'sentTo' needs "this.". 462
 Warning coding RequireThis Reference to instance variable 'errorCount' needs "this.". 469
 Warning coding RequireThis Reference to instance variable 'errorCount' needs "this.". 478
 Warning misc FinalParameters Parameter val should be final. 484
 Warning coding RequireThis Reference to instance variable 'errorCount' needs "this.". 485
 Warning misc FinalParameters Parameter val should be final. 491
 Warning coding RequireThis Reference to instance variable 'priority' needs "this.". 492
 Warning coding RequireThis Reference to instance variable 'priority' needs "this.". 499
 Warning misc FinalParameters Parameter val should be final. 507
 Warning coding RequireThis Reference to instance variable 'simpleMode' needs "this.". 508
 Warning coding RequireThis Reference to instance variable 'simpleMode' needs "this.". 515
 Warning coding RequireThis Reference to instance variable 'oldestFileModificationTime' needs "this.". 519
 Warning misc FinalParameters Parameter oldestFileModificationTime should be final. 522
 Warning coding HiddenField 'oldestFileModificationTime' hides a field. 522
 Warning coding RequireThis Reference to instance variable 'youngestFileModificationTime' needs "this.". 527
 Warning misc FinalParameters Parameter youngestFileModificationTime should be final. 530
 Warning coding HiddenField 'youngestFileModificationTime' hides a field. 530
 Warning coding RequireThis Reference to instance variable 'totalFileSize' needs "this.". 535
 Warning misc FinalParameters Parameter totalFileSize should be final. 538
 Warning coding HiddenField 'totalFileSize' hides a field. 538
 Warning misc FinalParameters Parameter that should be final. 547
 Warning coding FinalLocalVariable Variable 'root' should be declared final. 570
 Warning coding RequireThis Reference to instance variable 'workUnitList' needs "this.". 583
 Warning coding FinalLocalVariable Variable 'workunit' should be declared final. 584
 Warning coding FinalLocalVariable Variable 'jdom' should be declared final. 595
 Warning misc FinalParameters Parameter xml should be final. 606
 Warning coding FinalLocalVariable Variable 'jdoc' should be declared final. 607
 Warning misc FinalParameters Parameter jdom should be final. 624
 Warning coding FinalLocalVariable Variable 'root' should be declared final. 625
 Warning coding FinalLocalVariable Variable 'wb' should be declared final. 631
 Warning coding FinalLocalVariable Variable 'serr' should be declared final. 666
 Warning coding FinalLocalVariable Variable 'filename' should be declared final. 672
 Warning coding FinalLocalVariable Variable 'transactionId' should be declared final. 673
 Warning coding FinalLocalVariable Variable 'failedToParse' should be declared final. 674
 Warning coding FinalLocalVariable Variable 'failedToProcess' should be declared final. 675

emissary/pickup/WorkBundleTest.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter w1 should be final. 27
 Warning misc FinalParameters Parameter w2 should be final. 27
 Warning coding FinalLocalVariable Variable 'matchFileNames' should be declared final. 28
 Warning coding FinalLocalVariable Variable 'matchTxid' should be declared final. 36
 Warning coding FinalLocalVariable Variable 'w1' should be declared final. 49
 Warning coding FinalLocalVariable Variable 'w2' should be declared final. 62
 Warning coding FinalLocalVariable Variable 'xml' should be declared final. 66
 Warning coding FinalLocalVariable Variable 'w3' should be declared final. 69
 Warning coding FinalLocalVariable Variable 'w1' should be declared final. 80
 Warning coding FinalLocalVariable Variable 'w2' should be declared final. 81
 Warning coding FinalLocalVariable Variable 'w3' should be declared final. 84
 Warning coding FinalLocalVariable Variable 'w4' should be declared final. 112
 Warning coding FinalLocalVariable Variable 'oldbid' should be declared final. 123
 Warning coding FinalLocalVariable Variable 'w5' should be declared final. 130
 Warning coding FinalLocalVariable Variable 'w' should be declared final. 138
 Warning coding FinalLocalVariable Variable 'w2' should be declared final. 152
 Warning coding FinalLocalVariable Variable 'w2l' should be declared final. 163
 Warning coding FinalLocalVariable Variable 'w' should be declared final. 172
 Warning coding FinalLocalVariable Variable 'w2' should be declared final. 187
 Warning coding FinalLocalVariable Variable 'w2l' should be declared final. 197
 Warning coding FinalLocalVariable Variable 'w' should be declared final. 206
 Warning coding FinalLocalVariable Variable 'w2' should be declared final. 219
 Warning coding FinalLocalVariable Variable 'w1' should be declared final. 228
 Warning coding FinalLocalVariable Variable 'w2' should be declared final. 229
 Warning coding FinalLocalVariable Variable 'w' should be declared final. 238
 Warning coding FinalLocalVariable Variable 'w1' should be declared final. 247
 Warning coding FinalLocalVariable Variable 'bout' should be declared final. 251
 Warning coding FinalLocalVariable Variable 'out' should be declared final. 252
 Warning coding FinalLocalVariable Variable 'b' should be declared final. 257
 Warning coding FinalLocalVariable Variable 'bin' should be declared final. 259
 Warning coding FinalLocalVariable Variable 'in' should be declared final. 260
 Warning coding FinalLocalVariable Variable 'w2' should be declared final. 261
 Warning coding FinalLocalVariable Variable 'fileName' should be declared final. 271
 Warning coding FinalLocalVariable Variable 'wb' should be declared final. 276
 Warning coding FinalLocalVariable Variable 'bout' should be declared final. 286
 Warning coding FinalLocalVariable Variable 'out' should be declared final. 287
 Warning coding FinalLocalVariable Variable 'wb1' should be declared final. 288
 Warning coding FinalLocalVariable Variable 'fileName' should be declared final. 292

emissary/pickup/WorkSpace.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'feedCommand' must be private and have accessor methods. 61
 Warning design VisibilityModifier Variable 'pups' must be private and have accessor methods. 66
 Warning design VisibilityModifier Variable 'pattern' must be private and have accessor methods. 71
 Warning design VisibilityModifier Variable 'watcher' must be private and have accessor methods. 74
 Warning design VisibilityModifier Variable 'wantDirectories' must be private and have accessor methods. 78
 Warning design VisibilityModifier Variable 'debug' must be private and have accessor methods. 79
 Warning design VisibilityModifier Variable 'simpleMode' must be private and have accessor methods. 80
 Warning design VisibilityModifier Variable 'outputRootPath' must be private and have accessor methods. 81
 Warning design VisibilityModifier Variable 'eatPrefix' must be private and have accessor methods. 82
 Warning design VisibilityModifier Variable 'numberOfBundlesToSkip' must be private and have accessor methods. 83
 Warning design VisibilityModifier Variable 'skipDotFiles' must be private and have accessor methods. 84
 Warning design VisibilityModifier Variable 'loop' must be private and have accessor methods. 85
 Warning design VisibilityModifier Variable 'useRetryStrategy' must be private and have accessor methods. 86
 Warning design VisibilityModifier Variable 'myDirectories' must be private and have accessor methods. 88
 Warning design VisibilityModifier Variable 'stats' must be private and have accessor methods. 91
 Warning design VisibilityModifier Variable 'notifier' must be private and have accessor methods. 95
 Warning design VisibilityModifier Variable 'timeToQuit' must be private and have accessor methods. 98
 Warning design VisibilityModifier Variable 'collectorThreadHasQuit' must be private and have accessor methods. 99
 Warning design VisibilityModifier Variable 'jettyStartedHere' must be private and have accessor methods. 100
 Warning design VisibilityModifier Variable 'loopPauseTime' must be private and have accessor methods. 102
 Warning design VisibilityModifier Variable 'pendingHangTime' must be private and have accessor methods. 103
 Warning design VisibilityModifier Variable 'retryCount' must be private and have accessor methods. 105
 Warning design VisibilityModifier Variable 'useFileTimestamps' must be private and have accessor methods. 106
 Warning design VisibilityModifier Variable 'projectBase' must be private and have accessor methods. 108
 Warning design VisibilityModifier Variable 'filesPerMessage' must be private and have accessor methods. 114
 Warning design VisibilityModifier Variable 'maxBundleSize' must be private and have accessor methods. 116
 Warning design VisibilityModifier Variable 'filesProcessed' must be private and have accessor methods. 119
 Warning design VisibilityModifier Variable 'bundlesProcessed' must be private and have accessor methods. 120
 Warning design VisibilityModifier Variable 'bytesProcessed' must be private and have accessor methods. 121
 Warning design VisibilityModifier Variable 'dataCaseId' must be private and have accessor methods. 124
 Warning design VisibilityModifier Variable 'caseClosed' must be private and have accessor methods. 125
 Warning design VisibilityModifier Variable 'outbound' must be private and have accessor methods. 128
 Warning design VisibilityModifier Variable 'pending' must be private and have accessor methods. 133
 Warning design VisibilityModifier Variable 'filesSeen' must be private and have accessor methods. 137
 Warning design VisibilityModifier Variable 'filesDone' must be private and have accessor methods. 138
 Warning design VisibilityModifier Variable 'QLOCK' must be private and have accessor methods. 143
 Warning design VisibilityModifier Variable 'workSpaceName' must be private and have accessor methods. 147
 Warning design VisibilityModifier Variable 'workSpaceUrl' must be private and have accessor methods. 149
 Warning design VisibilityModifier Variable 'workSpaceKey' must be private and have accessor methods. 150
 Warning misc FinalParameters Parameter feedCommand should be final. 175
 Warning coding FinalLocalVariable Variable 'args' should be declared final. 206
 Warning coding RequireThis Reference to instance variable 'projectBase' needs "this.". 208
 Warning coding FinalLocalVariable Variable 'cmd' should be declared final. 228
 Warning coding FinalLocalVariable Variable 'server' should be declared final. 229
 Warning coding HiddenField 'pendingHangTime' hides a field. 320
 Warning coding FinalLocalVariable Variable 'item' should be declared final. 727
 Warning coding FinalLocalVariable Variable 'sz' should be declared final. 761
 Warning coding FinalLocalVariable Variable 'item' should be declared final. 829
 Warning blocks RightCurly '}' at column 34 should be alone on a line. 1077
 Warning design VisibilityModifier Variable 'myDirectory' must be private and have accessor methods. 1118
 Warning blocks RightCurly '}' at column 13 should be alone on a line. 1191
 Warning coding HiddenField 'wantDirectories' hides a field. 1202
 Warning coding FinalLocalVariable Variable 'bReturn' should be declared final. 1333
 Warning design VisibilityModifier Variable 'remoteMap' must be private and have accessor methods. 1378
 Warning design VisibilityModifier Variable 'shutDownSent' must be private and have accessor methods. 1379

emissary/pickup/WorkSpaceTest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'mws' must be private and have accessor methods. 20
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 27
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 37
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 39
 Warning coding FinalLocalVariable Variable 'C1' should be declared final. 44
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 45
 Warning coding FinalLocalVariable Variable 'wb' should be declared final. 49
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 52
 Warning coding FinalLocalVariable Variable 'wb' should be declared final. 56
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 59
 Warning coding FinalLocalVariable Variable 'taken' should be declared final. 62
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 62
 Warning coding FinalLocalVariable Variable 'args' should be declared final. 72
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 73
 Warning coding FinalLocalVariable Variable 'C1' should be declared final. 75
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 76
 Warning coding FinalLocalVariable Variable 'times' should be declared final. 78
 Warning coding FinalLocalVariable Variable 'wb' should be declared final. 81
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 84
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 91
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 92
 Warning coding FinalLocalVariable Variable 'args' should be declared final. 108
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 109
 Warning coding FinalLocalVariable Variable 'C1' should be declared final. 111
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 112
 Warning coding FinalLocalVariable Variable 'times' should be declared final. 114
 Warning coding FinalLocalVariable Variable 'wb' should be declared final. 117
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 120
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 127
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 128
 Warning coding FinalLocalVariable Variable 'args' should be declared final. 144
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 145
 Warning coding FinalLocalVariable Variable 'C1' should be declared final. 147
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 148
 Warning coding FinalLocalVariable Variable 'times' should be declared final. 150
 Warning coding FinalLocalVariable Variable 'wb' should be declared final. 153
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 156
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 163
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 164
 Warning coding FinalLocalVariable Variable 'args' should be declared final. 180
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 181
 Warning coding FinalLocalVariable Variable 'C1' should be declared final. 183
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 184
 Warning coding FinalLocalVariable Variable 'times' should be declared final. 186
 Warning coding FinalLocalVariable Variable 'wb' should be declared final. 189
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 192
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 198
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 199
 Warning coding FinalLocalVariable Variable 'args' should be declared final. 215
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 216
 Warning coding FinalLocalVariable Variable 'C1' should be declared final. 218
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 219
 Warning coding FinalLocalVariable Variable 'sizes' should be declared final. 221
 Warning coding FinalLocalVariable Variable 'wb' should be declared final. 224
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 227
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 234
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 235
 Warning coding FinalLocalVariable Variable 'args' should be declared final. 251
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 252
 Warning coding FinalLocalVariable Variable 'C1' should be declared final. 254
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 255
 Warning coding FinalLocalVariable Variable 'sizes' should be declared final. 257
 Warning coding FinalLocalVariable Variable 'wb' should be declared final. 260
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 263
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 269
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 270
 Warning coding FinalLocalVariable Variable 'args' should be declared final. 286
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 287
 Warning coding FinalLocalVariable Variable 'C1' should be declared final. 289
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 290
 Warning coding FinalLocalVariable Variable 'sizes' should be declared final. 292
 Warning coding FinalLocalVariable Variable 'wb' should be declared final. 295
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 298
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 305
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 306
 Warning coding FinalLocalVariable Variable 'args' should be declared final. 322
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 323
 Warning coding FinalLocalVariable Variable 'C1' should be declared final. 325
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 326
 Warning coding FinalLocalVariable Variable 'sizes' should be declared final. 328
 Warning coding FinalLocalVariable Variable 'wb' should be declared final. 331
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 334
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 340
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 341
 Warning coding FinalLocalVariable Variable 'C1' should be declared final. 353
 Warning coding FinalLocalVariable Variable 'C2' should be declared final. 354
 Warning coding FinalLocalVariable Variable 'C3' should be declared final. 355
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 358
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 359
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 360
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 361
 Warning coding FinalLocalVariable Variable 'wb' should be declared final. 364
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 368
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 369
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 370
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 371
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 372
 Warning coding FinalLocalVariable Variable 'taken' should be declared final. 375
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 375
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 379
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 380
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 381
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 382
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 385
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 386
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 389
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 390
 Warning coding RequireThis Reference to instance variable 'mws' needs "this.". 391
 Warning coding FinalLocalVariable Variable 'args' should be declared final. 396
 Warning coding FinalLocalVariable Variable 'command' should be declared final. 402
 Warning coding FinalLocalVariable Variable 'mws' should be declared final. 403
 Warning coding HiddenField 'mws' hides a field. 403
 Warning modifier RedundantModifier Redundant 'public' modifier. 410
 Warning blocks RightCurly '}' at column 48 should be alone on a line. 410
 Warning modifier RedundantModifier Redundant 'public' modifier. 412
 Warning misc FinalParameters Parameter command should be final. 412
 Warning misc FinalParameters Parameter pup should be final. 417
 Warning misc FinalParameters Parameter pup should be final. 422
 Warning misc FinalParameters Parameter wb should be final. 427
 Warning misc FinalParameters Parameter pup should be final. 443

emissary/pickup/WorkUnit.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter fileName should be final. 24
 Warning misc FinalParameters Parameter fileName should be final. 37
 Warning misc FinalParameters Parameter transactionId should be final. 37
 Warning misc FinalParameters Parameter failedToParse should be final. 37
 Warning misc FinalParameters Parameter failedToProcess should be final. 37
 Warning misc FinalParameters Parameter in should be final. 44
 Warning misc FinalParameters Parameter out should be final. 53
 Warning coding RequireThis Reference to instance variable 'fileName' needs "this.". 54
 Warning coding RequireThis Reference to instance variable 'transactionId' needs "this.". 55
 Warning coding RequireThis Reference to instance variable 'failedToParse' needs "this.". 56
 Warning coding RequireThis Reference to instance variable 'failedToProcess' needs "this.". 57
 Warning coding RequireThis Reference to instance variable 'fileName' needs "this.". 66
 Warning misc FinalParameters Parameter fileName should be final. 74
 Warning coding HiddenField 'fileName' hides a field. 74
 Warning coding RequireThis Reference to instance variable 'transactionId' needs "this.". 84
 Warning misc FinalParameters Parameter transactionId should be final. 92
 Warning coding HiddenField 'transactionId' hides a field. 92
 Warning coding RequireThis Reference to instance variable 'failedToParse' needs "this.". 109
 Warning coding RequireThis Reference to instance variable 'failedToProcess' needs "this.". 125

emissary/pickup/WorkUnitTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'workUnit' should be declared final. 15
 Warning coding FinalLocalVariable Variable 'workUnit' should be declared final. 24
 Warning coding FinalLocalVariable Variable 'txid' should be declared final. 25
 Warning coding FinalLocalVariable Variable 'workUnit' should be declared final. 32

emissary/pickup/file/FTestSpacePlaceInteraction.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'inarea' needs "this.". 46
 Warning coding RequireThis Reference to instance variable 'inarea' needs "this.". 47
 Warning coding RequireThis Reference to instance variable 'outarea' needs "this.". 49
 Warning coding RequireThis Reference to instance variable 'outarea' needs "this.". 50
 Warning coding FinalLocalVariable Variable 'testfile' should be declared final. 52
 Warning coding RequireThis Reference to instance variable 'inarea' needs "this.". 52
 Warning coding FinalLocalVariable Variable 'inareadir' should be declared final. 55
 Warning coding RequireThis Reference to instance variable 'inarea' needs "this.". 55
 Warning coding FinalLocalVariable Variable 'testfile2' should be declared final. 58
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 84
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 85
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 86
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 89
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 90
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 91
 Warning coding RequireThis Reference to instance variable 'inarea' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'outarea' needs "this.". 99
 Warning misc FinalParameters Parameter useFileTimestamps should be final. 103
 Warning misc FinalParameters Parameter useSimple should be final. 103
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 105
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 106
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 107
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 108
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 109
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 110
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 111
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 113
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 114
 Warning coding RequireThis Reference to instance variable 'inarea' needs "this.". 114
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 115
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 116
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 117
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 121
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 122
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 123
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 124
 Warning misc FinalParameters Parameter threadName should be final. 129
 Warning coding FinalLocalVariable Variable 'tspacethr' should be declared final. 131
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 131
 Warning coding RequireThis Reference to instance variable 'configStream' needs "this.". 141
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 142
 Warning coding RequireThis Reference to instance variable 'configStream' needs "this.". 142
 Warning coding RequireThis Reference to instance variable 'configStream' needs "this.". 151
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 152
 Warning coding RequireThis Reference to instance variable 'configStream' needs "this.". 152
 Warning coding RequireThis Reference to instance variable 'configStream' needs "this.". 161
 Warning coding FinalLocalVariable Variable 'myplace' should be declared final. 162
 Warning coding RequireThis Reference to instance variable 'configStream' needs "this.". 164
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 165
 Warning misc FinalParameters Parameter t1 should be final. 174
 Warning misc FinalParameters Parameter t2 should be final. 174
 Warning misc FinalParameters Parameter t3 should be final. 174
 Warning misc FinalParameters Parameter t4 should be final. 174
 Warning misc FinalParameters Parameter simple should be final. 174
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 177
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 178
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 179
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 183
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 184
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 186
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 187
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 191
 Warning coding FinalLocalVariable Variable 'fakeKey' should be declared final. 195
 Warning coding FinalLocalVariable Variable 'extrafile' should be declared final. 197
 Warning coding RequireThis Reference to instance variable 'inarea' needs "this.". 197
 Warning coding FinalLocalVariable Variable 'os' should be declared final. 200
 Warning coding FinalLocalVariable Variable 'extramsg' should be declared final. 201
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 207
 Warning coding FinalLocalVariable Variable 'bundle' should be declared final. 211
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 211
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 215
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 220
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 223
 Warning coding RequireThis Reference to instance variable 'configStream' needs "this.". 229
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 230
 Warning coding RequireThis Reference to instance variable 'configStream' needs "this.". 230
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 233
 Warning coding RequireThis Reference to instance variable 'space' needs "this.". 238
 Warning blocks RightCurly '}' at column 9 should be alone on a line. 242
 Warning design VisibilityModifier Variable 'expectSimple' must be private and have accessor methods. 250
 Warning design VisibilityModifier Variable 'expectationsMetCount' must be private and have accessor methods. 251
 Warning design VisibilityModifier Variable 'expectationsNotMetCount' must be private and have accessor methods. 252
 Warning modifier RedundantModifier Redundant 'public' modifier. 254
 Warning misc FinalParameters Parameter configInfo should be final. 254
 Warning misc FinalParameters Parameter dir should be final. 254
 Warning misc FinalParameters Parameter placeLoc should be final. 254
 Warning misc FinalParameters Parameter value should be final. 258
 Warning coding RequireThis Reference to instance variable 'expectSimple' needs "this.". 259
 Warning misc FinalParameters Parameter d should be final. 263
 Warning misc FinalParameters Parameter f should be final. 263
 Warning coding FinalLocalVariable Variable 'foundSimple' should be declared final. 265
 Warning coding RequireThis Reference to instance variable 'expectSimple' needs "this.". 266
 Warning coding RequireThis Reference to instance variable 'expectationsMetCount' needs "this.". 267
 Warning coding RequireThis Reference to instance variable 'expectationsNotMetCount' needs "this.". 269
 Warning coding RequireThis Reference to instance variable 'expectSimple' needs "this.". 271

emissary/pickup/file/FileDataServer.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'theDataDir' must be private and have accessor methods. 23
 Warning design VisibilityModifier Variable 'theDirectory' must be private and have accessor methods. 24
 Warning design VisibilityModifier Variable 'myParent' must be private and have accessor methods. 28
 Warning design VisibilityModifier Variable 'timeToShutdown' must be private and have accessor methods. 33
 Warning design VisibilityModifier Variable 'pollingInterval' must be private and have accessor methods. 36
 Warning design VisibilityModifier Variable 'bundleSize' must be private and have accessor methods. 39
 Warning misc FinalParameters Parameter inputDataDirectory should be final. 49
 Warning misc FinalParameters Parameter parent should be final. 49
 Warning misc FinalParameters Parameter pollingInterval should be final. 49
 Warning coding RequireThis Reference to instance variable 'myParent' needs "this.". 54
 Warning coding RequireThis Reference to instance variable 'theDataDir' needs "this.". 56
 Warning coding RequireThis Reference to instance variable 'theDirectory' needs "this.". 57
 Warning coding RequireThis Reference to instance variable 'theDirectory' needs "this.". 59
 Warning coding RequireThis Reference to instance variable 'theDirectory' needs "this.". 60
 Warning misc FinalParameters Parameter sz should be final. 74
 Warning coding RequireThis Reference to instance variable 'bundleSize' needs "this.". 75
 Warning coding RequireThis Reference to instance variable 'timeToShutdown' needs "this.". 85
 Warning coding FinalLocalVariable Variable 'holdDir' should be declared final. 91
 Warning coding RequireThis Reference to instance variable 'myParent' needs "this.". 91
 Warning coding FinalLocalVariable Variable 'errDir' should be declared final. 92
 Warning coding RequireThis Reference to instance variable 'myParent' needs "this.". 92
 Warning coding FinalLocalVariable Variable 'fileList' should be declared final. 96
 Warning coding RequireThis Reference to instance variable 'theDirectory' needs "this.". 96
 Warning design VisibilityModifier Variable 'maxFileToList' must be private and have accessor methods. 97
 Warning coding RequireThis Reference to instance variable 'bundleSize' needs "this.". 97
 Warning design VisibilityModifier Variable 'filesInList' must be private and have accessor methods. 98
 Warning misc FinalParameters Parameter dir should be final. 101
 Warning misc FinalParameters Parameter name should be final. 101
 Warning coding RequireThis Reference to instance variable 'filesInList' needs "this.". 102
 Warning coding RequireThis Reference to instance variable 'maxFileToList' needs "this.". 102
 Warning coding FinalLocalVariable Variable 'f' should be declared final. 108
 Warning coding RequireThis Reference to instance variable 'theDataDir' needs "this.". 108
 Warning coding FinalLocalVariable Variable 'newFile' should be declared final. 116
 Warning coding FinalLocalVariable Variable 'newFile' should be declared final. 136
 Warning coding RequireThis Reference to instance variable 'myParent' needs "this.". 139
 Warning coding FinalLocalVariable Variable 'renamed' should be declared final. 143
 Warning coding RequireThis Reference to instance variable 'pollingInterval' needs "this.". 158
 Warning misc FinalParameters Parameter f should be final. 172
 Warning misc FinalParameters Parameter errDir should be final. 172
 Warning coding FinalLocalVariable Variable 'n' should be declared final. 175
 Warning coding RequireThis Reference to instance variable 'timeToShutdown' needs "this.". 209

emissary/pickup/file/FilePickUpClient.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'pollingInterval' must be private and have accessor methods. 42
 Warning design VisibilityModifier Variable 'maxQueSize' must be private and have accessor methods. 43
 Warning design VisibilityModifier Variable 'queServer' must be private and have accessor methods. 44
 Warning design VisibilityModifier Variable 'currentBundle' must be private and have accessor methods. 48
 Warning design VisibilityModifier Variable 'currentWorkUnit' must be private and have accessor methods. 50
 Warning design VisibilityModifier Variable 'unixInRoot' must be private and have accessor methods. 52
 Warning design VisibilityModifier Variable 'unixOutRoot' must be private and have accessor methods. 53
 Warning design VisibilityModifier Variable 'digestHashType' must be private and have accessor methods. 54
 Warning design VisibilityModifier Variable 'digest' must be private and have accessor methods. 57
 Warning misc FinalParameters Parameter configInfo should be final. 71
 Warning misc FinalParameters Parameter dir should be final. 71
 Warning misc FinalParameters Parameter placeLoc should be final. 71
 Warning misc FinalParameters Parameter configInfo should be final. 80
 Warning misc FinalParameters Parameter dir should be final. 80
 Warning misc FinalParameters Parameter placeLoc should be final. 80
 Warning misc FinalParameters Parameter configInfo should be final. 86
 Warning coding RequireThis Reference to instance variable 'pollingInterval' needs "this.". 96
 Warning coding RequireThis Reference to instance variable 'pollingInterval' needs "this.". 96
 Warning coding RequireThis Reference to instance variable 'maxQueSize' needs "this.". 97
 Warning coding RequireThis Reference to instance variable 'maxQueSize' needs "this.". 97
 Warning coding RequireThis Reference to instance variable 'unixInRoot' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'unixOutRoot' needs "this.". 99
 Warning coding RequireThis Reference to instance variable 'digestHashType' needs "this.". 100
 Warning coding RequireThis Reference to instance variable 'digest' needs "this.". 103
 Warning coding RequireThis Reference to instance variable 'digestHashType' needs "this.". 103
 Warning coding RequireThis Reference to instance variable 'queServer' needs "this.". 110
 Warning coding RequireThis Reference to instance variable 'maxQueSize' needs "this.". 110
 Warning coding RequireThis Reference to instance variable 'pollingInterval' needs "this.". 110
 Warning coding RequireThis Reference to instance variable 'queServer' needs "this.". 111
 Warning coding RequireThis Reference to instance variable 'queServer' needs "this.". 120
 Warning coding RequireThis Reference to instance variable 'queServer' needs "this.". 122
 Warning coding RequireThis Reference to instance variable 'queServer' needs "this.". 132
 Warning coding RequireThis Reference to instance variable 'queServer' needs "this.". 133
 Warning coding RequireThis Reference to instance variable 'queServer' needs "this.". 141
 Warning coding RequireThis Reference to instance variable 'queServer' needs "this.". 142
 Warning coding RequireThis Reference to instance variable 'queServer' needs "this.". 152
 Warning misc FinalParameters Parameter path should be final. 162
 Warning misc FinalParameters Parameter f should be final. 170
 Warning misc FinalParameters Parameter eatPrefix should be final. 170
 Warning coding FinalLocalVariable Variable 'hf' should be declared final. 178
 Warning misc FinalParameters Parameter d should be final. 189
 Warning coding FinalLocalVariable Variable 'hdf' should be declared final. 193
 Warning misc FinalParameters Parameter paths should be final. 210
 Warning coding RequireThis Reference to instance variable 'currentBundle' needs "this.". 212
 Warning coding FinalLocalVariable Variable 'outputRoot' should be declared final. 213
 Warning coding FinalLocalVariable Variable 'opath' should be declared final. 221
 Warning coding ModifiedControlVariable Control variable 'path' is modified. 222
 Warning coding FinalLocalVariable Variable 'fixedName' should be declared final. 224
 Warning coding FinalLocalVariable Variable 'holdFile' should be declared final. 230
 Warning misc FinalParameters Parameter toProcess should be final. 308
 Warning misc FinalParameters Parameter fixedName should be final. 308
 Warning misc FinalParameters Parameter isOversize should be final. 308
 Warning misc FinalParameters Parameter simpleMode should be final. 308
 Warning misc FinalParameters Parameter e should be final. 308
 Warning coding FinalLocalVariable Variable 'errDir' should be declared final. 317
 Warning misc FinalParameters Parameter paths should be final. 337
 Warning coding RequireThis Reference to instance variable 'queServer' needs "this.". 338
 Warning coding RequireThis Reference to instance variable 'queServer' needs "this.". 348
 Warning misc FinalParameters Parameter space should be final. 355
 Warning misc FinalParameters Parameter queue should be final. 355
 Warning misc FinalParameters Parameter pollingInterval should be final. 355
 Warning misc FinalParameters Parameter path should be final. 365
 Warning misc FinalParameters Parameter d should be final. 377
 Warning misc FinalParameters Parameter f should be final. 377
 Warning coding FinalLocalVariable Variable 'eatPrefix' should be declared final. 380
 Warning coding RequireThis Reference to instance variable 'currentBundle' needs "this.". 380
 Warning coding RequireThis Reference to instance variable 'currentBundle' needs "this.". 381
 Warning coding VariableDeclarationUsageDistance Distance between variable 'simpleParam' declaration and its first usage is 6, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 382
 Warning coding FinalLocalVariable Variable 'simpleParam' should be declared final. 382
 Warning coding RequireThis Reference to instance variable 'currentBundle' needs "this.". 391
 Warning coding FinalLocalVariable Variable 'ep' should be declared final. 394
 Warning coding RequireThis Reference to instance variable 'currentBundle' needs "this.". 394
 Warning coding FinalLocalVariable Variable 'cid' should be declared final. 408
 Warning coding RequireThis Reference to instance variable 'currentBundle' needs "this.". 408
 Warning coding FinalLocalVariable Variable 'parts' should be declared final. 410
 Warning coding RequireThis Reference to instance variable 'digest' needs "this.". 415
 Warning coding FinalLocalVariable Variable 'hash' should be declared final. 419
 Warning misc FinalParameters Parameter filePath should be final. 441
 Warning misc FinalParameters Parameter prefix should be final. 441
 Warning coding FinalLocalVariable Variable 'hash' should be declared final. 445
 Warning misc FinalParameters Parameter initialCaseId should be final. 460
 Warning misc FinalParameters Parameter sessionName should be final. 460
 Warning misc FinalParameters Parameter fileName should be final. 460
 Warning misc FinalParameters Parameter metadata should be final. 460
 Warning misc FinalParameters Parameter root should be final. 474
 Warning misc FinalParameters Parameter prefix should be final. 474
 Warning misc FinalParameters Parameter caseid should be final. 474
 Warning misc FinalParameters Parameter dir should be final. 474
 Warning misc FinalParameters Parameter simpleMode should be final. 474

emissary/pickup/file/FilePickUpClientTest.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 41
 Warning coding FinalLocalVariable Variable 'clientConfig' should be declared final. 42
 Warning coding RequireThis Reference to instance variable 'client' needs "this.". 43
 Warning coding RequireThis Reference to instance variable 'bundle' needs "this.". 45
 Warning coding RequireThis Reference to instance variable 'client' needs "this.". 46
 Warning coding RequireThis Reference to instance variable 'bundle' needs "this.". 46
 Warning coding RequireThis Reference to instance variable 'client' needs "this.". 51
 Warning coding RequireThis Reference to instance variable 'client' needs "this.". 52
 Warning coding RequireThis Reference to instance variable 'client' needs "this.". 53
 Warning coding RequireThis Reference to instance variable 'bundle' needs "this.". 55
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 56
 Warning coding RequireThis Reference to instance variable 'client' needs "this.". 62
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 62
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 63
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 64
 Warning coding RequireThis Reference to instance variable 'bundle' needs "this.". 65
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 65
 Warning coding RequireThis Reference to instance variable 'bundle' needs "this.". 70
 Warning coding RequireThis Reference to instance variable 'client' needs "this.". 71
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 71
 Warning coding RequireThis Reference to instance variable 'bundle' needs "this.". 72
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 72
 Warning coding VariableDeclarationUsageDistance Distance between variable 'originalShortName' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 77
 Warning coding FinalLocalVariable Variable 'originalShortName' should be declared final. 77
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 77
 Warning coding RequireThis Reference to instance variable 'bundle' needs "this.". 78
 Warning coding RequireThis Reference to instance variable 'client' needs "this.". 79
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 79
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 80
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 81
 Warning coding RequireThis Reference to instance variable 'bundle' needs "this.". 86
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 87
 Warning coding RequireThis Reference to instance variable 'client' needs "this.". 88
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 88
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 89
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 90
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 91
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 92
 Warning coding RequireThis Reference to instance variable 'bundle' needs "this.". 97
 Warning coding RequireThis Reference to instance variable 'client' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'client' needs "this.". 99
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 99
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 101
 Warning coding FinalLocalVariable Variable 'filePath' should be declared final. 108
 Warning coding FinalLocalVariable Variable 'digest' should be declared final. 109
 Warning coding FinalLocalVariable Variable 'resultHash' should be declared final. 111
 Warning coding FinalLocalVariable Variable 'resultString' should be declared final. 112
 Warning coding RequireThis Reference to instance variable 'client' needs "this.". 115
 Warning coding RequireThis Reference to instance variable 'bundle' needs "this.". 118
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 119
 Warning coding RequireThis Reference to instance variable 'client' needs "this.". 120
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 120
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 121
 Warning design VisibilityModifier Variable 'nullifyCaseIdInHook' must be private and have accessor methods. 126
 Warning modifier RedundantModifier Redundant 'public' modifier. 128
 Warning misc FinalParameters Parameter configInfo should be final. 128
 Warning misc FinalParameters Parameter dir should be final. 128
 Warning misc FinalParameters Parameter placeLoc should be final. 128
 Warning misc FinalParameters Parameter d should be final. 133
 Warning misc FinalParameters Parameter f should be final. 133
 Warning misc FinalParameters Parameter wb should be final. 137
 Warning misc FinalParameters Parameter initialCaseId should be final. 147
 Warning misc FinalParameters Parameter sessionname should be final. 147
 Warning misc FinalParameters Parameter fileName should be final. 147
 Warning misc FinalParameters Parameter metadata should be final. 147
 Warning coding RequireThis Reference to instance variable 'nullifyCaseIdInHook' needs "this.". 148

emissary/pickup/file/FilePickUpPlace.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'pollingInterval' must be private and have accessor methods. 16
 Warning design VisibilityModifier Variable 'theDataServer' must be private and have accessor methods. 19
 Warning design VisibilityModifier Variable 'bundleSize' must be private and have accessor methods. 23
 Warning design VisibilityModifier Variable 'inputDataDirs' must be private and have accessor methods. 26
 Warning misc FinalParameters Parameter configInfo should be final. 40
 Warning misc FinalParameters Parameter dir should be final. 40
 Warning misc FinalParameters Parameter placeLoc should be final. 40
 Warning coding RequireThis Reference to instance variable 'pollingInterval' needs "this.". 56
 Warning coding RequireThis Reference to instance variable 'pollingInterval' needs "this.". 56
 Warning coding RequireThis Reference to instance variable 'bundleSize' needs "this.". 57
 Warning coding FinalLocalVariable Variable 'params' should be declared final. 58
 Warning coding RequireThis Reference to instance variable 'inputDataDirs' needs "this.". 59
 Warning coding RequireThis Reference to instance variable 'theDataServer' needs "this.". 67
 Warning coding RequireThis Reference to instance variable 'theDataServer' needs "this.". 79
 Warning coding RequireThis Reference to instance variable 'theDataServer' needs "this.". 90
 Warning coding RequireThis Reference to instance variable 'theDataServer' needs "this.". 104
 Warning coding RequireThis Reference to instance variable 'inputDataDirs' needs "this.". 117
 Warning coding FinalLocalVariable Variable 'fds' should be declared final. 118
 Warning coding RequireThis Reference to instance variable 'inputDataDirs' needs "this.". 118
 Warning coding RequireThis Reference to instance variable 'pollingInterval' needs "this.". 118
 Warning coding RequireThis Reference to instance variable 'bundleSize' needs "this.". 121
 Warning coding RequireThis Reference to instance variable 'theDataServer' needs "this.". 130

emissary/place/ComparisonPlace.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'loggingIdentifier' needs "this.". 67
 Warning coding RequireThis Reference to instance variable 'loggingIdentifier' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'placeA' needs "this.". 75
 Warning coding RequireThis Reference to instance variable 'placeB' needs "this.". 76
 Warning coding RequireThis Reference to instance variable 'placeA' needs "this.". 78
 Warning coding RequireThis Reference to instance variable 'placeB' needs "this.". 79
 Warning coding RequireThis Reference to instance variable 'placeA' needs "this.". 81
 Warning coding RequireThis Reference to instance variable 'placeB' needs "this.". 81
 Warning coding RequireThis Reference to instance variable 'placeA' needs "this.". 90
 Warning coding RequireThis Reference to instance variable 'placeA' needs "this.". 91
 Warning coding RequireThis Reference to instance variable 'placeB' needs "this.". 92
 Warning coding RequireThis Reference to instance variable 'placeA' needs "this.". 97
 Warning coding RequireThis Reference to instance variable 'placeB' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'loggingIdentifier' needs "this.". 101
 Warning coding HiddenField 'loggingIdentifier' hides a field. 122

emissary/place/ComparisonPlaceTest.java

Severity Category Rule Message Line
 Warning whitespace OperatorWrap '+' should be on a new line. 81
 Warning whitespace OperatorWrap '+' should be on a new line. 89

emissary/place/ComparisonPlaceTestProcessHDPlace.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter configFile should be final. 17
 Warning misc FinalParameters Parameter theDir should be final. 17
 Warning misc FinalParameters Parameter thePlaceLocation should be final. 17
 Warning coding RequireThis Reference to instance variable 'metadataKeyValueMap' needs "this.". 20
 Warning misc FinalParameters Parameter ibdo should be final. 24
 Warning coding RequireThis Reference to instance variable 'metadataKeyValueMap' needs "this.". 28

emissary/place/ComparisonPlaceTestProcessPlace.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter configFile should be final. 14
 Warning misc FinalParameters Parameter theDir should be final. 14
 Warning misc FinalParameters Parameter thePlaceLocation should be final. 14
 Warning coding RequireThis Reference to instance variable 'metadataKeyValueMap' needs "this.". 17
 Warning misc FinalParameters Parameter ibdo should be final. 21
 Warning coding RequireThis Reference to instance variable 'metadataKeyValueMap' needs "this.". 22

emissary/place/CoordinationPlace.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'placeKeys' must be private and have accessor methods. 40
 Warning design VisibilityModifier Variable 'placeRefs' must be private and have accessor methods. 43
 Warning design VisibilityModifier Variable 'outputForm' must be private and have accessor methods. 47
 Warning design VisibilityModifier Variable 'pushForm' must be private and have accessor methods. 48
 Warning design VisibilityModifier Variable 'updateTransformHistory' must be private and have accessor methods. 49
 Warning misc FinalParameters Parameter cfgInfo should be final. 61
 Warning misc FinalParameters Parameter dir should be final. 61
 Warning misc FinalParameters Parameter placeLoc should be final. 61
 Warning misc FinalParameters Parameter cfgInfo should be final. 71
 Warning misc FinalParameters Parameter cfgInfo should be final. 81
 Warning coding RequireThis Reference to instance variable 'outputForm' needs "this.". 106
 Warning coding RequireThis Reference to instance variable 'pushForm' needs "this.". 107
 Warning coding RequireThis Reference to instance variable 'updateTransformHistory' needs "this.". 108
 Warning coding RequireThis Reference to instance variable 'placeKeys' needs "this.". 110
 Warning coding RequireThis Reference to instance variable 'placeKeys' needs "this.". 111
 Warning coding RequireThis Reference to instance variable 'placeRefs' needs "this.". 113
 Warning coding RequireThis Reference to instance variable 'placeKeys' needs "this.". 114
 Warning coding FinalLocalVariable Variable 'ref' should be declared final. 117
 Warning coding RequireThis Reference to instance variable 'placeRefs' needs "this.". 119
 Warning coding FinalLocalVariable Variable 'skey' should be declared final. 127
 Warning coding FinalLocalVariable Variable 'sclz' should be declared final. 129
 Warning coding FinalLocalVariable Variable 'p' should be declared final. 130
 Warning coding RequireThis Reference to instance variable 'placeRefs' needs "this.". 132
 Warning misc FinalParameters Parameter d should be final. 150
 Warning misc FinalParameters Parameter p should be final. 150
 Warning misc FinalParameters Parameter p should be final. 163
 Warning misc FinalParameters Parameter errorOccurred should be final. 163
 Warning misc FinalParameters Parameter d should be final. 176
 Warning misc FinalParameters Parameter p should be final. 176
 Warning misc FinalParameters Parameter d should be final. 184
 Warning misc FinalParameters Parameter sproutCollection should be final. 191
 Warning misc FinalParameters Parameter d should be final. 191
 Warning misc FinalParameters Parameter sproutCollection should be final. 195
 Warning misc FinalParameters Parameter d should be final. 195
 Warning misc FinalParameters Parameter hd should be final. 195
 Warning misc FinalParameters Parameter d should be final. 209
 Warning misc FinalParameters Parameter hd should be final. 209
 Warning coding FinalLocalVariable Variable 'sproutCollection' should be declared final. 210
 Warning coding RequireThis Reference to instance variable 'placeRefs' needs "this.". 215
 Warning misc FinalParameters Parameter p should be final. 277
 Warning misc FinalParameters Parameter hd should be final. 277
 Warning misc FinalParameters Parameter ex should be final. 277
 Warning misc FinalParameters Parameter d should be final. 282
 Warning misc FinalParameters Parameter p should be final. 282
 Warning coding RequireThis Reference to instance variable 'updateTransformHistory' needs "this.". 283
 Warning coding FinalLocalVariable Variable 'de' should be declared final. 284
 Warning misc FinalParameters Parameter d should be final. 297
 Warning misc FinalParameters Parameter errorOccurred should be final. 297
 Warning misc FinalParameters Parameter d should be final. 320
 Warning coding RequireThis Reference to instance variable 'outputForm' needs "this.". 321
 Warning coding RequireThis Reference to instance variable 'pushForm' needs "this.". 322
 Warning coding RequireThis Reference to instance variable 'outputForm' needs "this.". 323
 Warning coding RequireThis Reference to instance variable 'outputForm' needs "this.". 327
 Warning coding RequireThis Reference to instance variable 'outputForm' needs "this.". 329
 Warning misc FinalParameters Parameter d should be final. 359
 Warning coding FinalLocalVariable Variable 'l' should be declared final. 360
 Warning misc FinalParameters Parameter d should be final. 373

emissary/place/CoordinationPlaceTest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'place' must be private and have accessor methods. 29
 Warning design VisibilityModifier Variable 'mockCoordPlace' must be private and have accessor methods. 30
 Warning coding FinalLocalVariable Variable 'configStream' should be declared final. 37
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 38
 Warning coding RequireThis Reference to instance variable 'mockCoordPlace' needs "this.". 40
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 41
 Warning coding RequireThis Reference to instance variable 'mockCoordPlace' needs "this.". 41
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 58
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 64
 Warning coding FinalLocalVariable Variable 'ibdo' should be declared final. 69
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 70
 Warning coding RequireThis Reference to instance variable 'mockCoordPlace' needs "this.". 76
 Warning coding FinalLocalVariable Variable 'ibdo' should be declared final. 79
 Warning coding FinalLocalVariable Variable 'sprouts' should be declared final. 80
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 80
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 88
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 89
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 92
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 96

emissary/place/FTestCoordinatePlace.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'configStream' should be declared final. 36
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 37
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 38
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 49
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 57
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 57
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 58
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 59
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 64
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 64
 Warning coding FinalLocalVariable Variable 'rw' should be declared final. 65
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 66
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 67
 Warning coding FinalLocalVariable Variable 'resourcesUsed' should be declared final. 68

emissary/place/FTestSkippingCoordinationPlace.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'configStream' should be declared final. 37
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 38
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 39
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 50
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 57
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 57
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 58
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 59
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 64
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 64
 Warning coding FinalLocalVariable Variable 'rw' should be declared final. 65
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 66
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 67
 Warning coding FinalLocalVariable Variable 'resourcesUsed' should be declared final. 68
 Warning modifier RedundantModifier Redundant 'public' modifier. 77
 Warning misc FinalParameters Parameter cfgInfo should be final. 77
 Warning misc FinalParameters Parameter d should be final. 82
 Warning misc FinalParameters Parameter p should be final. 82

emissary/place/IMultiFileServerPlace.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'package' should be separated from previous line. 4

emissary/place/KffHashPlace.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter thePlaceLocation should be final. 26
 Warning misc FinalParameters Parameter configFile should be final. 30
 Warning misc FinalParameters Parameter theDir should be final. 30
 Warning misc FinalParameters Parameter thePlaceLocation should be final. 30
 Warning misc FinalParameters Parameter configStream should be final. 34
 Warning misc FinalParameters Parameter theDir should be final. 34
 Warning misc FinalParameters Parameter thePlaceLocation should be final. 34
 Warning misc FinalParameters Parameter configStream should be final. 38
 Warning misc FinalParameters Parameter configFile should be final. 42
 Warning misc FinalParameters Parameter placeLocation should be final. 42
 Warning misc FinalParameters Parameter configStream should be final. 46
 Warning misc FinalParameters Parameter placeLocation should be final. 46
 Warning misc FinalParameters Parameter theDir should be final. 51
 Warning misc FinalParameters Parameter placeLocation should be final. 51
 Warning coding RequireThis Reference to instance variable 'useSbc' needs "this.". 53
 Warning coding RequireThis Reference to instance variable 'useSbc' needs "this.". 53
 Warning misc FinalParameters Parameter payload should be final. 58
 Warning coding RequireThis Reference to instance variable 'useSbc' needs "this.". 64

emissary/place/KffHashPlaceTest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'phonyData' must be private and have accessor methods. 18
 Warning modifier RedundantModifier Redundant 'public' modifier. 20
 Warning blocks RightCurly '}' at column 32 should be alone on a line. 20

emissary/place/MultiFileServerPlace.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'typeEngine' must be private and have accessor methods. 19
 Warning design VisibilityModifier Variable 'nonPropagatingMetadataValues' must be private and have accessor methods. 20
 Warning misc FinalParameters Parameter configInfo should be final. 27
 Warning misc FinalParameters Parameter dir should be final. 27
 Warning misc FinalParameters Parameter placeLoc should be final. 27
 Warning misc FinalParameters Parameter configInfo should be final. 33
 Warning misc FinalParameters Parameter placeLoc should be final. 33
 Warning misc FinalParameters Parameter configStream should be final. 38
 Warning misc FinalParameters Parameter theDir should be final. 38
 Warning misc FinalParameters Parameter thePlaceLocation should be final. 38
 Warning misc FinalParameters Parameter configStream should be final. 43
 Warning misc FinalParameters Parameter configStream should be final. 48
 Warning misc FinalParameters Parameter thePlaceLocation should be final. 48
 Warning coding RequireThis Reference to instance variable 'typeEngine' needs "this.". 60
 Warning coding RequireThis Reference to instance variable 'nonPropagatingMetadataValues' needs "this.". 61
 Warning misc FinalParameters Parameter d should be final. 80
 Warning misc FinalParameters Parameter parent should be final. 90
 Warning misc FinalParameters Parameter children should be final. 90
 Warning misc FinalParameters Parameter parent should be final. 101
 Warning misc FinalParameters Parameter children should be final. 101
 Warning misc FinalParameters Parameter nullifyFileType should be final. 101
 Warning misc FinalParameters Parameter parent should be final. 111
 Warning misc FinalParameters Parameter child should be final. 111
 Warning misc FinalParameters Parameter parent should be final. 122
 Warning misc FinalParameters Parameter child should be final. 122
 Warning misc FinalParameters Parameter nullifyFileType should be final. 122

emissary/place/MultiFileServerPlaceTest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'mfsp' must be private and have accessor methods. 27
 Warning design VisibilityModifier Variable 'parent' must be private and have accessor methods. 29
 Warning coding FinalLocalVariable Variable 'rr' should be declared final. 35
 Warning coding RequireThis Reference to instance variable 'mfsp' needs "this.". 37
 Warning coding RequireThis Reference to instance variable 'parent' needs "this.". 41
 Warning coding RequireThis Reference to instance variable 'mfsp' needs "this.". 48
 Warning coding RequireThis Reference to instance variable 'mfsp' needs "this.". 49
 Warning coding RequireThis Reference to instance variable 'parent' needs "this.". 50
 Warning coding RequireThis Reference to instance variable 'parent' needs "this.". 55
 Warning coding FinalLocalVariable Variable 'children' should be declared final. 56
 Warning coding RequireThis Reference to instance variable 'mfsp' needs "this.". 56
 Warning coding RequireThis Reference to instance variable 'parent' needs "this.". 56
 Warning coding RequireThis Reference to instance variable 'parent' needs "this.". 57
 Warning coding RequireThis Reference to instance variable 'parent' needs "this.". 63
 Warning coding FinalLocalVariable Variable 'children' should be declared final. 64
 Warning coding RequireThis Reference to instance variable 'mfsp' needs "this.". 64
 Warning coding RequireThis Reference to instance variable 'parent' needs "this.". 64
 Warning coding FinalLocalVariable Variable 'children' should be declared final. 70
 Warning coding RequireThis Reference to instance variable 'mfsp' needs "this.". 70
 Warning coding RequireThis Reference to instance variable 'parent' needs "this.". 70
 Warning coding RequireThis Reference to instance variable 'parent' needs "this.". 71
 Warning coding RequireThis Reference to instance variable 'parent' needs "this.". 77
 Warning coding RequireThis Reference to instance variable 'parent' needs "this.". 78
 Warning coding FinalLocalVariable Variable 'children' should be declared final. 79
 Warning coding RequireThis Reference to instance variable 'mfsp' needs "this.". 79
 Warning coding RequireThis Reference to instance variable 'parent' needs "this.". 79
 Warning coding RequireThis Reference to instance variable 'mfsp' needs "this.". 85
 Warning coding RequireThis Reference to instance variable 'parent' needs "this.". 86
 Warning coding FinalLocalVariable Variable 'children' should be declared final. 87
 Warning coding RequireThis Reference to instance variable 'mfsp' needs "this.". 87
 Warning coding RequireThis Reference to instance variable 'parent' needs "this.". 87
 Warning coding RequireThis Reference to instance variable 'parent' needs "this.". 93
 Warning coding FinalLocalVariable Variable 'children' should be declared final. 94
 Warning coding RequireThis Reference to instance variable 'mfsp' needs "this.". 94
 Warning coding RequireThis Reference to instance variable 'parent' needs "this.". 94
 Warning coding RequireThis Reference to instance variable 'parent' needs "this.". 100
 Warning coding FinalLocalVariable Variable 'children' should be declared final. 101
 Warning coding RequireThis Reference to instance variable 'mfsp' needs "this.". 101
 Warning coding RequireThis Reference to instance variable 'parent' needs "this.". 101
 Warning design VisibilityModifier Variable 'cft' must be private and have accessor methods. 108
 Warning modifier RedundantModifier Redundant 'public' modifier. 110
 Warning misc FinalParameters Parameter config should be final. 110
 Warning misc FinalParameters Parameter loc should be final. 110
 Warning misc FinalParameters Parameter payload should be final. 115
 Warning blocks RightCurly '}' at column 42 should be alone on a line. 120
 Warning misc FinalParameters Parameter payload should be final. 123
 Warning coding VariableDeclarationUsageDistance Distance between variable 'sprouts' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 125
 Warning coding FinalLocalVariable Variable 'sprouts' should be declared final. 125
 Warning coding FinalLocalVariable Variable 's' should be declared final. 127
 Warning coding RequireThis Reference to instance variable 'cft' needs "this.". 131
 Warning coding RequireThis Reference to instance variable 'cft' needs "this.". 132
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 144
 Warning coding FinalLocalVariable Variable 'emptyd' should be declared final. 146
 Warning coding RequireThis Reference to instance variable 'mfsp' needs "this.". 147
 Warning coding RequireThis Reference to instance variable 'mfsp' needs "this.". 148
 Warning coding RequireThis Reference to instance variable 'mfsp' needs "this.". 149

emissary/place/MultiFileUnixCommandPlace.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'doSynchronized' must be private and have accessor methods. 30
 Warning design VisibilityModifier Variable 'newChildForms' must be private and have accessor methods. 31
 Warning design VisibilityModifier Variable 'newParentForm' must be private and have accessor methods. 33
 Warning design VisibilityModifier Variable 'newErrorForm' must be private and have accessor methods. 34
 Warning design VisibilityModifier Variable 'keepFilesDebug' must be private and have accessor methods. 35
 Warning design VisibilityModifier Variable 'nukeMyProxies' must be private and have accessor methods. 36
 Warning design VisibilityModifier Variable 'recurseSubDirs' must be private and have accessor methods. 37
 Warning design VisibilityModifier Variable 'apBinDir' must be private and have accessor methods. 39
 Warning design VisibilityModifier Variable 'binFiles' must be private and have accessor methods. 41
 Warning design VisibilityModifier Variable 'binFileExt' must be private and have accessor methods. 43
 Warning design VisibilityModifier Variable 'outDirs' must be private and have accessor methods. 45
 Warning design VisibilityModifier Variable 'singleChildFiletype' must be private and have accessor methods. 46
 Warning design VisibilityModifier Variable 'keepParentHashesForSingleChild' must be private and have accessor methods. 47
 Warning design VisibilityModifier Variable 'keepParentFiletypeForSingleChild' must be private and have accessor methods. 48
 Warning design VisibilityModifier Variable 'setTitleToFile' must be private and have accessor methods. 52
 Warning design VisibilityModifier Variable 'fileTypesByExtension' must be private and have accessor methods. 53
 Warning design VisibilityModifier Variable 'contentFile' must be private and have accessor methods. 55
 Warning design VisibilityModifier Variable 'executrix' must be private and have accessor methods. 56
 Warning design VisibilityModifier Variable 'logfilename' must be private and have accessor methods. 57
 Warning design VisibilityModifier Variable 'charset' must be private and have accessor methods. 58
 Warning design VisibilityModifier Variable 'singleOutputAsChild' must be private and have accessor methods. 59
 Warning design VisibilityModifier Variable 'preserveParentData' must be private and have accessor methods. 60
 Warning design VisibilityModifier Variable 'placeDisplayName' must be private and have accessor methods. 62
 Warning misc FinalParameters Parameter configStream should be final. 69
 Warning misc FinalParameters Parameter configInfo should be final. 75
 Warning misc FinalParameters Parameter dir should be final. 75
 Warning misc FinalParameters Parameter placeLoc should be final. 75
 Warning misc FinalParameters Parameter configInfo should be final. 81
 Warning misc FinalParameters Parameter configInfo should be final. 86
 Warning misc FinalParameters Parameter loc should be final. 86
 Warning coding RequireThis Reference to instance variable 'executrix' needs "this.". 122
 Warning coding RequireThis Reference to instance variable 'contentFile' needs "this.". 123
 Warning coding RequireThis Reference to instance variable 'doSynchronized' needs "this.". 124
 Warning coding RequireThis Reference to instance variable 'nukeMyProxies' needs "this.". 125
 Warning coding RequireThis Reference to instance variable 'keepFilesDebug' needs "this.". 126
 Warning coding RequireThis Reference to instance variable 'recurseSubDirs' needs "this.". 127
 Warning coding RequireThis Reference to instance variable 'apBinDir' needs "this.". 128
 Warning coding RequireThis Reference to instance variable 'outDirs' needs "this.". 129
 Warning coding RequireThis Reference to instance variable 'charset' needs "this.". 130
 Warning coding RequireThis Reference to instance variable 'charset' needs "this.". 130
 Warning coding RequireThis Reference to instance variable 'binFileExt' needs "this.". 132
 Warning coding RequireThis Reference to instance variable 'binFiles' needs "this.". 133
 Warning coding RequireThis Reference to instance variable 'newErrorForm' needs "this.". 135
 Warning coding RequireThis Reference to instance variable 'newParentForm' needs "this.". 136
 Warning coding RequireThis Reference to instance variable 'newParentForm' needs "this.". 137
 Warning coding EqualsAvoidNull String literal expressions should be on the left side of an equals comparison. 137
 Warning coding RequireThis Reference to instance variable 'newParentForm' needs "this.". 138
 Warning coding RequireThis Reference to instance variable 'newChildForms' needs "this.". 140
 Warning coding RequireThis Reference to instance variable 'singleChildFiletype' needs "this.". 141
 Warning coding RequireThis Reference to instance variable 'keepParentHashesForSingleChild' needs "this.". 142
 Warning coding RequireThis Reference to instance variable 'keepParentFiletypeForSingleChild' needs "this.". 143
 Warning coding RequireThis Reference to instance variable 'setTitleToFile' needs "this.". 145
 Warning coding RequireThis Reference to instance variable 'placeDisplayName' needs "this.". 146
 Warning coding RequireThis Reference to instance variable 'logfilename' needs "this.". 147
 Warning coding RequireThis Reference to instance variable 'singleOutputAsChild' needs "this.". 148
 Warning coding RequireThis Reference to instance variable 'singleOutputAsChild' needs "this.". 148
 Warning coding RequireThis Reference to instance variable 'preserveParentData' needs "this.". 149
 Warning coding RequireThis Reference to instance variable 'preserveParentData' needs "this.". 149
 Warning coding FinalLocalVariable Variable 'tmp' should be declared final. 152
 Warning coding RequireThis Reference to instance variable 'fileTypesByExtension' needs "this.". 157
 Warning coding RequireThis Reference to instance variable 'logfilename' needs "this.". 166
 Warning misc FinalParameters Parameter e should be final. 174
 Warning coding RequireThis Reference to instance variable 'executrix' needs "this.". 175
 Warning coding RequireThis Reference to instance variable 'executrix' needs "this.". 182
 Warning coding RequireThis Reference to instance variable 'executrix' needs "this.". 190
 Warning misc FinalParameters Parameter tempDir should be final. 200
 Warning coding FinalLocalVariable Variable 'lfn' should be declared final. 203
 Warning coding RequireThis Reference to instance variable 'logfilename' needs "this.". 203
 Warning coding FinalLocalVariable Variable 'logdata' should be declared final. 204
 Warning coding RequireThis Reference to instance variable 'charset' needs "this.". 206
 Warning misc FinalParameters Parameter tmpDir should be final. 221
 Warning misc FinalParameters Parameter inputFileName should be final. 221
 Warning coding FinalLocalVariable Variable 'outFiles' should be declared final. 222
 Warning misc FinalParameters Parameter tmpDir should be final. 234
 Warning misc FinalParameters Parameter inputFileName should be final. 234
 Warning misc FinalParameters Parameter outFiles should be final. 234
 Warning coding RequireThis Reference to instance variable 'outDirs' needs "this.". 236
 Warning coding RequireThis Reference to instance variable 'outDirs' needs "this.". 237
 Warning coding FinalLocalVariable Variable 'dir' should be declared final. 238
 Warning coding RequireThis Reference to instance variable 'outDirs' needs "this.". 239
 Warning coding RequireThis Reference to instance variable 'outDirs' needs "this.". 242
 Warning coding RequireThis Reference to instance variable 'outDirs' needs "this.". 245
 Warning coding FinalLocalVariable Variable 'files' should be declared final. 248
 Warning coding RequireThis Reference to instance variable 'recurseSubDirs' needs "this.". 258
 Warning coding FinalLocalVariable Variable 'fname' should be declared final. 265
 Warning coding RequireThis Reference to instance variable 'binFiles' needs "this.". 266
 Warning coding RequireThis Reference to instance variable 'binFileExt' needs "this.". 275
 Warning coding RequireThis Reference to instance variable 'contentFile' needs "this.". 279
 Warning coding RequireThis Reference to instance variable 'contentFile' needs "this.". 279
 Warning misc FinalParameters Parameter o1 should be final. 300
 Warning misc FinalParameters Parameter o2 should be final. 300
 Warning misc FinalParameters Parameter parent should be final. 321
 Warning misc FinalParameters Parameter files should be final. 321
 Warning misc FinalParameters Parameter tempDirName should be final. 321
 Warning misc FinalParameters Parameter newData should be final. 321
 Warning coding FinalLocalVariable Variable 'sprouts' should be declared final. 322
 Warning coding FinalLocalVariable Variable 'fileCount' should be declared final. 329
 Warning coding FinalLocalVariable Variable 'theData' should be declared final. 344
 Warning coding FinalLocalVariable Variable 'metaData' should be declared final. 354
 Warning coding RequireThis Reference to instance variable 'setTitleToFile' needs "this.". 355
 Warning coding FinalLocalVariable Variable 'tmpForms' should be declared final. 359
 Warning coding FinalLocalVariable Variable 'dObj' should be declared final. 361
 Warning coding RequireThis Reference to instance variable 'preserveParentData' needs "this.". 373
 Warning coding RequireThis Reference to instance variable 'charset' needs "this.". 375
 Warning misc FinalParameters Parameter f should be final. 389
 Warning coding FinalLocalVariable Variable 'tmpForms' should be declared final. 390
 Warning coding RequireThis Reference to instance variable 'fileTypesByExtension' needs "this.". 392
 Warning coding RequireThis Reference to instance variable 'newChildForms' needs "this.". 398
 Warning misc FinalParameters Parameter parent should be final. 413
 Warning misc FinalParameters Parameter files should be final. 413
 Warning misc FinalParameters Parameter newData should be final. 413
 Warning misc FinalParameters Parameter dirName should be final. 413
 Warning coding RequireThis Reference to instance variable 'contentFile' needs "this.". 414
 Warning coding RequireThis Reference to instance variable 'contentFile' needs "this.". 415
 Warning coding FinalLocalVariable Variable 'fileData' should be declared final. 416
 Warning coding RequireThis Reference to instance variable 'contentFile' needs "this.". 416
 Warning coding RequireThis Reference to instance variable 'contentFile' needs "this.". 420
 Warning misc FinalParameters Parameter parent should be final. 434
 Warning misc FinalParameters Parameter numSubParts should be final. 434
 Warning misc FinalParameters Parameter actualFileCount should be final. 434
 Warning misc FinalParameters Parameter newParentData should be final. 434
 Warning misc FinalParameters Parameter data should be final. 449
 Warning misc FinalParameters Parameter parent should be final. 449
 Warning misc FinalParameters Parameter f should be final. 449
 Warning misc FinalParameters Parameter birthOrder should be final. 449
 Warning misc FinalParameters Parameter numSubParts should be final. 449
 Warning misc FinalParameters Parameter newParentData should be final. 449
 Warning misc FinalParameters Parameter data should be final. 466
 Warning misc FinalParameters Parameter parent should be final. 466
 Warning misc FinalParameters Parameter f should be final. 466
 Warning misc FinalParameters Parameter birthOrder should be final. 466
 Warning misc FinalParameters Parameter numSubParts should be final. 466
 Warning misc FinalParameters Parameter actualFileCount should be final. 466
 Warning misc FinalParameters Parameter newParentData should be final. 467
 Warning misc FinalParameters Parameter theSprout should be final. 467
 Warning misc FinalParameters Parameter d should be final. 479
 Warning misc FinalParameters Parameter f should be final. 479
 Warning coding FinalLocalVariable Variable 'theData' should be declared final. 480
 Warning misc FinalParameters Parameter d should be final. 493
 Warning misc FinalParameters Parameter f should be final. 493
 Warning misc FinalParameters Parameter theData should be final. 493
 Warning coding FinalLocalVariable Variable 'filename' should be declared final. 494
 Warning coding RequireThis Reference to instance variable 'setTitleToFile' needs "this.". 496
 Warning coding FinalLocalVariable Variable 'tmpForms' should be declared final. 499
 Warning coding RequireThis Reference to instance variable 'singleChildFiletype' needs "this.". 503
 Warning misc FinalParameters Parameter d should be final. 518
 Warning misc FinalParameters Parameter theData should be final. 518
 Warning misc FinalParameters Parameter f should be final. 518
 Warning misc FinalParameters Parameter theDataObject should be final. 527
 Warning misc FinalParameters Parameter theDataObject should be final. 537
 Warning misc FinalParameters Parameter tData should be final. 548
 Warning coding FinalLocalVariable Variable 'entries' should be declared final. 549
 Warning coding RequireThis Reference to instance variable 'doSynchronized' needs "this.". 551
 Warning coding RequireThis Reference to instance variable 'executrix' needs "this.". 565
 Warning coding RequireThis Reference to instance variable 'contentFile' needs "this.". 565
 Warning coding RequireThis Reference to instance variable 'singleOutputAsChild' needs "this.". 565
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 566
 Warning coding RequireThis Reference to instance variable 'keepParentHashesForSingleChild' needs "this.". 568
 Warning coding RequireThis Reference to instance variable 'keepParentFiletypeForSingleChild' needs "this.". 573
 Warning coding RequireThis Reference to instance variable 'newParentForm' needs "this.". 580
 Warning coding RequireThis Reference to instance variable 'newParentForm' needs "this.". 581
 Warning coding RequireThis Reference to instance variable 'newParentForm' needs "this.". 582
 Warning misc FinalParameters Parameter tData should be final. 595
 Warning misc FinalParameters Parameter tData should be final. 609
 Warning misc FinalParameters Parameter start should be final. 609
 Warning misc FinalParameters Parameter len should be final. 609
 Warning coding RequireThis Reference to instance variable 'newErrorForm' needs "this.". 622
 Warning coding RequireThis Reference to instance variable 'newErrorForm' needs "this.". 630
 Warning coding FinalLocalVariable Variable 'names' should be declared final. 638
 Warning coding RequireThis Reference to instance variable 'executrix' needs "this.". 638
 Warning coding FinalLocalVariable Variable 'cmd' should be declared final. 643
 Warning coding RequireThis Reference to instance variable 'executrix' needs "this.". 643
 Warning coding FinalLocalVariable Variable 'parentData' should be declared final. 644
 Warning coding RequireThis Reference to instance variable 'executrix' needs "this.". 648
 Warning coding RequireThis Reference to instance variable 'executrix' needs "this.". 650
 Warning coding FinalLocalVariable Variable 'errbuf' should be declared final. 651
 Warning coding RequireThis Reference to instance variable 'nukeMyProxies' needs "this.". 660
 Warning coding RequireThis Reference to instance variable 'nukeMyProxies' needs "this.". 663
 Warning coding FinalLocalVariable Variable 'files' should be declared final. 666
 Warning coding RequireThis Reference to instance variable 'newErrorForm' needs "this.". 684
 Warning misc FinalParameters Parameter cmd should be final. 695
 Warning misc FinalParameters Parameter cmd should be final. 707
 Warning misc FinalParameters Parameter stdout should be final. 707
 Warning misc FinalParameters Parameter stderr should be final. 707
 Warning coding RequireThis Reference to instance variable 'executrix' needs "this.". 708
 Warning coding RequireThis Reference to instance variable 'charset' needs "this.". 708
 Warning misc FinalParameters Parameter tempDir should be final. 717
 Warning coding RequireThis Reference to instance variable 'keepFilesDebug' needs "this.". 718
 Warning misc FinalParameters Parameter dir should be final. 728
 Warning coding FinalLocalVariable Variable 'status' should be declared final. 729

emissary/place/MultiFileUnixCommandPlaceTest.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter workDir should be final. 48
 Warning coding HiddenField 'workDir' hides a field. 48
 Warning coding FinalLocalVariable Variable 'rr' should be declared final. 57
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 59
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 60
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 61
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 62
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 67
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 69
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 70
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 77
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 78
 Warning coding RequireThis Reference to instance variable 'scriptFile' needs "this.". 79
 Warning coding RequireThis Reference to instance variable 'workDir' needs "this.". 80
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 86
 Warning coding FinalLocalVariable Variable 'att' should be declared final. 89
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 89
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 89
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 93
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 94
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 95
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 108
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 109
 Warning coding FinalLocalVariable Variable 'att' should be declared final. 112
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 112
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 112
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 113
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 117
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 130
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 131
 Warning coding FinalLocalVariable Variable 'att' should be declared final. 134
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 134
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 134
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 136
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 137
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 138
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 140
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 141
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 142
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 143
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 144
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 145
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 150
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 151
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 154
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 155
 Warning coding FinalLocalVariable Variable 'att' should be declared final. 157
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 157
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 157
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 159
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 165
 Warning coding FinalLocalVariable Variable 'mockLogger' should be declared final. 166
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 167
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 169
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 169
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 12, expected level should be one of the following: 6, 46, 47. 175
 Warning coding RequireThis Reference to instance variable 'scriptFile' needs "this.". 187
 Warning coding RequireThis Reference to instance variable 'scriptFile' needs "this.". 192
 Warning coding FinalLocalVariable Variable 'fos' should be declared final. 193
 Warning coding RequireThis Reference to instance variable 'scriptFile' needs "this.". 193
 Warning misc FinalParameters Parameter ot should be final. 198
 Warning misc FinalParameters Parameter outputCount should be final. 198
 Warning coding RequireThis Reference to instance variable 'scriptFile' needs "this.". 214

emissary/place/MyFileConfigedTestPlace.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'finishedSuperConstructor' must be private and have accessor methods. 10
 Warning design VisibilityModifier Variable 'processCounter' must be private and have accessor methods. 12
 Warning misc FinalParameters Parameter placeLocation should be final. 14
 Warning coding RequireThis Reference to instance variable 'finishedSuperConstructor' needs "this.". 16
 Warning misc FinalParameters Parameter configFile should be final. 19
 Warning misc FinalParameters Parameter dir should be final. 19
 Warning misc FinalParameters Parameter placeLocation should be final. 19
 Warning coding RequireThis Reference to instance variable 'finishedSuperConstructor' needs "this.". 21
 Warning misc FinalParameters Parameter configStream should be final. 24
 Warning misc FinalParameters Parameter dir should be final. 24
 Warning misc FinalParameters Parameter placeLocation should be final. 24
 Warning coding RequireThis Reference to instance variable 'finishedSuperConstructor' needs "this.". 26
 Warning coding RequireThis Reference to instance variable 'finishedSuperConstructor' needs "this.". 31
 Warning misc FinalParameters Parameter payload should be final. 35
 Warning coding RequireThis Reference to instance variable 'processCounter' needs "this.". 36

emissary/place/MyStreamConfigedTestPlace.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'finishedSuperConstructor' must be private and have accessor methods. 10
 Warning design VisibilityModifier Variable 'processCounter' must be private and have accessor methods. 12
 Warning misc FinalParameters Parameter placeLocation should be final. 14
 Warning coding RequireThis Reference to instance variable 'finishedSuperConstructor' needs "this.". 16
 Warning misc FinalParameters Parameter configFile should be final. 19
 Warning misc FinalParameters Parameter dir should be final. 19
 Warning misc FinalParameters Parameter placeLocation should be final. 19
 Warning coding RequireThis Reference to instance variable 'finishedSuperConstructor' needs "this.". 21
 Warning misc FinalParameters Parameter configStream should be final. 24
 Warning misc FinalParameters Parameter dir should be final. 24
 Warning misc FinalParameters Parameter placeLocation should be final. 24
 Warning coding RequireThis Reference to instance variable 'finishedSuperConstructor' needs "this.". 26
 Warning coding RequireThis Reference to instance variable 'finishedSuperConstructor' needs "this.". 31
 Warning misc FinalParameters Parameter payload should be final. 35
 Warning coding RequireThis Reference to instance variable 'processCounter' needs "this.". 36

emissary/place/OOMPlace.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter configInfo should be final. 9
 Warning misc FinalParameters Parameter dir should be final. 9
 Warning misc FinalParameters Parameter placeLoc should be final. 9
 Warning misc FinalParameters Parameter configInfo should be final. 13
 Warning misc FinalParameters Parameter dir should be final. 13
 Warning misc FinalParameters Parameter placeLoc should be final. 13
 Warning misc FinalParameters Parameter configInfo should be final. 17
 Warning misc FinalParameters Parameter theDataObject should be final. 22

emissary/place/RehashingPlaceTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'DATA' should be declared final. 28
 Warning coding VariableDeclarationUsageDistance Distance between variable 'DOUBLE_DATA' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 29
 Warning coding FinalLocalVariable Variable 'DOUBLE_DATA' should be declared final. 29
 Warning coding FinalLocalVariable Variable 'config' should be declared final. 32
 Warning coding FinalLocalVariable Variable 'tp' should be declared final. 33
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 34
 Warning coding FinalLocalVariable Variable 'kff' should be declared final. 35
 Warning coding VariableDeclarationUsageDistance Distance between variable 'oldhash' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 44
 Warning coding FinalLocalVariable Variable 'oldhash' should be declared final. 44
 Warning coding FinalLocalVariable Variable 'newhash' should be declared final. 56
 Warning modifier RedundantModifier Redundant 'public' modifier. 67
 Warning misc FinalParameters Parameter config should be final. 67
 Warning misc FinalParameters Parameter d should be final. 72
 Warning coding RequireThis Reference to instance variable 'useData' needs "this.". 74
 Warning misc FinalParameters Parameter data should be final. 81
 Warning coding RequireThis Reference to instance variable 'useData' needs "this.". 82

emissary/place/ServiceProviderPlace.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'configG' must be private and have accessor methods. 73
 Warning design VisibilityModifier Variable 'dirPlace' must be private and have accessor methods. 82
 Warning design VisibilityModifier Variable 'localDirPlace' must be private and have accessor methods. 84
 Warning design VisibilityModifier Variable 'keys' must be private and have accessor methods. 91
 Warning design VisibilityModifier Variable 'denyList' must be private and have accessor methods. 96
 Warning design VisibilityModifier Variable 'myKey' must be private and have accessor methods. 101
 Warning design VisibilityModifier Variable 'serviceCost' must be private and have accessor methods. 102
 Warning design VisibilityModifier Variable 'serviceQuality' must be private and have accessor methods. 103
 Warning design VisibilityModifier Variable 'placeName' must be private and have accessor methods. 105
 Warning design VisibilityModifier Variable 'serviceDescription' must be private and have accessor methods. 111
 Warning design VisibilityModifier Variable 'logger' must be private and have accessor methods. 121
 Warning design VisibilityModifier Variable 'kff' must be private and have accessor methods. 127
 Warning design VisibilityModifier Variable 'processMethodImplemented' must be private and have accessor methods. 135
 Warning design VisibilityModifier Variable 'heavyDutyMethodImplemented' must be private and have accessor methods. 136
 Warning coding FinalLocalVariable Variable 'placeLocation' should be declared final. 145
 Warning coding RequireThis Reference to instance variable 'configG' needs "this.". 146
 Warning misc FinalParameters Parameter thePlaceLocation should be final. 156
 Warning coding RequireThis Reference to instance variable 'configG' needs "this.". 158
 Warning misc FinalParameters Parameter configFile should be final. 169
 Warning misc FinalParameters Parameter theDir should be final. 169
 Warning misc FinalParameters Parameter thePlaceLocation should be final. 169
 Warning coding RequireThis Reference to instance variable 'configG' needs "this.". 171
 Warning misc FinalParameters Parameter configStream should be final. 182
 Warning misc FinalParameters Parameter theDir should be final. 182
 Warning misc FinalParameters Parameter thePlaceLocation should be final. 182
 Warning coding RequireThis Reference to instance variable 'configG' needs "this.". 184
 Warning misc FinalParameters Parameter configStream should be final. 193
 Warning coding FinalLocalVariable Variable 'placeLocation' should be declared final. 195
 Warning coding RequireThis Reference to instance variable 'configG' needs "this.". 196
 Warning misc FinalParameters Parameter configFile should be final. 206
 Warning misc FinalParameters Parameter placeLocation should be final. 206
 Warning misc FinalParameters Parameter configStream should be final. 217
 Warning misc FinalParameters Parameter placeLocation should be final. 217
 Warning misc FinalParameters Parameter configStream should be final. 226
 Warning misc FinalParameters Parameter placeLocation should be final. 226
 Warning misc FinalParameters Parameter configFileName should be final. 240
 Warning misc FinalParameters Parameter placeLocation should be final. 240
 Warning misc FinalParameters Parameter placeLocation should be final. 252
 Warning coding ParameterAssignment Assignment of parameter 'placeLocation' is not allowed. 254
 Warning coding FinalLocalVariable Variable 'myPackage' should be declared final. 260
 Warning coding FinalLocalVariable Variable 'configLocs' should be declared final. 261
 Warning coding FinalLocalVariable Variable 'pos' should be declared final. 263
 Warning coding FinalLocalVariable Variable 'serviceClass' should be declared final. 264
 Warning misc FinalParameters Parameter theDir should be final. 275
 Warning misc FinalParameters Parameter placeLocation should be final. 275
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 278
 Warning coding FinalLocalVariable Variable 'firstentry' should be declared final. 287
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 287
 Warning coding RequireThis Reference to instance variable 'myKey' needs "this.". 288
 Warning coding RequireThis Reference to instance variable 'serviceCost' needs "this.". 289
 Warning coding RequireThis Reference to instance variable 'serviceQuality' needs "this.". 290
 Warning coding RequireThis Reference to instance variable 'placeName' needs "this.". 291
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 297
 Warning coding RequireThis Reference to instance variable 'dirPlace' needs "this.". 297
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 299
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 310
 Warning coding FinalLocalVariable Variable 'bindKey' should be declared final. 311
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 312
 Warning misc FinalParameters Parameter theDir should be final. 334
 Warning coding RequireThis Reference to instance variable 'localDirPlace' needs "this.". 339
 Warning coding RequireThis Reference to instance variable 'dirPlace' needs "this.". 340
 Warning coding RequireThis Reference to instance variable 'localDirPlace' needs "this.". 340
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 343
 Warning coding RequireThis Reference to instance variable 'dirPlace' needs "this.". 348
 Warning coding RequireThis Reference to instance variable 'localDirPlace' needs "this.". 349
 Warning coding FinalLocalVariable Variable 'myUrl' should be declared final. 351
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 351
 Warning coding FinalLocalVariable Variable 'dirUrl' should be declared final. 352
 Warning coding RequireThis Reference to instance variable 'dirPlace' needs "this.". 352
 Warning coding RequireThis Reference to instance variable 'localDirPlace' needs "this.". 354
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 356
 Warning coding RequireThis Reference to instance variable 'dirPlace' needs "this.". 356
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 359
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 370
 Warning misc FinalParameters Parameter l should be final. 380
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 391
 Warning coding RequireThis Reference to instance variable 'serviceDescription' needs "this.". 391
 Warning coding RequireThis Reference to instance variable 'serviceCost' needs "this.". 391
 Warning coding RequireThis Reference to instance variable 'serviceQuality' needs "this.". 391
 Warning misc FinalParameters Parameter placeLocation should be final. 410
 Warning coding RequireThis Reference to instance variable 'serviceDescription' needs "this.". 411
 Warning coding RequireThis Reference to instance variable 'configG' needs "this.". 411
 Warning coding RequireThis Reference to instance variable 'serviceDescription' needs "this.". 412
 Warning coding RequireThis Reference to instance variable 'serviceDescription' needs "this.". 412
 Warning coding RequireThis Reference to instance variable 'serviceDescription' needs "this.". 413
 Warning coding ParameterAssignment Assignment of parameter 'placeLocation' is not allowed. 417
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 422
 Warning coding FinalLocalVariable Variable 'node' should be declared final. 425
 Warning coding HiddenField 'placeName' hides a field. 431
 Warning coding RequireThis Reference to instance variable 'configG' needs "this.". 431
 Warning coding RequireThis Reference to instance variable 'configG' needs "this.". 432
 Warning coding RequireThis Reference to instance variable 'configG' needs "this.". 433
 Warning coding VariableDeclarationUsageDistance Distance between variable 'serviceCost' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 434
 Warning coding FinalLocalVariable Variable 'serviceCost' should be declared final. 434
 Warning coding HiddenField 'serviceCost' hides a field. 434
 Warning coding RequireThis Reference to instance variable 'configG' needs "this.". 434
 Warning coding VariableDeclarationUsageDistance Distance between variable 'serviceQuality' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 435
 Warning coding FinalLocalVariable Variable 'serviceQuality' should be declared final. 435
 Warning coding HiddenField 'serviceQuality' hides a field. 435
 Warning coding RequireThis Reference to instance variable 'configG' needs "this.". 435
 Warning coding RequireThis Reference to instance variable 'configG' needs "this.". 450
 Warning coding FinalLocalVariable Variable 'de' should be declared final. 451
 Warning coding RequireThis Reference to instance variable 'serviceDescription' needs "this.". 451
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 452
 Warning coding RequireThis Reference to instance variable 'configG' needs "this.". 455
 Warning coding FinalLocalVariable Variable 'de' should be declared final. 456
 Warning coding RequireThis Reference to instance variable 'serviceDescription' needs "this.". 456
 Warning coding RequireThis Reference to instance variable 'denyList' needs "this.". 457
 Warning coding RequireThis Reference to instance variable 'configG' needs "this.". 488
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 490
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 492
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 497
 Warning coding RequireThis Reference to instance variable 'localDirPlace' needs "this.". 513
 Warning coding RequireThis Reference to instance variable 'localDirPlace' needs "this.". 514
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 516
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 516
 Warning coding RequireThis Reference to instance variable 'dirPlace' needs "this.". 516
 Warning misc FinalParameters Parameter payload should be final. 526
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 533
 Warning misc FinalParameters Parameter payloadList should be final. 546
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 548
 Warning coding FinalLocalVariable Variable 'list' should be declared final. 550
 Warning coding FinalLocalVariable Variable 'l' should be declared final. 556
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 564
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 565
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 571
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 573
 Warning misc FinalParameters Parameter payload should be final. 587
 Warning coding FinalLocalVariable Variable 'l' should be declared final. 591
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 595
 Warning misc FinalParameters Parameter payload should be final. 605
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 607
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 608
 Warning misc FinalParameters Parameter payload should be final. 619
 Warning coding RequireThis Reference to instance variable 'heavyDutyMethodImplemented' needs "this.". 620
 Warning coding FinalLocalVariable Variable 'children' should be declared final. 621
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 623
 Warning misc FinalParameters Parameter payload should be final. 639
 Warning coding RequireThis Reference to instance variable 'processMethodImplemented' needs "this.". 640
 Warning coding FinalLocalVariable Variable 'mname' should be declared final. 657
 Warning coding FinalLocalVariable Variable 'rname' should be declared final. 658
 Warning coding FinalLocalVariable Variable 'params' should be declared final. 659
 Warning coding EqualsAvoidNull String literal expressions should be on the left side of an equals comparison. 662
 Warning coding EqualsAvoidNull String literal expressions should be on the left side of an equals comparison. 662
 Warning coding RequireThis Reference to instance variable 'processMethodImplemented' needs "this.". 663
 Warning coding EqualsAvoidNull String literal expressions should be on the left side of an equals comparison. 664
 Warning coding RequireThis Reference to instance variable 'heavyDutyMethodImplemented' needs "this.". 665
 Warning coding RequireThis Reference to instance variable 'heavyDutyMethodImplemented' needs "this.". 670
 Warning coding RequireThis Reference to instance variable 'processMethodImplemented' needs "this.". 670
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 671
 Warning coding RequireThis Reference to instance variable 'processMethodImplemented' needs "this.". 678
 Warning coding RequireThis Reference to instance variable 'heavyDutyMethodImplemented' needs "this.". 678
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 679
 Warning misc FinalParameters Parameter d should be final. 692
 Warning coding FinalLocalVariable Variable 'nukem' should be declared final. 693
 Warning coding FinalLocalVariable Variable 'sz' should be declared final. 694
 Warning coding FinalLocalVariable Variable 'serviceProxies' should be declared final. 695
 Warning coding FinalLocalVariable Variable 'form' should be declared final. 704
 Warning coding FinalLocalVariable Variable 'wc' should be declared final. 709
 Warning coding FinalLocalVariable Variable 'pos' should be declared final. 718
 Warning coding FinalLocalVariable Variable 's' should be declared final. 734
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 735
 Warning coding FinalLocalVariable Variable 's' should be declared final. 747
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 748
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 763
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 776
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 776
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 784
 Warning misc FinalParameters Parameter serviceProxy should be final. 793
 Warning coding FinalLocalVariable Variable 'de' should be declared final. 795
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 795
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 800
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 805
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 806
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 809
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 816
 Warning misc FinalParameters Parameter key should be final. 826
 Warning coding FinalLocalVariable Variable 'de' should be declared final. 828
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 828
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 830
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 833
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 834
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 837
 Warning misc FinalParameters Parameter key should be final. 846
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 847
 Warning coding RequireThis Reference to instance variable 'dirPlace' needs "this.". 850
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 852
 Warning coding FinalLocalVariable Variable 'keylist' should be declared final. 859
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 869
 Warning coding RequireThis Reference to instance variable 'dirPlace' needs "this.". 873
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 875
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 882
 Warning misc FinalParameters Parameter keylist should be final. 890
 Warning coding RequireThis Reference to instance variable 'localDirPlace' needs "this.". 892
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 895
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 897
 Warning coding RequireThis Reference to instance variable 'localDirPlace' needs "this.". 898
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 901
 Warning misc FinalParameters Parameter keys should be final. 911
 Warning coding HiddenField 'keys' hides a field. 911
 Warning coding RequireThis Reference to instance variable 'localDirPlace' needs "this.". 913
 Warning coding RequireThis Reference to instance variable 'dirPlace' needs "this.". 913
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 916
 Warning coding RequireThis Reference to instance variable 'dirPlace' needs "this.". 916
 Warning coding FinalLocalVariable Variable 'da' should be declared final. 917
 Warning coding RequireThis Reference to instance variable 'dirPlace' needs "this.". 918
 Warning coding RequireThis Reference to instance variable 'localDirPlace' needs "this.". 919
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 920
 Warning coding RequireThis Reference to instance variable 'localDirPlace' needs "this.". 921
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 924
 Warning misc FinalParameters Parameter serviceProxy should be final. 936
 Warning coding FinalLocalVariable Variable 'keylist' should be declared final. 938
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 941
 Warning coding FinalLocalVariable Variable 'k' should be declared final. 942
 Warning coding FinalLocalVariable Variable 'kproxy' should be declared final. 943
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 952
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 956
 Warning coding FinalLocalVariable Variable 'de' should be declared final. 957
 Warning coding RequireThis Reference to instance variable 'serviceCost' needs "this.". 958
 Warning coding RequireThis Reference to instance variable 'serviceQuality' needs "this.". 959
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 961
 Warning misc FinalParameters Parameter key should be final. 971
 Warning coding FinalLocalVariable Variable 'keyWithOutExpense' should be declared final. 972
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 974
 Warning coding FinalLocalVariable Variable 'keylist' should be declared final. 975
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 979
 Warning coding FinalLocalVariable Variable 'de' should be declared final. 980
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 982
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 985
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 995
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 998
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 1005
 Warning coding RequireThis Reference to instance variable 'keys' needs "this.". 1015
 Warning coding RequireThis Reference to instance variable 'configG' needs "this.". 1025
 Warning coding FinalLocalVariable Variable 'runningConfigList' should be declared final. 1040
 Warning coding RequireThis Reference to instance variable 'configG' needs "this.". 1042
 Warning coding RequireThis Reference to instance variable 'configG' needs "this.". 1043
 Warning coding FinalLocalVariable Variable 'resource' should be declared final. 1052
 Warning coding FinalLocalVariable Variable 'placeStats' should be declared final. 1053
 Warning coding FinalLocalVariable Variable 'statsKey' should be declared final. 1057
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 1064
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 1071
 Warning coding RequireThis Reference to instance variable 'placeName' needs "this.". 1071
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 1072
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 1073
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 1074
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 1079
 Warning coding RequireThis Reference to instance variable 'placeName' needs "this.". 1079
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 1080
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 1081
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 1082
 Warning coding FinalLocalVariable Variable 'agent' should be declared final. 1093
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 1096
 Warning coding FinalLocalVariable Variable 'familyTree' should be declared final. 1098
 Warning coding FinalLocalVariable Variable 'member' should be declared final. 1101
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 1106
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 1110
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 1113
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 1116
 Warning misc FinalParameters Parameter s should be final. 1124
 Warning coding RequireThis Reference to instance variable 'denyList' needs "this.". 1125

emissary/place/ServiceProviderPlaceGetTLDTest.java

Severity Category Rule Message Line
 Warning coding VariableDeclarationUsageDistance Distance between variable 'place' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 35
 Warning coding FinalLocalVariable Variable 'place' should be declared final. 35
 Warning coding FinalLocalVariable Variable 'pool' should be declared final. 36
 Warning coding VariableDeclarationUsageDistance Distance between variable 'agent' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 37
 Warning coding FinalLocalVariable Variable 'agent' should be declared final. 37
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 40
 Warning coding FinalLocalVariable Variable 'child' should be declared final. 42
 Warning coding FinalLocalVariable Variable 'payloadList' should be declared final. 43
 Warning modifier RedundantModifier Redundant 'public' modifier. 66
 Warning misc FinalParameters Parameter d should be final. 71
 Warning coding FinalLocalVariable Variable 'p' should be declared final. 72

emissary/place/ServiceProviderPlaceTest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'configDir' must be private and have accessor methods. 87
 Warning coding FinalLocalVariable Variable 'config' should be declared final. 93
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 94
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 101
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 102
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 107
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 108
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 109
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 110
 Warning coding FinalLocalVariable Variable 'de' should be declared final. 111
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 111
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 117
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 118
 Warning coding FinalLocalVariable Variable 'proxies' should be declared final. 119
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 119
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 129
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 130
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 132
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 135
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 141
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 147
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 151
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 156
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 162
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 167
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 170
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 171
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 177
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 179
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 180
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 182
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 183
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 186
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 187
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 190
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 191
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 194
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 195
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 199
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 200
 Warning coding FinalLocalVariable Variable 'mtp' should be declared final. 207
 Warning misc FinalParameters Parameter usePackage should be final. 227
 Warning misc FinalParameters Parameter ctorType should be final. 227
 Warning coding FinalLocalVariable Variable 'cfg' should be declared final. 228
 Warning coding RequireThis Reference to instance variable 'configDir' needs "this.". 231
 Warning coding RequireThis Reference to instance variable 'configDir' needs "this.". 233
 Warning coding FinalLocalVariable Variable 'config' should be declared final. 249
 Warning coding FinalLocalVariable Variable 'config' should be declared final. 271
 Warning coding FinalLocalVariable Variable 'config' should be declared final. 278
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 279
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 281
 Warning coding FinalLocalVariable Variable 'a' should be declared final. 282
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 282
 Warning coding FinalLocalVariable Variable 'stats' should be declared final. 284
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 284
 Warning coding FinalLocalVariable Variable 'resourceLimit' should be declared final. 286
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 286
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 291
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 292
 Warning coding FinalLocalVariable Variable 'config' should be declared final. 323
 Warning coding FinalLocalVariable Variable 'config' should be declared final. 331
 Warning coding FinalLocalVariable Variable 'config' should be declared final. 340
 Warning coding FinalLocalVariable Variable 'tp' should be declared final. 341
 Warning coding FinalLocalVariable Variable 'de' should be declared final. 345
 Warning coding FinalLocalVariable Variable 'keys' should be declared final. 351
 Warning coding FinalLocalVariable Variable 'proxies' should be declared final. 355
 Warning coding FinalLocalVariable Variable 'config' should be declared final. 368
 Warning coding FinalLocalVariable Variable 'tp' should be declared final. 369
 Warning coding FinalLocalVariable Variable 'proxies' should be declared final. 387
 Warning coding FinalLocalVariable Variable 'config' should be declared final. 400
 Warning coding FinalLocalVariable Variable 'tp' should be declared final. 401
 Warning coding FinalLocalVariable Variable 'keys' should be declared final. 405
 Warning coding FinalLocalVariable Variable 'config' should be declared final. 417
 Warning coding FinalLocalVariable Variable 'tp' should be declared final. 418
 Warning coding FinalLocalVariable Variable 'config' should be declared final. 428
 Warning coding FinalLocalVariable Variable 'config' should be declared final. 436
 Warning coding FinalLocalVariable Variable 'tp' should be declared final. 446
 Warning coding FinalLocalVariable Variable 'config' should be declared final. 462
 Warning coding FinalLocalVariable Variable 'tp' should be declared final. 463
 Warning coding FinalLocalVariable Variable 'de' should be declared final. 469
 Warning coding FinalLocalVariable Variable 'keys' should be declared final. 476
 Warning coding FinalLocalVariable Variable 'sl' should be declared final. 482
 Warning coding FinalLocalVariable Variable 'place' should be declared final. 484
 Warning coding HiddenField 'place' hides a field. 484
 Warning coding FinalLocalVariable Variable 'proxies' should be declared final. 493
 Warning coding FinalLocalVariable Variable 'config' should be declared final. 509
 Warning coding FinalLocalVariable Variable 'tp' should be declared final. 510
 Warning coding FinalLocalVariable Variable 'config' should be declared final. 525
 Warning coding FinalLocalVariable Variable 'tp' should be declared final. 526
 Warning coding FinalLocalVariable Variable 'config' should be declared final. 539
 Warning coding FinalLocalVariable Variable 'p' should be declared final. 540
 Warning coding FinalLocalVariable Variable 'config2' should be declared final. 546
 Warning coding FinalLocalVariable Variable 'p2' should be declared final. 547
 Warning modifier RedundantModifier Redundant 'public' modifier. 557
 Warning modifier RedundantModifier Redundant 'public' modifier. 561
 Warning misc FinalParameters Parameter config should be final. 561
 Warning modifier RedundantModifier Redundant 'public' modifier. 565
 Warning misc FinalParameters Parameter config should be final. 565
 Warning misc FinalParameters Parameter loc should be final. 565
 Warning modifier RedundantModifier Redundant 'public' modifier. 569
 Warning misc FinalParameters Parameter config should be final. 569
 Warning misc FinalParameters Parameter dir should be final. 569
 Warning misc FinalParameters Parameter loc should be final. 569
 Warning misc FinalParameters Parameter d should be final. 574
 Warning misc FinalParameters Parameter d should be final. 578

emissary/place/UnixCommandPlace.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'doSynchronized' must be private and have accessor methods. 23
 Warning design VisibilityModifier Variable 'newForm' must be private and have accessor methods. 25
 Warning design VisibilityModifier Variable 'newFormOnError' must be private and have accessor methods. 26
 Warning design VisibilityModifier Variable 'metaDataTag' must be private and have accessor methods. 28
 Warning design VisibilityModifier Variable 'alternateView' must be private and have accessor methods. 30
 Warning design VisibilityModifier Variable 'addAsMetaData' must be private and have accessor methods. 31
 Warning design VisibilityModifier Variable 'perlChop' must be private and have accessor methods. 32
 Warning design VisibilityModifier Variable 'nukeAllProxies' must be private and have accessor methods. 33
 Warning design VisibilityModifier Variable 'keepFilesDebug' must be private and have accessor methods. 34
 Warning design VisibilityModifier Variable 'charset' must be private and have accessor methods. 35
 Warning design VisibilityModifier Variable 'logfilename' must be private and have accessor methods. 36
 Warning design VisibilityModifier Variable 'executrix' must be private and have accessor methods. 38
 Warning misc FinalParameters Parameter configInfo should be final. 45
 Warning misc FinalParameters Parameter configInfo should be final. 57
 Warning misc FinalParameters Parameter dir should be final. 57
 Warning misc FinalParameters Parameter placeLoc should be final. 57
 Warning misc FinalParameters Parameter configInfo should be final. 69
 Warning misc FinalParameters Parameter dir should be final. 69
 Warning misc FinalParameters Parameter placeLoc should be final. 69
 Warning misc FinalParameters Parameter configInfo should be final. 79
 Warning coding RequireThis Reference to instance variable 'doSynchronized' needs "this.". 101
 Warning coding RequireThis Reference to instance variable 'newForm' needs "this.". 102
 Warning coding RequireThis Reference to instance variable 'newForm' needs "this.". 103
 Warning coding RequireThis Reference to instance variable 'newForm' needs "this.". 104
 Warning coding RequireThis Reference to instance variable 'newForm' needs "this.". 106
 Warning coding RequireThis Reference to instance variable 'newForm' needs "this.". 107
 Warning coding RequireThis Reference to instance variable 'newFormOnError' needs "this.". 109
 Warning coding RequireThis Reference to instance variable 'alternateView' needs "this.". 110
 Warning coding RequireThis Reference to instance variable 'metaDataTag' needs "this.". 111
 Warning coding RequireThis Reference to instance variable 'metaDataTag' needs "this.". 112
 Warning coding RequireThis Reference to instance variable 'addAsMetaData' needs "this.". 113
 Warning coding RequireThis Reference to instance variable 'perlChop' needs "this.". 115
 Warning coding RequireThis Reference to instance variable 'nukeAllProxies' needs "this.". 116
 Warning coding RequireThis Reference to instance variable 'keepFilesDebug' needs "this.". 117
 Warning coding RequireThis Reference to instance variable 'charset' needs "this.". 118
 Warning coding RequireThis Reference to instance variable 'charset' needs "this.". 118
 Warning coding RequireThis Reference to instance variable 'executrix' needs "this.". 119
 Warning coding RequireThis Reference to instance variable 'logfilename' needs "this.". 120
 Warning coding RequireThis Reference to instance variable 'executrix' needs "this.". 121
 Warning coding RequireThis Reference to instance variable 'charset' needs "this.". 121
 Warning misc FinalParameters Parameter e should be final. 129
 Warning coding RequireThis Reference to instance variable 'executrix' needs "this.". 130
 Warning coding RequireThis Reference to instance variable 'executrix' needs "this.". 137
 Warning coding RequireThis Reference to instance variable 'executrix' needs "this.". 145
 Warning coding RequireThis Reference to instance variable 'logfilename' needs "this.". 153
 Warning misc FinalParameters Parameter tempDir should be final. 161
 Warning coding FinalLocalVariable Variable 'lfn' should be declared final. 164
 Warning coding RequireThis Reference to instance variable 'logfilename' needs "this.". 164
 Warning coding FinalLocalVariable Variable 'logdata' should be declared final. 165
 Warning coding RequireThis Reference to instance variable 'charset' needs "this.". 167
 Warning misc FinalParameters Parameter cmd should be final. 181
 Warning misc FinalParameters Parameter outputFile should be final. 181
 Warning coding FinalLocalVariable Variable 'errbuf' should be declared final. 183
 Warning coding FinalLocalVariable Variable 'result' should be declared final. 184
 Warning coding RequireThis Reference to instance variable 'executrix' needs "this.". 184
 Warning misc FinalParameters Parameter cmd should be final. 201
 Warning misc FinalParameters Parameter chop should be final. 201
 Warning coding RequireThis Reference to instance variable 'charset' needs "this.". 202
 Warning coding FinalLocalVariable Variable 'outbuf' should be declared final. 203
 Warning coding FinalLocalVariable Variable 'errbuf' should be declared final. 204
 Warning coding FinalLocalVariable Variable 'result' should be declared final. 205
 Warning coding RequireThis Reference to instance variable 'executrix' needs "this.". 205
 Warning coding RequireThis Reference to instance variable 'charset' needs "this.". 205
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 212
 Warning coding RequireThis Reference to instance variable 'charset' needs "this.". 222
 Warning misc FinalParameters Parameter d should be final. 232
 Warning misc FinalParameters Parameter theDataObject should be final. 243
 Warning coding RequireThis Reference to instance variable 'doSynchronized' needs "this.". 245
 Warning misc FinalParameters Parameter theDataObject should be final. 259
 Warning misc FinalParameters Parameter theDataObject should be final. 269
 Warning misc FinalParameters Parameter data should be final. 281
 Warning coding FinalLocalVariable Variable 'names' should be declared final. 282
 Warning coding RequireThis Reference to instance variable 'executrix' needs "this.". 282
 Warning coding FinalLocalVariable Variable 'tempDirName' should be declared final. 283
 Warning coding FinalLocalVariable Variable 'inputFileName' should be declared final. 284
 Warning coding FinalLocalVariable Variable 'outputFileName' should be declared final. 285
 Warning coding FinalLocalVariable Variable 'tempDir' should be declared final. 286
 Warning coding FinalLocalVariable Variable 'written' should be declared final. 295
 Warning coding FinalLocalVariable Variable 'cmd' should be declared final. 298
 Warning coding RequireThis Reference to instance variable 'executrix' needs "this.". 298
 Warning coding RequireThis Reference to instance variable 'executrix' needs "this.". 300
 Warning coding RequireThis Reference to instance variable 'executrix' needs "this.". 302
 Warning coding RequireThis Reference to instance variable 'perlChop' needs "this.". 303
 Warning coding RequireThis Reference to instance variable 'keepFilesDebug' needs "this.". 317
 Warning misc FinalParameters Parameter tData should be final. 334
 Warning misc FinalParameters Parameter newForm should be final. 334
 Warning coding HiddenField 'newForm' hides a field. 334
 Warning misc FinalParameters Parameter outputData should be final. 334
 Warning misc FinalParameters Parameter tData should be final. 345
 Warning misc FinalParameters Parameter tag should be final. 345
 Warning misc FinalParameters Parameter outputData should be final. 345
 Warning coding RequireThis Reference to instance variable 'metaDataTag' needs "this.". 346
 Warning coding RequireThis Reference to instance variable 'newForm' needs "this.". 347
 Warning coding RequireThis Reference to instance variable 'newForm' needs "this.". 348
 Warning misc FinalParameters Parameter tData should be final. 358
 Warning misc FinalParameters Parameter outputData should be final. 358
 Warning misc FinalParameters Parameter tData should be final. 368
 Warning misc FinalParameters Parameter outputData should be final. 368
 Warning misc FinalParameters Parameter tData should be final. 377
 Warning coding RequireThis Reference to instance variable 'newFormOnError' needs "this.". 378
 Warning coding RequireThis Reference to instance variable 'newFormOnError' needs "this.". 379
 Warning misc FinalParameters Parameter serviceType should be final. 391
 Warning misc FinalParameters Parameter tData should be final. 391
 Warning misc FinalParameters Parameter outputData should be final. 391
 Warning misc FinalParameters Parameter tData should be final. 401
 Warning coding FinalLocalVariable Variable 'outputData' should be declared final. 403
 Warning coding FinalLocalVariable Variable 'serviceType' should be declared final. 404
 Warning coding EqualsAvoidNull String literal expressions should be on the left side of an equals comparison. 406
 Warning coding EqualsAvoidNull String literal expressions should be on the left side of an equals comparison. 406
 Warning coding RequireThis Reference to instance variable 'addAsMetaData' needs "this.". 409
 Warning coding RequireThis Reference to instance variable 'metaDataTag' needs "this.". 410
 Warning coding RequireThis Reference to instance variable 'alternateView' needs "this.". 411
 Warning coding RequireThis Reference to instance variable 'alternateView' needs "this.". 412
 Warning coding EqualsAvoidNull String literal expressions should be on the left side of an equals comparison. 416
 Warning coding RequireThis Reference to instance variable 'alternateView' needs "this.". 419
 Warning coding RequireThis Reference to instance variable 'alternateView' needs "this.". 420
 Warning coding RequireThis Reference to instance variable 'addAsMetaData' needs "this.". 421
 Warning coding RequireThis Reference to instance variable 'metaDataTag' needs "this.". 422
 Warning coding RequireThis Reference to instance variable 'nukeAllProxies' needs "this.". 425
 Warning coding RequireThis Reference to instance variable 'newForm' needs "this.". 427
 Warning coding RequireThis Reference to instance variable 'newForm' needs "this.". 428
 Warning coding RequireThis Reference to instance variable 'newForm' needs "this.". 430
 Warning coding RequireThis Reference to instance variable 'newForm' needs "this.". 431
 Warning misc FinalParameters Parameter tData should be final. 446

emissary/place/UnixCommandPlaceTest.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'scriptFile' needs "this.". 51
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 54
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 55
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 56
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 61
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 68
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 69
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 70
 Warning coding RequireThis Reference to instance variable 'scriptFile' needs "this.". 71
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 77
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 80
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 80
 Warning coding FinalLocalVariable Variable 'altView' should be declared final. 81
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 81
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 83
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 89
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 90
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 93
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 93
 Warning coding FinalLocalVariable Variable 'altView' should be declared final. 94
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 94
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 96
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 102
 Warning coding FinalLocalVariable Variable 'mockLogger' should be declared final. 103
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 104
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 106
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 106
 Warning coding FinalLocalVariable Variable 'e' should be declared final. 112
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 119
 Warning coding FinalLocalVariable Variable 'DATA' should be declared final. 122
 Warning coding FinalLocalVariable Variable 'outputFile' should be declared final. 123
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 129
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 130
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 133
 Warning coding FinalLocalVariable Variable 'e' should be declared final. 141
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 144
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 145
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 146
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 148
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 151
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 152
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 155
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 12, expected level should be one of the following: 6, 46, 47. 159
 Warning coding RequireThis Reference to instance variable 'scriptFile' needs "this.". 171
 Warning coding RequireThis Reference to instance variable 'scriptFile' needs "this.". 176
 Warning coding FinalLocalVariable Variable 'fos' should be declared final. 177
 Warning coding RequireThis Reference to instance variable 'scriptFile' needs "this.". 177
 Warning misc FinalParameters Parameter ot should be final. 182
 Warning coding RequireThis Reference to instance variable 'scriptFile' needs "this.". 189

emissary/place/VersionPlace.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'regexPatternForVersion' must be private and have accessor methods. 20
 Warning misc FinalParameters Parameter configInfo should be final. 29
 Warning misc FinalParameters Parameter dir should be final. 29
 Warning misc FinalParameters Parameter placeLoc should be final. 29
 Warning misc FinalParameters Parameter configInfo should be final. 41
 Warning misc FinalParameters Parameter dir should be final. 41
 Warning misc FinalParameters Parameter placeLoc should be final. 41
 Warning misc FinalParameters Parameter configInfo should be final. 51
 Warning coding VariableDeclarationUsageDistance Distance between variable 'gitRepositoryState' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 65
 Warning coding FinalLocalVariable Variable 'gitRepositoryState' should be declared final. 65
 Warning coding RequireThis Reference to instance variable 'includeDate' needs "this.". 67
 Warning coding RequireThis Reference to instance variable 'useAbbrevHash' needs "this.". 68
 Warning coding FinalLocalVariable Variable 'cfgRegex' should be declared final. 70
 Warning coding RequireThis Reference to instance variable 'regexPatternForVersion' needs "this.". 71
 Warning coding RequireThis Reference to instance variable 'formattedVersion' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'versionHash' needs "this.". 74
 Warning misc FinalParameters Parameter payload should be final. 78
 Warning coding RequireThis Reference to instance variable 'formattedVersion' needs "this.". 79
 Warning coding RequireThis Reference to instance variable 'versionHash' needs "this.". 80
 Warning misc FinalParameters Parameter gitRepositoryState should be final. 87
 Warning coding FinalLocalVariable Variable 'version' should be declared final. 88
 Warning coding FinalLocalVariable Variable 'matcher' should be declared final. 89
 Warning coding RequireThis Reference to instance variable 'regexPatternForVersion' needs "this.". 89
 Warning coding RequireThis Reference to instance variable 'includeDate' needs "this.". 95
 Warning coding FinalLocalVariable Variable 'buildTime' should be declared final. 98
 Warning coding FinalLocalVariable Variable 'cutEndMark' should be declared final. 99
 Warning coding FinalLocalVariable Variable 'formattedDate' should be declared final. 100
 Warning misc FinalParameters Parameter gitRepositoryState should be final. 108
 Warning coding RequireThis Reference to instance variable 'useAbbrevHash' needs "this.". 109
 Warning misc FinalParameters Parameter includeDate should be final. 118
 Warning coding HiddenField 'includeDate' hides a field. 118
 Warning misc FinalParameters Parameter useAbbrevHash should be final. 122
 Warning coding HiddenField 'useAbbrevHash' hides a field. 122
 Warning coding RequireThis Reference to instance variable 'includeDate' needs "this.". 127
 Warning coding RequireThis Reference to instance variable 'useAbbrevHash' needs "this.". 131

emissary/place/VersionPlaceTest.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 35
 Warning coding RequireThis Reference to instance variable 'gitRepositoryFile' needs "this.". 36
 Warning coding RequireThis Reference to instance variable 'testGitRepoState' needs "this.". 37
 Warning coding RequireThis Reference to instance variable 'gitRepositoryFile' needs "this.". 37
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 44
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 45
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 46
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 52
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 54
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 54
 Warning coding RequireThis Reference to instance variable 'testGitRepoState' needs "this.". 55
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 55
 Warning coding FinalLocalVariable Variable 'is' should be declared final. 62
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 63
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 65
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 65
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 66
 Warning coding RequireThis Reference to instance variable 'testGitRepoState' needs "this.". 67
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 67
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 75
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 75
 Warning coding RequireThis Reference to instance variable 'testGitRepoState' needs "this.". 76
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 76
 Warning coding FinalLocalVariable Variable 'regexTestFile' should be declared final. 84
 Warning coding FinalLocalVariable Variable 'regexRepoState' should be declared final. 85
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 88
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 89
 Warning misc FinalParameters Parameter is should be final. 98
 Warning coding RequireThis Reference to instance variable 'gitRepositoryFile' needs "VersionPlaceTest.this.". 104

emissary/place/sample/CachePlace.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'cacheSize' must be private and have accessor methods. 16
 Warning design VisibilityModifier Variable 'cache' must be private and have accessor methods. 17
 Warning misc FinalParameters Parameter cfgInfo should be final. 22
 Warning misc FinalParameters Parameter dir should be final. 22
 Warning misc FinalParameters Parameter placeLoc should be final. 22
 Warning misc FinalParameters Parameter cfgInfo should be final. 30
 Warning coding RequireThis Reference to instance variable 'cacheSize' needs "this.". 40
 Warning coding RequireThis Reference to instance variable 'cacheSize' needs "this.". 40
 Warning coding RequireThis Reference to instance variable 'cache' needs "this.". 41
 Warning coding RequireThis Reference to instance variable 'cacheSize' needs "this.". 41
 Warning misc FinalParameters Parameter d should be final. 48
 Warning coding RequireThis Reference to instance variable 'cache' needs "this.". 49
 Warning coding RequireThis Reference to instance variable 'cache' needs "this.". 50
 Warning coding RequireThis Reference to instance variable 'cache' needs "this.". 53
 Warning coding RequireThis Reference to instance variable 'cacheSize' needs "this.". 53
 Warning coding FinalLocalVariable Variable 'evicted' should be declared final. 54
 Warning coding RequireThis Reference to instance variable 'cache' needs "this.". 54
 Warning misc FinalParameters Parameter d should be final. 59
 Warning coding RequireThis Reference to instance variable 'cacheSize' needs "this.". 64
 Warning coding RequireThis Reference to instance variable 'cache' needs "this.". 68
 Warning coding RequireThis Reference to instance variable 'cache' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'cache' needs "this.". 74
 Warning coding RequireThis Reference to instance variable 'cache' needs "this.". 81
 Warning coding RequireThis Reference to instance variable 'cache' needs "this.". 82
 Warning coding RequireThis Reference to instance variable 'cache' needs "this.". 83

emissary/place/sample/DelayPlace.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'delayTimeMillis' must be private and have accessor methods. 13
 Warning misc FinalParameters Parameter configInfo should be final. 18
 Warning misc FinalParameters Parameter dir should be final. 18
 Warning misc FinalParameters Parameter placeLoc should be final. 18
 Warning misc FinalParameters Parameter configInfo should be final. 26
 Warning coding RequireThis Reference to instance variable 'delayTimeMillis' needs "this.". 32
 Warning coding RequireThis Reference to instance variable 'delayTimeMillis' needs "this.". 32
 Warning misc FinalParameters Parameter tData should be final. 39
 Warning coding RequireThis Reference to instance variable 'delayTimeMillis' needs "this.". 44

emissary/place/sample/DevNullPlace.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter configInfo should be final. 16
 Warning misc FinalParameters Parameter dir should be final. 16
 Warning misc FinalParameters Parameter placeLoc should be final. 16
 Warning misc FinalParameters Parameter configInfo should be final. 23
 Warning blocks RightCurly '}' at column 47 should be alone on a line. 27
 Warning misc FinalParameters Parameter tData should be final. 33
 Warning coding FinalLocalVariable Variable 'before' should be declared final. 37
 Warning coding FinalLocalVariable Variable 'after' should be declared final. 38

emissary/place/sample/TemplatePlace.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter cfgInfo should be final. 30
 Warning misc FinalParameters Parameter dir should be final. 30
 Warning misc FinalParameters Parameter placeLoc should be final. 30
 Warning misc FinalParameters Parameter cfgInfo should be final. 40
 Warning misc FinalParameters Parameter cfgInfo should be final. 50
 Warning coding FinalLocalVariable Variable 'myImportantStringVariable' should be declared final. 62
 Warning coding FinalLocalVariable Variable 'myImportantBooleanVariable' should be declared final. 65
 Warning misc FinalParameters Parameter d should be final. 78

emissary/place/sample/ToLowerPlace.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter cfgInfo should be final. 25
 Warning misc FinalParameters Parameter dir should be final. 25
 Warning misc FinalParameters Parameter placeLoc should be final. 25
 Warning misc FinalParameters Parameter cfgInfo should be final. 33
 Warning coding RequireThis Reference to instance variable 'newForm' needs "this.". 44
 Warning coding RequireThis Reference to instance variable 'newForm' needs "this.". 44
 Warning coding RequireThis Reference to instance variable 'endForm' needs "this.". 45
 Warning coding RequireThis Reference to instance variable 'endForm' needs "this.". 45
 Warning misc FinalParameters Parameter d should be final. 52
 Warning coding FinalLocalVariable Variable 'data' should be declared final. 55
 Warning coding RequireThis Reference to instance variable 'newForm' needs "this.". 64
 Warning coding RequireThis Reference to instance variable 'endForm' needs "this.". 66

emissary/place/sample/ToUpperPlace.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter cfgInfo should be final. 25
 Warning misc FinalParameters Parameter dir should be final. 25
 Warning misc FinalParameters Parameter placeLoc should be final. 25
 Warning misc FinalParameters Parameter cfgInfo should be final. 33
 Warning coding RequireThis Reference to instance variable 'newForm' needs "this.". 43
 Warning coding RequireThis Reference to instance variable 'newForm' needs "this.". 43
 Warning coding RequireThis Reference to instance variable 'endForm' needs "this.". 44
 Warning coding RequireThis Reference to instance variable 'endForm' needs "this.". 44
 Warning misc FinalParameters Parameter d should be final. 51
 Warning coding FinalLocalVariable Variable 'data' should be declared final. 54
 Warning coding RequireThis Reference to instance variable 'newForm' needs "this.". 64
 Warning coding RequireThis Reference to instance variable 'endForm' needs "this.". 66

emissary/pool/AgentPool.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'factory' must be private and have accessor methods. 30
 Warning design VisibilityModifier Variable 'namespaceName' must be private and have accessor methods. 40
 Warning misc FinalParameters Parameter factory should be final. 85
 Warning misc FinalParameters Parameter factory should be final. 95
 Warning misc FinalParameters Parameter maxActive should be final. 95
 Warning misc FinalParameters Parameter factory should be final. 107
 Warning misc FinalParameters Parameter maxActive should be final. 107
 Warning misc FinalParameters Parameter name should be final. 107
 Warning coding RequireThis Reference to instance variable 'initialPoolSize' needs "this.". 110
 Warning misc FinalParameters Parameter name should be final. 119
 Warning coding RequireThis Reference to instance variable 'namespaceName' needs "this.". 120
 Warning coding RequireThis Reference to instance variable 'initialPoolSize' needs "this.". 128
 Warning coding RequireThis Reference to instance variable 'initialPoolSize' needs "this.". 130
 Warning coding RequireThis Reference to instance variable 'initialPoolSize' needs "this.". 131
 Warning coding RequireThis Reference to instance variable 'initialPoolSize' needs "this.". 132
 Warning coding FinalLocalVariable Variable 'level' should be declared final. 142
 Warning misc FinalParameters Parameter factory should be final. 158
 Warning coding HiddenField 'factory' hides a field. 158
 Warning coding RequireThis Reference to instance variable 'namespaceName' needs "this.". 174
 Warning coding RequireThis Reference to instance variable 'namespaceName' needs "this.". 181
 Warning coding FinalLocalVariable Variable 'a' should be declared final. 189
 Warning coding FinalLocalVariable Variable 'numberToKill' should be declared final. 207
 Warning coding FinalLocalVariable Variable 'waitTil' should be declared final. 208
 Warning coding FinalLocalVariable Variable 'currentIdle' should be declared final. 217
 Warning coding FinalLocalVariable Variable 'a' should be declared final. 221
 Warning misc FinalParameters Parameter agent should be final. 280
 Warning misc FinalParameters Parameter name should be final. 296
 Warning coding RequireThis Reference to instance variable 'factory' needs "this.". 314

emissary/pool/AgentPoolTest.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter maxMemoryInBytes should be final. 32
 Warning misc FinalParameters Parameter propertyOverride should be final. 33
 Warning misc FinalParameters Parameter expectedPoolSize should be final. 34
 Warning misc FinalParameters Parameter expectedException should be final. 35
 Warning misc FinalParameters Parameter expectedExceptionMsg should be final. 36
 Warning coding FinalLocalVariable Variable 'e' should be declared final. 39

emissary/pool/AgentThreadGroup.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter s should be final. 13
 Warning misc FinalParameters Parameter thread should be final. 18
 Warning misc FinalParameters Parameter throwable should be final. 18

emissary/pool/MobileAgentFactory.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'classString' must be private and have accessor methods. 30
 Warning design VisibilityModifier Variable 'maxAgentMoveErrors' must be private and have accessor methods. 32
 Warning design VisibilityModifier Variable 'maxAgentItinerary' must be private and have accessor methods. 33
 Warning coding FinalLocalVariable Variable 'conf' should be declared final. 49
 Warning coding RequireThis Reference to instance variable 'classString' needs "this.". 50
 Warning coding RequireThis Reference to instance variable 'maxAgentMoveErrors' needs "this.". 52
 Warning coding RequireThis Reference to instance variable 'maxAgentItinerary' needs "this.". 53
 Warning coding RequireThis Reference to instance variable 'classString' needs "this.". 65
 Warning misc FinalParameters Parameter clazz should be final. 73
 Warning coding RequireThis Reference to instance variable 'classString' needs "this.". 77
 Warning misc FinalParameters Parameter arg should be final. 85
 Warning coding FinalLocalVariable Variable 'aname' should be declared final. 98
 Warning coding RequireThis Reference to instance variable 'objectsCreated' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'objectsCreated' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'useNamespace' needs "this.". 100
 Warning coding RequireThis Reference to instance variable 'maxAgentItinerary' needs "this.". 105
 Warning coding RequireThis Reference to instance variable 'maxAgentMoveErrors' needs "this.". 106
 Warning coding RequireThis Reference to instance variable 'useNamespace' needs "this.". 109
 Warning coding RequireThis Reference to instance variable 'objectsCreated' needs "this.". 115
 Warning misc FinalParameters Parameter o should be final. 125
 Warning misc FinalParameters Parameter o should be final. 136
 Warning misc FinalParameters Parameter o should be final. 148
 Warning misc FinalParameters Parameter o should be final. 159
 Warning coding FinalLocalVariable Variable 'a' should be declared final. 160
 Warning coding RequireThis Reference to instance variable 'useNamespace' needs "this.". 163
 Warning misc FinalParameters Parameter s should be final. 174
 Warning coding RequireThis Reference to instance variable 'classString' needs "this.". 175
 Warning coding RequireThis Reference to instance variable 'classString' needs "this.". 184
 Warning coding RequireThis Reference to instance variable 'objectsCreated' needs "this.". 192

emissary/pool/MoveSpool.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'spool' must be private and have accessor methods. 34
 Warning design VisibilityModifier Variable 'pool' must be private and have accessor methods. 37
 Warning design VisibilityModifier Variable 'watcher' must be private and have accessor methods. 40
 Warning design VisibilityModifier Variable 'timeToQuit' must be private and have accessor methods. 43
 Warning design VisibilityModifier Variable 'moveCountMap' must be private and have accessor methods. 49
 Warning design VisibilityModifier Variable 'localDirectory' must be private and have accessor methods. 60
 Warning coding RequireThis Reference to instance variable 'watcher' needs "this.". 86
 Warning coding RequireThis Reference to instance variable 'watcher' needs "this.". 87
 Warning coding RequireThis Reference to instance variable 'watcher' needs "this.". 88
 Warning coding RequireThis Reference to instance variable 'watcher' needs "this.". 89
 Warning coding RequireThis Reference to instance variable 'pool' needs "this.". 95
 Warning coding RequireThis Reference to instance variable 'spool' needs "this.". 107
 Warning coding RequireThis Reference to instance variable 'spool' needs "this.". 108
 Warning coding RequireThis Reference to instance variable 'spool' needs "this.". 109
 Warning coding RequireThis Reference to instance variable 'spool' needs "this.". 111
 Warning coding RequireThis Reference to instance variable 'timeToQuit' needs "this.". 113
 Warning coding RequireThis Reference to instance variable 'localDirectory' needs "this.". 124
 Warning coding FinalLocalVariable Variable 'value' should be declared final. 127
 Warning coding RequireThis Reference to instance variable 'localDirectory' needs "this.". 129
 Warning coding RequireThis Reference to instance variable 'localDirectory' needs "this.". 137
 Warning coding RequireThis Reference to instance variable 'timeToQuit' needs "this.". 149
 Warning coding RequireThis Reference to instance variable 'spool' needs "this.". 152
 Warning coding RequireThis Reference to instance variable 'spool' needs "this.". 153
 Warning coding RequireThis Reference to instance variable 'spool' needs "this.". 162
 Warning coding RequireThis Reference to instance variable 'spool' needs "this.". 163
 Warning coding RequireThis Reference to instance variable 'spool' needs "this.". 164
 Warning coding RequireThis Reference to instance variable 'pool' needs "this.". 182
 Warning coding RequireThis Reference to instance variable 'pool' needs "this.". 192
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 208
 Warning coding RequireThis Reference to instance variable 'pool' needs "this.". 227
 Warning coding RequireThis Reference to instance variable 'spool' needs "this.". 249
 Warning coding RequireThis Reference to instance variable 'spool' needs "this.". 251
 Warning coding RequireThis Reference to instance variable 'highWaterMark' needs "this.". 251
 Warning coding RequireThis Reference to instance variable 'highWaterMark' needs "this.". 252
 Warning coding RequireThis Reference to instance variable 'spool' needs "this.". 252
 Warning coding RequireThis Reference to instance variable 'spool' needs "this.". 255
 Warning coding RequireThis Reference to instance variable 'dequeCount' needs "this.". 256
 Warning misc FinalParameters Parameter payload should be final. 268
 Warning misc FinalParameters Parameter payload should be final. 280
 Warning misc FinalParameters Parameter place should be final. 280
 Warning misc FinalParameters Parameter payload should be final. 293
 Warning misc FinalParameters Parameter place should be final. 293
 Warning misc FinalParameters Parameter errorCount should be final. 293
 Warning misc FinalParameters Parameter itineraryItems should be final. 293
 Warning misc FinalParameters Parameter method should be final. 308
 Warning misc FinalParameters Parameter payload should be final. 308
 Warning misc FinalParameters Parameter place should be final. 308
 Warning misc FinalParameters Parameter errorCount should be final. 308
 Warning misc FinalParameters Parameter itineraryItems should be final. 309
 Warning coding FinalLocalVariable Variable 'itemName' should be declared final. 311
 Warning coding FinalLocalVariable Variable 's' should be declared final. 313
 Warning coding RequireThis Reference to instance variable 'spool' needs "this.". 316
 Warning coding RequireThis Reference to instance variable 'spool' needs "this.". 317
 Warning coding RequireThis Reference to instance variable 'enqueCount' needs "this.". 318
 Warning coding RequireThis Reference to instance variable 'spool' needs "this.". 319
 Warning coding RequireThis Reference to instance variable 'spool' needs "this.". 320
 Warning coding RequireThis Reference to instance variable 'moveCountMap' needs "this.". 324
 Warning coding FinalLocalVariable Variable 'serviceName' should be declared final. 325
 Warning coding RequireThis Reference to instance variable 'moveCountMap' needs "this.". 326
 Warning coding FinalLocalVariable Variable 'count' should be declared final. 327
 Warning coding RequireThis Reference to instance variable 'moveCountMap' needs "this.". 327
 Warning coding RequireThis Reference to instance variable 'moveCountMap' needs "this.". 328
 Warning coding RequireThis Reference to instance variable 'moveCountMap' needs "this.". 330
 Warning coding RequireThis Reference to instance variable 'moveCountMap' needs "this.". 352
 Warning coding RequireThis Reference to instance variable 'moveCountMap' needs "this.". 353
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 363
 Warning coding RequireThis Reference to instance variable 'moveCountMap' needs "this.". 365
 Warning coding RequireThis Reference to instance variable 'moveCountMap' needs "this.". 366
 Warning coding RequireThis Reference to instance variable 'moveCountMap' needs "this.". 370
 Warning coding RequireThis Reference to instance variable 'spool' needs "this.". 384
 Warning coding RequireThis Reference to instance variable 'highWaterMark' needs "this.". 384
 Warning coding RequireThis Reference to instance variable 'enqueCount' needs "this.". 384
 Warning coding RequireThis Reference to instance variable 'dequeCount' needs "this.". 384
 Warning design VisibilityModifier Variable 'method' must be private and have accessor methods. 393
 Warning design VisibilityModifier Variable 'payload' must be private and have accessor methods. 394
 Warning design VisibilityModifier Variable 'place' must be private and have accessor methods. 395
 Warning design VisibilityModifier Variable 'errorCount' must be private and have accessor methods. 396
 Warning design VisibilityModifier Variable 'itineraryItems' must be private and have accessor methods. 397
 Warning misc FinalParameters Parameter method should be final. 399
 Warning misc FinalParameters Parameter payload should be final. 399
 Warning misc FinalParameters Parameter place should be final. 399
 Warning misc FinalParameters Parameter errorCount should be final. 399
 Warning misc FinalParameters Parameter itineraryItems should be final. 399
 Warning coding RequireThis Reference to instance variable 'payload' needs "this.". 411
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 418
 Warning coding RequireThis Reference to instance variable 'errorCount' needs "this.". 425
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 434
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 435
 Warning coding RequireThis Reference to instance variable 'itineraryItems' needs "this.". 446
 Warning coding RequireThis Reference to instance variable 'method' needs "this.". 453
 Warning coding RequireThis Reference to instance variable 'dequeCount' needs "this.". 472
 Warning coding RequireThis Reference to instance variable 'enqueCount' needs "this.". 481
 Warning coding RequireThis Reference to instance variable 'highWaterMark' needs "this.". 490
 Warning coding RequireThis Reference to instance variable 'spool' needs "this.". 494

emissary/pool/PayloadLauncher.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter payload should be final. 25
 Warning misc FinalParameters Parameter place should be final. 25
 Warning misc FinalParameters Parameter errorCount should be final. 25
 Warning misc FinalParameters Parameter itineraryItems should be final. 25
 Warning coding FinalLocalVariable Variable 'payloadName' should be declared final. 27
 Warning coding FinalLocalVariable Variable 'sz' should be declared final. 41
 Warning blocks RightCurly '}' at column 32 should be alone on a line. 84

emissary/roll/RollManager.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'executorThreadCount' must be private and have accessor methods. 26
 Warning design VisibilityModifier Variable 'exec' must be private and have accessor methods. 27
 Warning design VisibilityModifier Variable 'rollers' must be private and have accessor methods. 29
 Warning misc FinalParameters Parameter configG should be final. 39
 Warning coding FinalLocalVariable Variable 'configG' should be declared final. 49
 Warning misc FinalParameters Parameter configG should be final. 61
 Warning coding FinalLocalVariable Variable 'cfgRollers' should be declared final. 62
 Warning coding RequireThis Reference to instance variable 'executorThreadCount' needs "this.". 63
 Warning coding RequireThis Reference to instance variable 'executorThreadCount' needs "this.". 63
 Warning coding FinalLocalVariable Variable 'map' should be declared final. 66
 Warning coding RequireThis Reference to instance variable 'exec' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'executorThreadCount' needs "this.". 73
 Warning misc FinalParameters Parameter r should be final. 79
 Warning coding FinalLocalVariable Variable 'time' should be declared final. 80
 Warning coding FinalLocalVariable Variable 'progress' should be declared final. 81
 Warning coding FinalLocalVariable Variable 'unused' should be declared final. 86
 Warning coding RequireThis Reference to instance variable 'exec' needs "this.". 86
 Warning coding RequireThis Reference to instance variable 'rollers' needs "this.". 92
 Warning misc FinalParameters Parameter evt should be final. 100
 Warning coding RequireThis Reference to instance variable 'rollers' needs "this.". 101
 Warning coding FinalLocalVariable Variable 'r' should be declared final. 102
 Warning coding RequireThis Reference to instance variable 'exec' needs "this.". 105
 Warning misc FinalParameters Parameter configG should be final. 126
 Warning coding FinalLocalVariable Variable 'r' should be declared final. 137
 Warning design VisibilityModifier Variable 'count' must be private and have accessor methods. 149
 Warning misc FinalParameters Parameter r should be final. 152
 Warning coding FinalLocalVariable Variable 't' should be declared final. 153
 Warning coding RequireThis Reference to instance variable 'count' needs "this.". 153

emissary/roll/RollManagerTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'rm' should be declared final. 26
 Warning coding FinalLocalVariable Variable 'r' should be declared final. 27
 Warning coding FinalLocalVariable Variable 'rm' should be declared final. 35
 Warning coding FinalLocalVariable Variable 'r' should be declared final. 36
 Warning coding FinalLocalVariable Variable 'o' should be declared final. 37
 Warning coding FinalLocalVariable Variable 'rm' should be declared final. 48
 Warning coding FinalLocalVariable Variable 'r' should be declared final. 50
 Warning coding FinalLocalVariable Variable 'rm' should be declared final. 60
 Warning coding FinalLocalVariable Variable 'latch' should be declared final. 61
 Warning coding FinalLocalVariable Variable 'r' should be declared final. 62
 Warning design VisibilityModifier Variable 'i' must be private and have accessor methods. 63
 Warning coding RequireThis Reference to instance variable 'i' needs "this.". 67
 Warning design VisibilityModifier Variable 'o' must be private and have accessor methods. 90
 Warning design VisibilityModifier Variable 'prop' must be private and have accessor methods. 91
 Warning misc FinalParameters Parameter evt should be final. 94

emissary/roll/RollScheduledExecutor.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter corePoolSize should be final. 22
 Warning misc FinalParameters Parameter threadFactory should be final. 22
 Warning misc FinalParameters Parameter runnable should be final. 27
 Warning misc FinalParameters Parameter task should be final. 27
 Warning misc FinalParameters Parameter r should be final. 36
 Warning misc FinalParameters Parameter t should be final. 36
 Warning coding FinalLocalVariable Variable 'f' should be declared final. 39
 Warning coding FinalLocalVariable Variable 'ex' should be declared final. 50
 Warning coding FinalLocalVariable Variable 'rollable' should be declared final. 51
 Warning design VisibilityModifier Variable 'r' must be private and have accessor methods. 62
 Warning modifier RedundantModifier Redundant 'public' modifier. 64
 Warning misc FinalParameters Parameter rsf should be final. 64
 Warning misc FinalParameters Parameter r should be final. 64
 Warning coding RequireThis Reference to instance variable 'rsf' needs "this.". 71
 Warning coding RequireThis Reference to instance variable 'rsf' needs "this.". 76
 Warning misc FinalParameters Parameter mayInterruptIfRunning should be final. 80
 Warning coding RequireThis Reference to instance variable 'rsf' needs "this.". 81
 Warning coding RequireThis Reference to instance variable 'rsf' needs "this.". 86
 Warning coding RequireThis Reference to instance variable 'rsf' needs "this.". 91
 Warning coding RequireThis Reference to instance variable 'rsf' needs "this.". 96
 Warning misc FinalParameters Parameter timeout should be final. 100
 Warning misc FinalParameters Parameter unit should be final. 100
 Warning coding RequireThis Reference to instance variable 'rsf' needs "this.". 101
 Warning misc FinalParameters Parameter unit should be final. 105
 Warning coding RequireThis Reference to instance variable 'rsf' needs "this.". 106
 Warning misc FinalParameters Parameter o should be final. 110
 Warning coding RequireThis Reference to instance variable 'rsf' needs "this.". 111

emissary/roll/RollUtil.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter configG should be final. 19
 Warning misc FinalParameters Parameter configG should be final. 29
 Warning misc FinalParameters Parameter config should be final. 43
 Warning coding FinalLocalVariable Variable 'clz' should be declared final. 44
 Warning coding FinalLocalVariable Variable 'r' should be declared final. 46
 Warning coding FinalLocalVariable Variable 't' should be declared final. 47
 Warning coding FinalLocalVariable Variable 'period' should be declared final. 48
 Warning coding FinalLocalVariable Variable 'max' should be declared final. 49
 Warning misc FinalParameters Parameter l should be final. 54
 Warning misc FinalParameters Parameter unit should be final. 60
 Warning blocks RightCurly '}' at column 25 should be alone on a line. 65

emissary/roll/RollableTest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'wasRolled' must be private and have accessor methods. 12
 Warning design VisibilityModifier Variable 'updateCount' must be private and have accessor methods. 13
 Warning design VisibilityModifier Variable 'x' must be private and have accessor methods. 14
 Warning blocks RightCurly '}' at column 28 should be alone on a line. 16
 Warning coding RequireThis Reference to instance variable 'x' needs "this.". 20
 Warning coding RequireThis Reference to instance variable 'wasRolled' needs "this.". 21
 Warning coding RequireThis Reference to instance variable 'x' needs "this.". 31
 Warning blocks RightCurly '}' at column 45 should be alone on a line. 35
 Warning misc FinalParameters Parameter evt should be final. 39
 Warning coding FinalLocalVariable Variable 'r' should be declared final. 41
 Warning coding RequireThis Reference to instance variable 'updateCount' needs "this.". 43
 Warning coding RequireThis Reference to instance variable 'updateCount' needs "this.". 48

emissary/roll/Roller.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter max should be final. 36
 Warning misc FinalParameters Parameter t should be final. 36
 Warning misc FinalParameters Parameter period should be final. 36
 Warning misc FinalParameters Parameter r should be final. 36
 Warning misc FinalParameters Parameter t should be final. 44
 Warning misc FinalParameters Parameter period should be final. 44
 Warning misc FinalParameters Parameter r should be final. 44
 Warning misc FinalParameters Parameter t should be final. 48
 Warning misc FinalParameters Parameter period should be final. 48
 Warning misc FinalParameters Parameter r should be final. 48
 Warning misc FinalParameters Parameter max should be final. 48
 Warning misc FinalParameters Parameter pcl should be final. 56
 Warning coding RequireThis Reference to instance variable 'support' needs "this.". 57
 Warning misc FinalParameters Parameter pcl should be final. 60
 Warning coding RequireThis Reference to instance variable 'support' needs "this.". 61
 Warning misc FinalParameters Parameter val should be final. 68
 Warning coding RequireThis Reference to instance variable 'lock' needs "this.". 69
 Warning coding FinalLocalVariable Variable 'progressValue' should be declared final. 71
 Warning coding RequireThis Reference to instance variable 'progress' needs "this.". 71
 Warning coding RequireThis Reference to instance variable 'max' needs "this.". 72
 Warning coding RequireThis Reference to instance variable 'support' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'lock' needs "this.". 77
 Warning coding RequireThis Reference to instance variable 'max' needs "this.". 82
 Warning coding RequireThis Reference to instance variable 'progress' needs "this.". 86
 Warning coding RequireThis Reference to instance variable 't' needs "this.". 90
 Warning coding RequireThis Reference to instance variable 'period' needs "this.". 94
 Warning coding RequireThis Reference to instance variable 'r' needs "this.". 98
 Warning misc FinalParameters Parameter start should be final. 105
 Warning coding RequireThis Reference to instance variable 'lock' needs "this.". 106
 Warning coding RequireThis Reference to instance variable 'progress' needs "this.". 108
 Warning coding RequireThis Reference to instance variable 'lastRun' needs "this.". 109
 Warning coding RequireThis Reference to instance variable 'lock' needs "this.". 111
 Warning coding RequireThis Reference to instance variable 'lastRun' needs "this.". 116
 Warning coding RequireThis Reference to instance variable 'progressSchedule' needs "this.". 121
 Warning coding FinalLocalVariable Variable 'start' should be declared final. 127
 Warning coding RequireThis Reference to instance variable 'r' needs "this.". 128
 Warning coding RequireThis Reference to instance variable 'r' needs "this.". 129
 Warning coding RequireThis Reference to instance variable 'r' needs "this.". 135
 Warning coding RequireThis Reference to instance variable 'r' needs "this.". 136
 Warning coding FinalLocalVariable Variable 'time' should be declared final. 137
 Warning coding RequireThis Reference to instance variable 'r' needs "this.". 139
 Warning coding RequireThis Reference to instance variable 'progressSchedule' needs "this.". 141
 Warning coding RequireThis Reference to instance variable 'period' needs "this.". 147
 Warning coding RequireThis Reference to instance variable 't' needs "this.". 147
 Warning misc FinalParameters Parameter start should be final. 154
 Warning coding RequireThis Reference to instance variable 'period' needs "this.". 157
 Warning coding RequireThis Reference to instance variable 'max' needs "this.". 157
 Warning coding RequireThis Reference to instance variable 'progress' needs "this.". 157
 Warning coding RequireThis Reference to instance variable 'max' needs "this.". 157
 Warning coding RequireThis Reference to instance variable 'lastRun' needs "this.". 159

emissary/server/EmissaryServer.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter cmd should be final. 98
 Warning misc FinalParameters Parameter cmd should be final. 104
 Warning misc FinalParameters Parameter node should be final. 104
 Warning misc FinalParameters Parameter cmd should be final. 109
 Warning misc FinalParameters Parameter cmd should be final. 115
 Warning misc FinalParameters Parameter node should be final. 115
 Warning coding RequireThis Reference to instance variable 'cmd' needs "this.". 136
 Warning coding FinalLocalVariable Variable 'emissaryHandler' should be declared final. 150
 Warning coding FinalLocalVariable Variable 'lbConfigHandler' should be declared final. 154
 Warning coding FinalLocalVariable Variable 'apiHandler' should be declared final. 156
 Warning coding FinalLocalVariable Variable 'mvcHandler' should be declared final. 158
 Warning coding FinalLocalVariable Variable 'staticHandler' should be declared final. 161
 Warning coding FinalLocalVariable Variable 'loginService' should be declared final. 164
 Warning coding FinalLocalVariable Variable 'security' should be declared final. 165
 Warning coding FinalLocalVariable Variable 'configuredServer' should be declared final. 180
 Warning coding FinalLocalVariable Variable 'serverLocation' should be declared final. 194
 Warning coding RequireThis Reference to instance variable 'cmd' needs "this.". 194
 Warning coding RequireThis Reference to instance variable 'cmd' needs "this.". 194
 Warning coding RequireThis Reference to instance variable 'cmd' needs "this.". 194
 Warning coding FinalLocalVariable Variable 'envsh' should be declared final. 197
 Warning coding FinalLocalVariable Variable 'envUri' should be declared final. 202
 Warning coding FinalLocalVariable Variable 'er' should be declared final. 203
 Warning coding FinalLocalVariable Variable 'envString' should be declared final. 204
 Warning coding RequireThis Reference to instance variable 'cmd' needs "this.". 210
 Warning coding FinalLocalVariable Variable 'errorMsg' should be declared final. 226
 Warning misc FinalParameters Parameter silent should be final. 256
 Warning misc FinalParameters Parameter silent should be final. 276
 Warning coding FinalLocalVariable Variable 'sentinel' should be declared final. 341
 Warning coding FinalLocalVariable Variable 'obj' should be declared final. 374
 Warning coding FinalLocalVariable Variable 'rw' should be declared final. 392
 Warning misc FinalParameters Parameter initialLog should be final. 435
 Warning coding FinalLocalVariable Variable 'tda' should be declared final. 437
 Warning coding FinalLocalVariable Variable 'dumps' should be declared final. 438
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 439
 Warning coding FinalLocalVariable Variable 'threadcount' should be declared final. 445
 Warning coding FinalLocalVariable Variable 'pool' should be declared final. 465
 Warning coding VariableDeclarationUsageDistance Distance between variable 'handler' declaration and its first usage is 10, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 558
 Warning coding FinalLocalVariable Variable 'handler' should be declared final. 558
 Warning coding FinalLocalVariable Variable 'authConstraint' should be declared final. 560
 Warning coding FinalLocalVariable Variable 'noAuthConstraint' should be declared final. 565
 Warning coding FinalLocalVariable Variable 'mapping' should be declared final. 569
 Warning coding FinalLocalVariable Variable 'health' should be declared final. 573
 Warning coding FinalLocalVariable Variable 'jettyUsersFile' should be declared final. 583
 Warning coding FinalLocalVariable Variable 'homeHolder' should be declared final. 600
 Warning coding RequireThis Reference to instance variable 'cmd' needs "this.". 602
 Warning coding RequireThis Reference to instance variable 'cmd' needs "this.". 607
 Warning coding RequireThis Reference to instance variable 'cmd' needs "this.". 608
 Warning coding FinalLocalVariable Variable 'homeContextHandler' should be declared final. 614
 Warning coding FinalLocalVariable Variable 'apiHolder' should be declared final. 629
 Warning coding FinalLocalVariable Variable 'apiHolderContext' should be declared final. 631
 Warning coding FinalLocalVariable Variable 'mvcHolder' should be declared final. 647
 Warning coding FinalLocalVariable Variable 'mvcHolderContext' should be declared final. 650
 Warning misc FinalParameters Parameter application should be final. 656
 Warning coding FinalLocalVariable Variable 'configDir' should be declared final. 667
 Warning coding RequireThis Reference to instance variable 'cmd' needs "this.". 672
 Warning coding RequireThis Reference to instance variable 'cmd' needs "this.". 673
 Warning coding FinalLocalVariable Variable 'emissaryHolderContext' should be declared final. 676
 Warning coding RequireThis Reference to instance variable 'emissaryNode' needs "this.". 677
 Warning coding FinalLocalVariable Variable 'lbHolder' should be declared final. 683
 Warning coding FinalLocalVariable Variable 'lbHolderContext' should be declared final. 684
 Warning coding FinalLocalVariable Variable 'maxThreads' should be declared final. 692
 Warning coding FinalLocalVariable Variable 'minThreads' should be declared final. 693
 Warning coding FinalLocalVariable Variable 'lowThreads' should be declared final. 694
 Warning coding FinalLocalVariable Variable 'threadsPriority' should be declared final. 695
 Warning coding FinalLocalVariable Variable 'idleTimeout' should be declared final. 696
 Warning coding FinalLocalVariable Variable 'threadPool' should be declared final. 698
 Warning coding FinalLocalVariable Variable 'configuredServer' should be declared final. 702
 Warning misc FinalParameters Parameter server should be final. 716
 Warning coding HiddenField 'server' hides a field. 716
 Warning coding FinalLocalVariable Variable 'connector' should be declared final. 717
 Warning coding RequireThis Reference to instance variable 'cmd' needs "this.". 717
 Warning coding RequireThis Reference to instance variable 'cmd' needs "this.". 718
 Warning coding RequireThis Reference to instance variable 'cmd' needs "this.". 719
 Warning misc FinalParameters Parameter server should be final. 729
 Warning misc FinalParameters Parameter server should be final. 740
 Warning coding HiddenField 'server' hides a field. 740
 Warning coding FinalLocalVariable Variable 'httpConfig' should be declared final. 741
 Warning coding RequireThis Reference to instance variable 'cmd' needs "this.". 743
 Warning coding FinalLocalVariable Variable 'httpsConfig' should be declared final. 745
 Warning coding FinalLocalVariable Variable 'secureRequestCustomizer' should be declared final. 766
 Warning coding RequireThis Reference to instance variable 'cmd' needs "this.". 767
 Warning coding FinalLocalVariable Variable 'httpConnFactCfg' should be declared final. 779
 Warning coding FinalLocalVariable Variable 'keystore' should be declared final. 780
 Warning coding FinalLocalVariable Variable 'keystorePass' should be declared final. 782
 Warning coding FinalLocalVariable Variable 'trustStore' should be declared final. 784
 Warning coding FinalLocalVariable Variable 'trustStorePass' should be declared final. 786
 Warning coding FinalLocalVariable Variable 'sslContextFactory' should be declared final. 789
 Warning coding FinalLocalVariable Variable 'trustStoreInstance' should be declared final. 793

emissary/server/EmissaryServerIT.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'cmd' should be declared final. 27
 Warning coding FinalLocalVariable Variable 'server' should be declared final. 28
 Warning coding FinalLocalVariable Variable 'jettyServer' should be declared final. 29
 Warning coding FinalLocalVariable Variable 'pool' should be declared final. 30
 Warning coding FinalLocalVariable Variable 'cmd' should be declared final. 40
 Warning coding FinalLocalVariable Variable 'server' should be declared final. 41
 Warning coding FinalLocalVariable Variable 'client' should be declared final. 44
 Warning coding FinalLocalVariable Variable 'hostPort' should be declared final. 45
 Warning coding FinalLocalVariable Variable 'endpoint' should be declared final. 46
 Warning coding FinalLocalVariable Variable 'versionMap' should be declared final. 47
 Warning coding FinalLocalVariable Variable 'response' should be declared final. 48
 Warning coding FinalLocalVariable Variable 'cmd' should be declared final. 58
 Warning coding FinalLocalVariable Variable 'server' should be declared final. 59
 Warning coding FinalLocalVariable Variable 'node' should be declared final. 60
 Warning coding FinalLocalVariable Variable 'location' should be declared final. 61

emissary/server/InitializeContext.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter node should be final. 38
 Warning coding RequireThis Reference to instance variable 'node' needs "this.". 47
 Warning coding RequireThis Reference to instance variable 'node' needs "this.". 49

emissary/server/InitializeContextTest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'context' must be private and have accessor methods. 17
 Warning design VisibilityModifier Variable 'node' must be private and have accessor methods. 18
 Warning design VisibilityModifier Variable 'event' must be private and have accessor methods. 19
 Warning coding RequireThis Reference to instance variable 'node' needs "this.". 24
 Warning coding RequireThis Reference to instance variable 'event' needs "this.". 25
 Warning coding RequireThis Reference to instance variable 'context' needs "this.". 26
 Warning coding RequireThis Reference to instance variable 'node' needs "this.". 26
 Warning coding RequireThis Reference to instance variable 'context' needs "this.". 31
 Warning coding RequireThis Reference to instance variable 'event' needs "this.". 31
 Warning coding RequireThis Reference to instance variable 'node' needs "this.". 32

emissary/server/api/Agents.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 76
 Warning coding FinalLocalVariable Variable 'client' should be declared final. 80
 Warning coding FinalLocalVariable Variable 'remoteEndPoint' should be declared final. 82
 Warning coding FinalLocalVariable Variable 'remoteEntity' should be declared final. 83
 Warning misc FinalParameters Parameter delimiter should be final. 93
 Warning misc FinalParameters Parameter prefix should be final. 93
 Warning misc FinalParameters Parameter suffix should be final. 93
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 94
 Warning coding FinalLocalVariable Variable 'formatter' should be declared final. 95
 Warning coding FinalLocalVariable Variable 'joiner' should be declared final. 96
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 103
 Warning coding FinalLocalVariable Variable 'emissaryServer' should be declared final. 105
 Warning coding FinalLocalVariable Variable 'localNode' should be declared final. 106
 Warning coding FinalLocalVariable Variable 'localName' should be declared final. 107
 Warning coding FinalLocalVariable Variable 'agents' should be declared final. 108
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 114
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 121

emissary/server/api/ApiUtils.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter peer should be final. 22
 Warning coding FinalLocalVariable Variable 'emissaryServer' should be declared final. 31
 Warning coding FinalLocalVariable Variable 'localNode' should be declared final. 32
 Warning blocks RightCurly '}' at column 25 should be alone on a line. 40

emissary/server/api/Configs.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter name should be final. 37
 Warning misc FinalParameters Parameter name should be final. 44
 Warning misc FinalParameters Parameter name should be final. 55
 Warning misc FinalParameters Parameter detailed should be final. 55
 Warning coding FinalLocalVariable Variable 'cre' should be declared final. 59
 Warning misc FinalParameters Parameter name should be final. 72
 Warning misc FinalParameters Parameter detailed should be final. 72
 Warning coding FinalLocalVariable Variable 'list' should be declared final. 84
 Warning coding FinalLocalVariable Variable 'detailed' should be declared final. 98
 Warning coding FinalLocalVariable Variable 'flavors' should be declared final. 99
 Warning coding FinalLocalVariable Variable 'flavoredCfgs' should be declared final. 106
 Warning coding FinalLocalVariable Variable 'flavor' should be declared final. 108
 Warning misc FinalParameters Parameter config should be final. 124
 Warning misc FinalParameters Parameter flavoredConfigs should be final. 138
 Warning coding FinalLocalVariable Variable 'configs' should be declared final. 139
 Warning misc FinalParameters Parameter cfg should be final. 150
 Warning misc FinalParameters Parameter detailed should be final. 167
 Warning misc FinalParameters Parameter flavors should be final. 167
 Warning misc FinalParameters Parameter configs should be final. 167
 Warning misc FinalParameters Parameter cfgFile should be final. 167

emissary/server/api/Directories.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 35
 Warning coding FinalLocalVariable Variable 'dirPlace' should be declared final. 37
 Warning coding FinalLocalVariable Variable 'entries' should be declared final. 38
 Warning coding FinalLocalVariable Variable 'dirEntries' should be declared final. 40
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 47
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 49

emissary/server/api/EmissaryApiTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'mockServer' should be declared final. 57
 Warning coding FinalLocalVariable Variable 'node' should be declared final. 58
 Warning coding FinalLocalVariable Variable 'srvCmd' should be declared final. 59
 Warning coding FinalLocalVariable Variable 'expectedAgents' should be declared final. 83
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 16, expected level should be 10. 84
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 16, expected level should be 10. 85
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 16, expected level should be 10. 86
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 16, expected level should be 10. 87
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 16, expected level should be 10. 88
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 16, expected level should be 10. 89
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 16, expected level should be 10. 90
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 16, expected level should be 10. 91
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 16, expected level should be 10. 92
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 16, expected level should be 10. 93
 Warning coding FinalLocalVariable Variable 'pool' should be declared final. 95
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 100
 Warning coding FinalLocalVariable Variable 'pool' should be declared final. 113
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 117
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 134
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 152
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 165
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 178
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 189
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 206
 Warning coding FinalLocalVariable Variable 'expEntryKeys' should be declared final. 221
 Warning coding FinalLocalVariable Variable 'expDataIds' should be declared final. 226
 Warning coding FinalLocalVariable Variable 'expCost' should be declared final. 231
 Warning coding FinalLocalVariable Variable 'expExpense' should be declared final. 236
 Warning coding FinalLocalVariable Variable 'loc' should be declared final. 242
 Warning coding FinalLocalVariable Variable 'mockDir' should be declared final. 246
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 252
 Warning coding FinalLocalVariable Variable 'foundEntryKeys' should be declared final. 259
 Warning coding FinalLocalVariable Variable 'foundDataIds' should be declared final. 260
 Warning coding FinalLocalVariable Variable 'foundCost' should be declared final. 261
 Warning coding FinalLocalVariable Variable 'foundExpense' should be declared final. 262
 Warning coding FinalLocalVariable Variable 'metrics' should be declared final. 282
 Warning coding VariableDeclarationUsageDistance Distance between variable 'manager' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 283
 Warning coding FinalLocalVariable Variable 'manager' should be declared final. 283
 Warning coding FinalLocalVariable Variable 'registry' should be declared final. 284
 Warning coding FinalLocalVariable Variable 'metric' should be declared final. 286
 Warning coding FinalLocalVariable Variable 'metricsMap' should be declared final. 298
 Warning coding FinalLocalVariable Variable 'health' should be declared final. 307
 Warning coding FinalLocalVariable Variable 'registry' should be declared final. 308
 Warning coding FinalLocalVariable Variable 'manager' should be declared final. 309
 Warning coding FinalLocalVariable Variable 'PEER' should be declared final. 329
 Warning coding FinalLocalVariable Variable 'PEERS' should be declared final. 330
 Warning coding FinalLocalVariable Variable 'mockDirectory' should be declared final. 332
 Warning coding FinalLocalVariable Variable 'results' should be declared final. 337
 Warning coding FinalLocalVariable Variable 'hostAndPort' should be declared final. 345

emissary/server/api/Env.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 46
 Warning coding FinalLocalVariable Variable 'server' should be declared final. 48
 Warning coding FinalLocalVariable Variable 'command' should be declared final. 49
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 57
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 59
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 66
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 67

emissary/server/api/HealthCheckAction.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 28

emissary/server/api/MetricsAction.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 27

emissary/server/api/Pause.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter request should be final. 27
 Warning misc FinalParameters Parameter request should be final. 39
 Warning misc FinalParameters Parameter pause should be final. 48

emissary/server/api/Peers.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 39
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 49
 Warning coding FinalLocalVariable Variable 'peers' should be declared final. 50
 Warning coding FinalLocalVariable Variable 'client' should be declared final. 56
 Warning coding FinalLocalVariable Variable 'remoteEndPoint' should be declared final. 58
 Warning coding FinalLocalVariable Variable 'remoteEntity' should be declared final. 59
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 63

emissary/server/api/PeersIT.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'projectBase' should be declared final. 44
 Warning coding FinalLocalVariable Variable 'cmd' should be declared final. 45
 Warning coding FinalLocalVariable Variable 'server' should be declared final. 47
 Warning coding FinalLocalVariable Variable 'directoryPlace' should be declared final. 50
 Warning coding FinalLocalVariable Variable 'response' should be declared final. 64
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 68
 Warning coding FinalLocalVariable Variable 'response' should be declared final. 82
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 86
 Warning coding FinalLocalVariable Variable 'response' should be declared final. 100
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 104
 Warning modifier RedundantModifier Redundant 'public' modifier. 111
 Warning misc FinalParameters Parameter mode should be final. 111

emissary/server/api/Places.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 50
 Warning coding FinalLocalVariable Variable 'peers' should be declared final. 54
 Warning coding FinalLocalVariable Variable 'client' should be declared final. 55
 Warning coding FinalLocalVariable Variable 'remoteEndPoint' should be declared final. 57
 Warning coding FinalLocalVariable Variable 'remoteEntity' should be declared final. 58
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 70
 Warning coding FinalLocalVariable Variable 'emissaryServer' should be declared final. 72
 Warning coding FinalLocalVariable Variable 'localNode' should be declared final. 73
 Warning coding FinalLocalVariable Variable 'localName' should be declared final. 74
 Warning coding FinalLocalVariable Variable 'places' should be declared final. 75
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 86

emissary/server/api/Pool.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 47
 Warning coding FinalLocalVariable Variable 'client' should be declared final. 52
 Warning coding FinalLocalVariable Variable 'remoteEndPoint' should be declared final. 54
 Warning coding FinalLocalVariable Variable 'remoteEntity' should be declared final. 55
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 66
 Warning coding FinalLocalVariable Variable 'emissaryServer' should be declared final. 69
 Warning coding FinalLocalVariable Variable 'localNode' should be declared final. 70
 Warning coding FinalLocalVariable Variable 'nodeName' should be declared final. 71
 Warning coding FinalLocalVariable Variable 'agentKey' should be declared final. 76
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 85
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 93
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 98

emissary/server/api/Shutdown.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter request should be final. 26
 Warning misc FinalParameters Parameter request should be final. 33
 Warning misc FinalParameters Parameter request should be final. 38
 Warning misc FinalParameters Parameter force should be final. 38

emissary/server/api/Version.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 49
 Warning coding FinalLocalVariable Variable 'peers' should be declared final. 53
 Warning coding FinalLocalVariable Variable 'client' should be declared final. 54
 Warning coding FinalLocalVariable Variable 'remoteEndPoint' should be declared final. 56
 Warning coding FinalLocalVariable Variable 'remoteEntity' should be declared final. 57
 Warning coding FinalLocalVariable Variable 'entity' should be declared final. 68
 Warning coding FinalLocalVariable Variable 'emissaryServer' should be declared final. 71
 Warning coding FinalLocalVariable Variable 'localNode' should be declared final. 72
 Warning coding FinalLocalVariable Variable 'localPort' should be declared final. 73
 Warning coding FinalLocalVariable Variable 'localName' should be declared final. 74
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 78

emissary/server/mvc/DumpDirectoryAction.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter request should be final. 40
 Warning misc FinalParameters Parameter targetDir should be final. 40
 Warning coding FinalLocalVariable Variable 'map' should be declared final. 41
 Warning coding FinalLocalVariable Variable 'errors' should be declared final. 43
 Warning coding FinalLocalVariable Variable 'cleanTargetDirectory' should be declared final. 45
 Warning coding FinalLocalVariable Variable 'entryKeys' should be declared final. 71
 Warning coding FinalLocalVariable Variable 'now' should be declared final. 72
 Warning coding FinalLocalVariable Variable 'list' should be declared final. 77
 Warning coding FinalLocalVariable Variable 'peers' should be declared final. 92
 Warning design VisibilityModifier Variable 'link' must be private and have accessor methods. 115
 Warning design VisibilityModifier Variable 'peerkey' must be private and have accessor methods. 116
 Warning design VisibilityModifier Variable 'status' must be private and have accessor methods. 117
 Warning misc FinalParameters Parameter peerkey should be final. 119
 Warning misc FinalParameters Parameter healthy should be final. 119
 Warning design VisibilityModifier Variable 'dataId' must be private and have accessor methods. 129
 Warning design VisibilityModifier Variable 'entrylist' must be private and have accessor methods. 130
 Warning misc FinalParameters Parameter dataId should be final. 132
 Warning misc FinalParameters Parameter list should be final. 132
 Warning design VisibilityModifier Variable 'stripe' must be private and have accessor methods. 140
 Warning design VisibilityModifier Variable 'key' must be private and have accessor methods. 141
 Warning design VisibilityModifier Variable 'cost' must be private and have accessor methods. 142
 Warning design VisibilityModifier Variable 'quality' must be private and have accessor methods. 143
 Warning design VisibilityModifier Variable 'expense' must be private and have accessor methods. 144
 Warning design VisibilityModifier Variable 'age' must be private and have accessor methods. 145
 Warning misc FinalParameters Parameter stripe should be final. 147
 Warning misc FinalParameters Parameter entry should be final. 147
 Warning misc FinalParameters Parameter now should be final. 147
 Warning coding FinalLocalVariable Variable 'ago' should be declared final. 153
 Warning coding FinalLocalVariable Variable 'hh' should be declared final. 154
 Warning coding FinalLocalVariable Variable 'mm' should be declared final. 155
 Warning coding FinalLocalVariable Variable 'ss' should be declared final. 156
 Warning coding FinalLocalVariable Variable 'hhs' should be declared final. 157
 Warning coding FinalLocalVariable Variable 'mms' should be declared final. 158
 Warning coding FinalLocalVariable Variable 'sss' should be declared final. 159

emissary/server/mvc/EmissaryMvcTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'list' should be declared final. 30
 Warning coding FinalLocalVariable Variable 'dir' should be declared final. 33
 Warning coding FinalLocalVariable Variable 'out' should be declared final. 41
 Warning coding FinalLocalVariable Variable 'out' should be declared final. 58
 Warning coding FinalLocalVariable Variable 'action' should be declared final. 75
 Warning coding FinalLocalVariable Variable 'request' should be declared final. 76
 Warning coding FinalLocalVariable Variable 'out' should be declared final. 80
 Warning coding FinalLocalVariable Variable 'namespaceInfoSet' should be declared final. 83
 Warning coding FinalLocalVariable Variable 'found' should be declared final. 85
 Warning coding FinalLocalVariable Variable 'out' should be declared final. 108
 Warning coding FinalLocalVariable Variable 'list' should be declared final. 119
 Warning coding FinalLocalVariable Variable 'idir' should be declared final. 123
 Warning coding FinalLocalVariable Variable 'out' should be declared final. 132
 Warning coding FinalLocalVariable Variable 'out' should be declared final. 150
 Warning coding FinalLocalVariable Variable 'out' should be declared final. 160
 Warning coding FinalLocalVariable Variable 'out' should be declared final. 170

emissary/server/mvc/EnvironmentAction.java

Severity Category Rule Message Line
 Warning coding VariableDeclarationUsageDistance Distance between variable 'model' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 24
 Warning coding FinalLocalVariable Variable 'model' should be declared final. 24
 Warning coding FinalLocalVariable Variable 'systemProperties' should be declared final. 26
 Warning coding FinalLocalVariable Variable 'e' should be declared final. 27
 Warning coding FinalLocalVariable Variable 'keys' should be declared final. 28
 Warning coding FinalLocalVariable Variable 'environmentVariables' should be declared final. 36
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 37
 Warning design VisibilityModifier Variable 'string' must be private and have accessor methods. 49
 Warning modifier RedundantModifier Redundant 'public' modifier. 51
 Warning misc FinalParameters Parameter string should be final. 51
 Warning misc FinalParameters Parameter o should be final. 56
 Warning coding FinalLocalVariable Variable 'len1' should be declared final. 57
 Warning coding RequireThis Reference to instance variable 'string' needs "this.". 57
 Warning coding FinalLocalVariable Variable 'len2' should be declared final. 58
 Warning coding FinalLocalVariable Variable 'lim' should be declared final. 59
 Warning coding FinalLocalVariable Variable 'v1' should be declared final. 60
 Warning coding RequireThis Reference to instance variable 'string' needs "this.". 60
 Warning coding FinalLocalVariable Variable 'v2' should be declared final. 61
 Warning coding FinalLocalVariable Variable 'c1' should be declared final. 65
 Warning coding FinalLocalVariable Variable 'c2' should be declared final. 66

emissary/server/mvc/NamespaceAction.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter request should be final. 28
 Warning coding FinalLocalVariable Variable 'model' should be declared final. 29
 Warning coding FinalLocalVariable Variable 'namespaces' should be declared final. 30
 Warning coding FinalLocalVariable Variable 'clz' should be declared final. 34
 Warning coding FinalLocalVariable Variable 'context' should be declared final. 35
 Warning design VisibilityModifier Variable 'key' must be private and have accessor methods. 45
 Warning design VisibilityModifier Variable 'clz' must be private and have accessor methods. 46
 Warning design VisibilityModifier Variable 'value' must be private and have accessor methods. 47
 Warning design VisibilityModifier Variable 'valueClassName' must be private and have accessor methods. 48
 Warning design VisibilityModifier Variable 'dumpUrl' must be private and have accessor methods. 49
 Warning design VisibilityModifier Variable 'transferUrl' must be private and have accessor methods. 50
 Warning design VisibilityModifier Variable 'isDir' must be private and have accessor methods. 51
 Warning modifier RedundantModifier Redundant 'public' modifier. 53
 Warning misc FinalParameters Parameter key should be final. 53
 Warning misc FinalParameters Parameter clz should be final. 53
 Warning misc FinalParameters Parameter context should be final. 53

emissary/server/mvc/NavAction.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'nav' must be private and have accessor methods. 21
 Warning coding FinalLocalVariable Variable 'config' should be declared final. 24
 Warning coding RequireThis Reference to instance variable 'nav' needs "this.". 25
 Warning coding RequireThis Reference to instance variable 'nav' needs "this.". 26
 Warning coding RequireThis Reference to instance variable 'nav' needs "this.". 27
 Warning coding RequireThis Reference to instance variable 'nav' needs "this.". 28
 Warning coding RequireThis Reference to instance variable 'nav' needs "this.". 29
 Warning coding RequireThis Reference to instance variable 'nav' needs "this.". 37
 Warning design VisibilityModifier Variable 'appName' must be private and have accessor methods. 42
 Warning design VisibilityModifier Variable 'appVersion' must be private and have accessor methods. 43
 Warning design VisibilityModifier Variable 'navItems' must be private and have accessor methods. 44
 Warning design VisibilityModifier Variable 'navButtons' must be private and have accessor methods. 45
 Warning coding RequireThis Reference to instance variable 'appName' needs "this.". 48
 Warning misc FinalParameters Parameter appName should be final. 51
 Warning coding HiddenField 'appName' hides a field. 51
 Warning coding RequireThis Reference to instance variable 'appVersion' needs "this.". 56
 Warning misc FinalParameters Parameter appVersion should be final. 59
 Warning coding HiddenField 'appVersion' hides a field. 59
 Warning coding RequireThis Reference to instance variable 'navItems' needs "this.". 64
 Warning misc FinalParameters Parameter navItems should be final. 67
 Warning coding HiddenField 'navItems' hides a field. 67
 Warning coding RequireThis Reference to instance variable 'navButtons' needs "this.". 72
 Warning misc FinalParameters Parameter navButtons should be final. 75
 Warning coding HiddenField 'navButtons' hides a field. 75
 Warning misc FinalParameters Parameter map should be final. 79
 Warning design VisibilityModifier Variable 'display' must be private and have accessor methods. 85
 Warning design VisibilityModifier Variable 'link' must be private and have accessor methods. 86
 Warning misc FinalParameters Parameter display should be final. 88
 Warning misc FinalParameters Parameter link should be final. 88
 Warning coding RequireThis Reference to instance variable 'display' needs "this.". 94
 Warning misc FinalParameters Parameter display should be final. 97
 Warning coding HiddenField 'display' hides a field. 97
 Warning coding RequireThis Reference to instance variable 'link' needs "this.". 102
 Warning misc FinalParameters Parameter link should be final. 105
 Warning coding HiddenField 'link' hides a field. 105

emissary/server/mvc/PauseAction.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter request should be final. 24
 Warning misc FinalParameters Parameter request should be final. 32
 Warning misc FinalParameters Parameter message should be final. 36
 Warning coding FinalLocalVariable Variable 'model' should be declared final. 37

emissary/server/mvc/ShutdownAction.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter request should be final. 22
 Warning coding FinalLocalVariable Variable 'model' should be declared final. 23

emissary/server/mvc/ThreadDumpAction.java

Severity Category Rule Message Line
 Warning coding VariableDeclarationUsageDistance Distance between variable 'tmbean' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 29
 Warning coding FinalLocalVariable Variable 'tmbean' should be declared final. 29
 Warning coding FinalLocalVariable Variable 'model' should be declared final. 31
 Warning coding FinalLocalVariable Variable 'threadcount' should be declared final. 35
 Warning coding FinalLocalVariable Variable 'deadlocks' should be declared final. 41
 Warning coding FinalLocalVariable Variable 'tids' should be declared final. 42
 Warning coding FinalLocalVariable Variable 'threads' should be declared final. 50
 Warning design VisibilityModifier Variable 'stack' must be private and have accessor methods. 60
 Warning misc FinalParameters Parameter ti should be final. 62
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 63
 Warning coding RequireThis Reference to instance variable 'stack' needs "this.". 82

emissary/server/mvc/TransferDirectoryAction.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter dirname should be final. 32
 Warning coding FinalLocalVariable Variable 'cleanDirectoryName' should be declared final. 34
 Warning coding FinalLocalVariable Variable 'msg' should be declared final. 45

emissary/server/mvc/adapters/DirectoryAdapter.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'response' should be declared final. 89
 Warning coding FinalLocalVariable Variable 'count' should be declared final. 197
 Warning misc FinalParameters Parameter map should be final. 291
 Warning coding FinalLocalVariable Variable 'filtered' should be declared final. 292

emissary/server/mvc/adapters/RequestUtil.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 28 should be alone on a line. 21
 Warning misc FinalParameters Parameter parameter should be final. 239
 Warning misc FinalParameters Parameter parameters should be final. 249
 Warning coding FinalLocalVariable Variable 'sanitizedParameters' should be declared final. 250
 Warning misc FinalParameters Parameter parameters should be final. 265
 Warning coding FinalLocalVariable Variable 'sanitizedParameters' should be declared final. 266

emissary/server/mvc/adapters/RequestUtilTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'mockRequest' should be declared final. 23
 Warning coding FinalLocalVariable Variable 'mockRequest' should be declared final. 39
 Warning coding FinalLocalVariable Variable 'test' should be declared final. 55
 Warning coding FinalLocalVariable Variable 'testOk' should be declared final. 64
 Warning coding FinalLocalVariable Variable 'testBad' should be declared final. 65
 Warning coding FinalLocalVariable Variable 'testStrings' should be declared final. 66
 Warning coding FinalLocalVariable Variable 'resultStrings' should be declared final. 68
 Warning coding FinalLocalVariable Variable 'testOk' should be declared final. 78
 Warning coding FinalLocalVariable Variable 'testBad' should be declared final. 79
 Warning coding FinalLocalVariable Variable 'testStrings' should be declared final. 80
 Warning coding FinalLocalVariable Variable 'resultStrings' should be declared final. 82

emissary/server/mvc/internal/DeregisterPlaceAction.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter targetDir should be final. 44
 Warning misc FinalParameters Parameter dirAddKeys should be final. 44
 Warning coding FinalLocalVariable Variable 'cleanTargetDirectory' should be declared final. 45
 Warning coding FinalLocalVariable Variable 'cleanDirAddKeys' should be declared final. 46
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 54
 Warning coding FinalLocalVariable Variable 'numRemoved' should be declared final. 60

emissary/server/mvc/internal/DeregisterPlaceActionTest.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 41
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 42
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 43
 Warning misc FinalParameters Parameter badParam should be final. 60
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 62
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 63
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 66
 Warning misc FinalParameters Parameter paramsToSanitize should be final. 77
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 79
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 80
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 83
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 95
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 110
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 122
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 124
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 137
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 139
 Warning modifier RedundantModifier Redundant 'public' modifier. 150

emissary/server/mvc/internal/FailDirectoryAction.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter targetDirectory should be final. 45
 Warning misc FinalParameters Parameter failedDirectory should be final. 45
 Warning misc FinalParameters Parameter propagate should be final. 46
 Warning coding FinalLocalVariable Variable 'cleanTargetDirectory' should be declared final. 47
 Warning coding FinalLocalVariable Variable 'cleanFailedDirectory' should be declared final. 48
 Warning coding FinalLocalVariable Variable 'localDirectory' should be declared final. 55
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 57
 Warning coding FinalLocalVariable Variable 'count' should be declared final. 62
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 63

emissary/server/mvc/internal/FailDirectoryActionTest.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 45
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 46
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 47
 Warning misc FinalParameters Parameter badParam should be final. 66
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 68
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 69
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 72
 Warning misc FinalParameters Parameter paramsToSanitize should be final. 83
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 85
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 86
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 89
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 101
 Warning coding FinalLocalVariable Variable 'spy' should be declared final. 116
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 120
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 123
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 137
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 140
 Warning modifier RedundantModifier Redundant 'public' modifier. 152

emissary/server/mvc/internal/HeartbeatAction.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter fromPlace should be final. 57
 Warning misc FinalParameters Parameter toPlace should be final. 58

emissary/server/mvc/internal/HeartbeatActionTest.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 38
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 39
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 40
 Warning coding RequireThis Reference to instance variable 'node' needs "this.". 41
 Warning coding RequireThis Reference to instance variable 'node' needs "this.". 42
 Warning coding RequireThis Reference to instance variable 'node' needs "this.". 43
 Warning coding RequireThis Reference to instance variable 'dp' needs "this.". 44
 Warning coding RequireThis Reference to instance variable 'node' needs "this.". 44
 Warning coding RequireThis Reference to instance variable 'dp' needs "this.". 45
 Warning coding RequireThis Reference to instance variable 'dp' needs "this.". 46
 Warning misc FinalParameters Parameter badValue should be final. 59
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 61
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 62
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 65
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 77
 Warning coding RequireThis Reference to instance variable 'dp' needs "this.". 82
 Warning coding RequireThis Reference to instance variable 'dp' needs "this.". 90
 Warning coding RequireThis Reference to instance variable 'dp' needs "this.". 91
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 94
 Warning coding RequireThis Reference to instance variable 'dp' needs "this.". 99

emissary/server/mvc/internal/RegisterPeerAction.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter directoryName should be final. 49
 Warning misc FinalParameters Parameter targetDirectory should be final. 49
 Warning coding FinalLocalVariable Variable 'cleanDirectoryName' should be declared final. 50
 Warning coding FinalLocalVariable Variable 'cleanTargetDirectory' should be declared final. 51
 Warning misc FinalParameters Parameter peerKey should be final. 59
 Warning misc FinalParameters Parameter dirName should be final. 59
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 69
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 74
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 78
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 91

emissary/server/mvc/internal/RegisterPeerActionTest.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 46
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 47
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 48
 Warning coding RequireThis Reference to instance variable 'node' needs "this.". 50
 Warning coding RequireThis Reference to instance variable 'node' needs "this.". 51
 Warning coding RequireThis Reference to instance variable 'node' needs "this.". 52
 Warning coding FinalLocalVariable Variable 'directoryPlace' should be declared final. 54
 Warning coding RequireThis Reference to instance variable 'node' needs "this.". 54
 Warning misc FinalParameters Parameter badValue should be final. 67
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 69
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 70
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 73
 Warning misc FinalParameters Parameter paramsToSanitize should be final. 84
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 86
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 87
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 90
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 102
 Warning coding FinalLocalVariable Variable 'newFormParams' should be declared final. 113
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 133

emissary/server/mvc/internal/RollOutputsAction.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter outputFilterNames should be final. 30
 Warning misc FinalParameters Parameter namespaceName should be final. 31
 Warning coding FinalLocalVariable Variable 'outputNames' should be declared final. 33
 Warning coding FinalLocalVariable Variable 'dropOffPlace' should be declared final. 34
 Warning coding FinalLocalVariable Variable 'f' should be declared final. 38
 Warning coding FinalLocalVariable Variable 'rw' should be declared final. 49

emissary/server/mvc/internal/WorkBundleCompletedAction.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter placeName should be final. 43
 Warning misc FinalParameters Parameter spaceName should be final. 43
 Warning misc FinalParameters Parameter bundleId should be final. 44
 Warning misc FinalParameters Parameter itWorked should be final. 44
 Warning coding FinalLocalVariable Variable 'cleanPlaceName' should be declared final. 45
 Warning coding FinalLocalVariable Variable 'cleanSpaceName' should be declared final. 46
 Warning coding FinalLocalVariable Variable 'cleanBundleId' should be declared final. 47
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 60
 Warning misc FinalParameters Parameter spaceName should be final. 65
 Warning misc FinalParameters Parameter placeName should be final. 65
 Warning misc FinalParameters Parameter bundleId should be final. 65
 Warning misc FinalParameters Parameter itWorked should be final. 65
 Warning coding FinalLocalVariable Variable 'pickupClientNamespaceKey' should be declared final. 72

emissary/server/mvc/internal/WorkBundleCompletedActionTest.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 40
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 41
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 42
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 43
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 44
 Warning coding FinalLocalVariable Variable 'ws' should be declared final. 45
 Warning misc FinalParameters Parameter badValue should be final. 58
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 60
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 61
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 62
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 63
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 66
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 78
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 81
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 93
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 96
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 110
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 113
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 125
 Warning coding FinalLocalVariable Variable 'spyWs' should be declared final. 139
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 144

emissary/server/mvc/internal/WorkSpaceClientOpenWorkSpaceAction.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter placeName should be final. 40
 Warning misc FinalParameters Parameter spaceName should be final. 40
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 44
 Warning misc FinalParameters Parameter placeName should be final. 49
 Warning misc FinalParameters Parameter spaceName should be final. 49
 Warning coding FinalLocalVariable Variable 'placeKey' should be declared final. 52
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 58

emissary/server/mvc/internal/WorkSpaceClientSpaceTakeAction.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter placeName should be final. 44
 Warning misc FinalParameters Parameter spaceName should be final. 44
 Warning coding FinalLocalVariable Variable 'cleanPlaceName' should be declared final. 45
 Warning coding FinalLocalVariable Variable 'cleanSpaceName' should be declared final. 46
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 55
 Warning misc FinalParameters Parameter placeName should be final. 60
 Warning misc FinalParameters Parameter spaceName should be final. 60
 Warning coding FinalLocalVariable Variable 'workspaceKey' should be declared final. 62

emissary/server/mvc/internal/WorkSpaceClientSpaceTakeActionTest.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 40
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 41
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 42
 Warning coding FinalLocalVariable Variable 'ws' should be declared final. 43
 Warning misc FinalParameters Parameter badValue should be final. 56
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 58
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 59
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 62
 Warning misc FinalParameters Parameter paramsToSanitize should be final. 73
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 75
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 76
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 79
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 92
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 95
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 109
 Warning coding FinalLocalVariable Variable 'spy' should be declared final. 122
 Warning coding FinalLocalVariable Variable 'wb' should be declared final. 123
 Warning coding RequireThis Reference to instance variable 'formParams' needs "this.". 130

emissary/spi/ClassLocationVerificationProvider.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'configG' should be declared final. 21
 Warning coding FinalLocalVariable Variable 'classNameLocationMap' should be declared final. 22
 Warning misc FinalParameters Parameter className should be final. 30
 Warning misc FinalParameters Parameter expectedClassLoc should be final. 30
 Warning coding FinalLocalVariable Variable 'clazz' should be declared final. 33
 Warning coding FinalLocalVariable Variable 'classLocPath' should be declared final. 34
 Warning coding FinalLocalVariable Variable 'classLocName' should be declared final. 35
 Warning misc FinalParameters Parameter expectedLocation should be final. 50
 Warning misc FinalParameters Parameter locationName should be final. 50
 Warning misc FinalParameters Parameter expectedLocation should be final. 54
 Warning misc FinalParameters Parameter location should be final. 54
 Warning misc FinalParameters Parameter locationName should be final. 54
 Warning misc FinalParameters Parameter className should be final. 58
 Warning misc FinalParameters Parameter expectedLocation should be final. 58
 Warning misc FinalParameters Parameter location should be final. 58

emissary/spi/ClassLocationVerificationProviderTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'emissaryClassName' should be declared final. 13
 Warning coding FinalLocalVariable Variable 'javaClassName' should be declared final. 23

emissary/spi/EmissaryObjectTracingProvider.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter d should be final. 10
 Warning misc FinalParameters Parameter filename should be final. 10
 Warning misc FinalParameters Parameter stage should be final. 10
 Warning misc FinalParameters Parameter fieldMap should be final. 10
 Warning misc FinalParameters Parameter fieldMap should be final. 16

emissary/spi/InitializationProvider.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 30 should be alone on a line. 12

emissary/spi/ObjectTracingService.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 37 should be alone on a line. 22
 Warning misc FinalParameters Parameter d should be final. 24
 Warning misc FinalParameters Parameter filename should be final. 24
 Warning misc FinalParameters Parameter stage should be final. 24
 Warning misc FinalParameters Parameter useObjectTracing should be final. 24
 Warning coding FinalLocalVariable Variable 'jsonFieldMap' should be declared final. 31

emissary/spi/SPILoader.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'loader' should be declared final. 21
 Warning coding FinalLocalVariable Variable 'loader' should be declared final. 30
 Warning blocks RightCurly '}' at column 26 should be alone on a line. 35

emissary/test/core/junit5/ExtractionTest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'kff' must be private and have accessor methods. 51
 Warning design VisibilityModifier Variable 'place' must be private and have accessor methods. 55
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 59
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 64
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 65
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 66
 Warning misc FinalParameters Parameter resource should be final. 95
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 96
 Warning coding FinalLocalVariable Variable 'controlDoc' should be declared final. 99
 Warning coding FinalLocalVariable Variable 'data' should be declared final. 105
 Warning coding FinalLocalVariable Variable 'initialForm' should be declared final. 106
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 107
 Warning coding FinalLocalVariable Variable 'attachments' should be declared final. 110
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 110
 Warning misc FinalParameters Parameter payload should be final. 121
 Warning misc FinalParameters Parameter controlDoc should be final. 121
 Warning misc FinalParameters Parameter payload should be final. 125
 Warning misc FinalParameters Parameter attachments should be final. 125
 Warning misc FinalParameters Parameter place should be final. 129
 Warning coding HiddenField 'place' hides a field. 129
 Warning misc FinalParameters Parameter payload should be final. 129
 Warning misc FinalParameters Parameter answers should be final. 133
 Warning misc FinalParameters Parameter payload should be final. 133
 Warning misc FinalParameters Parameter attachments should be final. 133
 Warning misc FinalParameters Parameter tname should be final. 133
 Warning misc FinalParameters Parameter answers should be final. 137
 Warning misc FinalParameters Parameter payload should be final. 137
 Warning misc FinalParameters Parameter attachment should be final. 137
 Warning misc FinalParameters Parameter tname should be final. 137
 Warning misc FinalParameters Parameter answers should be final. 141
 Warning misc FinalParameters Parameter payload should be final. 141
 Warning misc FinalParameters Parameter attachments should be final. 141
 Warning misc FinalParameters Parameter tname should be final. 141
 Warning misc FinalParameters Parameter answers should be final. 145
 Warning misc FinalParameters Parameter payload should be final. 145
 Warning misc FinalParameters Parameter attachment should be final. 145
 Warning misc FinalParameters Parameter tname should be final. 145
 Warning misc FinalParameters Parameter answers should be final. 149
 Warning misc FinalParameters Parameter payload should be final. 149
 Warning misc FinalParameters Parameter attachments should be final. 149
 Warning misc FinalParameters Parameter tname should be final. 149
 Warning coding FinalLocalVariable Variable 'root' should be declared final. 151
 Warning coding FinalLocalVariable Variable 'atname' should be declared final. 162
 Warning coding FinalLocalVariable Variable 'el' should be declared final. 163
 Warning misc FinalParameters Parameter el should be final. 172
 Warning misc FinalParameters Parameter payload should be final. 172
 Warning misc FinalParameters Parameter attachments should be final. 172
 Warning misc FinalParameters Parameter tname should be final. 172
 Warning coding FinalLocalVariable Variable 'numAtt' should be declared final. 175
 Warning coding FinalLocalVariable Variable 'numAttElements' should be declared final. 176
 Warning coding FinalLocalVariable Variable 'cf' should be declared final. 192
 Warning coding FinalLocalVariable Variable 'index' should be declared final. 194
 Warning coding FinalLocalVariable Variable 'cf' should be declared final. 206
 Warning coding FinalLocalVariable Variable 'ft' should be declared final. 212
 Warning coding FinalLocalVariable Variable 'cfsize' should be declared final. 217
 Warning coding FinalLocalVariable Variable 'classification' should be declared final. 222
 Warning coding FinalLocalVariable Variable 'dataLength' should be declared final. 228
 Warning coding FinalLocalVariable Variable 'shortName' should be declared final. 233
 Warning coding FinalLocalVariable Variable 'fontEncoding' should be declared final. 238
 Warning coding FinalLocalVariable Variable 'broke' should be declared final. 243
 Warning coding FinalLocalVariable Variable 'key' should be declared final. 250
 Warning coding FinalLocalVariable Variable 'key' should be declared final. 257
 Warning coding FinalLocalVariable Variable 'payloadData' should be declared final. 268
 Warning coding FinalLocalVariable Variable 'viewName' should be declared final. 274
 Warning coding FinalLocalVariable Variable 'lengthStr' should be declared final. 275
 Warning coding FinalLocalVariable Variable 'viewData' should be declared final. 276
 Warning coding FinalLocalVariable Variable 'viewName' should be declared final. 287
 Warning coding FinalLocalVariable Variable 'viewData' should be declared final. 288
 Warning coding FinalLocalVariable Variable 'extractCount' should be declared final. 293
 Warning coding FinalLocalVariable Variable 'numExtractElements' should be declared final. 294
 Warning coding FinalLocalVariable Variable 'extractedChildren' should be declared final. 297
 Warning coding FinalLocalVariable Variable 'foundCount' should be declared final. 298
 Warning coding FinalLocalVariable Variable 'extel' should be declared final. 313
 Warning misc FinalParameters Parameter parentTag should be final. 330
 Warning misc FinalParameters Parameter key should be final. 330
 Warning misc FinalParameters Parameter tname should be final. 330
 Warning misc FinalParameters Parameter meta should be final. 336
 Warning misc FinalParameters Parameter data should be final. 336
 Warning misc FinalParameters Parameter tname should be final. 336
 Warning coding FinalLocalVariable Variable 'key' should be declared final. 337
 Warning coding FinalLocalVariable Variable 'mm' should be declared final. 340
 Warning coding EqualsAvoidNull String literal expressions should be on the left side of an equals comparison. 350
 Warning coding EqualsAvoidNull String literal expressions should be on the left side of an equals comparison. 353
 Warning coding EqualsAvoidNull String literal expressions should be on the left side of an equals comparison. 353
 Warning coding EqualsAvoidNull String literal expressions should be on the left side of an equals comparison. 356
 Warning coding EqualsAvoidNull String literal expressions should be on the left side of an equals comparison. 356
 Warning coding EqualsAvoidNull String literal expressions should be on the left side of an equals comparison. 359
 Warning coding EqualsAvoidNull String literal expressions should be on the left side of an equals comparison. 362
 Warning coding FinalLocalVariable Variable 'separatorAttribute' should be declared final. 369
 Warning coding FinalLocalVariable Variable 'separator' should be declared final. 370
 Warning coding FinalLocalVariable Variable 'expectedValues' should be declared final. 372
 Warning coding FinalLocalVariable Variable 'actualValues' should be declared final. 373
 Warning misc FinalParameters Parameter payload should be final. 384
 Warning misc FinalParameters Parameter doc should be final. 384
 Warning coding RequireThis Reference to instance variable 'kff' needs "this.". 385
 Warning coding FinalLocalVariable Variable 'root' should be declared final. 386
 Warning coding FinalLocalVariable Variable 'setup' should be declared final. 387
 Warning coding FinalLocalVariable Variable 'cfChildren' should be declared final. 390
 Warning coding FinalLocalVariable Variable 'key' should be declared final. 409
 Warning coding FinalLocalVariable Variable 'value' should be declared final. 410
 Warning coding FinalLocalVariable Variable 'name' should be declared final. 415
 Warning coding FinalLocalVariable Variable 'value' should be declared final. 416

emissary/test/core/junit5/FunctionalTest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'jserver' must be private and have accessor methods. 31
 Warning design VisibilityModifier Variable 'jetty' must be private and have accessor methods. 33
 Warning design VisibilityModifier Variable 'directory' must be private and have accessor methods. 35
 Warning design VisibilityModifier Variable 'pool' must be private and have accessor methods. 37
 Warning design VisibilityModifier Variable 'spool' must be private and have accessor methods. 39
 Warning misc FinalParameters Parameter name should be final. 45
 Warning misc FinalParameters Parameter port should be final. 52
 Warning coding FinalLocalVariable Variable 'url' should be declared final. 53
 Warning coding FinalLocalVariable Variable 'thePlace' should be declared final. 56
 Warning misc FinalParameters Parameter port should be final. 73
 Warning coding FinalLocalVariable Variable 'PROJECT_BASE' should be declared final. 74
 Warning coding FinalLocalVariable Variable 'realmFile' should be declared final. 76
 Warning coding FinalLocalVariable Variable 'nodeName' should be declared final. 81
 Warning coding FinalLocalVariable Variable 'args' should be declared final. 82
 Warning coding FinalLocalVariable Variable 'cmd' should be declared final. 84
 Warning coding RequireThis Reference to instance variable 'jserver' needs "this.". 86
 Warning coding RequireThis Reference to instance variable 'jetty' needs "this.". 87
 Warning coding RequireThis Reference to instance variable 'jserver' needs "this.". 87
 Warning misc FinalParameters Parameter port should be final. 104
 Warning coding RequireThis Reference to instance variable 'directory' needs "this.". 107
 Warning coding RequireThis Reference to instance variable 'pool' needs "this.". 110
 Warning coding RequireThis Reference to instance variable 'spool' needs "this.". 115
 Warning misc FinalParameters Parameter key should be final. 121
 Warning misc FinalParameters Parameter clsName should be final. 121
 Warning coding RequireThis Reference to instance variable 'directory' needs "this.". 122
 Warning coding RequireThis Reference to instance variable 'directory' needs "this.". 123
 Warning misc FinalParameters Parameter key should be final. 129
 Warning misc FinalParameters Parameter clsName should be final. 129
 Warning misc FinalParameters Parameter dir should be final. 129
 Warning misc FinalParameters Parameter key should be final. 133
 Warning misc FinalParameters Parameter clsName should be final. 133
 Warning misc FinalParameters Parameter configStream should be final. 133
 Warning coding RequireThis Reference to instance variable 'directory' needs "this.". 134
 Warning coding RequireThis Reference to instance variable 'directory' needs "this.". 135
 Warning coding FinalLocalVariable Variable 'obj' should be declared final. 145
 Warning coding RequireThis Reference to instance variable 'directory' needs "this.". 155
 Warning coding RequireThis Reference to instance variable 'directory' needs "this.". 155
 Warning coding RequireThis Reference to instance variable 'directory' needs "this.". 156
 Warning coding RequireThis Reference to instance variable 'directory' needs "this.". 157
 Warning coding RequireThis Reference to instance variable 'jserver' needs "this.". 160
 Warning coding RequireThis Reference to instance variable 'jserver' needs "this.". 160
 Warning coding RequireThis Reference to instance variable 'jserver' needs "this.". 161
 Warning coding RequireThis Reference to instance variable 'jetty' needs "this.". 162
 Warning coding RequireThis Reference to instance variable 'jserver' needs "this.". 164
 Warning coding RequireThis Reference to instance variable 'pool' needs "this.". 167
 Warning coding RequireThis Reference to instance variable 'pool' needs "this.". 168
 Warning coding RequireThis Reference to instance variable 'pool' needs "this.". 169
 Warning coding FinalLocalVariable Variable 'realmFile' should be declared final. 177

emissary/test/core/junit5/IdentificationTest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'place' must be private and have accessor methods. 34
 Warning misc FinalParameters Parameter resource should be final. 60
 Warning coding FinalLocalVariable Variable 'data' should be declared final. 64
 Warning coding VariableDeclarationUsageDistance Distance between variable 'expectedAnswer' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 65
 Warning coding FinalLocalVariable Variable 'expectedAnswer' should be declared final. 65
 Warning coding FinalLocalVariable Variable 'payload' should be declared final. 66
 Warning misc FinalParameters Parameter resource should be final. 85
 Warning misc FinalParameters Parameter payload should be final. 89
 Warning misc FinalParameters Parameter resource should be final. 89
 Warning misc FinalParameters Parameter payload should be final. 93
 Warning misc FinalParameters Parameter resource should be final. 93
 Warning misc FinalParameters Parameter payload should be final. 97
 Warning misc FinalParameters Parameter resource should be final. 97
 Warning misc FinalParameters Parameter expected should be final. 97
 Warning misc FinalParameters Parameter payload should be final. 101
 Warning misc FinalParameters Parameter resource should be final. 101
 Warning misc FinalParameters Parameter expected should be final. 101
 Warning misc FinalParameters Parameter payload should be final. 105
 Warning misc FinalParameters Parameter resource should be final. 105
 Warning misc FinalParameters Parameter expected should be final. 105
 Warning coding FinalLocalVariable Variable 'expectedForms' should be declared final. 106
 Warning coding FinalLocalVariable Variable 'result' should be declared final. 108

emissary/test/core/junit5/InitialFinalFormFormat.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'originalFileName' needs "this.". 29
 Warning coding RequireThis Reference to instance variable 'baseFileName' needs "this.". 30
 Warning coding RequireThis Reference to instance variable 'originalFileName' needs "this.". 30
 Warning coding RequireThis Reference to instance variable 'originalFileName' needs "this.". 30
 Warning coding RequireThis Reference to instance variable 'initialForm' needs "this.". 31
 Warning coding RequireThis Reference to instance variable 'finalForm' needs "this.". 32
 Warning coding RequireThis Reference to instance variable 'comments' needs "this.". 33
 Warning coding RequireThis Reference to instance variable 'baseFileName' needs "this.". 38
 Warning coding RequireThis Reference to instance variable 'initialForm' needs "this.". 41
 Warning coding RequireThis Reference to instance variable 'finalForm' needs "this.". 43
 Warning coding RequireThis Reference to instance variable 'comments' needs "this.". 45
 Warning coding RequireThis Reference to instance variable 'initialForm' needs "this.". 57
 Warning coding RequireThis Reference to instance variable 'finalForm' needs "this.". 66
 Warning coding RequireThis Reference to instance variable 'comments' needs "this.". 75
 Warning coding RequireThis Reference to instance variable 'baseFileName' needs "this.". 85
 Warning coding RequireThis Reference to instance variable 'originalFileName' needs "this.". 94
 Warning coding RequireThis Reference to instance variable 'path' needs "this.". 103

emissary/test/core/junit5/LogbackTester.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'name' must be private and have accessor methods. 23
 Warning design VisibilityModifier Variable 'logger' must be private and have accessor methods. 24
 Warning design VisibilityModifier Variable 'appender' must be private and have accessor methods. 25
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 31
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 32
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 34
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 34
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 35
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 36
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 36
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 37
 Warning misc FinalParameters Parameter events should be final. 40
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 43
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 45
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 46
 Warning coding FinalLocalVariable Variable 'proxy' should be declared final. 54
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 64
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 65
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 81
 Warning design VisibilityModifier Variable 'level' must be private and have accessor methods. 85
 Warning design VisibilityModifier Variable 'message' must be private and have accessor methods. 86
 Warning design VisibilityModifier Variable 'throwableClassName' must be private and have accessor methods. 88
 Warning design VisibilityModifier Variable 'throwableMessage' must be private and have accessor methods. 90
 Warning misc FinalParameters Parameter level should be final. 92
 Warning misc FinalParameters Parameter message should be final. 92
 Warning misc FinalParameters Parameter throwable should be final. 92
 Warning misc FinalParameters Parameter level should be final. 98
 Warning misc FinalParameters Parameter message should be final. 98
 Warning misc FinalParameters Parameter throwableClassName should be final. 98
 Warning misc FinalParameters Parameter throwableMessage should be final. 98
 Warning coding RequireThis Reference to instance variable 'level' needs "this.". 110
 Warning coding RequireThis Reference to instance variable 'message' needs "this.". 110
 Warning coding RequireThis Reference to instance variable 'throwableClassName' needs "this.". 110
 Warning coding RequireThis Reference to instance variable 'throwableMessage' needs "this.". 110
 Warning misc FinalParameters Parameter obj should be final. 114
 Warning coding FinalLocalVariable Variable 'other' should be declared final. 122
 Warning coding RequireThis Reference to instance variable 'level' needs "this.". 124
 Warning whitespace OperatorWrap '&&' should be on a new line. 124
 Warning coding RequireThis Reference to instance variable 'message' needs "this.". 125
 Warning whitespace OperatorWrap '&&' should be on a new line. 125
 Warning coding RequireThis Reference to instance variable 'throwableClassName' needs "this.". 126
 Warning whitespace OperatorWrap '&&' should be on a new line. 126
 Warning coding RequireThis Reference to instance variable 'throwableMessage' needs "this.". 127
 Warning coding RequireThis Reference to instance variable 'level' needs "this.". 132
 Warning coding RequireThis Reference to instance variable 'message' needs "this.". 132
 Warning coding RequireThis Reference to instance variable 'throwableClassName' needs "this.". 133
 Warning coding RequireThis Reference to instance variable 'throwableMessage' needs "this.". 133

emissary/test/core/junit5/LogbackTesterTest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'logger' must be private and have accessor methods. 19
 Warning coding FinalLocalVariable Variable 'logBackTester' should be declared final. 23
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 23
 Warning coding FinalLocalVariable Variable 'logBackTester' should be declared final. 29
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 29
 Warning coding FinalLocalVariable Variable 'events' should be declared final. 31
 Warning coding FinalLocalVariable Variable 'event2' should be declared final. 32
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 34
 Warning coding FinalLocalVariable Variable 'logBackTester' should be declared final. 40
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 40
 Warning coding FinalLocalVariable Variable 'events' should be declared final. 42
 Warning coding FinalLocalVariable Variable 'event2' should be declared final. 43
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 45
 Warning coding FinalLocalVariable Variable 'thrownException' should be declared final. 46
 Warning coding FinalLocalVariable Variable 'logBackTester' should be declared final. 53
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 53
 Warning coding FinalLocalVariable Variable 'events' should be declared final. 55
 Warning coding FinalLocalVariable Variable 'event3' should be declared final. 56
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 58
 Warning coding FinalLocalVariable Variable 'thrownException' should be declared final. 59
 Warning coding FinalLocalVariable Variable 'logBackTester' should be declared final. 66
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 66
 Warning coding FinalLocalVariable Variable 'events' should be declared final. 68
 Warning coding FinalLocalVariable Variable 'event4' should be declared final. 69
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 71
 Warning coding FinalLocalVariable Variable 'thrownException' should be declared final. 72
 Warning coding FinalLocalVariable Variable 'logBackTester' should be declared final. 79
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 79
 Warning coding FinalLocalVariable Variable 'events' should be declared final. 81
 Warning coding FinalLocalVariable Variable 'event4' should be declared final. 82
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 84
 Warning coding FinalLocalVariable Variable 'thrownException' should be declared final. 85

emissary/test/core/junit5/RegressionTest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'actualSimplifiedLogEvents' must be private and have accessor methods. 54
 Warning coding RequireThis Reference to instance variable 'actualSimplifiedLogEvents' needs "this.". 175
 Warning coding FinalLocalVariable Variable 'viewSha256' should be declared final. 184
 Warning coding FinalLocalVariable Variable 'payloadSha256' should be declared final. 189
 Warning coding FinalLocalVariable Variable 'recordSha256' should be declared final. 194
 Warning coding FinalLocalVariable Variable 'attachmentSha256' should be declared final. 202
 Warning misc FinalParameters Parameter simplifiedLogEvents should be final. 225
 Warning misc FinalParameters Parameter bytes should be final. 235
 Warning misc FinalParameters Parameter place should be final. 309
 Warning misc FinalParameters Parameter payload should be final. 309
 Warning coding RequireThis Reference to instance variable 'actualSimplifiedLogEvents' needs "this.". 312
 Warning coding RequireThis Reference to instance variable 'actualSimplifiedLogEvents' needs "this.". 319
 Warning coding RequireThis Reference to instance variable 'actualSimplifiedLogEvents' needs "this.". 340

emissary/test/core/junit5/RegressionTestUtil.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 35 should be alone on a line. 102
 Warning coding FinalLocalVariable Variable 'xmlPath' should be declared final. 209
 Warning coding FinalLocalVariable Variable 'ansPath' should be declared final. 213
 Warning coding FinalLocalVariable Variable 'testNamePos' should be declared final. 214

emissary/test/core/junit5/TestExtractionTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'builder' should be declared final. 32
 Warning coding FinalLocalVariable Variable 'inputStream' should be declared final. 33
 Warning coding FinalLocalVariable Variable 'answerDoc' should be declared final. 35
 Warning coding FinalLocalVariable Variable 'test' should be declared final. 38
 Warning coding FinalLocalVariable Variable 'meta' should be declared final. 40
 Warning coding FinalLocalVariable Variable 'builder' should be declared final. 49
 Warning coding FinalLocalVariable Variable 'inputStream' should be declared final. 50
 Warning coding FinalLocalVariable Variable 'answerDoc' should be declared final. 52
 Warning coding FinalLocalVariable Variable 'test' should be declared final. 55
 Warning coding FinalLocalVariable Variable 'meta' should be declared final. 57
 Warning coding FinalLocalVariable Variable 'builder' should be declared final. 64
 Warning coding FinalLocalVariable Variable 'inputStream' should be declared final. 65
 Warning coding FinalLocalVariable Variable 'answerDoc' should be declared final. 67
 Warning coding FinalLocalVariable Variable 'fontEncodingValue' should be declared final. 70
 Warning coding FinalLocalVariable Variable 'builder' should be declared final. 76
 Warning coding FinalLocalVariable Variable 'inputStream' should be declared final. 77
 Warning coding FinalLocalVariable Variable 'answerDoc' should be declared final. 79
 Warning coding FinalLocalVariable Variable 'test' should be declared final. 83
 Warning coding FinalLocalVariable Variable 'dataList' should be declared final. 85
 Warning coding FinalLocalVariable Variable 'bangIndexData' should be declared final. 86
 Warning coding FinalLocalVariable Variable 'bangContainsData' should be declared final. 93
 Warning misc FinalParameters Parameter dataList should be final. 99
 Warning misc FinalParameters Parameter matchMode should be final. 99
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 113
 Warning coding FinalLocalVariable Variable 'test' should be declared final. 114
 Warning coding FinalLocalVariable Variable 'builder' should be declared final. 116
 Warning coding FinalLocalVariable Variable 'inputStream' should be declared final. 117
 Warning coding FinalLocalVariable Variable 'doc' should be declared final. 118
 Warning coding FinalLocalVariable Variable 'answers' should be declared final. 119

emissary/test/core/junit5/UnitTest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'logger' must be private and have accessor methods. 44
 Warning design VisibilityModifier Variable 'answerFileClassRef' must be private and have accessor methods. 52
 Warning design VisibilityModifier Variable 'temporaryDirectory' must be private and have accessor methods. 56
 Warning design VisibilityModifier Variable 'TMPDIR' must be private and have accessor methods. 58
 Warning design VisibilityModifier Variable 'thisPackage' must be private and have accessor methods. 60
 Warning design VisibilityModifier Variable 'origConfigPkg' must be private and have accessor methods. 62
 Warning misc FinalParameters Parameter name should be final. 74
 Warning coding RequireThis Reference to instance variable 'thisPackage' needs "this.". 101
 Warning coding FinalLocalVariable Variable 'projectBase' should be declared final. 108
 Warning coding FinalLocalVariable Variable 'command' should be declared final. 114
 Warning misc FinalParameters Parameter max should be final. 122
 Warning coding FinalLocalVariable Variable 'td' should be declared final. 123
 Warning coding FinalLocalVariable Variable 'ti' should be declared final. 124
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 126
 Warning coding FinalLocalVariable Variable 'rr' should be declared final. 138
 Warning misc FinalParameters Parameter clz should be final. 145
 Warning coding FinalLocalVariable Variable 'rr' should be declared final. 146
 Warning coding FinalLocalVariable Variable 'rs' should be declared final. 147
 Warning misc FinalParameters Parameter ansClz should be final. 156
 Warning coding RequireThis Reference to instance variable 'answerFiles' needs "this.". 157
 Warning coding RequireThis Reference to instance variable 'answerFiles' needs "this.". 158
 Warning coding RequireThis Reference to instance variable 'answerFileClassRef' needs "this.". 159
 Warning misc FinalParameters Parameter ansClz should be final. 162
 Warning coding FinalLocalVariable Variable 'rr' should be declared final. 163
 Warning misc FinalParameters Parameter ansClz should be final. 167
 Warning misc FinalParameters Parameter resourceReader should be final. 167
 Warning coding FinalLocalVariable Variable 'rr' should be declared final. 175
 Warning misc FinalParameters Parameter millis should be final. 185
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 194
 Warning misc FinalParameters Parameter pkg should be final. 204
 Warning coding RequireThis Reference to instance variable 'origConfigPkg' needs "this.". 208
 Warning coding RequireThis Reference to instance variable 'thisPackage' needs "this.". 214
 Warning coding RequireThis Reference to instance variable 'origConfigPkg' needs "this.". 223
 Warning coding RequireThis Reference to instance variable 'origConfigPkg' needs "this.". 224
 Warning coding RequireThis Reference to instance variable 'origConfigPkg' needs "this.". 225
 Warning misc FinalParameters Parameter resource should be final. 235
 Warning coding FinalLocalVariable Variable 'datPos' should be declared final. 236
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 238
 Warning coding RequireThis Reference to instance variable 'answerFiles' needs "this.". 243
 Warning coding FinalLocalVariable Variable 'testFileName' should be declared final. 247
 Warning coding RequireThis Reference to instance variable 'answerFiles' needs "this.". 248
 Warning coding FinalLocalVariable Variable 'builder' should be declared final. 256
 Warning coding FinalLocalVariable Variable 'answerDoc' should be declared final. 257
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 261
 Warning misc FinalParameters Parameter context should be final. 269
 Warning misc FinalParameters Parameter cause should be final. 269

emissary/test/core/junit5/extensions/EmissaryIsolatedClassLoaderExtension.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter invocation should be final. 19
 Warning misc FinalParameters Parameter invocationContext should be final. 19
 Warning misc FinalParameters Parameter extensionContext should be final. 20
 Warning misc FinalParameters Parameter invocationContext should be final. 29
 Warning misc FinalParameters Parameter extensionContext should be final. 30
 Warning coding FinalLocalVariable Variable 'testClass' should be declared final. 32
 Warning coding FinalLocalVariable Variable 'testMethod' should be declared final. 33
 Warning coding FinalLocalVariable Variable 'originalClassLoader' should be declared final. 36
 Warning coding FinalLocalVariable Variable 'isolatedClassLoader' should be declared final. 38
 Warning coding FinalLocalVariable Variable 'isolatedTestClass' should be declared final. 44
 Warning coding FinalLocalVariable Variable 'testInstance' should be declared final. 45
 Warning coding FinalLocalVariable Variable 'method' should be declared final. 46
 Warning coding FinalLocalVariable Variable 'systemClassLoader' should be declared final. 62
 Warning coding FinalLocalVariable Variable 'paths' should be declared final. 66
 Warning misc FinalParameters Parameter name should be final. 77

emissary/test/core/junit5/extensions/TestAttempts.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter context should be final. 51
 Warning misc FinalParameters Parameter context should be final. 57
 Warning misc FinalParameters Parameter context should be final. 62
 Warning misc FinalParameters Parameter throwable should be final. 62
 Warning misc FinalParameters Parameter context should be final. 67
 Warning misc FinalParameters Parameter context should be final. 71
 Warning coding FinalLocalVariable Variable 'store' should be declared final. 72
 Warning coding FinalLocalVariable Variable 'key' should be declared final. 73
 Warning misc FinalParameters Parameter context should be final. 77
 Warning coding FinalLocalVariable Variable 'retryTest' should be declared final. 78
 Warning coding FinalLocalVariable Variable 'maxAttempts' should be declared final. 80
 Warning misc FinalParameters Parameter context should be final. 85
 Warning misc FinalParameters Parameter throwable should be final. 85
 Warning coding FinalLocalVariable Variable 'testAttempt' should be declared final. 86
 Warning design VisibilityModifier Variable 'maxAttempts' must be private and have accessor methods. 104
 Warning design VisibilityModifier Variable 'attempts' must be private and have accessor methods. 105
 Warning design VisibilityModifier Variable 'exceptions' must be private and have accessor methods. 106
 Warning misc FinalParameters Parameter maxAttempts should be final. 108
 Warning coding RequireThis Reference to instance variable 'attempts' needs "this.". 135
 Warning coding RequireThis Reference to instance variable 'maxAttempts' needs "this.". 136
 Warning coding RequireThis Reference to instance variable 'exceptions' needs "this.". 140
 Warning coding RequireThis Reference to instance variable 'attempts' needs "this.". 144
 Warning coding RequireThis Reference to instance variable 'attempts' needs "this.". 148
 Warning coding RequireThis Reference to instance variable 'exceptions' needs "this.". 148
 Warning coding RequireThis Reference to instance variable 'attempts' needs "this.". 152
 Warning coding RequireThis Reference to instance variable 'maxAttempts' needs "this.". 152
 Warning design VisibilityModifier Variable 'maxAttempts' must be private and have accessor methods. 161
 Warning modifier RedundantModifier Redundant 'public' modifier. 163
 Warning misc FinalParameters Parameter maxAttempts should be final. 163
 Warning misc FinalParameters Parameter invocationIndex should be final. 168
 Warning coding RequireThis Reference to instance variable 'maxAttempts' needs "this.". 169

emissary/test/util/ComplexUnicodeSamples.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 38 should be alone on a line. 14
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 44
 Warning coding FinalLocalVariable Variable 'xmlWithExp' should be declared final. 109
 Warning misc FinalParameters Parameter text should be final. 151
 Warning coding FinalLocalVariable Variable 'breakIterator' should be declared final. 153
 Warning misc FinalParameters Parameter text should be final. 176
 Warning coding FinalLocalVariable Variable 'breakIterator' should be declared final. 177

emissary/test/util/ComplexUnicodeSamplesTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'facepalm' should be declared final. 44
 Warning coding FinalLocalVariable Variable 'nfcDecomp' should be declared final. 98
 Warning coding FinalLocalVariable Variable 'nfkcDecomp' should be declared final. 99
 Warning coding FinalLocalVariable Variable 'nfcComp' should be declared final. 103
 Warning coding FinalLocalVariable Variable 'nfkcComp' should be declared final. 104
 Warning coding FinalLocalVariable Variable 'facepalm' should be declared final. 113
 Warning coding FinalLocalVariable Variable 'facepalm' should be declared final. 120
 Warning coding FinalLocalVariable Variable 'facepalm' should be declared final. 128
 Warning coding FinalLocalVariable Variable 'j' should be declared final. 129
 Warning coding FinalLocalVariable Variable 'facepalm' should be declared final. 136
 Warning coding FinalLocalVariable Variable 'j' should be declared final. 137

emissary/test/util/RegularExpressionTestUtil.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 42 should be alone on a line. 22
 Warning misc FinalParameters Parameter regexPatternString should be final. 33
 Warning misc FinalParameters Parameter shouldMatch should be final. 33
 Warning misc FinalParameters Parameter shouldNotMatch should be final. 33
 Warning coding FinalLocalVariable Variable 'subjectUnderTest' should be declared final. 39
 Warning misc FinalParameters Parameter patternUnderTest should be final. 54
 Warning misc FinalParameters Parameter shouldMatch should be final. 54
 Warning misc FinalParameters Parameter shouldNotMatch should be final. 54
 Warning coding FinalLocalVariable Variable 'mm' should be declared final. 62
 Warning coding FinalLocalVariable Variable 'dmm' should be declared final. 70

emissary/test/util/ThreadDump.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'tmbean' must be private and have accessor methods. 13

emissary/transform/HtmlEscapePlace.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter cfgInfo should be final. 43
 Warning misc FinalParameters Parameter dir should be final. 43
 Warning misc FinalParameters Parameter placeLoc should be final. 43
 Warning misc FinalParameters Parameter cfgInfo should be final. 51
 Warning coding RequireThis Reference to instance variable 'outputForm' needs "this.". 68
 Warning misc FinalParameters Parameter d should be final. 78
 Warning coding FinalLocalVariable Variable 'incomingForm' should be declared final. 83
 Warning coding FinalLocalVariable Variable 'counters' should be declared final. 84
 Warning coding RequireThis Reference to instance variable 'outputForm' needs "this.". 92
 Warning coding RequireThis Reference to instance variable 'outputForm' needs "this.". 93
 Warning misc FinalParameters Parameter d should be final. 121
 Warning coding FinalLocalVariable Variable 'textView' should be declared final. 124
 Warning misc FinalParameters Parameter d should be final. 137
 Warning coding FinalLocalVariable Variable 'summary' should be declared final. 139
 Warning misc FinalParameters Parameter d should be final. 151
 Warning coding FinalLocalVariable Variable 'title' should be declared final. 153
 Warning misc FinalParameters Parameter d should be final. 166
 Warning coding FinalLocalVariable Variable 'enc' should be declared final. 168
 Warning misc FinalParameters Parameter d should be final. 174
 Warning coding FinalLocalVariable Variable 'pos' should be declared final. 178
 Warning coding ModifiedControlVariable Control variable 'cf' is modified. 180
 Warning misc FinalParameters Parameter s should be final. 187

emissary/transform/HtmlEscapePlaceTest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'place' must be private and have accessor methods. 41
 Warning design VisibilityModifier Variable 'd' must be private and have accessor methods. 42
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 48
 Warning coding RequireThis Reference to instance variable 'd' needs "this.". 49
 Warning coding FinalLocalVariable Variable 'view' should be declared final. 54
 Warning coding RequireThis Reference to instance variable 'd' needs "this.". 55
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 56
 Warning coding RequireThis Reference to instance variable 'd' needs "this.". 56
 Warning coding RequireThis Reference to instance variable 'd' needs "this.". 57
 Warning coding RequireThis Reference to instance variable 'd' needs "this.". 62
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 63
 Warning coding RequireThis Reference to instance variable 'd' needs "this.". 63
 Warning coding RequireThis Reference to instance variable 'd' needs "this.". 64
 Warning coding RequireThis Reference to instance variable 'd' needs "this.". 69
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 70
 Warning coding RequireThis Reference to instance variable 'd' needs "this.". 70
 Warning coding RequireThis Reference to instance variable 'd' needs "this.". 71
 Warning coding FinalLocalVariable Variable 'expected' should be declared final. 76
 Warning coding RequireThis Reference to instance variable 'd' needs "this.". 77
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 78
 Warning coding RequireThis Reference to instance variable 'd' needs "this.". 78
 Warning coding RequireThis Reference to instance variable 'd' needs "this.". 79
 Warning coding FinalLocalVariable Variable 'expected' should be declared final. 84
 Warning coding RequireThis Reference to instance variable 'd' needs "this.". 85
 Warning coding RequireThis Reference to instance variable 'place' needs "this.". 86
 Warning coding RequireThis Reference to instance variable 'd' needs "this.". 86
 Warning coding RequireThis Reference to instance variable 'd' needs "this.". 87
 Warning coding FinalLocalVariable Variable 'actual' should be declared final. 92

emissary/transform/JavascriptEscapePlace.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter cfgInfo should be final. 35
 Warning misc FinalParameters Parameter dir should be final. 35
 Warning misc FinalParameters Parameter placeLoc should be final. 35
 Warning misc FinalParameters Parameter cfgInfo should be final. 45
 Warning coding RequireThis Reference to instance variable 'outputForm' needs "this.". 62
 Warning coding RequireThis Reference to instance variable 'outputForm' needs "this.". 62
 Warning misc FinalParameters Parameter d should be final. 69
 Warning coding FinalLocalVariable Variable 'incomingForm' should be declared final. 74
 Warning coding FinalLocalVariable Variable 'newData' should be declared final. 78
 Warning coding RequireThis Reference to instance variable 'outputForm' needs "this.". 83
 Warning coding RequireThis Reference to instance variable 'outputForm' needs "this.". 84

emissary/transform/JsonEscapePlace.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter cfgInfo should be final. 35
 Warning misc FinalParameters Parameter dir should be final. 35
 Warning misc FinalParameters Parameter placeLoc should be final. 35
 Warning misc FinalParameters Parameter cfgInfo should be final. 45
 Warning coding RequireThis Reference to instance variable 'outputForm' needs "this.". 62
 Warning coding RequireThis Reference to instance variable 'outputForm' needs "this.". 62
 Warning misc FinalParameters Parameter d should be final. 69
 Warning coding FinalLocalVariable Variable 'incomingForm' should be declared final. 74
 Warning coding FinalLocalVariable Variable 'newData' should be declared final. 78

emissary/transform/decode/HtmlEscape.java

Severity Category Rule Message Line
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 29
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 34
 Warning misc FinalParameters Parameter data should be final. 42
 Warning misc FinalParameters Parameter data should be final. 56
 Warning misc FinalParameters Parameter counters should be final. 56
 Warning coding FinalLocalVariable Variable 'startPos' should be declared final. 78
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 87
 Warning coding FinalLocalVariable Variable 's' should be declared final. 90
 Warning coding ModifiedControlVariable Control variable 'i' is modified. 95
 Warning misc FinalParameters Parameter s should be final. 121
 Warning misc FinalParameters Parameter s should be final. 132
 Warning misc FinalParameters Parameter counters should be final. 132
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 137
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 138
 Warning coding FinalLocalVariable Variable 'hexModifier' should be declared final. 143
 Warning coding FinalLocalVariable Variable 'isHex' should be declared final. 144
 Warning coding FinalLocalVariable Variable 'encodedChar' should be declared final. 145
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 146
 Warning misc FinalParameters Parameter s should be final. 176
 Warning misc FinalParameters Parameter isHex should be final. 176
 Warning misc FinalParameters Parameter s should be final. 198
 Warning misc FinalParameters Parameter s should be final. 209
 Warning misc FinalParameters Parameter counters should be final. 209
 Warning coding FinalLocalVariable Variable 'slen' should be declared final. 210
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 211
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 214
 Warning blocks LeftCurly '{' at column 17 should be on the previous line. 225
 Warning coding FinalLocalVariable Variable 'val' should be declared final. 245
 Warning coding ModifiedControlVariable Control variable 'i' is modified. 252
 Warning coding ModifiedControlVariable Control variable 'i' is modified. 254
 Warning misc FinalParameters Parameter s should be final. 274
 Warning misc FinalParameters Parameter s should be final. 282
 Warning misc FinalParameters Parameter counters should be final. 282
 Warning coding FinalLocalVariable Variable 'baos' should be declared final. 283
 Warning coding FinalLocalVariable Variable 'slen' should be declared final. 284
 Warning blocks LeftCurly '{' at column 17 should be on the previous line. 295
 Warning coding FinalLocalVariable Variable 'val' should be declared final. 303
 Warning coding ModifiedControlVariable Control variable 'i' is modified. 313
 Warning coding ModifiedControlVariable Control variable 'i' is modified. 315
 Warning misc FinalParameters Parameter entity should be final. 332
 Warning coding FinalLocalVariable Variable 's' should be declared final. 333
 Warning blocks RightCurly '}' at column 27 should be alone on a line. 341
 Warning misc FinalParameters Parameter args should be final. 344
 Warning coding FinalLocalVariable Variable 'content' should be declared final. 354

emissary/transform/decode/HtmlEscapeTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 't' should be declared final. 19
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 16, expected level should be 10. 20
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 16, expected level should be 10. 21
 Warning coding FinalLocalVariable Variable 'ans' should be declared final. 23
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 16, expected level should be 10. 24
 Warning coding FinalLocalVariable Variable 's' should be declared final. 27
 Warning coding FinalLocalVariable Variable 'b' should be declared final. 29
 Warning coding FinalLocalVariable Variable 't' should be declared final. 36
 Warning coding FinalLocalVariable Variable 'ans' should be declared final. 38
 Warning coding FinalLocalVariable Variable 's' should be declared final. 41
 Warning coding FinalLocalVariable Variable 'b' should be declared final. 43
 Warning coding FinalLocalVariable Variable 't' should be declared final. 50
 Warning coding FinalLocalVariable Variable 's' should be declared final. 51
 Warning coding FinalLocalVariable Variable 't' should be declared final. 57
 Warning coding FinalLocalVariable Variable 's' should be declared final. 58
 Warning coding FinalLocalVariable Variable 't' should be declared final. 64
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 65
 Warning coding FinalLocalVariable Variable 't' should be declared final. 72
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 73
 Warning coding FinalLocalVariable Variable 't' should be declared final. 80
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 81
 Warning coding FinalLocalVariable Variable 't' should be declared final. 88
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 89
 Warning coding FinalLocalVariable Variable 't' should be declared final. 96
 Warning coding FinalLocalVariable Variable 'ans' should be declared final. 98
 Warning coding FinalLocalVariable Variable 's' should be declared final. 101
 Warning coding FinalLocalVariable Variable 'b' should be declared final. 103
 Warning coding FinalLocalVariable Variable 't' should be declared final. 110
 Warning coding FinalLocalVariable Variable 's' should be declared final. 111
 Warning coding FinalLocalVariable Variable 't' should be declared final. 118
 Warning coding FinalLocalVariable Variable 'ans' should be declared final. 120
 Warning coding FinalLocalVariable Variable 's' should be declared final. 123
 Warning coding FinalLocalVariable Variable 'b' should be declared final. 125
 Warning coding FinalLocalVariable Variable 's' should be declared final. 163
 Warning coding FinalLocalVariable Variable 't' should be declared final. 164
 Warning coding FinalLocalVariable Variable 's' should be declared final. 170
 Warning coding FinalLocalVariable Variable 't' should be declared final. 171
 Warning coding FinalLocalVariable Variable 's' should be declared final. 177
 Warning coding FinalLocalVariable Variable 's' should be declared final. 183
 Warning coding FinalLocalVariable Variable 's' should be declared final. 189
 Warning coding FinalLocalVariable Variable 's' should be declared final. 195
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 226
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 233
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 240
 Warning coding FinalLocalVariable Variable 's' should be declared final. 241
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 248
 Warning coding FinalLocalVariable Variable 's' should be declared final. 249

emissary/transform/decode/JavascriptEscape.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter data should be final. 15
 Warning coding FinalLocalVariable Variable 'out' should be declared final. 16
 Warning coding FinalLocalVariable Variable 's' should be declared final. 21
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 22
 Warning coding ModifiedControlVariable Control variable 'i' is modified. 26
 Warning blocks RightCurly '}' at column 33 should be alone on a line. 44
 Warning misc FinalParameters Parameter args should be final. 47
 Warning coding FinalLocalVariable Variable 'content' should be declared final. 51
 Warning coding FinalLocalVariable Variable 'escaped' should be declared final. 58

emissary/transform/decode/JsonEscape.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter data should be final. 17
 Warning coding FinalLocalVariable Variable 'out' should be declared final. 18
 Warning coding FinalLocalVariable Variable 's' should be declared final. 23
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 24
 Warning coding ModifiedControlVariable Control variable 'i' is modified. 28
 Warning coding FinalLocalVariable Variable 's' should be declared final. 44
 Warning coding FinalLocalVariable Variable 'num' should be declared final. 46
 Warning coding FinalLocalVariable Variable 'ch' should be declared final. 47
 Warning coding ModifiedControlVariable Control variable 'i' is modified. 50
 Warning coding FinalLocalVariable Variable 'b' should be declared final. 55
 Warning coding ModifiedControlVariable Control variable 'i' is modified. 65
 Warning misc FinalParameters Parameter b should be final. 73
 Warning blocks RightCurly '}' at column 27 should be alone on a line. 78
 Warning misc FinalParameters Parameter args should be final. 81
 Warning coding FinalLocalVariable Variable 'content' should be declared final. 83
 Warning coding FinalLocalVariable Variable 'escaped' should be declared final. 90

emissary/transform/decode/JsonEscapeTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'input' should be declared final. 13
 Warning coding FinalLocalVariable Variable 'output' should be declared final. 14
 Warning coding FinalLocalVariable Variable 'input' should be declared final. 20
 Warning coding FinalLocalVariable Variable 'output' should be declared final. 21
 Warning coding FinalLocalVariable Variable 'input' should be declared final. 27
 Warning coding FinalLocalVariable Variable 'output' should be declared final. 28
 Warning coding FinalLocalVariable Variable 'input' should be declared final. 34
 Warning coding IllegalTokenText Avoid using corresponding octal or Unicode escape. 34
 Warning coding FinalLocalVariable Variable 'output' should be declared final. 35
 Warning coding FinalLocalVariable Variable 'input' should be declared final. 41
 Warning coding FinalLocalVariable Variable 'output' should be declared final. 42
 Warning coding FinalLocalVariable Variable 'input' should be declared final. 48
 Warning coding FinalLocalVariable Variable 'output' should be declared final. 49

emissary/util/ByteUtil.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter b should be final. 41
 Warning misc FinalParameters Parameter array should be final. 51
 Warning misc FinalParameters Parameter c should be final. 66
 Warning misc FinalParameters Parameter array should be final. 76
 Warning misc FinalParameters Parameter b should be final. 91
 Warning misc FinalParameters Parameter b should be final. 101
 Warning misc FinalParameters Parameter b should be final. 111
 Warning misc FinalParameters Parameter array should be final. 122
 Warning misc FinalParameters Parameter b should be final. 138
 Warning misc FinalParameters Parameter pos should be final. 138
 Warning misc FinalParameters Parameter a should be final. 167
 Warning misc FinalParameters Parameter b should be final. 167
 Warning misc FinalParameters Parameter a should be final. 185
 Warning misc FinalParameters Parameter b should be final. 185
 Warning misc FinalParameters Parameter c should be final. 185
 Warning misc FinalParameters Parameter a should be final. 210
 Warning misc FinalParameters Parameter astart should be final. 210
 Warning misc FinalParameters Parameter aend should be final. 210
 Warning misc FinalParameters Parameter b should be final. 210
 Warning misc FinalParameters Parameter bstart should be final. 210
 Warning misc FinalParameters Parameter bend should be final. 210
 Warning coding FinalLocalVariable Variable 'alen' should be declared final. 211
 Warning coding FinalLocalVariable Variable 'blen' should be declared final. 212
 Warning coding FinalLocalVariable Variable 'rslt' should be declared final. 214
 Warning misc FinalParameters Parameter a should be final. 235
 Warning misc FinalParameters Parameter astart should be final. 235
 Warning misc FinalParameters Parameter aend should be final. 235
 Warning misc FinalParameters Parameter b should be final. 235
 Warning misc FinalParameters Parameter bstart should be final. 235
 Warning misc FinalParameters Parameter bend should be final. 235
 Warning misc FinalParameters Parameter c should be final. 235
 Warning misc FinalParameters Parameter cstart should be final. 235
 Warning misc FinalParameters Parameter cend should be final. 235
 Warning coding FinalLocalVariable Variable 'alen' should be declared final. 236
 Warning coding FinalLocalVariable Variable 'blen' should be declared final. 237
 Warning coding FinalLocalVariable Variable 'clen' should be declared final. 238
 Warning coding FinalLocalVariable Variable 'rslt' should be declared final. 240
 Warning misc FinalParameters Parameter a should be final. 253
 Warning misc FinalParameters Parameter pos should be final. 253
 Warning coding FinalLocalVariable Variable 'list' should be declared final. 254
 Warning coding FinalLocalVariable Variable 'part1' should be declared final. 256
 Warning coding FinalLocalVariable Variable 'part2' should be declared final. 257
 Warning misc FinalParameters Parameter data should be final. 277
 Warning misc FinalParameters Parameter pos should be final. 277
 Warning coding IllegalTokenText Avoid using corresponding octal or Unicode escape. 391
 Warning blocks RightCurly '}' at column 25 should be alone on a line. 403

emissary/util/ByteUtilTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'res' should be declared final. 50
 Warning coding FinalLocalVariable Variable 'input' should be declared final. 57
 Warning coding FinalLocalVariable Variable 'parts' should be declared final. 58
 Warning coding FinalLocalVariable Variable 'parts' should be declared final. 68
 Warning coding FinalLocalVariable Variable 'input' should be declared final. 75
 Warning coding FinalLocalVariable Variable 'parts' should be declared final. 76
 Warning coding FinalLocalVariable Variable 'input' should be declared final. 83
 Warning coding FinalLocalVariable Variable 'parts' should be declared final. 84
 Warning coding FinalLocalVariable Variable 'no' should be declared final. 194
 Warning coding FinalLocalVariable Variable 'yes' should be declared final. 195
 Warning coding FinalLocalVariable Variable 'data' should be declared final. 206
 Warning coding FinalLocalVariable Variable 'newLineCarriageTab' should be declared final. 214
 Warning coding FinalLocalVariable Variable 'euro' should be declared final. 219
 Warning coding FinalLocalVariable Variable 'nihao' should be declared final. 225
 Warning coding FinalLocalVariable Variable 'emoji' should be declared final. 231
 Warning coding FinalLocalVariable Variable 'uNull' should be declared final. 237
 Warning coding FinalLocalVariable Variable 'nnbsp' should be declared final. 243
 Warning coding FinalLocalVariable Variable 'zwbsp' should be declared final. 249
 Warning coding FinalLocalVariable Variable 'rep' should be declared final. 255

emissary/util/CaseInsensitiveMap.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter initialCapacity should be final. 27
 Warning misc FinalParameters Parameter initialCapacity should be final. 34
 Warning misc FinalParameters Parameter loadFactor should be final. 34
 Warning misc FinalParameters Parameter map should be final. 41
 Warning misc FinalParameters Parameter key should be final. 51
 Warning misc FinalParameters Parameter value should be final. 51
 Warning coding FinalLocalVariable Variable 'uckey' should be declared final. 53
 Warning coding RequireThis Reference to instance variable 'remap' needs "this.". 54
 Warning coding RequireThis Reference to instance variable 'remap' needs "this.". 57
 Warning misc FinalParameters Parameter key should be final. 68
 Warning coding FinalLocalVariable Variable 'strkey' should be declared final. 72
 Warning coding RequireThis Reference to instance variable 'remap' needs "this.". 72
 Warning misc FinalParameters Parameter t should be final. 85
 Warning misc FinalParameters Parameter key should be final. 95
 Warning coding FinalLocalVariable Variable 'strkey' should be declared final. 99
 Warning coding RequireThis Reference to instance variable 'remap' needs "this.". 99
 Warning misc FinalParameters Parameter key should be final. 112
 Warning coding FinalLocalVariable Variable 'uckey' should be declared final. 116
 Warning coding FinalLocalVariable Variable 'strkey' should be declared final. 117
 Warning coding RequireThis Reference to instance variable 'remap' needs "this.". 117
 Warning coding RequireThis Reference to instance variable 'remap' needs "this.". 122

emissary/util/CaseInsensitiveMapTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 18
 Warning coding FinalLocalVariable Variable 's' should be declared final. 20
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 27
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 36
 Warning coding FinalLocalVariable Variable 'p' should be declared final. 37
 Warning coding FinalLocalVariable Variable 'p' should be declared final. 46
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 49
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 55
 Warning coding FinalLocalVariable Variable 'pair' should be declared final. 59

emissary/util/CharacterCounterSet.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter initialCapacity should be final. 26
 Warning misc FinalParameters Parameter initialCapacity should be final. 37
 Warning misc FinalParameters Parameter loadFactor should be final. 37
 Warning misc FinalParameters Parameter s should be final. 99
 Warning coding FinalLocalVariable Variable 'cpc' should be declared final. 100
 Warning coding FinalLocalVariable Variable 'offset' should be declared final. 102
 Warning coding FinalLocalVariable Variable 'cp' should be declared final. 103
 Warning coding FinalLocalVariable Variable 'cpa' should be declared final. 104
 Warning coding FinalLocalVariable Variable 'scp' should be declared final. 105

emissary/util/CharacterCounterSetTest.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter s should be final. 30
 Warning misc FinalParameters Parameter expectedLetterCount should be final. 30
 Warning misc FinalParameters Parameter expectedDigitCount should be final. 30
 Warning misc FinalParameters Parameter expectedPunctuationCount should be final. 31
 Warning misc FinalParameters Parameter expectedBlankSpaceCount should be final. 31
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 32

emissary/util/CharsetUtil.java

Severity Category Rule Message Line
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 12, expected level should be one of the following: 6, 55, 56. 47
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 12, expected level should be one of the following: 6, 55, 56. 48
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 12, expected level should be one of the following: 6, 55, 56. 49
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 12, expected level should be one of the following: 6, 55, 56. 50
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 12, expected level should be one of the following: 6, 55, 56. 51
 Warning naming MethodName Method name 'jGetUtfCharArray' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9_]*$'. 89
 Warning coding FallThrough Fall through from previous branch of the switch statement. 256
 Warning coding FallThrough Fall through from previous branch of the switch statement. 261
 Warning coding FallThrough Fall through from previous branch of the switch statement. 289
 Warning blocks RightCurly '}' at column 28 should be alone on a line. 326

emissary/util/CharsetUtilTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'b' should be declared final. 59

emissary/util/ClassComparator.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 32 should be alone on a line. 11
 Warning misc FinalParameters Parameter clazz should be final. 47
 Warning misc FinalParameters Parameter iface should be final. 47

emissary/util/ClassLookupCache.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 33 should be alone on a line. 151

emissary/util/ConstructorLookupCache.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'public' modifier. 50
 Warning blocks RightCurly '}' at column 39 should be alone on a line. 268

emissary/util/ConstructorLookupCacheTest.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'public' modifier. 22
 Warning blocks RightCurly '}' at column 32 should be alone on a line. 22
 Warning modifier RedundantModifier Redundant 'public' modifier. 25
 Warning misc FinalParameters Parameter arg1 should be final. 25
 Warning blocks RightCurly '}' at column 44 should be alone on a line. 25
 Warning modifier RedundantModifier Redundant 'public' modifier. 28
 Warning misc FinalParameters Parameter arg1 should be final. 28
 Warning misc FinalParameters Parameter arg2 should be final. 28
 Warning misc FinalParameters Parameter arg3 should be final. 28
 Warning blocks RightCurly '}' at column 75 should be alone on a line. 28
 Warning modifier RedundantModifier Redundant 'public' modifier. 31
 Warning misc FinalParameters Parameter arg1 should be final. 31
 Warning misc FinalParameters Parameter arg2 should be final. 31
 Warning misc FinalParameters Parameter arg3 should be final. 31
 Warning misc FinalParameters Parameter arg4 should be final. 31
 Warning blocks RightCurly '}' at column 80 should be alone on a line. 31
 Warning misc FinalParameters Parameter args should be final. 37

emissary/util/CounterSet.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'flexentry' must be private and have accessor methods. 14
 Warning blocks RightCurly '}' at column 26 should be alone on a line. 19
 Warning misc FinalParameters Parameter flexentry should be final. 26
 Warning misc FinalParameters Parameter initialCapacity should be final. 36
 Warning misc FinalParameters Parameter initialCapacity should be final. 46
 Warning misc FinalParameters Parameter loadFactor should be final. 46
 Warning misc FinalParameters Parameter val should be final. 55
 Warning coding RequireThis Reference to instance variable 'flexentry' needs "this.". 65
 Warning misc FinalParameters Parameter key should be final. 80
 Warning misc FinalParameters Parameter keys should be final. 89
 Warning misc FinalParameters Parameter key should be final. 102
 Warning misc FinalParameters Parameter val should be final. 102
 Warning coding RequireThis Reference to instance variable 'flexentry' needs "this.". 105
 Warning misc FinalParameters Parameter key should be final. 117
 Warning misc FinalParameters Parameter key should be final. 127

emissary/util/CounterSetTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 16
 Warning coding FinalLocalVariable Variable 'keys' should be declared final. 19
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 25
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 33
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 40
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 47

emissary/util/CustomRolloverLogbackAppender.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'configG' should be declared final. 21
 Warning coding RequireThis Reference to instance variable 'rolloverTime' needs "this.". 22
 Warning coding RequireThis Reference to instance variable 'rolloverTime' needs "this.". 22
 Warning coding RequireThis Reference to instance variable 'isConfigured' needs "this.". 31
 Warning coding RequireThis Reference to instance variable 'isConfigured' needs "this.". 33
 Warning coding FinalLocalVariable Variable 'currentTime' should be declared final. 36
 Warning coding FinalLocalVariable Variable 'maxIntervalSinceLastLoggingInMillis' should be declared final. 37
 Warning coding RequireThis Reference to instance variable 'rolloverTime' needs "this.". 37
 Warning coding RequireThis Reference to instance variable 'start' needs "this.". 39
 Warning coding RequireThis Reference to instance variable 'start' needs "this.". 41

emissary/util/DataUtil.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 25 should be alone on a line. 157

emissary/util/DateTimeFormatParser.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'zone' must be private and have accessor methods. 36
 Warning blocks RightCurly '}' at column 37 should be alone on a line. 49
 Warning coding FinalLocalVariable Variable 'configG' should be declared final. 53
 Warning misc FinalParameters Parameter configG should be final. 82
 Warning misc FinalParameters Parameter entryType should be final. 82
 Warning misc FinalParameters Parameter dateFormats should be final. 82
 Warning coding HiddenField 'dateFormats' hides a field. 82
 Warning misc FinalParameters Parameter dateString should be final. 105
 Warning coding FinalLocalVariable Variable 'cleanedDateString' should be declared final. 127
 Warning coding FinalLocalVariable Variable 'methodList' should be declared final. 129
 Warning coding FinalLocalVariable Variable 'date' should be declared final. 136
 Warning coding FinalLocalVariable Variable 'odt' should be declared final. 208
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 228

emissary/util/DateTimeFormatParserLegacy.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'configG' should be declared final. 31
 Warning blocks RightCurly '}' at column 43 should be alone on a line. 90

emissary/util/DateTimeFormatParserTest.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter date should be final. 38
 Warning misc FinalParameters Parameter expected should be final. 38
 Warning misc FinalParameters Parameter msg should be final. 38
 Warning coding FinalLocalVariable Variable 'unknownParse' should be declared final. 39
 Warning misc FinalParameters Parameter date should be final. 49
 Warning misc FinalParameters Parameter expected should be final. 49
 Warning coding FinalLocalVariable Variable 'unknownParse' should be declared final. 50
 Warning coding FinalLocalVariable Variable 'knownParse' should be declared final. 53

emissary/util/DependencyCheck.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'config' must be private and have accessor methods. 21
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 31
 Warning misc FinalParameters Parameter config should be final. 34
 Warning misc FinalParameters Parameter executable should be final. 44
 Warning coding FinalLocalVariable Variable 'command' should be declared final. 46
 Warning coding FinalLocalVariable Variable 'exec' should be declared final. 47
 Warning coding FinalLocalVariable Variable 'returnVal' should be declared final. 48
 Warning misc FinalParameters Parameter pathToDir should be final. 61
 Warning blocks AvoidNestedBlocks Avoid nested blocks. 63
 Warning misc FinalParameters Parameter pathToFile should be final. 79
 Warning blocks AvoidNestedBlocks Avoid nested blocks. 81
 Warning misc FinalParameters Parameter key should be final. 91
 Warning coding RequireThis Reference to instance variable 'config' needs "this.". 92
 Warning coding FinalLocalVariable Variable 'reqExeSet' should be declared final. 96
 Warning coding FinalLocalVariable Variable 'reqDirSet' should be declared final. 97
 Warning coding FinalLocalVariable Variable 'reqFileSet' should be declared final. 98
 Warning coding VariableDeclarationUsageDistance Distance between variable 'optExeSet' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 99
 Warning coding FinalLocalVariable Variable 'optExeSet' should be declared final. 99
 Warning coding VariableDeclarationUsageDistance Distance between variable 'optDirSet' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 100
 Warning coding FinalLocalVariable Variable 'optDirSet' should be declared final. 100
 Warning coding VariableDeclarationUsageDistance Distance between variable 'optFileSet' declaration and its first usage is 6, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 101
 Warning coding FinalLocalVariable Variable 'optFileSet' should be declared final. 101
 Warning coding FinalLocalVariable Variable 'exists' should be declared final. 104
 Warning coding FinalLocalVariable Variable 'exists' should be declared final. 108
 Warning coding FinalLocalVariable Variable 'exists' should be declared final. 112
 Warning coding FinalLocalVariable Variable 'exists' should be declared final. 116
 Warning coding FinalLocalVariable Variable 'exists' should be declared final. 120
 Warning coding FinalLocalVariable Variable 'exists' should be declared final. 124
 Warning misc FinalParameters Parameter args should be final. 129
 Warning coding FinalLocalVariable Variable 'dependencyCheck' should be declared final. 130

emissary/util/DependencyCheckTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'exists' should be declared final. 30
 Warning coding FinalLocalVariable Variable 'exists' should be declared final. 36
 Warning coding FinalLocalVariable Variable 'exists' should be declared final. 42
 Warning coding FinalLocalVariable Variable 'exists' should be declared final. 48
 Warning coding FinalLocalVariable Variable 'conf' should be declared final. 55
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 62
 Warning coding FinalLocalVariable Variable 'originalOut' should be declared final. 63
 Warning coding FinalLocalVariable Variable 'baos' should be declared final. 64
 Warning coding FinalLocalVariable Variable 'myOut' should be declared final. 65

emissary/util/DisposeHelper.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 30 should be alone on a line. 19

emissary/util/DisposeHelperTest.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 49
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 50
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 51
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 51
 Warning coding RequireThis Reference to instance variable 'rLogger' needs "this.". 52
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 52
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 53
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 58
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 58
 Warning coding RequireThis Reference to instance variable 'rLogger' needs "this.". 59
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 59
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 67
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 69
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 70
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 71
 Warning whitespace OperatorWrap '&&' should be on a new line. 72
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 78
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 79
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 80
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 81
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 87
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 88
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 89
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 90
 Warning whitespace OperatorWrap '&&' should be on a new line. 91
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 97
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 102
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 103
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 104
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 105
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 106
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 107
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 108
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 113
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 114
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 118
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 119
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 129
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 130
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 141
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 142
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 147
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 148
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 149
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 160
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 161
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 166
 Warning coding RequireThis Reference to instance variable 'bdo' needs "this.". 167

emissary/util/Entropy.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter length should be final. 12
 Warning coding FinalLocalVariable Variable 'size' should be declared final. 16
 Warning coding FinalLocalVariable Variable 'histogramArray' should be declared final. 17
 Warning blocks RightCurly '}' at column 24 should be alone on a line. 45

emissary/util/EntropyTest.java

Severity Category Rule Message Line
 Warning sizes LineLength Line is longer than 170 characters (found 196). 16
 Warning coding FinalLocalVariable Variable 'b' should be declared final. 23

emissary/util/FlexibleDateTimeParser.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'configurator' should be declared final. 83
 Warning coding FinalLocalVariable Variable 'configEntriesMain' should be declared final. 86
 Warning coding FinalLocalVariable Variable 'configEntriesExtra' should be declared final. 89
 Warning coding FinalLocalVariable Variable 'removeRegex' should be declared final. 92
 Warning coding FinalLocalVariable Variable 'extraTextRemoveRegex' should be declared final. 96
 Warning misc FinalParameters Parameter tryExtensiveParsing should be final. 130
 Warning coding FinalLocalVariable Variable 'zdt' should be declared final. 131
 Warning coding FinalLocalVariable Variable 'cleanedDateString' should be declared final. 161
 Warning coding FinalLocalVariable Variable 'accessor' should be declared final. 174
 Warning coding FinalLocalVariable Variable 'matcher' should be declared final. 211
 Warning coding FinalLocalVariable Variable 'secondChanceDate' should be declared final. 213
 Warning misc FinalParameters Parameter tryExtensiveParsing should be final. 228
 Warning coding FinalLocalVariable Variable 'dateFormats' should be declared final. 266
 Warning misc FinalParameters Parameter entry should be final. 298
 Warning blocks RightCurly '}' at column 39 should be alone on a line. 330

emissary/util/FlexibleDateTimeParserTest.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter date should be final. 46
 Warning misc FinalParameters Parameter expected should be final. 46
 Warning misc FinalParameters Parameter msg should be final. 46
 Warning coding FinalLocalVariable Variable 'unknownParse' should be declared final. 47
 Warning misc FinalParameters Parameter date should be final. 58
 Warning misc FinalParameters Parameter expected should be final. 58
 Warning misc FinalParameters Parameter formatter should be final. 58
 Warning coding FinalLocalVariable Variable 'unknownParse' should be declared final. 59
 Warning coding FinalLocalVariable Variable 'knownParse' should be declared final. 62
 Warning misc FinalParameters Parameter date should be final. 76
 Warning misc FinalParameters Parameter expected should be final. 76
 Warning misc FinalParameters Parameter msg should be final. 76
 Warning coding FinalLocalVariable Variable 'unknownParse' should be declared final. 77
 Warning misc FinalParameters Parameter dateString should be final. 88
 Warning misc FinalParameters Parameter expected should be final. 88
 Warning coding FinalLocalVariable Variable 'offsets' should be declared final. 89
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 16, expected level should be one of the following: 10, 28, 29. 90
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 16, expected level should be one of the following: 10, 28, 29. 91
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 16, expected level should be one of the following: 10, 28, 29. 92
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 16, expected level should be one of the following: 10, 28, 29. 93
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 16, expected level should be one of the following: 10, 28, 29. 94
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 16, expected level should be one of the following: 10, 28, 29. 95
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 16, expected level should be one of the following: 10, 28, 29. 96
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 16, expected level should be one of the following: 10, 28, 29. 97
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 16, expected level should be one of the following: 10, 28, 29. 98
 Warning coding FinalLocalVariable Variable 'dateAndOffset' should be declared final. 101
 Warning coding FinalLocalVariable Variable 'pattern' should be declared final. 114
 Warning coding FinalLocalVariable Variable 'dtf' should be declared final. 196
 Warning coding FinalLocalVariable Variable 'pattern' should be declared final. 204
 Warning coding FinalLocalVariable Variable 'pattern' should be declared final. 251
 Warning coding FinalLocalVariable Variable 'pattern' should be declared final. 282
 Warning coding FinalLocalVariable Variable 'pattern' should be declared final. 305
 Warning coding FinalLocalVariable Variable 'pattern' should be declared final. 354
 Warning coding FinalLocalVariable Variable 'pattern' should be declared final. 373
 Warning coding FinalLocalVariable Variable 'pattern' should be declared final. 412
 Warning coding FinalLocalVariable Variable 'pattern' should be declared final. 438
 Warning coding FinalLocalVariable Variable 'pattern' should be declared final. 464
 Warning coding FinalLocalVariable Variable 'pattern' should be declared final. 477
 Warning coding FinalLocalVariable Variable 'pattern' should be declared final. 507
 Warning coding FinalLocalVariable Variable 'pattern' should be declared final. 517
 Warning coding FinalLocalVariable Variable 'pattern' should be declared final. 541
 Warning coding FinalLocalVariable Variable 'pattern' should be declared final. 554
 Warning coding FinalLocalVariable Variable 'pattern' should be declared final. 571
 Warning coding FinalLocalVariable Variable 'pattern' should be declared final. 580
 Warning coding FinalLocalVariable Variable 'pattern' should be declared final. 603
 Warning coding FinalLocalVariable Variable 'pattern' should be declared final. 621
 Warning coding FinalLocalVariable Variable 'pattern' should be declared final. 627
 Warning coding FinalLocalVariable Variable 'pattern' should be declared final. 633
 Warning coding FinalLocalVariable Variable 'pattern' should be declared final. 639
 Warning coding FinalLocalVariable Variable 'pattern' should be declared final. 645
 Warning coding FinalLocalVariable Variable 'pattern' should be declared final. 651

emissary/util/GitRepositoryState.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter properties should be final. 42
 Warning misc FinalParameters Parameter gitProperties should be final. 72
 Warning coding FinalLocalVariable Variable 'properties' should be declared final. 73
 Warning misc FinalParameters Parameter gitProperties should be final. 82
 Warning coding FinalLocalVariable Variable 'properties' should be declared final. 83
 Warning misc FinalParameters Parameter gitRepositoryState should be final. 92
 Warning misc FinalParameters Parameter applicationName should be final. 92
 Warning coding RequireThis Reference to instance variable 'tags' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'branch' needs "this.". 102
 Warning coding RequireThis Reference to instance variable 'dirty' needs "this.". 106
 Warning coding RequireThis Reference to instance variable 'remoteOriginUrl' needs "this.". 110
 Warning coding RequireThis Reference to instance variable 'commitIdAbbrev' needs "this.". 114
 Warning coding RequireThis Reference to instance variable 'commitId' needs "this.". 118
 Warning coding RequireThis Reference to instance variable 'describe' needs "this.". 122
 Warning coding RequireThis Reference to instance variable 'describeShort' needs "this.". 126
 Warning coding RequireThis Reference to instance variable 'commitUserName' needs "this.". 130
 Warning coding RequireThis Reference to instance variable 'commitUserEmail' needs "this.". 134
 Warning coding RequireThis Reference to instance variable 'commitMessageFull' needs "this.". 138
 Warning coding RequireThis Reference to instance variable 'commitMessageShort' needs "this.". 142
 Warning coding RequireThis Reference to instance variable 'commitTime' needs "this.". 146
 Warning coding RequireThis Reference to instance variable 'closestTagName' needs "this.". 150
 Warning coding RequireThis Reference to instance variable 'closestTagCommitCount' needs "this.". 154
 Warning coding RequireThis Reference to instance variable 'buildUserName' needs "this.". 158
 Warning coding RequireThis Reference to instance variable 'buildUserEmail' needs "this.". 162
 Warning coding RequireThis Reference to instance variable 'buildTime' needs "this.". 166
 Warning coding RequireThis Reference to instance variable 'buildHost' needs "this.". 170
 Warning coding RequireThis Reference to instance variable 'buildVersion' needs "this.". 174

emissary/util/Hexl.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter data should be final. 24
 Warning misc FinalParameters Parameter data should be final. 32
 Warning misc FinalParameters Parameter data should be final. 41
 Warning misc FinalParameters Parameter limit should be final. 41
 Warning coding FinalLocalVariable Variable 'output' should be declared final. 43
 Warning coding FinalLocalVariable Variable 'rhs' should be declared final. 53
 Warning coding FinalLocalVariable Variable 's' should be declared final. 70
 Warning coding FinalLocalVariable Variable 's' should be declared final. 79
 Warning blocks RightCurly '}' at column 21 should be alone on a line. 112
 Warning misc FinalParameters Parameter argv should be final. 115

emissary/util/HtmlEntityMap.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'entityMap' must be private and have accessor methods. 21
 Warning coding FinalLocalVariable Variable 'configG' should be declared final. 29
 Warning coding FinalLocalVariable Variable 'emap' should be declared final. 30
 Warning coding RequireThis Reference to instance variable 'entityMap' needs "this.". 31
 Warning misc FinalParameters Parameter entity should be final. 43
 Warning coding ParameterAssignment Assignment of parameter 'entity' is not allowed. 46
 Warning coding ParameterAssignment Assignment of parameter 'entity' is not allowed. 48
 Warning coding RequireThis Reference to instance variable 'entityMap' needs "this.". 51
 Warning misc FinalParameters Parameter out should be final. 54
 Warning coding RequireThis Reference to instance variable 'entityMap' needs "this.". 69
 Warning coding FinalLocalVariable Variable 'val' should be declared final. 70
 Warning coding FinalLocalVariable Variable 'cpc' should be declared final. 71
 Warning misc FinalParameters Parameter args should be final. 94
 Warning coding FinalLocalVariable Variable 'h' should be declared final. 95

emissary/util/HtmlEntityMapTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'h' should be declared final. 15
 Warning coding FinalLocalVariable Variable 'baos' should be declared final. 16
 Warning coding FinalLocalVariable Variable 'myOut' should be declared final. 17
 Warning coding FinalLocalVariable Variable 'report' should be declared final. 20

emissary/util/JMXUtil.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 24 should be alone on a line. 51

emissary/util/JavaCharSet.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 28 should be alone on a line. 85

emissary/util/LineTokenizer.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'previousIndex' must be private and have accessor methods. 12
 Warning design VisibilityModifier Variable 'index' must be private and have accessor methods. 13
 Warning design VisibilityModifier Variable 'delim' must be private and have accessor methods. 14
 Warning design VisibilityModifier Variable 'tokenCount' must be private and have accessor methods. 15
 Warning design VisibilityModifier Variable 'data' must be private and have accessor methods. 16
 Warning design VisibilityModifier Variable 'charset' must be private and have accessor methods. 18
 Warning misc FinalParameters Parameter theData should be final. 25
 Warning misc FinalParameters Parameter theData should be final. 35
 Warning misc FinalParameters Parameter delim should be final. 35
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 37
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 40
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 42
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 43
 Warning coding RequireThis Reference to instance variable 'tokenCount' needs "this.". 44
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 49
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 49
 Warning coding RequireThis Reference to instance variable 'tokenCount' needs "this.". 50
 Warning misc FinalParameters Parameter theData should be final. 62
 Warning misc FinalParameters Parameter delim should be final. 62
 Warning misc FinalParameters Parameter charset should be final. 62
 Warning misc FinalParameters Parameter theData should be final. 74
 Warning misc FinalParameters Parameter delim should be final. 74
 Warning misc FinalParameters Parameter charset should be final. 74
 Warning misc FinalParameters Parameter theData should be final. 85
 Warning misc FinalParameters Parameter charset should be final. 85
 Warning misc FinalParameters Parameter theData should be final. 96
 Warning misc FinalParameters Parameter charset should be final. 96
 Warning misc FinalParameters Parameter charset should be final. 106
 Warning coding HiddenField 'charset' hides a field. 106
 Warning misc FinalParameters Parameter charset should be final. 115
 Warning coding HiddenField 'charset' hides a field. 115
 Warning coding RequireThis Reference to instance variable 'tokenCount' needs "this.". 125
 Warning coding RequireThis Reference to instance variable 'tokenCount' needs "this.". 134
 Warning coding RequireThis Reference to instance variable 'index' needs "this.". 144
 Warning coding FinalLocalVariable Variable 'btok' should be declared final. 155
 Warning coding RequireThis Reference to instance variable 'charset' needs "this.". 161
 Warning coding RequireThis Reference to instance variable 'charset' needs "this.". 162
 Warning coding RequireThis Reference to instance variable 'tokenCount' needs "this.". 178
 Warning coding RequireThis Reference to instance variable 'index' needs "this.". 182
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 184
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 184
 Warning coding RequireThis Reference to instance variable 'delim' needs "this.". 184
 Warning coding FinalLocalVariable Variable 'tok' should be declared final. 187
 Warning coding RequireThis Reference to instance variable 'index' needs "this.". 187
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 188
 Warning coding RequireThis Reference to instance variable 'index' needs "this.". 188
 Warning coding RequireThis Reference to instance variable 'index' needs "this.". 188
 Warning coding RequireThis Reference to instance variable 'tokenCount' needs "this.". 190
 Warning coding RequireThis Reference to instance variable 'previousIndex' needs "this.". 191
 Warning coding RequireThis Reference to instance variable 'index' needs "this.". 191
 Warning coding RequireThis Reference to instance variable 'tokenCount' needs "this.". 192
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 192
 Warning coding RequireThis Reference to instance variable 'delim' needs "this.". 192
 Warning coding RequireThis Reference to instance variable 'index' needs "this.". 193
 Warning coding RequireThis Reference to instance variable 'index' needs "this.". 195
 Warning coding RequireThis Reference to instance variable 'previousIndex' needs "this.". 206
 Warning coding RequireThis Reference to instance variable 'tokenCount' needs "this.". 209
 Warning coding RequireThis Reference to instance variable 'index' needs "this.". 210
 Warning coding RequireThis Reference to instance variable 'previousIndex' needs "this.". 210
 Warning coding RequireThis Reference to instance variable 'previousIndex' needs "this.". 211

emissary/util/LineTokenizerTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'lt' should be declared final. 19
 Warning coding FinalLocalVariable Variable 'lt' should be declared final. 25
 Warning coding FinalLocalVariable Variable 'lt' should be declared final. 31
 Warning coding FinalLocalVariable Variable 'lt' should be declared final. 55
 Warning coding FinalLocalVariable Variable 'lt' should be declared final. 64
 Warning coding FinalLocalVariable Variable 'lt' should be declared final. 73

emissary/util/MagicNumberUtil.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 31 should be alone on a line. 110

emissary/util/MagicNumberUtilTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 17
 Warning coding FinalLocalVariable Variable 'f1' should be declared final. 18
 Warning coding FinalLocalVariable Variable 'f2' should be declared final. 19
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 38

emissary/util/Pair.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'key' must be private and have accessor methods. 13
 Warning design VisibilityModifier Variable 'value' must be private and have accessor methods. 14

emissary/util/PayloadUtil.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'compactHistory' must be private and have accessor methods. 39
 Warning misc FinalParameters Parameter fileType should be final. 71
 Warning misc FinalParameters Parameter preference should be final. 71
 Warning coding FinalLocalVariable Variable 'historyCase' should be declared final. 130
 Warning misc FinalParameters Parameter fileType should be final. 158
 Warning misc FinalParameters Parameter form should be final. 311
 Warning blocks RightCurly '}' at column 28 should be alone on a line. 316

emissary/util/PayloadUtilTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'now' should be declared final. 49
 Warning coding FinalLocalVariable Variable 'now' should be declared final. 70
 Warning coding FinalLocalVariable Variable 'now' should be declared final. 90
 Warning coding FinalLocalVariable Variable 'alphaLow' should be declared final. 253
 Warning coding FinalLocalVariable Variable 'formChars' should be declared final. 274
 Warning coding FinalLocalVariable Variable 'formCharArray' should be declared final. 278
 Warning coding FinalLocalVariable Variable 'rand' should be declared final. 281
 Warning coding FinalLocalVariable Variable 'word' should be declared final. 284
 Warning coding FinalLocalVariable Variable 'size' should be declared final. 285
 Warning coding FinalLocalVariable Variable 'form' should be declared final. 289
 Warning misc FinalParameters Parameter form should be final. 369

emissary/util/PkiUtil.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'pemData' should be declared final. 50
 Warning misc FinalParameters Parameter data should be final. 61
 Warning misc FinalParameters Parameter keyStore should be final. 65
 Warning misc FinalParameters Parameter pemData should be final. 65
 Warning coding FinalLocalVariable Variable 'matcher' should be declared final. 72
 Warning coding FinalLocalVariable Variable 'derBytes' should be declared final. 74
 Warning coding FinalLocalVariable Variable 'certificateFactory' should be declared final. 75
 Warning coding FinalLocalVariable Variable 'x509Certificate' should be declared final. 76
 Warning coding FinalLocalVariable Variable 'realPw' should be declared final. 90
 Warning coding FinalLocalVariable Variable 'matcher' should be declared final. 101
 Warning blocks RightCurly '}' at column 24 should be alone on a line. 112

emissary/util/PkiUtilTest.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter resourceName should be final. 34
 Warning coding FinalLocalVariable Variable 'path' should be declared final. 35
 Warning coding FinalLocalVariable Variable 'path' should be declared final. 41
 Warning coding FinalLocalVariable Variable 'keyStore' should be declared final. 42
 Warning coding FinalLocalVariable Variable 'pazz' should be declared final. 59
 Warning coding FinalLocalVariable Variable 'alias' should be declared final. 60
 Warning coding FinalLocalVariable Variable 'key' should be declared final. 65
 Warning coding FinalLocalVariable Variable 'keyStoreCertificate' should be declared final. 72
 Warning coding FinalLocalVariable Variable 'password' should be declared final. 81
 Warning coding FinalLocalVariable Variable 'password' should be declared final. 94
 Warning misc FinalParameters Parameter name should be final. 99
 Warning coding FinalLocalVariable Variable 'resource' should be declared final. 100

emissary/util/PlaceComparisonHelper.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 38 should be alone on a line. 23

emissary/util/PlaceComparisonHelperTest.java

Severity Category Rule Message Line
 Warning whitespace OperatorWrap '+' should be on a new line. 30
 Warning whitespace OperatorWrap '+' should be on a new line. 31
 Warning whitespace OperatorWrap '+' should be on a new line. 32
 Warning whitespace OperatorWrap '+' should be on a new line. 33
 Warning whitespace OperatorWrap '+' should be on a new line. 34
 Warning whitespace OperatorWrap '+' should be on a new line. 35
 Warning coding RequireThis Reference to instance variable 'ibdoNewPlace' needs "this.". 46
 Warning coding RequireThis Reference to instance variable 'ibdoOldPlace' needs "this.". 47
 Warning coding RequireThis Reference to instance variable 'resultsNewPlace' needs "this.". 48
 Warning coding RequireThis Reference to instance variable 'resultsOldPlace' needs "this.". 49
 Warning coding RequireThis Reference to instance variable 'ibdoNewPlace' needs "this.". 70
 Warning coding RequireThis Reference to instance variable 'resultsNewPlace' needs "this.". 72
 Warning coding RequireThis Reference to instance variable 'resultsNewPlace' needs "this.". 74
 Warning coding RequireThis Reference to instance variable 'ibdoNewPlace' needs "this.". 74
 Warning coding RequireThis Reference to instance variable 'resultsNewPlace' needs "this.". 76
 Warning coding RequireThis Reference to instance variable 'ibdoNewPlace' needs "this.". 76
 Warning coding RequireThis Reference to instance variable 'resultsNewPlace' needs "this.". 78
 Warning coding RequireThis Reference to instance variable 'ibdoNewPlace' needs "this.". 78
 Warning coding RequireThis Reference to instance variable 'resultsNewPlace' needs "this.". 80
 Warning coding RequireThis Reference to instance variable 'ibdoNewPlace' needs "this.". 80
 Warning coding RequireThis Reference to instance variable 'resultsNewPlace' needs "this.". 82
 Warning coding RequireThis Reference to instance variable 'ibdoNewPlace' needs "this.". 82
 Warning coding RequireThis Reference to instance variable 'resultsNewPlace' needs "this.". 94
 Warning coding RequireThis Reference to instance variable 'ibdoNewPlace' needs "this.". 94
 Warning coding RequireThis Reference to instance variable 'ibdoNewPlace' needs "this.". 100
 Warning coding RequireThis Reference to instance variable 'resultsOldPlace' needs "this.". 100
 Warning coding RequireThis Reference to instance variable 'resultsNewPlace' needs "this.". 100
 Warning coding RequireThis Reference to instance variable 'ibdoOldPlace' needs "this.". 102
 Warning coding RequireThis Reference to instance variable 'resultsOldPlace' needs "this.". 102
 Warning coding RequireThis Reference to instance variable 'resultsNewPlace' needs "this.". 102
 Warning coding RequireThis Reference to instance variable 'ibdoOldPlace' needs "this.". 104
 Warning coding RequireThis Reference to instance variable 'ibdoNewPlace' needs "this.". 104
 Warning coding RequireThis Reference to instance variable 'resultsNewPlace' needs "this.". 104
 Warning coding RequireThis Reference to instance variable 'ibdoOldPlace' needs "this.". 106
 Warning coding RequireThis Reference to instance variable 'ibdoNewPlace' needs "this.". 106
 Warning coding RequireThis Reference to instance variable 'resultsOldPlace' needs "this.". 106
 Warning coding RequireThis Reference to instance variable 'ibdoOldPlace' needs "this.". 108
 Warning coding RequireThis Reference to instance variable 'ibdoNewPlace' needs "this.". 108
 Warning coding RequireThis Reference to instance variable 'resultsOldPlace' needs "this.". 108
 Warning coding RequireThis Reference to instance variable 'resultsNewPlace' needs "this.". 108
 Warning coding RequireThis Reference to instance variable 'ibdoOldPlace' needs "this.". 110
 Warning coding RequireThis Reference to instance variable 'ibdoNewPlace' needs "this.". 110
 Warning coding RequireThis Reference to instance variable 'resultsOldPlace' needs "this.". 110
 Warning coding RequireThis Reference to instance variable 'resultsNewPlace' needs "this.". 110
 Warning coding RequireThis Reference to instance variable 'ibdoOldPlace' needs "this.". 134
 Warning coding RequireThis Reference to instance variable 'ibdoNewPlace' needs "this.". 134
 Warning coding RequireThis Reference to instance variable 'resultsOldPlace' needs "this.". 134
 Warning coding RequireThis Reference to instance variable 'resultsNewPlace' needs "this.". 134
 Warning coding RequireThis Reference to instance variable 'ibdoOldPlace' needs "this.". 136
 Warning coding RequireThis Reference to instance variable 'resultsOldPlace' needs "this.". 136
 Warning coding RequireThis Reference to instance variable 'resultsNewPlace' needs "this.". 136
 Warning coding RequireThis Reference to instance variable 'ibdoOldPlace' needs "this.". 138
 Warning coding RequireThis Reference to instance variable 'ibdoNewPlace' needs "this.". 138
 Warning coding RequireThis Reference to instance variable 'resultsOldPlace' needs "this.". 138
 Warning coding RequireThis Reference to instance variable 'ibdoOldPlace' needs "this.". 140
 Warning coding RequireThis Reference to instance variable 'resultsOldPlace' needs "this.". 140
 Warning coding RequireThis Reference to instance variable 'ibdoOldPlace' needs "this.". 142

emissary/util/ShortNameComparator.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter obj1 should be final. 21
 Warning misc FinalParameters Parameter obj2 should be final. 21
 Warning coding FinalLocalVariable Variable 's1' should be declared final. 25
 Warning coding FinalLocalVariable Variable 's2' should be declared final. 26
 Warning coding FinalLocalVariable Variable 'int1' should be declared final. 57
 Warning coding FinalLocalVariable Variable 'int2' should be declared final. 58

emissary/util/ShortNameComparatorTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'unsorted' should be declared final. 53
 Warning coding FinalLocalVariable Variable 'actual' should be declared final. 62
 Warning coding FinalLocalVariable Variable 'expected' should be declared final. 70

emissary/util/SizeUtil.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter str should be final. 54
 Warning misc FinalParameters Parameter ibdo should be final. 74
 Warning coding FinalLocalVariable Variable 'k' should be declared final. 99
 Warning coding FinalLocalVariable Variable 'values' should be declared final. 107
 Warning misc FinalParameters Parameter familyTree should be final. 130
 Warning misc FinalParameters Parameter ibdo should be final. 154
 Warning coding FinalLocalVariable Variable 'childObjList' should be declared final. 163
 Warning misc FinalParameters Parameter ibdo should be final. 185
 Warning blocks RightCurly '}' at column 25 should be alone on a line. 219

emissary/util/StringUtil.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter in should be final. 13
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 16
 Warning blocks RightCurly '}' at column 27 should be alone on a line. 27

emissary/util/TestMinimalServiceProviderPlace.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter payload should be final. 22

emissary/util/TimeUtil.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'zoneId' should be declared final. 56
 Warning coding FinalLocalVariable Variable 'zoneId' should be declared final. 81
 Warning coding FinalLocalVariable Variable 'formatter' should be declared final. 82
 Warning coding FinalLocalVariable Variable 'dateStringDefault' should be declared final. 108
 Warning misc FinalParameters Parameter date should be final. 130
 Warning misc FinalParameters Parameter hexDate should be final. 217
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 218
 Warning coding FinalLocalVariable Variable 'dateHex' should be declared final. 221
 Warning coding FinalLocalVariable Variable 'timeHex' should be declared final. 222
 Warning coding FinalLocalVariable Variable 'daysToAdd' should be declared final. 223
 Warning coding FinalLocalVariable Variable 'millisToAdd' should be declared final. 225
 Warning coding FinalLocalVariable Variable 'msg' should be declared final. 240
 Warning blocks RightCurly '}' at column 25 should be alone on a line. 255

emissary/util/TimeUtilTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'zdt' should be declared final. 65
 Warning coding FinalLocalVariable Variable 'hexDate1' should be declared final. 110
 Warning coding FinalLocalVariable Variable 'hexDate2' should be declared final. 111
 Warning coding FinalLocalVariable Variable 'invalidHexDate1' should be declared final. 115
 Warning coding FinalLocalVariable Variable 'invalidHexDate2' should be declared final. 116

emissary/util/TypeEngine.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'contextMapping' must be private and have accessor methods. 26
 Warning design VisibilityModifier Variable 'extraMapping' must be private and have accessor methods. 29
 Warning misc FinalParameters Parameter configG should be final. 34
 Warning coding FinalLocalVariable Variable 'l' should be declared final. 35
 Warning misc FinalParameters Parameter configFiles should be final. 44
 Warning blocks RightCurly '}' at column 26 should be alone on a line. 51
 Warning misc FinalParameters Parameter configFiles should be final. 56
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 65
 Warning coding FinalLocalVariable Variable 'engineName' should be declared final. 66
 Warning coding RequireThis Reference to instance variable 'contextMapping' needs "this.". 68
 Warning misc FinalParameters Parameter engine should be final. 83
 Warning misc FinalParameters Parameter label should be final. 83
 Warning coding FinalLocalVariable Variable 'extra' should be declared final. 94
 Warning coding RequireThis Reference to instance variable 'extraMapping' needs "this.". 94
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 101
 Warning coding RequireThis Reference to instance variable 'contextMapping' needs "this.". 101
 Warning misc FinalParameters Parameter engine should be final. 116
 Warning misc FinalParameters Parameter label should be final. 116
 Warning misc FinalParameters Parameter value should be final. 116
 Warning coding FinalLocalVariable Variable 'extra' should be declared final. 117
 Warning coding RequireThis Reference to instance variable 'extraMapping' needs "this.". 117
 Warning misc FinalParameters Parameter engine should be final. 126
 Warning misc FinalParameters Parameter fn should be final. 126
 Warning coding FinalLocalVariable Variable 'idx' should be declared final. 131

emissary/util/UnixFile.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter magicFile should be final. 40
 Warning misc FinalParameters Parameter magicFile should be final. 51
 Warning misc FinalParameters Parameter swallowParseException should be final. 51
 Warning coding RequireThis Reference to instance variable 'util' needs "this.". 57
 Warning misc FinalParameters Parameter magicPaths should be final. 65
 Warning misc FinalParameters Parameter magicPaths should be final. 75
 Warning misc FinalParameters Parameter swallowParseException should be final. 75
 Warning coding FinalLocalVariable Variable 'mFile' should be declared final. 77
 Warning coding RequireThis Reference to instance variable 'util' needs "this.". 82
 Warning coding RequireThis Reference to instance variable 'util' needs "this.". 88
 Warning misc FinalParameters Parameter bytes should be final. 97
 Warning coding FinalLocalVariable Variable 'subjectFileType' should be declared final. 102
 Warning misc FinalParameters Parameter bytes should be final. 115
 Warning misc FinalParameters Parameter bytes should be final. 131
 Warning coding RequireThis Reference to instance variable 'util' needs "this.". 132
 Warning misc FinalParameters Parameter args should be final. 139
 Warning coding FinalLocalVariable Variable 'magicNumberFile' should be declared final. 155
 Warning coding FinalLocalVariable Variable 'target' should be declared final. 167
 Warning coding FinalLocalVariable Variable 'data' should be declared final. 173

emissary/util/Version.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'rez' should be declared final. 33
 Warning coding RequireThis Reference to instance variable 'version' needs "this.". 38
 Warning coding RequireThis Reference to instance variable 'timestamp' needs "this.". 40
 Warning misc FinalParameters Parameter line should be final. 52
 Warning coding RequireThis Reference to instance variable 'version' needs "this.". 61
 Warning coding RequireThis Reference to instance variable 'timestamp' needs "this.". 61
 Warning coding RequireThis Reference to instance variable 'version' needs "this.". 65
 Warning coding RequireThis Reference to instance variable 'timestamp' needs "this.". 69
 Warning misc FinalParameters Parameter args should be final. 72

emissary/util/WatcherThread.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'package' should be separated from previous line. 2
 Warning blocks RightCurly '}' at column 29 should be alone on a line. 17
 Warning misc FinalParameters Parameter pp should be final. 19
 Warning coding RequireThis Reference to instance variable 'proc' needs "this.". 20
 Warning misc FinalParameters Parameter nn should be final. 23
 Warning coding RequireThis Reference to instance variable 'delay' needs "this.". 24
 Warning misc FinalParameters Parameter pp should be final. 27
 Warning coding RequireThis Reference to instance variable 'proc' needs "this.". 28
 Warning coding RequireThis Reference to instance variable 'flag' needs "this.". 32
 Warning coding FinalLocalVariable Variable 'nTries' should be declared final. 42
 Warning coding FinalLocalVariable Variable 'partialDelay' should be declared final. 43
 Warning coding RequireThis Reference to instance variable 'delay' needs "this.". 43
 Warning coding RequireThis Reference to instance variable 'flag' needs "this.". 46
 Warning coding RequireThis Reference to instance variable 'proc' needs "this.". 47
 Warning coding RequireThis Reference to instance variable 'proc' needs "this.". 53
 Warning coding RequireThis Reference to instance variable 'proc' needs "this.". 55
 Warning coding RequireThis Reference to instance variable 'proc' needs "this.". 56
 Warning coding RequireThis Reference to instance variable 'flag' needs "this.". 57
 Warning misc FinalParameters Parameter args should be final. 68
 Warning coding FinalLocalVariable Variable 'wt' should be declared final. 69
 Warning coding FinalLocalVariable Variable 'name' should be declared final. 70
 Warning coding FinalLocalVariable Variable 'proc' should be declared final. 82
 Warning coding FinalLocalVariable Variable 'out' should be declared final. 86
 Warning coding FinalLocalVariable Variable 'err' should be declared final. 87
 Warning coding FinalLocalVariable Variable 't1' should be declared final. 89
 Warning coding FinalLocalVariable Variable 't2' should be declared final. 90

emissary/util/WindowedSeekableByteChannel.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'estimatedLength' must be private and have accessor methods. 36
 Warning design VisibilityModifier Variable 'minposition' must be private and have accessor methods. 41
 Warning coding RequireThis Reference to instance variable 'buff1' needs "this.". 89
 Warning coding RequireThis Reference to instance variable 'buff2' needs "this.". 89
 Warning coding RequireThis Reference to instance variable 'buff1' needs "this.". 93
 Warning coding RequireThis Reference to instance variable 'buff2' needs "this.". 93
 Warning coding RequireThis Reference to instance variable 'buff1' needs "this.". 105
 Warning coding RequireThis Reference to instance variable 'buff2' needs "this.". 105
 Warning coding RequireThis Reference to instance variable 'buff1' needs "this.". 110
 Warning coding RequireThis Reference to instance variable 'buff2' needs "this.". 110
 Warning coding RequireThis Reference to instance variable 'buff1' needs "this.". 114
 Warning coding RequireThis Reference to instance variable 'buff2' needs "this.". 114
 Warning coding RequireThis Reference to instance variable 'buff1' needs "this.". 121
 Warning coding RequireThis Reference to instance variable 'buff2' needs "this.". 121
 Warning coding RequireThis Reference to instance variable 'buff1' needs "this.". 281
 Warning coding RequireThis Reference to instance variable 'buff2' needs "this.". 281

emissary/util/WindowedSeekableByteChannelTest.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'public' modifier. 30
 Warning blocks RightCurly '}' at column 47 should be alone on a line. 30

emissary/util/io/BufferedWriterOutputStream.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter writer should be final. 20
 Warning misc FinalParameters Parameter blockSize should be final. 20
 Warning coding RequireThis Reference to instance variable 'buffer' needs "this.". 22
 Warning misc FinalParameters Parameter writer should be final. 25
 Warning misc FinalParameters Parameter bytes should be final. 30
 Warning misc FinalParameters Parameter start should be final. 30
 Warning misc FinalParameters Parameter length should be final. 30
 Warning coding RequireThis Reference to instance variable 'buffer' needs "this.". 34
 Warning coding RequireThis Reference to instance variable 'bufferLength' needs "this.". 34
 Warning coding RequireThis Reference to instance variable 'buffer' needs "this.". 41
 Warning coding RequireThis Reference to instance variable 'bufferLength' needs "this.". 41
 Warning coding RequireThis Reference to instance variable 'bufferLength' needs "this.". 45
 Warning coding RequireThis Reference to instance variable 'buffer' needs "this.". 45
 Warning coding RequireThis Reference to instance variable 'writer' needs "this.". 46
 Warning coding RequireThis Reference to instance variable 'buffer' needs "this.". 46
 Warning coding RequireThis Reference to instance variable 'bufferLength' needs "this.". 47
 Warning coding ParameterAssignment Assignment of parameter 'start' is not allowed. 51
 Warning coding ParameterAssignment Assignment of parameter 'length' is not allowed. 52
 Warning misc FinalParameters Parameter bytes should be final. 57
 Warning misc FinalParameters Parameter b should be final. 62
 Warning coding RequireThis Reference to instance variable 'buffer' needs "this.". 63
 Warning coding RequireThis Reference to instance variable 'bufferLength' needs "this.". 63
 Warning coding RequireThis Reference to instance variable 'bufferLength' needs "this.". 65
 Warning coding RequireThis Reference to instance variable 'buffer' needs "this.". 65
 Warning coding RequireThis Reference to instance variable 'writer' needs "this.". 66
 Warning coding RequireThis Reference to instance variable 'buffer' needs "this.". 66
 Warning coding RequireThis Reference to instance variable 'bufferLength' needs "this.". 67
 Warning coding RequireThis Reference to instance variable 'bufferLength' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'writer' needs "this.". 74
 Warning coding RequireThis Reference to instance variable 'buffer' needs "this.". 74
 Warning coding RequireThis Reference to instance variable 'bufferLength' needs "this.". 74
 Warning coding RequireThis Reference to instance variable 'bufferLength' needs "this.". 75

emissary/util/io/FastStringBuffer.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'curPos' must be private and have accessor methods. 34
 Warning design VisibilityModifier Variable 'buffer' must be private and have accessor methods. 35
 Warning design VisibilityModifier Variable 'myString' must be private and have accessor methods. 37
 Warning design VisibilityModifier Variable 'stream' must be private and have accessor methods. 38
 Warning design VisibilityModifier Variable 'bytesWritten' must be private and have accessor methods. 39
 Warning misc FinalParameters Parameter s should be final. 313
 Warning misc FinalParameters Parameter charset should be final. 313

emissary/util/io/FileFind.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 24 should be alone on a line. 38
 Warning misc FinalParameters Parameter options should be final. 43
 Warning coding RequireThis Reference to instance variable 'wantFiles' needs "this.". 46
 Warning coding RequireThis Reference to instance variable 'wantDirectories' needs "this.". 51
 Warning misc FinalParameters Parameter filename should be final. 55
 Warning misc FinalParameters Parameter filename should be final. 59
 Warning misc FinalParameters Parameter filter should be final. 59
 Warning misc FinalParameters Parameter args should be final. 64
 Warning coding FinalLocalVariable Variable 'ff' should be declared final. 66
 Warning coding FinalLocalVariable Variable 'i' should be declared final. 75
 Warning coding FinalLocalVariable Variable 'f' should be declared final. 77
 Warning modifier RedundantModifier Redundant 'public' modifier. 100
 Warning misc FinalParameters Parameter filename should be final. 100
 Warning modifier RedundantModifier Redundant 'public' modifier. 104
 Warning misc FinalParameters Parameter filename should be final. 104
 Warning misc FinalParameters Parameter filter should be final. 104
 Warning coding FinalLocalVariable Variable 'f' should be declared final. 105
 Warning coding RequireThis Reference to instance variable 'currentPath' needs "this.". 109
 Warning coding RequireThis Reference to instance variable 'currentPath' needs "this.". 119
 Warning coding RequireThis Reference to instance variable 'currentPath' needs "this.". 125
 Warning coding FinalLocalVariable Variable 'tmp' should be declared final. 126
 Warning coding RequireThis Reference to instance variable 'currentPath' needs "this.". 126
 Warning coding RequireThis Reference to instance variable 'currentPath' needs "this.". 144
 Warning coding FinalLocalVariable Variable 'tmp' should be declared final. 145
 Warning coding RequireThis Reference to instance variable 'currentPath' needs "this.". 145
 Warning coding FinalLocalVariable Variable 'theDir' should be declared final. 152
 Warning coding RequireThis Reference to instance variable 'currentPath' needs "this.". 152
 Warning coding FinalLocalVariable Variable 'tmpContents' should be declared final. 155
 Warning coding RequireThis Reference to instance variable 'filter' needs "this.". 155
 Warning coding RequireThis Reference to instance variable 'currentPath' needs "this.". 156
 Warning coding RequireThis Reference to instance variable 'wantDirectories' needs "FileFind.this.". 159
 Warning coding RequireThis Reference to instance variable 'currentPath' needs "this.". 160
 Warning coding RequireThis Reference to instance variable 'currentPath' needs "this.". 167
 Warning coding RequireThis Reference to instance variable 'currentPath' needs "this.". 169
 Warning whitespace EmptyLineSeparator 'CLASS_DEF' should be separated from previous line. 180
 Warning modifier RedundantModifier Redundant 'public' modifier. 184
 Warning misc FinalParameters Parameter contents should be final. 184
 Warning coding RequireThis Reference to instance variable 'position' needs "this.". 186
 Warning coding RequireThis Reference to instance variable 'position' needs "this.". 190
 Warning coding RequireThis Reference to instance variable 'contents' needs "this.". 190
 Warning coding RequireThis Reference to instance variable 'contents' needs "this.". 194
 Warning coding RequireThis Reference to instance variable 'position' needs "this.". 194

emissary/util/io/FileManipulator.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'theTempFile' should be declared final. 34
 Warning blocks RightCurly '}' at column 32 should be alone on a line. 59

emissary/util/io/ListOpenFiles.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'exec' must be private and have accessor methods. 11
 Warning misc FinalParameters Parameter path should be final. 13
 Warning misc FinalParameters Parameter path should be final. 17
 Warning coding FinalLocalVariable Variable 'returnVal' should be declared final. 22
 Warning coding RequireThis Reference to instance variable 'exec' needs "this.". 22

emissary/util/io/ListOpenFilesTest.java

Severity Category Rule Message Line
 Warning coding HiddenField 'tmpDir' hides a field. 30
 Warning coding RequireThis Reference to instance variable 'file' needs "this.". 35
 Warning coding RequireThis Reference to instance variable 'file' needs "this.". 50
 Warning coding RequireThis Reference to instance variable 'instance' needs "this.". 52
 Warning coding RequireThis Reference to instance variable 'file' needs "this.". 52
 Warning coding RequireThis Reference to instance variable 'instance' needs "this.". 54
 Warning coding RequireThis Reference to instance variable 'file' needs "this.". 54
 Warning coding RequireThis Reference to instance variable 'instance' needs "this.". 57
 Warning coding RequireThis Reference to instance variable 'tmpDir' needs "this.". 57

emissary/util/io/LoggingInputStream.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'inputStream' needs "this.". 50
 Warning coding RequireThis Reference to instance variable 'prefix' needs "this.". 52
 Warning coding RequireThis Reference to instance variable 'inputStream' needs "this.". 59
 Warning coding RequireThis Reference to instance variable 'prefix' needs "this.". 61
 Warning coding RequireThis Reference to instance variable 'inputStream' needs "this.". 68
 Warning coding RequireThis Reference to instance variable 'prefix' needs "this.". 70
 Warning coding RequireThis Reference to instance variable 'inputStream' needs "this.". 77
 Warning coding RequireThis Reference to instance variable 'prefix' needs "this.". 79
 Warning coding RequireThis Reference to instance variable 'inputStream' needs "this.". 86
 Warning coding RequireThis Reference to instance variable 'prefix' needs "this.". 88
 Warning coding RequireThis Reference to instance variable 'prefix' needs "this.". 95
 Warning coding RequireThis Reference to instance variable 'inputStream' needs "this.". 97
 Warning coding RequireThis Reference to instance variable 'prefix' needs "this.". 102
 Warning coding RequireThis Reference to instance variable 'inputStream' needs "this.". 104
 Warning coding RequireThis Reference to instance variable 'prefix' needs "this.". 109
 Warning coding RequireThis Reference to instance variable 'inputStream' needs "this.". 111
 Warning coding RequireThis Reference to instance variable 'inputStream' needs "this.". 116
 Warning coding RequireThis Reference to instance variable 'prefix' needs "this.". 118
 Warning coding RequireThis Reference to instance variable 'logStackTrace' needs "this.". 124
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 130
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 132

emissary/util/io/LoggingPrintStream.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 't' should be declared final. 100
 Warning coding RequireThis Reference to instance variable 'linesToSkip' needs "this.". 118
 Warning coding FinalLocalVariable Variable 'unused' should be declared final. 121
 Warning coding RequireThis Reference to instance variable 'executorService' needs "this.". 121
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 121
 Warning coding RequireThis Reference to instance variable 'level' needs "this.". 121
 Warning coding RequireThis Reference to instance variable 'streamName' needs "this.". 121
 Warning coding RequireThis Reference to instance variable 'linesToSkip' needs "this.". 147
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 150
 Warning coding FinalLocalVariable Variable 'unused' should be declared final. 155
 Warning coding RequireThis Reference to instance variable 'executorService' needs "this.". 155
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 155
 Warning coding RequireThis Reference to instance variable 'level' needs "this.". 155
 Warning coding RequireThis Reference to instance variable 'streamName' needs "this.". 155
 Warning coding RequireThis Reference to instance variable 'linesToSkip' needs "this.". 160
 Warning coding RequireThis Reference to instance variable 'linesToSkip' needs "this.". 161
 Warning coding RequireThis Reference to instance variable 'executorService' needs "this.". 173
 Warning coding RequireThis Reference to instance variable 'executorService' needs "this.". 174
 Warning coding RequireThis Reference to instance variable 'executorService' needs "this.". 175
 Warning coding RequireThis Reference to instance variable 'closeWaitTime' needs "this.". 175
 Warning coding RequireThis Reference to instance variable 'closeWaitTimeUnit' needs "this.". 175
 Warning coding MissingSwitchDefault switch without "default" clause. 200

emissary/util/io/LoggingPrintStreamTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'loggingPrintStream' should be declared final. 64
 Warning coding FinalLocalVariable Variable 'logbackTester' should be declared final. 75
 Warning coding FinalLocalVariable Variable 'loggingPrintStreamDebug' should be declared final. 76
 Warning coding FinalLocalVariable Variable 'loggingPrintStreamError' should be declared final. 79
 Warning coding FinalLocalVariable Variable 'loggingPrintStreamInfo' should be declared final. 82
 Warning coding FinalLocalVariable Variable 'loggingPrintStreamTrace' should be declared final. 85
 Warning coding FinalLocalVariable Variable 'loggingPrintStreamWarn' should be declared final. 88
 Warning indentation Indentation 'array initialization lcurly' has incorrect indentation level 20, expected level should be one of the following: 12, 14. 111
 Warning indentation Indentation 'array initialization lcurly' has incorrect indentation level 20, expected level should be one of the following: 12, 14. 113
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 28, expected level should be one of the following: 14, 21, 22. 114
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 28, expected level should be one of the following: 14, 21, 22. 115
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 28, expected level should be one of the following: 14, 21, 22. 116
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 28, expected level should be one of the following: 14, 21, 22. 117
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 28, expected level should be one of the following: 14, 21, 22. 118
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 28, expected level should be one of the following: 14, 21, 22. 119
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 28, expected level should be one of the following: 14, 21, 22. 120
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 28, expected level should be one of the following: 14, 21, 22. 121
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 28, expected level should be one of the following: 14, 21, 22. 122
 Warning coding FinalLocalVariable Variable 'baos' should be declared final. 134
 Warning coding FinalLocalVariable Variable 'loggingPrintStream' should be declared final. 135
 Warning coding FinalLocalVariable Variable 'logbackTester' should be declared final. 173
 Warning coding FinalLocalVariable Variable 'baos' should be declared final. 174
 Warning coding FinalLocalVariable Variable 'loggingPrintStream' should be declared final. 175
 Warning coding FinalLocalVariable Variable 'logbackTester' should be declared final. 193
 Warning coding FinalLocalVariable Variable 'baos' should be declared final. 194
 Warning coding FinalLocalVariable Variable 'loggingPrintStream' should be declared final. 195
 Warning coding FinalLocalVariable Variable 'stringWriter' should be declared final. 197
 Warning coding FinalLocalVariable Variable 'printWriter' should be declared final. 198
 Warning coding FinalLocalVariable Variable 'logbackTester' should be declared final. 216
 Warning coding FinalLocalVariable Variable 'byteArrayOutputStream' should be declared final. 217
 Warning coding FinalLocalVariable Variable 'printStream' should be declared final. 218
 Warning coding FinalLocalVariable Variable 'loggingPrintStream' should be declared final. 219
 Warning indentation Indentation 'array initialization lcurly' has incorrect indentation level 20, expected level should be one of the following: 12, 14. 231
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 28, expected level should be one of the following: 14, 21, 22. 232
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 28, expected level should be one of the following: 14, 21, 22. 233
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 28, expected level should be one of the following: 14, 21, 22. 234
 Warning indentation Indentation 'array initialization' child has incorrect indentation level 28, expected level should be one of the following: 14, 21, 22. 235
 Warning coding FinalLocalVariable Variable 'logbackTester' should be declared final. 246
 Warning coding FinalLocalVariable Variable 'byteArrayOutputStream' should be declared final. 247
 Warning coding FinalLocalVariable Variable 'printStream' should be declared final. 248
 Warning coding FinalLocalVariable Variable 'loggingPrintStream' should be declared final. 249
 Warning coding FinalLocalVariable Variable 'unused' should be declared final. 260
 Warning design VisibilityModifier Variable 'name' must be private and have accessor methods. 280
 Warning design VisibilityModifier Variable 'logger' must be private and have accessor methods. 281
 Warning design VisibilityModifier Variable 'appender' must be private and have accessor methods. 282
 Warning modifier RedundantModifier Redundant 'public' modifier. 284
 Warning coding RequireThis Reference to instance variable 'name' needs "this.". 287
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 288
 Warning coding RequireThis Reference to instance variable 'name' needs "this.". 288
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 289
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 291
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 291
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 292
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 293
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 293
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 294
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 304
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 306
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 307
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 317

emissary/util/io/ReadOutput.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'finished' must be private and have accessor methods. 22
 Warning misc FinalParameters Parameter is should be final. 24
 Warning misc FinalParameters Parameter str should be final. 24
 Warning coding RequireThis Reference to instance variable 'br' needs "this.". 25
 Warning coding RequireThis Reference to instance variable 'tag' needs "this.". 26
 Warning misc FinalParameters Parameter is should be final. 29
 Warning misc FinalParameters Parameter str should be final. 29
 Warning misc FinalParameters Parameter outp should be final. 29
 Warning coding RequireThis Reference to instance variable 'br' needs "this.". 30
 Warning coding RequireThis Reference to instance variable 'tag' needs "this.". 31
 Warning coding RequireThis Reference to instance variable 'ps' needs "this.". 32
 Warning coding RequireThis Reference to instance variable 'finished' needs "this.". 38
 Warning coding RequireThis Reference to instance variable 'br' needs "this.". 40
 Warning coding RequireThis Reference to instance variable 'finished' needs "this.". 40
 Warning coding RequireThis Reference to instance variable 'ps' needs "this.". 41
 Warning coding RequireThis Reference to instance variable 'ps' needs "this.". 42
 Warning coding RequireThis Reference to instance variable 'tag' needs "this.". 42
 Warning coding RequireThis Reference to instance variable 'br' needs "this.". 45
 Warning coding RequireThis Reference to instance variable 'finished' needs "this.". 53

emissary/util/io/ResourceReader.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 30 should be alone on a line. 37
 Warning misc FinalParameters Parameter o should be final. 44
 Warning misc FinalParameters Parameter c should be final. 53
 Warning coding FinalLocalVariable Variable 'name' should be declared final. 54
 Warning misc FinalParameters Parameter c should be final. 61
 Warning misc FinalParameters Parameter o should be final. 70
 Warning misc FinalParameters Parameter c should be final. 79
 Warning coding FinalLocalVariable Variable 'name' should be declared final. 80
 Warning misc FinalParameters Parameter c should be final. 87
 Warning misc FinalParameters Parameter pkg should be final. 94
 Warning misc FinalParameters Parameter name should be final. 94
 Warning misc FinalParameters Parameter c should be final. 101
 Warning misc FinalParameters Parameter pkg should be final. 108
 Warning misc FinalParameters Parameter name should be final. 108
 Warning misc FinalParameters Parameter name should be final. 118
 Warning coding ParameterAssignment Assignment of parameter 'name' is not allowed. 120
 Warning misc FinalParameters Parameter name should be final. 131
 Warning coding ParameterAssignment Assignment of parameter 'name' is not allowed. 133
 Warning misc FinalParameters Parameter c should be final. 145
 Warning coding FinalLocalVariable Variable 'cx' should be declared final. 149
 Warning coding FinalLocalVariable Variable 'loader' should be declared final. 150
 Warning misc FinalParameters Parameter c should be final. 163
 Warning misc FinalParameters Parameter c should be final. 173
 Warning misc FinalParameters Parameter c should be final. 183
 Warning misc FinalParameters Parameter c should be final. 193
 Warning misc FinalParameters Parameter c should be final. 204
 Warning misc FinalParameters Parameter suffix should be final. 204
 Warning coding FinalLocalVariable Variable 'results' should be declared final. 205
 Warning coding FinalLocalVariable Variable 'url' should be declared final. 206
 Warning misc FinalParameters Parameter c should be final. 231
 Warning misc FinalParameters Parameter url should be final. 231
 Warning misc FinalParameters Parameter suffix should be final. 231
 Warning coding FinalLocalVariable Variable 'results' should be declared final. 232
 Warning coding FinalLocalVariable Variable 'jc' should be declared final. 234
 Warning coding FinalLocalVariable Variable 'jf' should be declared final. 235
 Warning coding FinalLocalVariable Variable 'cmatch' should be declared final. 236
 Warning coding FinalLocalVariable Variable 'entry' should be declared final. 238
 Warning coding FinalLocalVariable Variable 'name' should be declared final. 239
 Warning misc FinalParameters Parameter c should be final. 262
 Warning misc FinalParameters Parameter url should be final. 262
 Warning misc FinalParameters Parameter suffix should be final. 262
 Warning coding FinalLocalVariable Variable 'results' should be declared final. 263
 Warning coding FinalLocalVariable Variable 'cmatch' should be declared final. 264
 Warning coding FinalLocalVariable Variable 'base' should be declared final. 277
 Warning coding FinalLocalVariable Variable 'pkgNamePart' should be declared final. 278
 Warning coding FinalLocalVariable Variable 'classNamePart' should be declared final. 279
 Warning coding FinalLocalVariable Variable 'list' should be declared final. 281
 Warning coding FinalLocalVariable Variable 'dir' should be declared final. 290
 Warning coding FinalLocalVariable Variable 'list' should be declared final. 292

emissary/util/io/ResourceReaderTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'resources' should be declared final. 26
 Warning coding FinalLocalVariable Variable 'rr' should be declared final. 33
 Warning coding FinalLocalVariable Variable 'is' should be declared final. 41
 Warning blocks EmptyCatchBlock Empty catch block. 45
 Warning coding FinalLocalVariable Variable 'rr' should be declared final. 69

emissary/util/io/SocketUtils.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter str should be final. 11
 Warning misc FinalParameters Parameter os should be final. 11
 Warning misc FinalParameters Parameter is should be final. 16
 Warning coding FinalLocalVariable Variable 'contentSize' should be declared final. 17
 Warning coding FinalLocalVariable Variable 'theContent' should be declared final. 18
 Warning misc FinalParameters Parameter bb should be final. 23
 Warning misc FinalParameters Parameter os should be final. 23
 Warning misc FinalParameters Parameter theStream should be final. 28
 Warning coding FinalLocalVariable Variable 'contentSize' should be declared final. 29
 Warning coding FinalLocalVariable Variable 'theContent' should be declared final. 30
 Warning blocks RightCurly '}' at column 28 should be alone on a line. 36

emissary/util/io/UnitTestFileUtils.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter path should be final. 17
 Warning misc FinalParameters Parameter file should be final. 20
 Warning misc FinalParameters Parameter attrs should be final. 20
 Warning misc FinalParameters Parameter dir should be final. 26
 Warning misc FinalParameters Parameter exc should be final. 26
 Warning misc FinalParameters Parameter path should be final. 33
 Warning misc FinalParameters Parameter regex should be final. 33
 Warning coding FinalLocalVariable Variable 'paths' should be declared final. 34
 Warning misc FinalParameters Parameter dir should be final. 44
 Warning misc FinalParameters Parameter ext should be final. 44
 Warning misc FinalParameters Parameter dir should be final. 49
 Warning misc FinalParameters Parameter ext should be final. 49
 Warning misc FinalParameters Parameter depth should be final. 49
 Warning blocks RightCurly '}' at column 34 should be alone on a line. 56

emissary/util/magic/ByteArrayPrecisionException.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter msg should be final. 10

emissary/util/magic/MagicMath.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'literals' must be private and have accessor methods. 19
 Warning whitespace SeparatorWrap ',' should be on the previous line. 20
 Warning whitespace SeparatorWrap ',' should be on the previous line. 21
 Warning whitespace SeparatorWrap ',' should be on the previous line. 22
 Warning whitespace SeparatorWrap ',' should be on the previous line. 23
 Warning whitespace SeparatorWrap ',' should be on the previous line. 24
 Warning whitespace SeparatorWrap ',' should be on the previous line. 25
 Warning whitespace SeparatorWrap ',' should be on the previous line. 26
 Warning whitespace SeparatorWrap ',' should be on the previous line. 27
 Warning whitespace SeparatorWrap ',' should be on the previous line. 28
 Warning whitespace SeparatorWrap ',' should be on the previous line. 29
 Warning whitespace SeparatorWrap ',' should be on the previous line. 30
 Warning whitespace SeparatorWrap ',' should be on the previous line. 31
 Warning whitespace SeparatorWrap ',' should be on the previous line. 32
 Warning whitespace SeparatorWrap ',' should be on the previous line. 33
 Warning whitespace SeparatorWrap ',' should be on the previous line. 34
 Warning whitespace SeparatorWrap ',' should be on the previous line. 35
 Warning whitespace SeparatorWrap ',' should be on the previous line. 36
 Warning whitespace SeparatorWrap ',' should be on the previous line. 37
 Warning whitespace SeparatorWrap ',' should be on the previous line. 38
 Warning whitespace SeparatorWrap ',' should be on the previous line. 39
 Warning whitespace SeparatorWrap ',' should be on the previous line. 40
 Warning whitespace SeparatorWrap ',' should be on the previous line. 41
 Warning whitespace SeparatorWrap ',' should be on the previous line. 42
 Warning whitespace SeparatorWrap ',' should be on the previous line. 43
 Warning whitespace SeparatorWrap ',' should be on the previous line. 44
 Warning misc FinalParameters Parameter b should be final. 47
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 48
 Warning misc FinalParameters Parameter s should be final. 58
 Warning coding FinalLocalVariable Variable 'array' should be declared final. 59
 Warning coding FinalLocalVariable Variable 'chars' should be declared final. 60
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 65
 Warning coding FinalLocalVariable Variable 'bytes' should be declared final. 97
 Warning coding FinalLocalVariable Variable 'iter' should be declared final. 98
 Warning coding FinalLocalVariable Variable 'num' should be declared final. 100
 Warning misc FinalParameters Parameter s should be final. 106
 Warning misc FinalParameters Parameter arraySize should be final. 117
 Warning misc FinalParameters Parameter stringValue should be final. 117
 Warning misc FinalParameters Parameter s should be final. 128
 Warning coding FinalLocalVariable Variable 'sub' should be declared final. 129
 Warning coding FinalLocalVariable Variable 'integer' should be declared final. 130
 Warning misc FinalParameters Parameter data should be final. 137
 Warning misc FinalParameters Parameter length should be final. 137
 Warning coding FinalLocalVariable Variable 'newValues' should be declared final. 157
 Warning misc FinalParameters Parameter data should be final. 169
 Warning misc FinalParameters Parameter maskValues should be final. 169
 Warning coding FinalLocalVariable Variable 'target' should be declared final. 170
 Warning misc FinalParameters Parameter s should be final. 177
 Warning coding FinalLocalVariable Variable 'array' should be declared final. 185
 Warning coding FinalLocalVariable Variable 'b' should be declared final. 187
 Warning misc FinalParameters Parameter s should be final. 193
 Warning misc FinalParameters Parameter s should be final. 197
 Warning coding EqualsAvoidNull String literal expressions should be on the left side of an equals comparison. 200
 Warning misc FinalParameters Parameter arraySize should be final. 208
 Warning misc FinalParameters Parameter integerValue should be final. 208
 Warning coding FinalLocalVariable Variable 'valueBytes' should be declared final. 209
 Warning misc FinalParameters Parameter stringValue should be final. 216
 Warning misc FinalParameters Parameter bytes should be final. 227
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 228
 Warning misc FinalParameters Parameter data should be final. 238
 Warning misc FinalParameters Parameter radix should be final. 238
 Warning coding FinalLocalVariable Variable 'adjustedData' should be declared final. 250
 Warning coding FinalLocalVariable Variable 'value' should be declared final. 251
 Warning misc FinalParameters Parameter data should be final. 256
 Warning coding FinalLocalVariable Variable 'adjustedData' should be declared final. 265
 Warning coding FinalLocalVariable Variable 'value' should be declared final. 266
 Warning misc FinalParameters Parameter array should be final. 270
 Warning misc FinalParameters Parameter offset should be final. 270
 Warning misc FinalParameters Parameter array should be final. 284
 Warning misc FinalParameters Parameter offset should be final. 284
 Warning coding FinalLocalVariable Variable 't' should be declared final. 289
 Warning blocks RightCurly '}' at column 26 should be alone on a line. 295

emissary/util/magic/MagicMathTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'x' should be declared final. 12
 Warning coding FinalLocalVariable Variable 'entry' should be declared final. 18
 Warning coding FinalLocalVariable Variable 'exception' should be declared final. 19

emissary/util/magic/MagicNumber.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'depth' must be private and have accessor methods. 94
 Warning design VisibilityModifier Variable 'offset' must be private and have accessor methods. 95
 Warning design VisibilityModifier Variable 'offsetUnary' must be private and have accessor methods. 96
 Warning design VisibilityModifier Variable 'dataType' must be private and have accessor methods. 99
 Warning design VisibilityModifier Variable 'dataTypeLength' must be private and have accessor methods. 100
 Warning design VisibilityModifier Variable 'mask' must be private and have accessor methods. 101
 Warning design VisibilityModifier Variable 'signedValue' must be private and have accessor methods. 102
 Warning design VisibilityModifier Variable 'unaryOperator' must be private and have accessor methods. 105
 Warning design VisibilityModifier Variable 'value' must be private and have accessor methods. 107
 Warning design VisibilityModifier Variable 'substitute' must be private and have accessor methods. 108
 Warning design VisibilityModifier Variable 'description' must be private and have accessor methods. 112
 Warning design VisibilityModifier Variable 'dependencies' must be private and have accessor methods. 115
 Warning misc FinalParameters Parameter data should be final. 131
 Warning coding FinalLocalVariable Variable 'desc' should be declared final. 132
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 136
 Warning misc FinalParameters Parameter desc should be final. 143
 Warning coding ModifiedControlVariable Control variable 'i' is modified. 148
 Warning misc FinalParameters Parameter data should be final. 160
 Warning coding RequireThis Reference to instance variable 'description' needs "this.". 164
 Warning misc FinalParameters Parameter desc should be final. 170
 Warning misc FinalParameters Parameter data should be final. 170
 Warning coding RequireThis Reference to instance variable 'substitute' needs "this.". 172
 Warning coding FinalLocalVariable Variable 'chars' should be declared final. 175
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 179
 Warning coding FinalLocalVariable Variable 'next' should be declared final. 182
 Warning coding FinalLocalVariable Variable 'subType' should be declared final. 184
 Warning coding RequireThis Reference to instance variable 'dataType' needs "this.". 185
 Warning coding RequireThis Reference to instance variable 'offset' needs "this.". 186
 Warning coding FinalLocalVariable Variable 'sub' should be declared final. 187
 Warning coding RequireThis Reference to instance variable 'offset' needs "this.". 187
 Warning coding FinalLocalVariable Variable 'subData' should be declared final. 192
 Warning coding RequireThis Reference to instance variable 'offset' needs "this.". 192
 Warning coding RequireThis Reference to instance variable 'dataTypeLength' needs "this.". 192
 Warning coding FinalLocalVariable Variable 'sub' should be declared final. 194
 Warning coding FinalLocalVariable Variable 'subData' should be declared final. 200
 Warning coding RequireThis Reference to instance variable 'offset' needs "this.". 200
 Warning coding RequireThis Reference to instance variable 'dataTypeLength' needs "this.". 200
 Warning coding FinalLocalVariable Variable 'sub' should be declared final. 202
 Warning misc FinalParameters Parameter data should be final. 220
 Warning misc FinalParameters Parameter sb should be final. 220
 Warning misc FinalParameters Parameter layer should be final. 220
 Warning coding RequireThis Reference to instance variable 'dependencies' needs "this.". 222
 Warning coding RequireThis Reference to instance variable 'dependencies' needs "this.". 222
 Warning coding FinalLocalVariable Variable 'dependentItems' should be declared final. 228
 Warning coding RequireThis Reference to instance variable 'dependencies' needs "this.". 228
 Warning coding FinalLocalVariable Variable 's' should be declared final. 231
 Warning misc FinalParameters Parameter data should be final. 251
 Warning coding FinalLocalVariable Variable 'subject' should be declared final. 252
 Warning coding RequireThis Reference to instance variable 'offset' needs "this.". 252
 Warning coding RequireThis Reference to instance variable 'dataTypeLength' needs "this.". 252
 Warning misc FinalParameters Parameter data should be final. 262
 Warning coding RequireThis Reference to instance variable 'substitute' needs "this.". 263
 Warning coding FinalLocalVariable Variable 'mValues' should be declared final. 266
 Warning coding RequireThis Reference to instance variable 'value' needs "this.". 266
 Warning coding RequireThis Reference to instance variable 'unaryOperator' needs "this.". 268
 Warning coding FinalLocalVariable Variable 'end' should be declared final. 270
 Warning coding RequireThis Reference to instance variable 'unaryOperator' needs "this.". 271
 Warning misc FinalParameters Parameter data should be final. 340
 Warning misc FinalParameters Parameter offset should be final. 340
 Warning misc FinalParameters Parameter length should be final. 340
 Warning coding FinalLocalVariable Variable 'subject' should be declared final. 347
 Warning misc FinalParameters Parameter dependencyLayer should be final. 356
 Warning coding RequireThis Reference to instance variable 'dependencies' needs "this.". 357
 Warning coding RequireThis Reference to instance variable 'dependencies' needs "this.". 358
 Warning coding RequireThis Reference to instance variable 'dependencies' needs "this.". 360
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 371
 Warning coding RequireThis Reference to instance variable 'depth' needs "this.". 372
 Warning coding RequireThis Reference to instance variable 'offsetUnary' needs "this.". 373
 Warning coding RequireThis Reference to instance variable 'offsetUnary' needs "this.". 374
 Warning coding RequireThis Reference to instance variable 'offset' needs "this.". 377
 Warning coding RequireThis Reference to instance variable 'offset' needs "this.". 381
 Warning coding RequireThis Reference to instance variable 'dataType' needs "this.". 385
 Warning coding RequireThis Reference to instance variable 'mask' needs "this.". 386
 Warning coding RequireThis Reference to instance variable 'mask' needs "this.". 386
 Warning coding RequireThis Reference to instance variable 'mask' needs "this.". 388
 Warning coding RequireThis Reference to instance variable 'unaryOperator' needs "this.". 392
 Warning coding RequireThis Reference to instance variable 'unaryOperator' needs "this.". 394
 Warning coding RequireThis Reference to instance variable 'unaryOperator' needs "this.". 397
 Warning coding RequireThis Reference to instance variable 'value' needs "this.". 399
 Warning coding RequireThis Reference to instance variable 'description' needs "this.". 402
 Warning misc FinalParameters Parameter sbuf should be final. 409
 Warning misc FinalParameters Parameter depth should be final. 409
 Warning coding HiddenField 'depth' hides a field. 409
 Warning coding FinalLocalVariable Variable 'd' should be declared final. 411
 Warning coding RequireThis Reference to instance variable 'description' needs "this.". 413
 Warning coding RequireThis Reference to instance variable 'dependencies' needs "this.". 415
 Warning coding RequireThis Reference to instance variable 'dependencies' needs "this.". 415
 Warning coding FinalLocalVariable Variable 'dependentItems' should be declared final. 418
 Warning coding RequireThis Reference to instance variable 'dependencies' needs "this.". 418

emissary/util/magic/MagicNumberFactory.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 35 should be alone on a line. 37
 Warning misc FinalParameters Parameter configData should be final. 49
 Warning misc FinalParameters Parameter zeroDepthErrorList should be final. 49
 Warning misc FinalParameters Parameter continuationErrorMap should be final. 50
 Warning misc FinalParameters Parameter configData should be final. 65
 Warning misc FinalParameters Parameter zeroDepthErrorList should be final. 65
 Warning misc FinalParameters Parameter continuationErrorMap should be final. 66
 Warning misc FinalParameters Parameter swallowParseException should be final. 66
 Warning coding FinalLocalVariable Variable 'magicNumberList' should be declared final. 68
 Warning coding FinalLocalVariable Variable 'depth' should be declared final. 80
 Warning coding FinalLocalVariable Variable 'item' should be declared final. 97
 Warning whitespace OperatorWrap '&&' should be on a new line. 132
 Warning whitespace OperatorWrap '&&' should be on a new line. 133
 Warning coding FinalLocalVariable Variable 'mItem' should be declared final. 141
 Warning coding FinalLocalVariable Variable 'signature' should be declared final. 142
 Warning misc FinalParameters Parameter storage should be final. 176
 Warning misc FinalParameters Parameter entry should be final. 176
 Warning misc FinalParameters Parameter swallowParseException should be final. 176
 Warning coding FinalLocalVariable Variable 'item' should be declared final. 177
 Warning misc FinalParameters Parameter extensions should be final. 191
 Warning misc FinalParameters Parameter target should be final. 191
 Warning coding FinalLocalVariable Variable 'extensionArray' should be declared final. 192
 Warning misc FinalParameters Parameter entry should be final. 205
 Warning misc FinalParameters Parameter entry should be final. 215
 Warning misc FinalParameters Parameter swallowParseException should be final. 215
 Warning coding FinalLocalVariable Variable 'columns' should be declared final. 217
 Warning coding FinalLocalVariable Variable 'item' should be declared final. 218
 Warning misc FinalParameters Parameter entry should be final. 260
 Warning coding FinalLocalVariable Variable 'columns' should be declared final. 262
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 268
 Warning coding ModifiedControlVariable Control variable 'i' is modified. 271
 Warning coding ModifiedControlVariable Control variable 'i' is modified. 275
 Warning misc FinalParameters Parameter entry should be final. 297
 Warning coding FinalLocalVariable Variable 'invalidOperatorIndex' should be declared final. 302
 Warning coding FinalLocalVariable Variable 'tail' should be declared final. 304
 Warning coding FinalLocalVariable Variable 'columns' should be declared final. 308
 Warning misc FinalParameters Parameter columns should be final. 323
 Warning misc FinalParameters Parameter item should be final. 323
 Warning misc FinalParameters Parameter columns should be final. 340
 Warning misc FinalParameters Parameter entry should be final. 347
 Warning misc FinalParameters Parameter columns should be final. 363
 Warning coding EqualsAvoidNull String literal expressions should be on the left side of an equals comparison. 370
 Warning coding FinalLocalVariable Variable 'ix' should be declared final. 378
 Warning coding FinalLocalVariable Variable 'dataTypeId' should be declared final. 382
 Warning misc FinalParameters Parameter arg should be final. 389
 Warning coding FinalLocalVariable Variable 'dataTypeIdInt' should be declared final. 390
 Warning misc FinalParameters Parameter columns should be final. 404
 Warning misc FinalParameters Parameter item should be final. 404
 Warning coding FinalLocalVariable Variable 'ix' should be declared final. 405
 Warning coding FinalLocalVariable Variable 'maskValues' should be declared final. 407
 Warning misc FinalParameters Parameter columns should be final. 416
 Warning misc FinalParameters Parameter item should be final. 416
 Warning coding FinalLocalVariable Variable 'strVal' should be declared final. 420
 Warning coding FinalLocalVariable Variable 'unaryLen' should be declared final. 428
 Warning misc FinalParameters Parameter s should be final. 449
 Warning coding FinalLocalVariable Variable 'op' should be declared final. 455
 Warning coding FinalLocalVariable Variable 'len' should be declared final. 456
 Warning misc FinalParameters Parameter item should be final. 480
 Warning coding FinalLocalVariable Variable 'dataTypeId' should be declared final. 481
 Warning misc FinalParameters Parameter columns should be final. 512
 Warning misc FinalParameters Parameter item should be final. 512
 Warning coding FinalLocalVariable Variable 'unaryLen' should be declared final. 513
 Warning misc FinalParameters Parameter dataTypeId should be final. 528

emissary/util/magic/MagicNumberTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 15
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 22
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 30
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 38
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 46
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 54
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 62
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 71
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 80
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 89
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 98
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 106
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 115
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 124
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 133
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 142
 Warning coding FinalLocalVariable Variable 'm' should be declared final. 164

emissary/util/magic/ParseException.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter message should be final. 10

emissary/util/os/OSReleaseUtil.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 30 should be alone on a line. 15
 Warning misc FinalParameters Parameter osReleasePath should be final. 26
 Warning coding FinalLocalVariable Variable 'versionIdOptional' should be declared final. 31
 Warning coding FinalLocalVariable Variable 'versionIdLine' should be declared final. 33
 Warning misc FinalParameters Parameter osReleasePath should be final. 52
 Warning misc FinalParameters Parameter osReleasePath should be final. 65
 Warning misc FinalParameters Parameter osReleasePath should be final. 78
 Warning misc FinalParameters Parameter osReleasePath should be final. 91
 Warning misc FinalParameters Parameter osReleasePath should be final. 95
 Warning misc FinalParameters Parameter osName should be final. 95

emissary/util/os/OSReleaseUtilTest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'centos7Path' must be private and have accessor methods. 17
 Warning design VisibilityModifier Variable 'rhel8Path' must be private and have accessor methods. 19
 Warning design VisibilityModifier Variable 'ubuntu20Path' must be private and have accessor methods. 21
 Warning coding FinalLocalVariable Variable 'rr' should be declared final. 25

emissary/util/roll/RollableFileOutputStream.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'lock' must be private and have accessor methods. 27
 Warning design VisibilityModifier Variable 'rolling' must be private and have accessor methods. 29
 Warning design VisibilityModifier Variable 'fileOutputStream' must be private and have accessor methods. 32
 Warning design VisibilityModifier Variable 'currentFile' must be private and have accessor methods. 35
 Warning design VisibilityModifier Variable 'namegen' must be private and have accessor methods. 37
 Warning design VisibilityModifier Variable 'bytesWritten' must be private and have accessor methods. 41
 Warning design VisibilityModifier Variable 'deleteZeroByteFiles' must be private and have accessor methods. 43
 Warning misc FinalParameters Parameter namegen should be final. 49
 Warning misc FinalParameters Parameter dir should be final. 49
 Warning misc FinalParameters Parameter namegen should be final. 59
 Warning coding FinalLocalVariable Variable 'filter' should be declared final. 65
 Warning coding FinalLocalVariable Variable 'newFile' should be declared final. 77
 Warning coding RequireThis Reference to instance variable 'currentFile' needs "this.". 78
 Warning coding RequireThis Reference to instance variable 'fileOutputStream' needs "this.". 79
 Warning coding FinalLocalVariable Variable 'newName' should be declared final. 83
 Warning coding RequireThis Reference to instance variable 'namegen' needs "this.". 83
 Warning coding FinalLocalVariable Variable 'seqFname' should be declared final. 85
 Warning coding RequireThis Reference to instance variable 'seq' needs "this.". 85
 Warning coding RequireThis Reference to instance variable 'currentFile' needs "this.". 86
 Warning coding RequireThis Reference to instance variable 'currentFile' needs "this.". 86
 Warning coding RequireThis Reference to instance variable 'currentFile' needs "this.". 86
 Warning coding RequireThis Reference to instance variable 'namegen' needs "this.". 87
 Warning coding RequireThis Reference to instance variable 'seq' needs "this.". 88
 Warning coding RequireThis Reference to instance variable 'dir' needs "this.". 90
 Warning coding RequireThis Reference to instance variable 'fileOutputStream' needs "this.". 94
 Warning coding RequireThis Reference to instance variable 'fileOutputStream' needs "this.". 95
 Warning coding RequireThis Reference to instance variable 'currentFile' needs "this.". 96
 Warning coding RequireThis Reference to instance variable 'currentFile' needs "this.". 98
 Warning coding RequireThis Reference to instance variable 'bytesWritten' needs "this.". 99
 Warning misc FinalParameters Parameter f should be final. 102
 Warning coding RequireThis Reference to instance variable 'deleteZeroByteFiles' needs "this.". 103
 Warning coding FinalLocalVariable Variable 'nonDot' should be declared final. 113
 Warning coding RequireThis Reference to instance variable 'dir' needs "this.". 114
 Warning coding RequireThis Reference to instance variable 'dir' needs "this.". 118
 Warning coding RequireThis Reference to instance variable 'lock' needs "this.". 131
 Warning coding RequireThis Reference to instance variable 'rolling' needs "this.". 133
 Warning coding RequireThis Reference to instance variable 'currentFile' needs "this.". 138
 Warning coding RequireThis Reference to instance variable 'rolling' needs "this.". 140
 Warning coding RequireThis Reference to instance variable 'lock' needs "this.". 141
 Warning coding RequireThis Reference to instance variable 'rolling' needs "this.". 152
 Warning misc FinalParameters Parameter c should be final. 155
 Warning coding RequireThis Reference to instance variable 'lock' needs "this.". 173
 Warning coding RequireThis Reference to instance variable 'fileOutputStream' needs "this.". 176
 Warning coding RequireThis Reference to instance variable 'currentFile' needs "this.". 177
 Warning coding RequireThis Reference to instance variable 'lock' needs "this.". 179
 Warning misc FinalParameters Parameter b should be final. 189
 Warning coding RequireThis Reference to instance variable 'lock' needs "this.". 190
 Warning coding RequireThis Reference to instance variable 'fileOutputStream' needs "this.". 192
 Warning coding RequireThis Reference to instance variable 'bytesWritten' needs "this.". 193
 Warning coding RequireThis Reference to instance variable 'lock' needs "this.". 195
 Warning misc FinalParameters Parameter b should be final. 208
 Warning misc FinalParameters Parameter off should be final. 208
 Warning misc FinalParameters Parameter len should be final. 208
 Warning coding RequireThis Reference to instance variable 'lock' needs "this.". 209
 Warning coding RequireThis Reference to instance variable 'fileOutputStream' needs "this.". 211
 Warning coding RequireThis Reference to instance variable 'bytesWritten' needs "this.". 212
 Warning coding RequireThis Reference to instance variable 'lock' needs "this.". 214
 Warning coding RequireThis Reference to instance variable 'bytesWritten' needs "this.". 224
 Warning coding RequireThis Reference to instance variable 'deleteZeroByteFiles' needs "this.". 233
 Warning misc FinalParameters Parameter deleteZeroByteFiles should be final. 240
 Warning coding HiddenField 'deleteZeroByteFiles' hides a field. 240

emissary/util/roll/RollableFileOutputStreamTest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'tmpDir' must be private and have accessor methods. 27
 Warning design VisibilityModifier Variable 'currentFile' must be private and have accessor methods. 28
 Warning design VisibilityModifier Variable 'lastFile' must be private and have accessor methods. 29
 Warning coding HiddenField 'tmpDir' hides a field. 32
 Warning coding FinalLocalVariable Variable 'file1name' should be declared final. 43
 Warning coding FinalLocalVariable Variable 'file2name' should be declared final. 44
 Warning coding FinalLocalVariable Variable 'file1' should be declared final. 45
 Warning coding RequireThis Reference to instance variable 'tmpDir' needs "this.". 45
 Warning coding FinalLocalVariable Variable 'file2' should be declared final. 48
 Warning coding RequireThis Reference to instance variable 'tmpDir' needs "this.". 48
 Warning coding RequireThis Reference to instance variable 'tmpDir' needs "this.". 51
 Warning coding RequireThis Reference to instance variable 'tmpDir' needs "this.". 57
 Warning coding RequireThis Reference to instance variable 'tmpDir' needs "this.". 60
 Warning coding RequireThis Reference to instance variable 'tmpDir' needs "this.". 69
 Warning coding RequireThis Reference to instance variable 'tmpDir' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'lastFile' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'tmpDir' needs "this.". 74
 Warning coding RequireThis Reference to instance variable 'currentFile' needs "this.". 74
 Warning coding FinalLocalVariable Variable 'instance' should be declared final. 84
 Warning coding RequireThis Reference to instance variable 'tmpDir' needs "this.". 84
 Warning coding RequireThis Reference to instance variable 'tmpDir' needs "this.". 94
 Warning coding FinalLocalVariable Variable 'f' should be declared final. 97
 Warning coding RequireThis Reference to instance variable 'tmpDir' needs "this.". 97
 Warning coding RequireThis Reference to instance variable 'currentFile' needs "this.". 97
 Warning coding RequireThis Reference to instance variable 'tmpDir' needs "this.". 109
 Warning coding FinalLocalVariable Variable 'f' should be declared final. 112
 Warning coding RequireThis Reference to instance variable 'tmpDir' needs "this.". 112
 Warning coding RequireThis Reference to instance variable 'currentFile' needs "this.". 112
 Warning coding RequireThis Reference to instance variable 'tmpDir' needs "this.". 127
 Warning coding FinalLocalVariable Variable 'f' should be declared final. 132
 Warning coding RequireThis Reference to instance variable 'tmpDir' needs "this.". 132
 Warning coding RequireThis Reference to instance variable 'currentFile' needs "this.". 132
 Warning coding RequireThis Reference to instance variable 'lastFile' needs "this.". 138
 Warning coding RequireThis Reference to instance variable 'currentFile' needs "this.". 138
 Warning coding RequireThis Reference to instance variable 'currentFile' needs "this.". 139
 Warning coding RequireThis Reference to instance variable 'currentFile' needs "this.". 140

emissary/util/search/BackwardsTreeScanner.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter keywordStrings should be final. 42
 Warning misc FinalParameters Parameter keywordStrings should be final. 52
 Warning coding FinalLocalVariable Variable 'keywords' should be declared final. 55
 Warning coding RequireThis Reference to instance variable 'root' needs "this.". 56
 Warning coding RequireThis Reference to instance variable 'root' needs "this.". 60
 Warning misc FinalParameters Parameter data should be final. 69
 Warning misc FinalParameters Parameter offset should be final. 69
 Warning misc FinalParameters Parameter result should be final. 69
 Warning coding RequireThis Reference to instance variable 'root' needs "this.". 74
 Warning coding FinalLocalVariable Variable 'ch' should be declared final. 79
 Warning coding FinalLocalVariable Variable 'id' should be declared final. 89
 Warning coding FinalLocalVariable Variable 'tmp' should be declared final. 90
 Warning design VisibilityModifier Variable 'nextStates' must be private and have accessor methods. 106
 Warning design VisibilityModifier Variable 'gotHereBy' must be private and have accessor methods. 108
 Warning design VisibilityModifier Variable 'matches' must be private and have accessor methods. 111
 Warning misc FinalParameters Parameter gotHereBy should be final. 114
 Warning misc FinalParameters Parameter word should be final. 118
 Warning misc FinalParameters Parameter id should be final. 118
 Warning misc FinalParameters Parameter word should be final. 128
 Warning misc FinalParameters Parameter wordLoc should be final. 128
 Warning misc FinalParameters Parameter id should be final. 128
 Warning coding RequireThis Reference to instance variable 'matches' needs "this.". 139
 Warning coding RequireThis Reference to instance variable 'matches' needs "this.". 140
 Warning coding FinalLocalVariable Variable 'newMatches' should be declared final. 142
 Warning coding RequireThis Reference to instance variable 'matches' needs "this.". 142
 Warning coding RequireThis Reference to instance variable 'matches' needs "this.". 143
 Warning coding RequireThis Reference to instance variable 'matches' needs "this.". 143
 Warning coding RequireThis Reference to instance variable 'matches' needs "this.". 144
 Warning coding RequireThis Reference to instance variable 'matches' needs "this.". 145
 Warning coding RequireThis Reference to instance variable 'matches' needs "this.". 145
 Warning coding FinalLocalVariable Variable 'nextChar' should be declared final. 148
 Warning coding RequireThis Reference to instance variable 'nextStates' needs "this.". 150
 Warning coding RequireThis Reference to instance variable 'nextStates' needs "this.". 153
 Warning misc FinalParameters Parameter out should be final. 160
 Warning misc FinalParameters Parameter out should be final. 165
 Warning misc FinalParameters Parameter prefix should be final. 165
 Warning coding RequireThis Reference to instance variable 'gotHereBy' needs "this.". 166
 Warning coding RequireThis Reference to instance variable 'gotHereBy' needs "this.". 166
 Warning coding RequireThis Reference to instance variable 'gotHereBy' needs "this.". 167
 Warning coding RequireThis Reference to instance variable 'gotHereBy' needs "this.". 169
 Warning coding RequireThis Reference to instance variable 'matches' needs "this.". 171
 Warning coding RequireThis Reference to instance variable 'matches' needs "this.". 173
 Warning coding RequireThis Reference to instance variable 'nextStates' needs "this.". 178

emissary/util/search/BackwardsTreeScannerTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'first' should be declared final. 16
 Warning coding RequireThis Reference to instance variable 'defaultKeywords' needs "this.". 17
 Warning coding FinalLocalVariable Variable 'second' should be declared final. 22
 Warning coding RequireThis Reference to instance variable 'defaultKeywords' needs "this.". 22
 Warning coding FinalLocalVariable Variable 'hits' should be declared final. 29
 Warning coding FinalLocalVariable Variable 'second' should be declared final. 30
 Warning coding RequireThis Reference to instance variable 'defaultKeywords' needs "this.". 30

emissary/util/search/ByteMatcher.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter data should be final. 26
 Warning misc FinalParameters Parameter data should be final. 30
 Warning misc FinalParameters Parameter data should be final. 34
 Warning misc FinalParameters Parameter data should be final. 38
 Warning misc FinalParameters Parameter charsetName should be final. 38
 Warning misc FinalParameters Parameter data should be final. 42
 Warning misc FinalParameters Parameter charset should be final. 42
 Warning misc FinalParameters Parameter data should be final. 51
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 64
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 71
 Warning misc FinalParameters Parameter pattern should be final. 77
 Warning misc FinalParameters Parameter pattern should be final. 86
 Warning misc FinalParameters Parameter pattern should be final. 98
 Warning misc FinalParameters Parameter startOfs should be final. 98
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 100
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 104
 Warning misc FinalParameters Parameter pattern should be final. 111
 Warning misc FinalParameters Parameter startOfs should be final. 111
 Warning misc FinalParameters Parameter pattern should be final. 126
 Warning misc FinalParameters Parameter beginIndex should be final. 126
 Warning misc FinalParameters Parameter endIndex should be final. 126
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 129
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 129
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 129
 Warning coding RequireThis Reference to instance variable 'scanner' needs "this.". 134
 Warning misc FinalParameters Parameter pattern should be final. 147
 Warning misc FinalParameters Parameter beginIndex should be final. 147
 Warning misc FinalParameters Parameter endIndex should be final. 147
 Warning misc FinalParameters Parameter pattern should be final. 159
 Warning misc FinalParameters Parameter pattern should be final. 169
 Warning misc FinalParameters Parameter pattern should be final. 180
 Warning misc FinalParameters Parameter startOfs should be final. 180
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 182
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 186
 Warning misc FinalParameters Parameter pattern should be final. 196
 Warning misc FinalParameters Parameter startOfs should be final. 196
 Warning misc FinalParameters Parameter pattern should be final. 210
 Warning misc FinalParameters Parameter beginIndex should be final. 210
 Warning misc FinalParameters Parameter endIndex should be final. 210
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 213
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 213
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 213
 Warning coding RequireThis Reference to instance variable 'scanner' needs "this.". 217
 Warning misc FinalParameters Parameter pattern should be final. 230
 Warning misc FinalParameters Parameter beginIndex should be final. 230
 Warning misc FinalParameters Parameter endIndex should be final. 230
 Warning misc FinalParameters Parameter offset should be final. 238
 Warning misc FinalParameters Parameter pattern should be final. 238
 Warning coding FinalLocalVariable Variable 'patternBytes' should be declared final. 244
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 248
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 252
 Warning misc FinalParameters Parameter i should be final. 265
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 267
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 268
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 271
 Warning misc FinalParameters Parameter start should be final. 281
 Warning misc FinalParameters Parameter end should be final. 281
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 282
 Warning coding FinalLocalVariable Variable 'slice' should be declared final. 283
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 284
 Warning misc FinalParameters Parameter s should be final. 294
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 295
 Warning misc FinalParameters Parameter pattern should be final. 317
 Warning misc FinalParameters Parameter beginIndex should be final. 317
 Warning misc FinalParameters Parameter endIndex should be final. 317
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 320
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 320
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 320
 Warning coding RequireThis Reference to instance variable 'scanner' needs "this.". 328
 Warning coding FinalLocalVariable Variable 'matchPos' should be declared final. 329
 Warning coding RequireThis Reference to instance variable 'scanner' needs "this.". 329
 Warning coding RequireThis Reference to instance variable 'scanner' needs "this.". 332
 Warning misc FinalParameters Parameter pattern should be final. 343
 Warning misc FinalParameters Parameter startOfs should be final. 343
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 345
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 349
 Warning misc FinalParameters Parameter pattern should be final. 352
 Warning misc FinalParameters Parameter pattern should be final. 358
 Warning misc FinalParameters Parameter pattern should be final. 364
 Warning misc FinalParameters Parameter startOfs should be final. 364
 Warning misc FinalParameters Parameter pattern should be final. 380
 Warning misc FinalParameters Parameter beginIndex should be final. 380
 Warning misc FinalParameters Parameter endIndex should be final. 380
 Warning misc FinalParameters Parameter pattern should be final. 396
 Warning misc FinalParameters Parameter beginIndex should be final. 396
 Warning misc FinalParameters Parameter endIndex should be final. 396
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 399
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 399
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 399
 Warning coding RequireThis Reference to instance variable 'scanner' needs "this.". 403
 Warning coding FinalLocalVariable Variable 'matchPosList' should be declared final. 404
 Warning coding RequireThis Reference to instance variable 'scanner' needs "this.". 404
 Warning coding RequireThis Reference to instance variable 'scanner' needs "this.". 407
 Warning misc FinalParameters Parameter pattern should be final. 419
 Warning misc FinalParameters Parameter startOfs should be final. 419
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 421
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 425
 Warning misc FinalParameters Parameter pattern should be final. 434
 Warning misc FinalParameters Parameter pattern should be final. 449
 Warning misc FinalParameters Parameter beginIndex should be final. 449
 Warning misc FinalParameters Parameter endIndex should be final. 449
 Warning misc FinalParameters Parameter pattern should be final. 461
 Warning misc FinalParameters Parameter startOfs should be final. 461
 Warning misc FinalParameters Parameter pattern should be final. 472
 Warning misc FinalParameters Parameter key should be final. 482
 Warning misc FinalParameters Parameter ofs should be final. 482
 Warning misc FinalParameters Parameter delim should be final. 482
 Warning coding FinalLocalVariable Variable 'keypos' should be declared final. 484
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 490
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 490
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 490
 Warning coding FinalLocalVariable Variable 'delimpos' should be declared final. 494
 Warning coding FinalLocalVariable Variable 'eodpos' should be declared final. 495
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 497
 Warning misc FinalParameters Parameter key should be final. 505
 Warning misc FinalParameters Parameter ofs should be final. 505
 Warning misc FinalParameters Parameter key should be final. 509
 Warning misc FinalParameters Parameter key should be final. 518
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 519
 Warning misc FinalParameters Parameter key should be final. 523
 Warning misc FinalParameters Parameter ofs should be final. 523
 Warning misc FinalParameters Parameter limit should be final. 523
 Warning coding FinalLocalVariable Variable 'keypos' should be declared final. 526
 Warning coding FinalLocalVariable Variable 'sDelim' should be declared final. 540
 Warning coding FinalLocalVariable Variable 'strLength' should be declared final. 541
 Warning coding RequireThis Reference to instance variable 'mydata' needs "this.". 568
 Warning coding FinalLocalVariable Variable 'value' should be declared final. 573
 Warning coding FinalLocalVariable Variable 'sb' should be declared final. 580

emissary/util/search/ByteMatcherTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'byteMatcher' should be declared final. 44
 Warning coding FinalLocalVariable Variable 'localDataTwo' should be declared final. 50
 Warning coding FinalLocalVariable Variable 'firstToken' should be declared final. 51
 Warning coding FinalLocalVariable Variable 'secondToken' should be declared final. 52
 Warning coding FinalLocalVariable Variable 'byteMatcher' should be declared final. 53
 Warning coding FinalLocalVariable Variable 'localDataOne' should be declared final. 67
 Warning coding VariableDeclarationUsageDistance Distance between variable 'localDataTwo' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 68
 Warning coding FinalLocalVariable Variable 'localDataTwo' should be declared final. 68
 Warning coding FinalLocalVariable Variable 'firstToken' should be declared final. 69
 Warning coding FinalLocalVariable Variable 'secondToken' should be declared final. 70
 Warning coding FinalLocalVariable Variable 'byteMatcher' should be declared final. 71
 Warning coding FinalLocalVariable Variable 'findTestCaseSensitive' should be declared final. 96
 Warning coding FinalLocalVariable Variable 'findTestCaseInsensitive' should be declared final. 108
 Warning coding FinalLocalVariable Variable 'testStartOffs' should be declared final. 120
 Warning coding FinalLocalVariable Variable 'testEndOffs' should be declared final. 121
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 139
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 144
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 149
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 154
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 274
 Warning coding RequireThis Reference to instance variable 'b' needs "this.". 279
 Warning coding FinalLocalVariable Variable 'byteAt' should be declared final. 294

emissary/util/search/ByteTokenizer.java

Severity Category Rule Message Line
 Warning coding RequireThis Reference to instance variable 'delimiters' needs "this.". 39
 Warning coding RequireThis Reference to instance variable 'maxDelimChar' needs "this.". 40
 Warning coding RequireThis Reference to instance variable 'delimiters' needs "this.". 45
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 46
 Warning coding RequireThis Reference to instance variable 'delimiters' needs "this.". 46
 Warning coding RequireThis Reference to instance variable 'maxDelimChar' needs "this.". 51
 Warning misc FinalParameters Parameter bytes should be final. 68
 Warning misc FinalParameters Parameter start should be final. 68
 Warning misc FinalParameters Parameter len should be final. 68
 Warning misc FinalParameters Parameter delim should be final. 68
 Warning misc FinalParameters Parameter returnDelims should be final. 68
 Warning coding RequireThis Reference to instance variable 'currentPosition' needs "this.". 69
 Warning coding RequireThis Reference to instance variable 'newPosition' needs "this.". 70
 Warning coding RequireThis Reference to instance variable 'delimsChanged' needs "this.". 71
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 72
 Warning coding RequireThis Reference to instance variable 'maxPosition' needs "this.". 73
 Warning coding RequireThis Reference to instance variable 'delimiters' needs "this.". 74
 Warning coding RequireThis Reference to instance variable 'retDelims' needs "this.". 75
 Warning misc FinalParameters Parameter bytes should be final. 90
 Warning misc FinalParameters Parameter start should be final. 90
 Warning misc FinalParameters Parameter len should be final. 90
 Warning misc FinalParameters Parameter delim should be final. 90
 Warning misc FinalParameters Parameter returnDelims should be final. 90
 Warning misc FinalParameters Parameter encoding should be final. 90
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 93
 Warning misc FinalParameters Parameter bytes should be final. 110
 Warning misc FinalParameters Parameter start should be final. 110
 Warning misc FinalParameters Parameter len should be final. 110
 Warning misc FinalParameters Parameter delim should be final. 110
 Warning misc FinalParameters Parameter bytes should be final. 124
 Warning misc FinalParameters Parameter start should be final. 124
 Warning misc FinalParameters Parameter len should be final. 124
 Warning misc FinalParameters Parameter delim should be final. 124
 Warning misc FinalParameters Parameter encoding should be final. 124
 Warning misc FinalParameters Parameter bytes should be final. 138
 Warning misc FinalParameters Parameter start should be final. 138
 Warning misc FinalParameters Parameter len should be final. 138
 Warning misc FinalParameters Parameter bytes should be final. 154
 Warning misc FinalParameters Parameter delim should be final. 154
 Warning misc FinalParameters Parameter returnDelims should be final. 154
 Warning misc FinalParameters Parameter bytes should be final. 167
 Warning misc FinalParameters Parameter delim should be final. 167
 Warning misc FinalParameters Parameter returnDelims should be final. 167
 Warning misc FinalParameters Parameter encoding should be final. 167
 Warning misc FinalParameters Parameter bytes should be final. 178
 Warning misc FinalParameters Parameter delim should be final. 178
 Warning misc FinalParameters Parameter bytes should be final. 190
 Warning misc FinalParameters Parameter delim should be final. 190
 Warning misc FinalParameters Parameter encoding should be final. 190
 Warning misc FinalParameters Parameter bytes should be final. 202
 Warning misc FinalParameters Parameter startPos should be final. 210
 Warning coding RequireThis Reference to instance variable 'delimiters' needs "this.". 211
 Warning coding RequireThis Reference to instance variable 'retDelims' needs "this.". 216
 Warning coding RequireThis Reference to instance variable 'maxPosition' needs "this.". 216
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 217
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 217
 Warning coding RequireThis Reference to instance variable 'maxDelimChar' needs "this.". 218
 Warning coding RequireThis Reference to instance variable 'delimiters' needs "this.". 218
 Warning misc FinalParameters Parameter startPos should be final. 230
 Warning coding RequireThis Reference to instance variable 'maxPosition' needs "this.". 232
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 233
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 233
 Warning coding RequireThis Reference to instance variable 'maxDelimChar' needs "this.". 234
 Warning coding RequireThis Reference to instance variable 'delimiters' needs "this.". 234
 Warning coding RequireThis Reference to instance variable 'retDelims' needs "this.". 239
 Warning coding FinalLocalVariable Variable 'c' should be declared final. 240
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 240
 Warning coding RequireThis Reference to instance variable 'maxDelimChar' needs "this.". 241
 Warning coding RequireThis Reference to instance variable 'delimiters' needs "this.". 241
 Warning coding RequireThis Reference to instance variable 'newPosition' needs "this.". 261
 Warning coding RequireThis Reference to instance variable 'currentPosition' needs "this.". 261
 Warning coding RequireThis Reference to instance variable 'newPosition' needs "this.". 262
 Warning coding RequireThis Reference to instance variable 'maxPosition' needs "this.". 262
 Warning coding RequireThis Reference to instance variable 'currentPosition' needs "this.". 278
 Warning coding RequireThis Reference to instance variable 'newPosition' needs "this.". 278
 Warning coding RequireThis Reference to instance variable 'delimsChanged' needs "this.". 278
 Warning coding RequireThis Reference to instance variable 'newPosition' needs "this.". 278
 Warning coding RequireThis Reference to instance variable 'currentPosition' needs "this.". 278
 Warning coding RequireThis Reference to instance variable 'delimsChanged' needs "this.". 281
 Warning coding RequireThis Reference to instance variable 'newPosition' needs "this.". 282
 Warning coding RequireThis Reference to instance variable 'currentPosition' needs "this.". 284
 Warning coding RequireThis Reference to instance variable 'maxPosition' needs "this.". 284
 Warning coding FinalLocalVariable Variable 'start' should be declared final. 287
 Warning coding RequireThis Reference to instance variable 'currentPosition' needs "this.". 287
 Warning coding RequireThis Reference to instance variable 'currentPosition' needs "this.". 288
 Warning coding RequireThis Reference to instance variable 'currentPosition' needs "this.". 288
 Warning coding RequireThis Reference to instance variable 'encoding' needs "this.". 292
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 293
 Warning coding RequireThis Reference to instance variable 'currentPosition' needs "this.". 293
 Warning coding RequireThis Reference to instance variable 'encoding' needs "this.". 293
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 295
 Warning coding RequireThis Reference to instance variable 'currentPosition' needs "this.". 295
 Warning misc FinalParameters Parameter delim should be final. 313
 Warning coding RequireThis Reference to instance variable 'delimiters' needs "this.". 314
 Warning coding RequireThis Reference to instance variable 'delimsChanged' needs "this.". 317
 Warning coding RequireThis Reference to instance variable 'currentPosition' needs "this.". 332
 Warning coding RequireThis Reference to instance variable 'maxPosition' needs "this.". 333
 Warning coding RequireThis Reference to instance variable 'maxPosition' needs "this.". 335

emissary/util/search/ByteTokenizerTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'testBytes' should be declared final. 16
 Warning coding FinalLocalVariable Variable 'byteTokenizer' should be declared final. 17
 Warning coding FinalLocalVariable Variable 'exception' should be declared final. 22

emissary/util/search/FastBoyerMoore.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'keywords' must be private and have accessor methods. 15
 Warning design VisibilityModifier Variable 'minKeywordLength' must be private and have accessor methods. 16
 Warning design VisibilityModifier Variable 'lookup' must be private and have accessor methods. 17
 Warning design VisibilityModifier Variable 'scanner' must be private and have accessor methods. 18
 Warning design VisibilityModifier Variable 'data' must be private and have accessor methods. 20
 Warning design VisibilityModifier Variable 'root' must be private and have accessor methods. 21
 Warning blocks RightCurly '}' at column 31 should be alone on a line. 25
 Warning indentation Indentation 'array initialization lcurly' has incorrect indentation level 20, expected level should be one of the following: 14, 37, 38, 40. 181
 Warning indentation Indentation 'array initialization lcurly' has incorrect indentation level 20, expected level should be one of the following: 14, 37, 38, 40. 182
 Warning indentation Indentation 'array initialization lcurly' has incorrect indentation level 20, expected level should be one of the following: 14, 37, 38, 40. 183
 Warning indentation Indentation 'array initialization lcurly' has incorrect indentation level 20, expected level should be one of the following: 14, 37, 38, 40. 184
 Warning indentation Indentation 'array initialization lcurly' has incorrect indentation level 20, expected level should be one of the following: 14, 37, 38, 40. 185
 Warning indentation Indentation 'array initialization lcurly' has incorrect indentation level 20, expected level should be one of the following: 14, 37, 38, 40. 186
 Warning design VisibilityModifier Variable 'root' must be private and have accessor methods. 226
 Warning design VisibilityModifier Variable 'data' must be private and have accessor methods. 228
 Warning design VisibilityModifier Variable 'nextStates' must be private and have accessor methods. 384
 Warning design VisibilityModifier Variable 'gotHereBy' must be private and have accessor methods. 387
 Warning design VisibilityModifier Variable 'matches' must be private and have accessor methods. 391

emissary/util/search/FastBoyerMooreTest.java

Severity Category Rule Message Line
 Warning indentation Indentation 'array initialization lcurly' has incorrect indentation level 12, expected level should be one of the following: 6, 41, 42, 44. 15

emissary/util/search/Hit.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'hit' must be private and have accessor methods. 12
 Warning blocks RightCurly '}' at column 19 should be alone on a line. 14

emissary/util/search/KeywordScanner.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter data should be final. 35
 Warning coding HiddenField 'data' hides a field. 35
 Warning misc FinalParameters Parameter data should be final. 39
 Warning coding HiddenField 'data' hides a field. 39
 Warning misc FinalParameters Parameter charsetName should be final. 39
 Warning misc FinalParameters Parameter data should be final. 43
 Warning coding HiddenField 'data' hides a field. 43
 Warning misc FinalParameters Parameter charset should be final. 43
 Warning misc FinalParameters Parameter data should be final. 52
 Warning coding HiddenField 'data' hides a field. 52
 Warning coding FinalLocalVariable Variable 'matches' should be declared final. 158
 Warning coding RequireThis Reference to instance variable 'caseSensitive' needs "this.". 245
 Warning coding FinalLocalVariable Variable 'currentByte' should be declared final. 263

emissary/util/search/KeywordScannerTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'otherData' should be declared final. 30
 Warning coding FinalLocalVariable Variable 'otherData' should be declared final. 38
 Warning coding FinalLocalVariable Variable 'lks' should be declared final. 103
 Warning coding FinalLocalVariable Variable 'findTest' should be declared final. 104
 Warning coding FinalLocalVariable Variable 'findIs' should be declared final. 109
 Warning coding FinalLocalVariable Variable 'startOffset' should be declared final. 114
 Warning coding FinalLocalVariable Variable 'endOffset' should be declared final. 118

emissary/util/search/MultiKeywordScanner.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 35 should be alone on a line. 20

emissary/util/search/MultiKeywordScannerTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'multiKeywordScanner' should be declared final. 15
 Warning coding RequireThis Reference to instance variable 'defaultKeywords' needs "this.". 16
 Warning coding FinalLocalVariable Variable 'multiKeywordScanner' should be declared final. 30
 Warning coding RequireThis Reference to instance variable 'defaultKeywords' needs "this.". 31
 Warning coding FinalLocalVariable Variable 'multiKeywordScanner' should be declared final. 43
 Warning coding RequireThis Reference to instance variable 'defaultKeywords' needs "this.". 44
 Warning coding FinalLocalVariable Variable 'multiKeywordScanner' should be declared final. 56
 Warning coding RequireThis Reference to instance variable 'defaultKeywords' needs "this.". 57
 Warning coding FinalLocalVariable Variable 'multiKeywordScanner' should be declared final. 74
 Warning coding RequireThis Reference to instance variable 'defaultKeywords' needs "this.". 75
 Warning coding FinalLocalVariable Variable 'multiKeywordScanner' should be declared final. 87
 Warning coding RequireThis Reference to instance variable 'defaultKeywords' needs "this.". 88
 Warning coding FinalLocalVariable Variable 'multiKeywordScanner' should be declared final. 100
 Warning coding RequireThis Reference to instance variable 'defaultKeywords' needs "this.". 101
 Warning coding FinalLocalVariable Variable 'keywords' should be declared final. 105
 Warning coding FinalLocalVariable Variable 'hits' should be declared final. 107

emissary/util/shell/Executrix.java

Severity Category Rule Message Line
 Warning naming TypeName Type name 'OUTPUT_TYPE' must match pattern '^[A-Z][a-zA-Z0-9]*$'. 48
 Warning design VisibilityModifier Variable 'command' must be private and have accessor methods. 52
 Warning design VisibilityModifier Variable 'inFileEnding' must be private and have accessor methods. 53
 Warning design VisibilityModifier Variable 'outFileEnding' must be private and have accessor methods. 54
 Warning design VisibilityModifier Variable 'output' must be private and have accessor methods. 55
 Warning design VisibilityModifier Variable 'order' must be private and have accessor methods. 56
 Warning design VisibilityModifier Variable 'numArgs' must be private and have accessor methods. 57
 Warning design VisibilityModifier Variable 'tmpDir' must be private and have accessor methods. 58
 Warning design VisibilityModifier Variable 'tmpDirFile' must be private and have accessor methods. 59
 Warning design VisibilityModifier Variable 'minimumDataSize' must be private and have accessor methods. 60
 Warning design VisibilityModifier Variable 'maximumDataSize' must be private and have accessor methods. 61
 Warning design VisibilityModifier Variable 'placeName' must be private and have accessor methods. 62
 Warning design VisibilityModifier Variable 'vmSizeLimit' must be private and have accessor methods. 63
 Warning design VisibilityModifier Variable 'cpuTimeLimit' must be private and have accessor methods. 64
 Warning design VisibilityModifier Variable 'processMaxMillis' must be private and have accessor methods. 65
 Warning coding FinalLocalVariable Variable 'theContent' should be declared final. 189
 Warning coding FinalLocalVariable Variable 'read' should be declared final. 460
 Warning misc FinalParameters Parameter eConfig should be final. 849
 Warning misc FinalParameters Parameter p should be final. 893
 Warning misc FinalParameters Parameter data should be final. 893
 Warning misc FinalParameters Parameter tmpNames should be final. 1061
 Warning design VisibilityModifier Variable 'cmd' must be private and have accessor methods. 1430
 Warning design VisibilityModifier Variable 'data' must be private and have accessor methods. 1431
 Warning design VisibilityModifier Variable 'err' must be private and have accessor methods. 1432
 Warning design VisibilityModifier Variable 'charset' must be private and have accessor methods. 1433
 Warning design VisibilityModifier Variable 'env' must be private and have accessor methods. 1434
 Warning modifier RedundantModifier Redundant 'public' modifier. 1436
 Warning misc FinalParameters Parameter cmd should be final. 1436
 Warning misc FinalParameters Parameter data should be final. 1436
 Warning misc FinalParameters Parameter err should be final. 1436
 Warning misc FinalParameters Parameter charset should be final. 1436
 Warning misc FinalParameters Parameter env should be final. 1436
 Warning coding RequireThis Reference to instance variable 'cmd' needs "this.". 1445
 Warning coding RequireThis Reference to instance variable 'data' needs "this.". 1449
 Warning coding RequireThis Reference to instance variable 'cmd' needs "this.". 1453
 Warning coding RequireThis Reference to instance variable 'cmd' needs "this.". 1454
 Warning coding RequireThis Reference to instance variable 'env' needs "this.". 1455
 Warning coding RequireThis Reference to instance variable 'env' needs "this.". 1456
 Warning misc FinalParameters Parameter p should be final. 1463
 Warning misc FinalParameters Parameter p should be final. 1467
 Warning coding RequireThis Reference to instance variable 'err' needs "this.". 1468
 Warning coding RequireThis Reference to instance variable 'err' needs "this.". 1468
 Warning coding RequireThis Reference to instance variable 'charset' needs "this.". 1468
 Warning design VisibilityModifier Variable 'out' must be private and have accessor methods. 1472
 Warning modifier RedundantModifier Redundant 'public' modifier. 1474
 Warning misc FinalParameters Parameter cmd should be final. 1474
 Warning misc FinalParameters Parameter data should be final. 1474
 Warning misc FinalParameters Parameter out should be final. 1474
 Warning misc FinalParameters Parameter err should be final. 1474
 Warning misc FinalParameters Parameter charset should be final. 1474
 Warning misc FinalParameters Parameter env should be final. 1474
 Warning misc FinalParameters Parameter p should be final. 1480
 Warning coding RequireThis Reference to instance variable 'out' needs "this.". 1481
 Warning coding RequireThis Reference to instance variable 'out' needs "this.". 1481
 Warning design VisibilityModifier Variable 'out' must be private and have accessor methods. 1487
 Warning modifier RedundantModifier Redundant 'public' modifier. 1489
 Warning misc FinalParameters Parameter cmd should be final. 1489
 Warning misc FinalParameters Parameter data should be final. 1489
 Warning misc FinalParameters Parameter out should be final. 1489
 Warning misc FinalParameters Parameter err should be final. 1489
 Warning misc FinalParameters Parameter charset should be final. 1489
 Warning misc FinalParameters Parameter env should be final. 1490
 Warning misc FinalParameters Parameter p should be final. 1496
 Warning coding RequireThis Reference to instance variable 'out' needs "this.". 1497
 Warning coding RequireThis Reference to instance variable 'out' needs "this.". 1497

emissary/util/shell/ExecutrixTest.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter dir should be final. 43
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 44
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 46
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 54
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 61
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 62
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 63
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 65
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 84
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 85
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 86
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 87
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 89
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 104
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 105
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 106
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 113
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 128
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 129
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 130
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 137
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 148
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 238
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 243
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 251
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 298
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 314
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 326
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 330
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 331
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 341
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 347
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 351
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 355
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 362
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 366
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 370
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 377
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 381
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 385
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 386
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 399
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 401
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 413
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 417
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 418
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 428
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 434
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 438
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 442
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 449
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 453
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 457
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 464
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 468
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 472
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 473
 Warning coding FinalLocalVariable Variable 'expected' should be declared final. 484
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 493
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 496
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 501
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 506
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 512
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 521
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 527
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 528
 Warning coding FinalLocalVariable Variable 'expected' should be declared final. 538
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 545
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 548
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 553
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 559
 Warning coding FinalLocalVariable Variable 'expected' should be declared final. 569
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 576
 Warning coding RequireThis Reference to instance variable 'e' needs "this.". 582

emissary/util/shell/ProcessReader.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter contextMap should be final. 24
 Warning coding HiddenField 'contextMap' hides a field. 24
 Warning coding RequireThis Reference to instance variable 'contextMap' needs "this.". 33
 Warning coding RequireThis Reference to instance variable 'contextMap' needs "this.". 34

emissary/util/shell/ProcessReaderTest.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'appender' must be private and have accessor methods. 36
 Warning design VisibilityModifier Variable 'encoder' must be private and have accessor methods. 38
 Warning coding RequireThis Reference to instance variable 'encoder' needs "this.". 45
 Warning coding RequireThis Reference to instance variable 'encoder' needs "this.". 46
 Warning coding RequireThis Reference to instance variable 'encoder' needs "this.". 47
 Warning coding RequireThis Reference to instance variable 'encoder' needs "this.". 48
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 50
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 51
 Warning coding RequireThis Reference to instance variable 'encoder' needs "this.". 51
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 52
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 54
 Warning coding RequireThis Reference to instance variable 'encoder' needs "this.". 68
 Warning coding RequireThis Reference to instance variable 'encoder' needs "this.". 69
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 71
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 72
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 85
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 86
 Warning coding FinalLocalVariable Variable 'objectUnderTest' should be declared final. 88
 Warning coding FinalLocalVariable Variable 'expected' should be declared final. 93
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 102
 Warning coding RequireThis Reference to instance variable 'appender' needs "this.". 103
 Warning coding FinalLocalVariable Variable 'objectUnderTest' should be declared final. 105
 Warning coding FinalLocalVariable Variable 'expected' should be declared final. 111
 Warning design VisibilityModifier Variable 'logger' must be private and have accessor methods. 117
 Warning coding RequireThis Reference to instance variable 'logger' needs "this.". 132

emissary/util/shell/ReadBinaryOutputBuffer.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter baos should be final. 13
 Warning coding RequireThis Reference to instance variable 'inputStream' needs "this.". 22
 Warning coding RequireThis Reference to instance variable 'baos' needs "this.". 22
 Warning blocks RightCurly '}' at column 27 should be alone on a line. 29
 Warning coding RequireThis Reference to instance variable 'baos' needs "this.". 32
 Warning coding RequireThis Reference to instance variable 'baos' needs "this.". 36

emissary/util/shell/ReadBinaryOutputBufferTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'buffer' should be declared final. 19

emissary/util/shell/ReadOutputBuffer.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'finished' must be private and have accessor methods. 24

emissary/util/shell/ReadOutputBufferTest.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'buffer' should be declared final. 21

emissary/util/shell/ReadOutputLogger.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'bufferedReader' must be private and have accessor methods. 16
 Warning design VisibilityModifier Variable 'inputReader' must be private and have accessor methods. 17
 Warning design VisibilityModifier Variable 'finished' must be private and have accessor methods. 18
 Warning design VisibilityModifier Variable 'name' must be private and have accessor methods. 19
 Warning blocks RightCurly '}' at column 13 should be alone on a line. 41

emissary/util/shell/TempFileNames.java

Severity Category Rule Message Line
 Warning misc FinalParameters Parameter tmpDir should be final. 29
 Warning misc FinalParameters Parameter placeName should be final. 29
 Warning misc FinalParameters Parameter inFileEnding should be final. 29
 Warning misc FinalParameters Parameter outFileEnding should be final. 29
 Warning coding RequireThis Reference to instance variable 'base' needs "this.". 30
 Warning coding RequireThis Reference to instance variable 'tempDir' needs "this.". 31
 Warning coding RequireThis Reference to instance variable 'in' needs "this.". 32
 Warning coding RequireThis Reference to instance variable 'base' needs "this.". 32
 Warning coding RequireThis Reference to instance variable 'out' needs "this.". 33
 Warning coding RequireThis Reference to instance variable 'base' needs "this.". 33
 Warning coding RequireThis Reference to instance variable 'basePath' needs "this.". 34
 Warning coding RequireThis Reference to instance variable 'tempDir' needs "this.". 34
 Warning coding RequireThis Reference to instance variable 'base' needs "this.". 34
 Warning coding RequireThis Reference to instance variable 'inputFilename' needs "this.". 35
 Warning coding RequireThis Reference to instance variable 'basePath' needs "this.". 35
 Warning coding RequireThis Reference to instance variable 'outputFilename' needs "this.". 36
 Warning coding RequireThis Reference to instance variable 'basePath' needs "this.". 36
 Warning coding RequireThis Reference to instance variable 'tempDir' needs "this.". 48
 Warning coding RequireThis Reference to instance variable 'base' needs "this.". 62
 Warning coding RequireThis Reference to instance variable 'basePath' needs "this.". 76
 Warning coding RequireThis Reference to instance variable 'in' needs "this.". 88
 Warning coding RequireThis Reference to instance variable 'out' needs "this.". 100
 Warning coding RequireThis Reference to instance variable 'inputFilename' needs "this.". 112
 Warning coding RequireThis Reference to instance variable 'outputFilename' needs "this.". 124
 Warning whitespace OperatorWrap '+' should be on a new line. 129
 Warning coding RequireThis Reference to instance variable 'tempDir' needs "this.". 130
 Warning whitespace OperatorWrap '+' should be on a new line. 130
 Warning coding RequireThis Reference to instance variable 'base' needs "this.". 131
 Warning whitespace OperatorWrap '+' should be on a new line. 131
 Warning coding RequireThis Reference to instance variable 'basePath' needs "this.". 132
 Warning whitespace OperatorWrap '+' should be on a new line. 132
 Warning coding RequireThis Reference to instance variable 'in' needs "this.". 133
 Warning whitespace OperatorWrap '+' should be on a new line. 133
 Warning coding RequireThis Reference to instance variable 'out' needs "this.". 134
 Warning whitespace OperatorWrap '+' should be on a new line. 134
 Warning coding RequireThis Reference to instance variable 'inputFilename' needs "this.". 135
 Warning whitespace OperatorWrap '+' should be on a new line. 135
 Warning coding RequireThis Reference to instance variable 'outputFilename' needs "this.". 136
 Warning whitespace OperatorWrap '+' should be on a new line. 136

emissary/util/web/HtmlEscaper.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 28 should be alone on a line. 56

emissary/util/web/HttpPostParameters.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 34 should be alone on a line. 26

emissary/util/web/Url.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 20 should be alone on a line. 236

emissary/util/web/UrlData.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'password' must be private and have accessor methods. 14
 Warning design VisibilityModifier Variable 'props' must be private and have accessor methods. 15
 Warning design VisibilityModifier Variable 'referer' must be private and have accessor methods. 16
 Warning design VisibilityModifier Variable 'responseCode' must be private and have accessor methods. 17
 Warning design VisibilityModifier Variable 'theContent' must be private and have accessor methods. 18
 Warning design VisibilityModifier Variable 'theUrl' must be private and have accessor methods. 19
 Warning design VisibilityModifier Variable 'theMethod' must be private and have accessor methods. 20
 Warning design VisibilityModifier Variable 'userName' must be private and have accessor methods. 21
 Warning design VisibilityModifier Variable 'userAgent' must be private and have accessor methods. 22
 Warning blocks RightCurly '}' at column 23 should be alone on a line. 36

emissary/util/web/UrlRequestProperty.java

Severity Category Rule Message Line
 Warning design VisibilityModifier Variable 'key' must be private and have accessor methods. 15
 Warning design VisibilityModifier Variable 'value' must be private and have accessor methods. 17
 Warning blocks RightCurly '}' at column 34 should be alone on a line. 19

emissary/util/web/UrlTest.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 27 should be alone on a line. 14

emissary/util/xml/AbstractJDOMUtil.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'builder' should be declared final. 38

emissary/util/xml/JDOMUtil.java

Severity Category Rule Message Line
 Warning blocks RightCurly '}' at column 25 should be alone on a line. 88

emissary/util/xml/SaferJDOMUtil.java

Severity Category Rule Message Line
 Warning coding FinalLocalVariable Variable 'builder' should be declared final. 19
 Warning blocks RightCurly '}' at column 30 should be alone on a line. 92